Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/libraryelastic/business/search/AbstractSearchLeaf.java

Rule Violation Line
AbstractClassWithoutAnyMethod No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 4043

fr/paris/lutece/plugins/libraryelastic/util/Constants.java

Rule Violation Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3957

fr/paris/lutece/plugins/libraryelastic/util/ElasticConnexion.java

Rule Violation Line
MethodNamingConventions The instance method name 'GET' doesn't match '[a-z][a-zA-Z0-9]*' 7983
MethodNamingConventions The instance method name 'PUT' doesn't match '[a-z][a-zA-Z0-9]*' 9699
MethodNamingConventions The instance method name 'POST' doesn't match '[a-z][a-zA-Z0-9]*' 112115
MethodNamingConventions The instance method name 'DELETE' doesn't match '[a-z][a-zA-Z0-9]*' 126129

Priority 3

fr/paris/lutece/plugins/libraryelastic/business/bulk/AbstractSubRequest.java

Rule Violation Line
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 4088
CommentRequired Header comments are required 4088
CommentRequired Public method and constructor comments are required 4548

fr/paris/lutece/plugins/libraryelastic/business/bulk/BulkRequest.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 47
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 47
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 88
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 101

fr/paris/lutece/plugins/libraryelastic/business/search/BoolQuery.java

Rule Violation Line
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _listMust field if you want a default access modifier 51
DefaultPackage Use explicit scoping instead of the default package private level 51
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _listFilter field if you want a default access modifier 52
DefaultPackage Use explicit scoping instead of the default package private level 52
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _listShould field if you want a default access modifier 53
DefaultPackage Use explicit scoping instead of the default package private level 53
DefaultPackage Use explicit scoping instead of the default package private level 54
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _listMustNot field if you want a default access modifier 54
CommentRequired Public method and constructor comments are required 7380
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 77
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 98
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 119
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 140
NPathComplexity The method 'getNodeContent(JsonNodeFactory)' has an NPath complexity of 256 149226
CyclomaticComplexity The method 'getNodeContent(JsonNodeFactory)' has a cyclomatic complexity of 13. 149226
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 156
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 174
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 192
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 210

fr/paris/lutece/plugins/libraryelastic/business/search/SearchRequest.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for '_searchQuery' 44
RedundantFieldInitializer Avoid using redundant field initializer for '_nSize' 45

fr/paris/lutece/plugins/libraryelastic/util/Elastic.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 53485
ImmutableField Private field '_connexion' could be made final; it is only initialized in the declaration or constructor. 55
ImmutableField Private field '_strServerUrl' could be made final; it is only initialized in the declaration or constructor. 56
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 462
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 479
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 480
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 481

fr/paris/lutece/plugins/libraryelastic/util/ElasticClientException.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 4148
CommentRequired Public method and constructor comments are required 4347

fr/paris/lutece/plugins/libraryelastic/util/ElasticConnexion.java

Rule Violation Line
ImmutableField Private field '_clientHttp' could be made final; it is only initialized in the declaration or constructor. 47
UncommentedEmptyConstructor Document empty constructor 6769

Files

fr/paris/lutece/plugins/libraryelastic/business/bulk/AbstractSubRequest.java

Rule Violation Priority Line
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 3 4088
CommentRequired Header comments are required 3 4088
CommentRequired Public method and constructor comments are required 3 4548

fr/paris/lutece/plugins/libraryelastic/business/bulk/BulkRequest.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 47
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 47
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 88
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 101

fr/paris/lutece/plugins/libraryelastic/business/search/AbstractSearchLeaf.java

Rule Violation Priority Line
AbstractClassWithoutAnyMethod No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 1 4043

fr/paris/lutece/plugins/libraryelastic/business/search/BoolQuery.java

Rule Violation Priority Line
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _listMust field if you want a default access modifier 3 51
DefaultPackage Use explicit scoping instead of the default package private level 3 51
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _listFilter field if you want a default access modifier 3 52
DefaultPackage Use explicit scoping instead of the default package private level 3 52
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _listShould field if you want a default access modifier 3 53
DefaultPackage Use explicit scoping instead of the default package private level 3 53
DefaultPackage Use explicit scoping instead of the default package private level 3 54
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _listMustNot field if you want a default access modifier 3 54
CommentRequired Public method and constructor comments are required 3 7380
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 77
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 98
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 119
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 140
NPathComplexity The method 'getNodeContent(JsonNodeFactory)' has an NPath complexity of 256 3 149226
CyclomaticComplexity The method 'getNodeContent(JsonNodeFactory)' has a cyclomatic complexity of 13. 3 149226
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 156
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 174
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 192
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 210

fr/paris/lutece/plugins/libraryelastic/business/search/SearchRequest.java

Rule Violation Priority Line
RedundantFieldInitializer Avoid using redundant field initializer for '_searchQuery' 3 44
RedundantFieldInitializer Avoid using redundant field initializer for '_nSize' 3 45

fr/paris/lutece/plugins/libraryelastic/util/Constants.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 3957

fr/paris/lutece/plugins/libraryelastic/util/Elastic.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 53485
ImmutableField Private field '_connexion' could be made final; it is only initialized in the declaration or constructor. 3 55
ImmutableField Private field '_strServerUrl' could be made final; it is only initialized in the declaration or constructor. 3 56
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 462
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 479
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 480
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 481

fr/paris/lutece/plugins/libraryelastic/util/ElasticClientException.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 4148
CommentRequired Public method and constructor comments are required 3 4347

fr/paris/lutece/plugins/libraryelastic/util/ElasticConnexion.java

Rule Violation Priority Line
ImmutableField Private field '_clientHttp' could be made final; it is only initialized in the declaration or constructor. 3 47
UncommentedEmptyConstructor Document empty constructor 3 6769
MethodNamingConventions The instance method name 'GET' doesn't match '[a-z][a-zA-Z0-9]*' 1 7983
MethodNamingConventions The instance method name 'PUT' doesn't match '[a-z][a-zA-Z0-9]*' 1 9699
MethodNamingConventions The instance method name 'POST' doesn't match '[a-z][a-zA-Z0-9]*' 1 112115
MethodNamingConventions The instance method name 'DELETE' doesn't match '[a-z][a-zA-Z0-9]*' 1 126129