The following document contains the results of PMD 6.13.0.
Rule | Violation | Line |
---|---|---|
FieldNamingConventions | The final field name '_mapAttributes' doesn't match '[a-z][a-zA-Z0-9]*' | 116 |
Rule | Violation | Line |
---|---|---|
FieldNamingConventions | The final field name '_daoCustomer' doesn't match '[a-z][a-zA-Z0-9]*' | 45 |
Rule | Violation | Line |
---|---|---|
FieldNamingConventions | The final field name '_demandDao' doesn't match '[a-z][a-zA-Z0-9]*' | 53 |
FieldNamingConventions | The final field name '_listDemandListener' doesn't match '[a-z][a-zA-Z0-9]*' | 54 |
FieldNamingConventions | The final field name '_notificationDao' doesn't match '[a-z][a-zA-Z0-9]*' | 55 |
FieldNamingConventions | The final field name '_listNotificationListener' doesn't match '[a-z][a-zA-Z0-9]*' | 56 |
FieldNamingConventions | The final field name '_notificationEventDao' doesn't match '[a-z][a-zA-Z0-9]*' | 57 |
Rule | Violation | Line |
---|---|---|
FieldNamingConventions | The final field name '_mapMockCustomer' doesn't match '[a-z][a-zA-Z0-9]*' | 52 |
Rule | Violation | Line |
---|---|---|
FieldNamingConventions | The final field name '_mapMockDemand' doesn't match '[a-z][a-zA-Z0-9]*' | 52 |
Rule | Violation | Line |
---|---|---|
FieldNamingConventions | The final field name '_listLogAction' doesn't match '[a-z][a-zA-Z0-9]*' | 47 |
Rule | Violation | Line |
---|---|---|
FieldNamingConventions | The final field name '_listMockNotification' doesn't match '[a-z][a-zA-Z0-9]*' | 52 |
Rule | Violation | Line |
---|---|---|
FieldNamingConventions | The final field name '_listLogAction' doesn't match '[a-z][a-zA-Z0-9]*' | 47 |
Rule | Violation | Line |
---|---|---|
FormalParameterNamingConventions | The method parameter name '_strType' doesn't match '[a-z][a-zA-Z0-9]*' | 120 |
FormalParameterNamingConventions | The method parameter name '_strStatus' doesn't match '[a-z][a-zA-Z0-9]*' | 137 |
FormalParameterNamingConventions | The method parameter name '_strReason' doesn't match '[a-z][a-zA-Z0-9]*' | 154 |
FormalParameterNamingConventions | The method parameter name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 172 |
Rule | Violation | Line |
---|---|---|
ClassNamingConventions | The utility class name 'NotificationConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–57 |
Rule | Violation | Line |
---|---|---|
FormalParameterNamingConventions | The method parameter name '_lStartDate' doesn't match '[a-z][a-zA-Z0-9]*' | 230 |
FormalParameterNamingConventions | The method parameter name '_lEndDate' doesn't match '[a-z][a-zA-Z0-9]*' | 257 |
Rule | Violation | Line |
---|---|---|
FormalParameterNamingConventions | The method parameter name '_strErrorMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 118 |
Rule | Violation | Line |
---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 53 |
TooManyFields | Too many fields | 54–487 |
Rule | Violation | Line |
---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 50 |
TooManyFields | Too many fields | 54–440 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 65 |
Rule | Violation | Line |
---|---|---|
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 71 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 72 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 88 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 89 |
UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'notificationDao' | 247 |
Rule | Violation | Line |
---|---|---|
CommentRequired | Header comments are required | 38–140 |
Rule | Violation | Line |
---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 47–161 |
Rule | Violation | Line |
---|---|---|
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 52 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 52 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 72 |
Rule | Violation | Line |
---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 51–178 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 52 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 52 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 60 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 77 |
Rule | Violation | Line |
---|---|---|
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 47 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 85–105 |
Rule | Violation | Line |
---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 50–282 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 52 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 61 |
NPathComplexity | The method 'loadByFilter(NotificationFilter)' has an NPath complexity of 2917 | 77–117 |
CyclomaticComplexity | The method 'loadByFilter(NotificationFilter)' has a cyclomatic complexity of 16. | 77–117 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 79 |
NPathComplexity | The method 'loadIdsByFilter(NotificationFilter)' has an NPath complexity of 2917 | 157–197 |
CyclomaticComplexity | The method 'loadIdsByFilter(NotificationFilter)' has a cyclomatic complexity of 16. | 157–197 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 218 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 234 |
ShortVariable | Avoid variables with short names like id | 259 |
Rule | Violation | Line |
---|---|---|
DefaultPackage | Use explicit scoping instead of the default package private level | 50 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _eventList field if you want a default access modifier | 50 |
ControlStatementBraces | This statement should have braces | 71 |
Rule | Violation | Line |
---|---|---|
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 47 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 85–120 |
Rule | Violation | Line |
---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 46 |
Rule | Violation | Line |
---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 43 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strBillingAccount field if you want a default access modifier | 49 |
DefaultPackage | Use explicit scoping instead of the default package private level | 49 |
DefaultPackage | Use explicit scoping instead of the default package private level | 50 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strBillingGroup field if you want a default access modifier | 50 |
Rule | Violation | Line |
---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 55 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 149 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 235 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 275 |
Rule | Violation | Line |
---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 47 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 87 |
Rule | Violation | Line |
---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 53 |
Rule | Violation | Line |
---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 47 |
Rule | Violation | Line |
---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 44–152 |
ShortVariable | Avoid variables with short names like id | 52 |
ShortVariable | Avoid variables with short names like id | 151 |
Rule | Violation | Line |
---|---|---|
UnnecessaryModifier | Unnecessary modifier 'public' on method 'loadByNotification': the method is declared in an interface type | 73 |
Rule | Violation | Line |
---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 49 |
Rule | Violation | Line |
---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 60 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 283 |
Rule | Violation | Line |
---|---|---|
ImportFromSamePackage | No need to import a type that lives in the same package | 42 |
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 49 |
Rule | Violation | Line |
---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 43–294 |
Rule | Violation | Line |
---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 44 |
Rule | Violation | Line |
---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 47 |
Rule | Violation | Line |
---|---|---|
CommentRequired | Enum comments are required | 4–88 |
UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'EnumGenericStatus(Integer, String)': enum constructors are implicitly private | 22–26 |
Rule | Violation | Line |
---|---|---|
AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 41–122 |
Rule | Violation | Line |
---|---|---|
UnnecessaryModifier | Unnecessary modifier 'public' on method 'process': the method is declared in an interface type | 51 |
UnnecessaryModifier | Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type | 58 |
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like e | 66 |
Rule | Violation | Line |
---|---|---|
BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 240–243 |
BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 330–333 |
BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 394–397 |
Rule | Violation | Line |
---|---|---|
BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 419–422 |
Rule | Violation | Line |
---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.grubusiness.business.web.rs.DemandDisplay' | 37 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 53 |
TooManyFields | Too many fields | 3 | 54–487 |
FieldNamingConventions | The final field name '_mapAttributes' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 116 |
BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 240–243 |
BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 330–333 |
BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 394–397 |
Rule | Violation | Priority | Line |
---|---|---|---|
FieldNamingConventions | The final field name '_daoCustomer' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 45 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 50 |
TooManyFields | Too many fields | 3 | 54–440 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 65 |
BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 419–422 |
Rule | Violation | Priority | Line |
---|---|---|---|
FieldNamingConventions | The final field name '_demandDao' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 53 |
FieldNamingConventions | The final field name '_listDemandListener' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 54 |
FieldNamingConventions | The final field name '_notificationDao' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 55 |
FieldNamingConventions | The final field name '_listNotificationListener' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 56 |
FieldNamingConventions | The final field name '_notificationEventDao' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 57 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 71 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 72 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 88 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 89 |
UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'notificationDao' | 3 | 247 |
Rule | Violation | Priority | Line |
---|---|---|---|
CommentRequired | Header comments are required | 3 | 38–140 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.grubusiness.business.web.rs.DemandDisplay' | 4 | 37 |
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 47–161 |
Rule | Violation | Priority | Line |
---|---|---|---|
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 52 |
FieldNamingConventions | The final field name '_mapMockCustomer' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 52 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 52 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 72 |
Rule | Violation | Priority | Line |
---|---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 51–178 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 52 |
FieldNamingConventions | The final field name '_mapMockDemand' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 52 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 52 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 60 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 77 |
Rule | Violation | Priority | Line |
---|---|---|---|
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 47 |
FieldNamingConventions | The final field name '_listLogAction' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 47 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 85–105 |
Rule | Violation | Priority | Line |
---|---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 50–282 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 52 |
FieldNamingConventions | The final field name '_listMockNotification' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 52 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 61 |
NPathComplexity | The method 'loadByFilter(NotificationFilter)' has an NPath complexity of 2917 | 3 | 77–117 |
CyclomaticComplexity | The method 'loadByFilter(NotificationFilter)' has a cyclomatic complexity of 16. | 3 | 77–117 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 79 |
NPathComplexity | The method 'loadIdsByFilter(NotificationFilter)' has an NPath complexity of 2917 | 3 | 157–197 |
CyclomaticComplexity | The method 'loadIdsByFilter(NotificationFilter)' has a cyclomatic complexity of 16. | 3 | 157–197 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 218 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 234 |
ShortVariable | Avoid variables with short names like id | 3 | 259 |
Rule | Violation | Priority | Line |
---|---|---|---|
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 50 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _eventList field if you want a default access modifier | 3 | 50 |
ControlStatementBraces | This statement should have braces | 3 | 71 |
Rule | Violation | Priority | Line |
---|---|---|---|
FieldNamingConventions | The final field name '_listLogAction' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 47 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 47 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 85–120 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 46 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 43 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strBillingAccount field if you want a default access modifier | 3 | 49 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 49 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 50 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _strBillingGroup field if you want a default access modifier | 3 | 50 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 55 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 149 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 235 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 275 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 47 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 87 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 53 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 47 |
FormalParameterNamingConventions | The method parameter name '_strType' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 120 |
FormalParameterNamingConventions | The method parameter name '_strStatus' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 137 |
FormalParameterNamingConventions | The method parameter name '_strReason' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 154 |
FormalParameterNamingConventions | The method parameter name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 172 |
Rule | Violation | Priority | Line |
---|---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 44–152 |
ShortVariable | Avoid variables with short names like id | 3 | 52 |
ShortVariable | Avoid variables with short names like id | 3 | 151 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnnecessaryModifier | Unnecessary modifier 'public' on method 'loadByNotification': the method is declared in an interface type | 3 | 73 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 49 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 60 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 283 |
Rule | Violation | Priority | Line |
---|---|---|---|
ClassNamingConventions | The utility class name 'NotificationConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 39–57 |
Rule | Violation | Priority | Line |
---|---|---|---|
ImportFromSamePackage | No need to import a type that lives in the same package | 3 | 42 |
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 49 |
Rule | Violation | Priority | Line |
---|---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 43–294 |
FormalParameterNamingConventions | The method parameter name '_lStartDate' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 230 |
FormalParameterNamingConventions | The method parameter name '_lEndDate' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 257 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 44 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 47 |
Rule | Violation | Priority | Line |
---|---|---|---|
CommentRequired | Enum comments are required | 3 | 4–88 |
UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'EnumGenericStatus(Integer, String)': enum constructors are implicitly private | 3 | 22–26 |
Rule | Violation | Priority | Line |
---|---|---|---|
AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 3 | 41–122 |
FormalParameterNamingConventions | The method parameter name '_strErrorMessage' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 118 |
Rule | Violation | Priority | Line |
---|---|---|---|
UnnecessaryModifier | Unnecessary modifier 'public' on method 'process': the method is declared in an interface type | 3 | 51 |
UnnecessaryModifier | Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type | 3 | 58 |
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like e | 3 | 66 |