Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/stock/commons/AbstractDTO.java

Rule Violation Line
FieldNamingConventions The field name 'mapper' doesn't match '_[a-z][a-zA-Z0-9]*' 54

fr/paris/lutece/plugins/stock/commons/exception/ValidationException.java

Rule Violation Line
FieldNamingConventions The field name 'constraintViolationList' doesn't match '_[a-z][a-zA-Z0-9]*' 57

fr/paris/lutece/plugins/stock/commons/validator/AfterCurrentDateValidator.java

Rule Violation Line
FieldNamingConventions The field name 'sdf' doesn't match '_[a-z][a-zA-Z0-9]*' 53

fr/paris/lutece/plugins/stock/commons/validator/DateFormatValidator.java

Rule Violation Line
FieldNamingConventions The field name 'format' doesn't match '_[a-z][a-zA-Z0-9]*' 53
FieldNamingConventions The field name 'sdf' doesn't match '_[a-z][a-zA-Z0-9]*' 54

fr/paris/lutece/plugins/stock/commons/validator/HexColorCodeValidator.java

Rule Violation Line
FieldNamingConventions The final field name '_pattern' doesn't match '[a-z][a-zA-Z0-9]*' 50

fr/paris/lutece/plugins/stock/commons/validator/ListEmailValidator.java

Rule Violation Line
FieldNamingConventions The field name 'pattern' doesn't match '_[a-z][a-zA-Z0-9]*' 58

fr/paris/lutece/plugins/stock/service/impl/AbstractService.java

Rule Violation Line
AbstractClassWithoutAnyMethod No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 4548

fr/paris/lutece/plugins/stock/utils/FileUtils.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 49111
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 73

fr/paris/lutece/plugins/stock/utils/MultiPartFormOutputStream.java

Rule Violation Line
AvoidUsingShortType Do not use the short type 192
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 275

fr/paris/lutece/plugins/stock/utils/QrCodeFactory.java

Rule Violation Line
ClassNamingConventions The utility class name 'QrCodeFactory' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 5494

fr/paris/lutece/plugins/stock/utils/TimestampValidation.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'setErrorValue' called during object construction 58

Priority 2

fr/paris/lutece/plugins/stock/utils/FileUtils.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'file' 96

fr/paris/lutece/plugins/stock/utils/ImageUtils.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 80
GuardLogStatement Logger calls should be surrounded by log level guards. 109

fr/paris/lutece/plugins/stock/utils/MultiPartFormOutputStream.java

Rule Violation Line
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 119
AvoidReassigningParameters Avoid reassigning parameters such as 'value' 222

fr/paris/lutece/plugins/stock/utils/NumberUtils.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 70

Priority 3

fr/paris/lutece/plugins/stock/commons/AbstractDTO.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 79

fr/paris/lutece/plugins/stock/commons/dao/AbstractStockDAO.java

Rule Violation Line
ShortVariable Avoid variables with short names like em 74
ShortVariable Avoid variables with short names like cb 75
ShortVariable Avoid variables with short names like pq 93
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'pq' 95
ShortVariable Avoid variables with short names like pq 112

fr/paris/lutece/plugins/stock/commons/dao/PagedQuery.java

Rule Violation Line
ImmutableField Private field '_countQuery' could be made final; it is only initialized in the declaration or constructor. 61
SingularField Perhaps '_paginationProperties' could be replaced by a local variable. 64
ImmutableField Private field '_paginationProperties' could be made final; it is only initialized in the declaration or constructor. 64
CommentRequired Public method and constructor comments are required 95106
MissingOverride The method 'getResultList()' is missing an @Override annotation. 95106
MissingOverride The method 'getSingleResult()' is missing an @Override annotation. 113116
CommentRequired Public method and constructor comments are required 113116
CommentRequired Public method and constructor comments are required 123126
MissingOverride The method 'executeUpdate()' is missing an @Override annotation. 123126
LinguisticNaming Linguistics Antipattern - The setter 'setMaxResults' should not return any type except void linguistically 133136
MissingOverride The method 'setMaxResults(int)' is missing an @Override annotation. 133136
CommentRequired Public method and constructor comments are required 133136
MissingOverride The method 'getMaxResults()' is missing an @Override annotation. 143146
CommentRequired Public method and constructor comments are required 143146
LinguisticNaming Linguistics Antipattern - The setter 'setFirstResult' should not return any type except void linguistically 153156
CommentRequired Public method and constructor comments are required 153156
MissingOverride The method 'setFirstResult(int)' is missing an @Override annotation. 153156
MissingOverride The method 'getFirstResult()' is missing an @Override annotation. 163166
CommentRequired Public method and constructor comments are required 163166
MissingOverride The method 'setHint(String, Object)' is missing an @Override annotation. 173176
CommentRequired Public method and constructor comments are required 173176
LinguisticNaming Linguistics Antipattern - The setter 'setHint' should not return any type except void linguistically 173176
CommentRequired Public method and constructor comments are required 183186
MissingOverride The method 'getHints()' is missing an @Override annotation. 183186
LinguisticNaming Linguistics Antipattern - The setter 'setParameter' should not return any type except void linguistically 193196
MissingOverride The method 'setParameter(Parameter, T)' is missing an @Override annotation. 193196
CommentRequired Public method and constructor comments are required 193196
CommentRequired Public method and constructor comments are required 203206
MissingOverride The method 'setParameter(Parameter, Calendar, TemporalType)' is missing an @Override annotation. 203206
LinguisticNaming Linguistics Antipattern - The setter 'setParameter' should not return any type except void linguistically 203206
CommentRequired Public method and constructor comments are required 213216
MissingOverride The method 'setParameter(Parameter, Date, TemporalType)' is missing an @Override annotation. 213216
LinguisticNaming Linguistics Antipattern - The setter 'setParameter' should not return any type except void linguistically 213216
LinguisticNaming Linguistics Antipattern - The setter 'setParameter' should not return any type except void linguistically 223226
CommentRequired Public method and constructor comments are required 223226
MissingOverride The method 'setParameter(String, Object)' is missing an @Override annotation. 223226
MissingOverride The method 'setParameter(String, Calendar, TemporalType)' is missing an @Override annotation. 233236
LinguisticNaming Linguistics Antipattern - The setter 'setParameter' should not return any type except void linguistically 233236
CommentRequired Public method and constructor comments are required 233236
MissingOverride The method 'setParameter(String, Date, TemporalType)' is missing an @Override annotation. 243246
CommentRequired Public method and constructor comments are required 243246
LinguisticNaming Linguistics Antipattern - The setter 'setParameter' should not return any type except void linguistically 243246
MissingOverride The method 'setParameter(int, Object)' is missing an @Override annotation. 253256
CommentRequired Public method and constructor comments are required 253256
LinguisticNaming Linguistics Antipattern - The setter 'setParameter' should not return any type except void linguistically 253256
LinguisticNaming Linguistics Antipattern - The setter 'setParameter' should not return any type except void linguistically 263266
CommentRequired Public method and constructor comments are required 263266
MissingOverride The method 'setParameter(int, Calendar, TemporalType)' is missing an @Override annotation. 263266
LinguisticNaming Linguistics Antipattern - The setter 'setParameter' should not return any type except void linguistically 273276
CommentRequired Public method and constructor comments are required 273276
MissingOverride The method 'setParameter(int, Date, TemporalType)' is missing an @Override annotation. 273276
MissingOverride The method 'getParameters()' is missing an @Override annotation. 283286
CommentRequired Public method and constructor comments are required 283286
CommentRequired Public method and constructor comments are required 293296
MissingOverride The method 'getParameter(String)' is missing an @Override annotation. 293296
MissingOverride The method 'getParameter(String, Class)' is missing an @Override annotation. 303306
CommentRequired Public method and constructor comments are required 303306
CommentRequired Public method and constructor comments are required 313316
MissingOverride The method 'getParameter(int)' is missing an @Override annotation. 313316
MissingOverride The method 'getParameter(int, Class)' is missing an @Override annotation. 323326
CommentRequired Public method and constructor comments are required 323326
MissingOverride The method 'isBound(Parameter)' is missing an @Override annotation. 333336
CommentRequired Public method and constructor comments are required 333336
CommentRequired Public method and constructor comments are required 343346
MissingOverride The method 'getParameterValue(Parameter)' is missing an @Override annotation. 343346
CommentRequired Public method and constructor comments are required 353356
MissingOverride The method 'getParameterValue(String)' is missing an @Override annotation. 353356
CommentRequired Public method and constructor comments are required 363366
MissingOverride The method 'getParameterValue(int)' is missing an @Override annotation. 363366
CommentRequired Public method and constructor comments are required 373376
LinguisticNaming Linguistics Antipattern - The setter 'setFlushMode' should not return any type except void linguistically 373376
MissingOverride The method 'setFlushMode(FlushModeType)' is missing an @Override annotation. 373376
MissingOverride The method 'getFlushMode()' is missing an @Override annotation. 383386
CommentRequired Public method and constructor comments are required 383386
MissingOverride The method 'setLockMode(LockModeType)' is missing an @Override annotation. 393396
LinguisticNaming Linguistics Antipattern - The setter 'setLockMode' should not return any type except void linguistically 393396
CommentRequired Public method and constructor comments are required 393396
MissingOverride The method 'getLockMode()' is missing an @Override annotation. 403406
CommentRequired Public method and constructor comments are required 403406
MissingOverride The method 'unwrap(Class)' is missing an @Override annotation. 413416
CommentRequired Public method and constructor comments are required 413416

fr/paris/lutece/plugins/stock/commons/dao/PaginationPropertiesAdapterDataTable.java

Rule Violation Line
ShortVariable Avoid variables with short names like p 52

fr/paris/lutece/plugins/stock/commons/dao/PaginationPropertiesImpl.java

Rule Violation Line
MissingOverride The method 'getFirstResult()' is missing an @Override annotation. 7881
MissingOverride The method 'getPageSize()' is missing an @Override annotation. 8689

fr/paris/lutece/plugins/stock/commons/exception/BusinessException.java

Rule Violation Line
DataClass The class 'BusinessException' is suspected to be a Data Class (WOC=14.286%, NOPA=0, NOAM=4, WMC=9) 44142
ArrayIsStoredDirectly The user-supplied array 'arguments' is stored directly. 74
MethodReturnsInternalArray Returning '_arguments' may expose an internal array. 109
ArrayIsStoredDirectly The user-supplied array 'arguments' is stored directly. 118
MissingOverride The method 'getMessage()' is missing an @Override annotation. 128141

fr/paris/lutece/plugins/stock/commons/exception/FunctionnalException.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 5760

fr/paris/lutece/plugins/stock/commons/exception/ValidationException.java

Rule Violation Line
MissingOverride The method 'getMessage()' is missing an @Override annotation. 124138

fr/paris/lutece/plugins/stock/commons/validator/AfterCurrentDateValidator.java

Rule Violation Line
SingularField Perhaps 'sdf' could be replaced by a local variable. 53
MissingOverride The method 'initialize(AfterCurrentDate)' is missing an @Override annotation. 5862
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 60
MissingOverride The method 'isValid(String, ConstraintValidatorContext)' is missing an @Override annotation. 6778
CollapsibleIfStatements These nested if statements could be combined 7275

fr/paris/lutece/plugins/stock/commons/validator/DateFormatValidator.java

Rule Violation Line
SingularField Perhaps 'format' could be replaced by a local variable. 53
MissingOverride The method 'initialize(DateFormat)' is missing an @Override annotation. 5964
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 62
MissingOverride The method 'isValid(String, ConstraintValidatorContext)' is missing an @Override annotation. 6984

fr/paris/lutece/plugins/stock/commons/validator/HexColorCodeValidator.java

Rule Violation Line
MissingOverride The method 'initialize(HexColorCode)' is missing an @Override annotation. 5557
UncommentedEmptyMethodBody Document empty method body 5657
MissingOverride The method 'isValid(String, ConstraintValidatorContext)' is missing an @Override annotation. 6265

fr/paris/lutece/plugins/stock/commons/validator/ListEmailValidator.java

Rule Violation Line
ImmutableField Private field 'pattern' could be made final; it is only initialized in the declaration or constructor. 58
MissingOverride The method 'initialize(ListEmail)' is missing an @Override annotation. 6466
UncommentedEmptyMethodBody Document empty method body 6566
MissingOverride The method 'isValid(String, ConstraintValidatorContext)' is missing an @Override annotation. 7188
ShortVariable Avoid variables with short names like m 80

fr/paris/lutece/plugins/stock/commons/validator/ValidIdValidator.java

Rule Violation Line
MissingOverride The method 'initialize(ValidId)' is missing an @Override annotation. 5254
UncommentedEmptyMethodBody Document empty method body 5354
MissingOverride The method 'isValid(AbstractDTO, ConstraintValidatorContext)' is missing an @Override annotation. 7078

fr/paris/lutece/plugins/stock/commons/validator/annotation/AfterCurrentDate.java

Rule Violation Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 4850
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 51

fr/paris/lutece/plugins/stock/commons/validator/annotation/DateFormat.java

Rule Violation Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 4850
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 51

fr/paris/lutece/plugins/stock/commons/validator/annotation/HexColorCode.java

Rule Violation Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 4850
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 51

fr/paris/lutece/plugins/stock/commons/validator/annotation/ListEmail.java

Rule Violation Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 4850
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 51

fr/paris/lutece/plugins/stock/commons/validator/annotation/ValidId.java

Rule Violation Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 4850
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 51

fr/paris/lutece/plugins/stock/service/impl/AbstractService.java

Rule Violation Line
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 4548

fr/paris/lutece/plugins/stock/utils/CsvUtils.java

Rule Violation Line
CommentRequired Header comments are required 54158
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 55158
CyclomaticComplexity The method 'ecrireCsv(String, ResultList, OutputStream)' has a cyclomatic complexity of 16. 81157
LinguisticNaming Linguistics Antipattern - The variable 'isProprieteCsv' indicates linguistically it is a boolean, but it is 'InputStream' 88
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 88
ShortVariable Avoid variables with short names like i 122
AvoidDuplicateLiterals The String literal "Problème lors de l'édition du fichier CSV : " appears 4 times in this file; the first occurrence is on line 140 140
IdenticalCatchBranches 'catch' branch identical to 'IOException' branch 142145
IdenticalCatchBranches 'catch' branch identical to 'IOException' branch 146149
IdenticalCatchBranches 'catch' branch identical to 'IOException' branch 150153

fr/paris/lutece/plugins/stock/utils/DateUtils.java

Rule Violation Line
GodClass Possible God Class (WMC=49, ATFD=116, TCC=2.105%) 52549
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 87
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'timeStamp' 120
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strDate' 137
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strDate' 154
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 166
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 178
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 212
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'timeStamp' 245
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 271
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 272
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 288
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 315322
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 319
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 333
PositionLiteralsFirstInComparisons Position literals first in String comparisons 336
ShortVariable Avoid variables with short names like c 342
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 347
CyclomaticComplexity The method 'valideDateEntreLeEtLeOuLe(List, boolean)' has a cyclomatic complexity of 11. 365414
ConfusingTernary Avoid if (x != y) ..; else ..; 369412
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 430
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'timeStamp' 451
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'timeStamp' 521
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'timeStamp' 547

fr/paris/lutece/plugins/stock/utils/EntityBean.java

Rule Violation Line
ShortVariable Avoid variables with short names like id 55

fr/paris/lutece/plugins/stock/utils/FileUtils.java

Rule Violation Line
ShortVariable Avoid variables with short names like is 69
AssignmentInOperand Avoid assignments in operands 76
ShortVariable Avoid variables with short names like i 99

fr/paris/lutece/plugins/stock/utils/FloatConverter.java

Rule Violation Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 55
MissingOverride The method 'convert(Class, Object)' is missing an @Override annotation. 5582
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 6272
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 68

fr/paris/lutece/plugins/stock/utils/ImageUtils.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 113

fr/paris/lutece/plugins/stock/utils/IntegerConverter.java

Rule Violation Line
MissingOverride The method 'convert(Class, Object)' is missing an @Override annotation. 5582
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 55
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 6272
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 68

fr/paris/lutece/plugins/stock/utils/ListUtils.java

Rule Violation Line
AvoidDuplicateLiterals The String literal "Erreur lors de la création d'une liste pour combo : " appears 4 times in this file; the first occurrence is on line 99 99
IdenticalCatchBranches 'catch' branch identical to 'IllegalAccessException' branch 101104
IdenticalCatchBranches 'catch' branch identical to 'IllegalAccessException' branch 105108
IdenticalCatchBranches 'catch' branch identical to 'IllegalAccessException' branch 109112
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 109

fr/paris/lutece/plugins/stock/utils/MapConverter.java

Rule Violation Line
MissingOverride The method 'convert(Class, Object)' is missing an @Override annotation. 5999
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 59
CollapsibleIfStatements These nested if statements could be combined 6679
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 6679

fr/paris/lutece/plugins/stock/utils/MultiPartFormOutputStream.java

Rule Violation Line
GodClass Possible God Class (WMC=47, ATFD=36, TCC=4.412%) 58490
TooManyMethods This class has too many methods, consider refactoring it. 59490
ImmutableField Private field '_out' could be made final; it is only initialized in the declaration or constructor. 74
ImmutableField Private field '_boundary' could be made final; it is only initialized in the declaration or constructor. 79
ShortVariable Avoid variables with short names like os 93
UnnecessaryConversionTemporary Avoid unnecessary temporaries when converting primitives to Strings 119
ShortVariable Avoid variables with short names like is 292
UselessStringValueOf No need to call String.valueOf to append to a string. 304
UselessStringValueOf No need to call String.valueOf to append to a string. 304
UselessStringValueOf No need to call String.valueOf to append to a string. 305
UselessStringValueOf No need to call String.valueOf to append to a string. 305
UselessStringValueOf No need to call String.valueOf to append to a string. 306
UselessStringValueOf No need to call String.valueOf to append to a string. 306
ShortVariable Avoid variables with short names like r 326
AssignmentInOperand Avoid assignments in operands 327
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 336
UselessStringValueOf No need to call String.valueOf to append to a string. 371
UselessStringValueOf No need to call String.valueOf to append to a string. 371
UselessStringValueOf No need to call String.valueOf to append to a string. 372
UselessStringValueOf No need to call String.valueOf to append to a string. 372
UselessStringValueOf No need to call String.valueOf to append to a string. 373
UselessStringValueOf No need to call String.valueOf to append to a string. 373

fr/paris/lutece/plugins/stock/utils/NumberUtils.java

Rule Violation Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 121
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 142
ShortVariable Avoid variables with short names like n 156
ShortVariable Avoid variables with short names like a 156
ShortVariable Avoid variables with short names like p 158
ShortVariable Avoid variables with short names like a 169
ShortVariable Avoid variables with short names like nf 171
ShortVariable Avoid variables with short names like df 172
ShortVariable Avoid variables with short names like p 189
ShortVariable Avoid variables with short names like m 190
ShortVariable Avoid variables with short names like p 204
ShortVariable Avoid variables with short names like m 205

fr/paris/lutece/plugins/stock/utils/QrCodeFactory.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 83
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 87

fr/paris/lutece/plugins/stock/utils/TimestampConverter.java

Rule Violation Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 59
MissingOverride The method 'convert(Class, Object)' is missing an @Override annotation. 5999
CollapsibleIfStatements These nested if statements could be combined 6679
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 6679

fr/paris/lutece/plugins/stock/utils/TimestampValidation.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 128131
ShortVariable Avoid variables with short names like o 128
UselessOverridingMethod Overriding method merely calls super 134137

fr/paris/lutece/plugins/stock/utils/dozer/CustomDTODozerConverter.java

Rule Violation Line
MissingOverride The method 'convert(Object, Object, Class, Class)' is missing an @Override annotation. 6199
CyclomaticComplexity The method 'convert(Object, Object, Class, Class)' has a cyclomatic complexity of 13. 6199
ShortVariable Avoid variables with short names like id 71
AvoidDuplicateLiterals The String literal "Problème lors de la conversion d'un " appears 4 times in this file; the first occurrence is on line 82 82
IdenticalCatchBranches 'catch' branch identical to 'NumberFormatException' branch 8487
IdenticalCatchBranches 'catch' branch identical to 'NumberFormatException' branch 8891
IdenticalCatchBranches 'catch' branch identical to 'NumberFormatException' branch 9295

fr/paris/lutece/plugins/stock/utils/dozer/CustomIdDozerConverter.java

Rule Violation Line
MissingOverride The method 'convert(Object, Object, Class, Class)' is missing an @Override annotation. 5799
ConfusingTernary Avoid if (x != y) ..; else ..; 6097
ShortVariable Avoid variables with short names like id 65
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 69
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 96

Priority 4

fr/paris/lutece/plugins/stock/commons/exception/BusinessException.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 118

fr/paris/lutece/plugins/stock/utils/MultiPartFormOutputStream.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 117
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 132
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 147
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 162
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 177
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 192
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 207
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 222
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 261
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 292
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 359
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 403
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 416
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 448

Files

fr/paris/lutece/plugins/stock/commons/AbstractDTO.java

Rule Violation Priority Line
FieldNamingConventions The field name 'mapper' doesn't match '_[a-z][a-zA-Z0-9]*' 1 54
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 79

fr/paris/lutece/plugins/stock/commons/dao/AbstractStockDAO.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like em 3 74
ShortVariable Avoid variables with short names like cb 3 75
ShortVariable Avoid variables with short names like pq 3 93
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'pq' 3 95
ShortVariable Avoid variables with short names like pq 3 112

fr/paris/lutece/plugins/stock/commons/dao/PagedQuery.java

Rule Violation Priority Line
ImmutableField Private field '_countQuery' could be made final; it is only initialized in the declaration or constructor. 3 61
SingularField Perhaps '_paginationProperties' could be replaced by a local variable. 3 64
ImmutableField Private field '_paginationProperties' could be made final; it is only initialized in the declaration or constructor. 3 64
CommentRequired Public method and constructor comments are required 3 95106
MissingOverride The method 'getResultList()' is missing an @Override annotation. 3 95106
MissingOverride The method 'getSingleResult()' is missing an @Override annotation. 3 113116
CommentRequired Public method and constructor comments are required 3 113116
CommentRequired Public method and constructor comments are required 3 123126
MissingOverride The method 'executeUpdate()' is missing an @Override annotation. 3 123126
LinguisticNaming Linguistics Antipattern - The setter 'setMaxResults' should not return any type except void linguistically 3 133136
MissingOverride The method 'setMaxResults(int)' is missing an @Override annotation. 3 133136
CommentRequired Public method and constructor comments are required 3 133136
MissingOverride The method 'getMaxResults()' is missing an @Override annotation. 3 143146
CommentRequired Public method and constructor comments are required 3 143146
LinguisticNaming Linguistics Antipattern - The setter 'setFirstResult' should not return any type except void linguistically 3 153156
CommentRequired Public method and constructor comments are required 3 153156
MissingOverride The method 'setFirstResult(int)' is missing an @Override annotation. 3 153156
MissingOverride The method 'getFirstResult()' is missing an @Override annotation. 3 163166
CommentRequired Public method and constructor comments are required 3 163166
MissingOverride The method 'setHint(String, Object)' is missing an @Override annotation. 3 173176
CommentRequired Public method and constructor comments are required 3 173176
LinguisticNaming Linguistics Antipattern - The setter 'setHint' should not return any type except void linguistically 3 173176
CommentRequired Public method and constructor comments are required 3 183186
MissingOverride The method 'getHints()' is missing an @Override annotation. 3 183186
LinguisticNaming Linguistics Antipattern - The setter 'setParameter' should not return any type except void linguistically 3 193196
MissingOverride The method 'setParameter(Parameter, T)' is missing an @Override annotation. 3 193196
CommentRequired Public method and constructor comments are required 3 193196
CommentRequired Public method and constructor comments are required 3 203206
MissingOverride The method 'setParameter(Parameter, Calendar, TemporalType)' is missing an @Override annotation. 3 203206
LinguisticNaming Linguistics Antipattern - The setter 'setParameter' should not return any type except void linguistically 3 203206
CommentRequired Public method and constructor comments are required 3 213216
MissingOverride The method 'setParameter(Parameter, Date, TemporalType)' is missing an @Override annotation. 3 213216
LinguisticNaming Linguistics Antipattern - The setter 'setParameter' should not return any type except void linguistically 3 213216
LinguisticNaming Linguistics Antipattern - The setter 'setParameter' should not return any type except void linguistically 3 223226
CommentRequired Public method and constructor comments are required 3 223226
MissingOverride The method 'setParameter(String, Object)' is missing an @Override annotation. 3 223226
MissingOverride The method 'setParameter(String, Calendar, TemporalType)' is missing an @Override annotation. 3 233236
LinguisticNaming Linguistics Antipattern - The setter 'setParameter' should not return any type except void linguistically 3 233236
CommentRequired Public method and constructor comments are required 3 233236
MissingOverride The method 'setParameter(String, Date, TemporalType)' is missing an @Override annotation. 3 243246
CommentRequired Public method and constructor comments are required 3 243246
LinguisticNaming Linguistics Antipattern - The setter 'setParameter' should not return any type except void linguistically 3 243246
MissingOverride The method 'setParameter(int, Object)' is missing an @Override annotation. 3 253256
CommentRequired Public method and constructor comments are required 3 253256
LinguisticNaming Linguistics Antipattern - The setter 'setParameter' should not return any type except void linguistically 3 253256
LinguisticNaming Linguistics Antipattern - The setter 'setParameter' should not return any type except void linguistically 3 263266
CommentRequired Public method and constructor comments are required 3 263266
MissingOverride The method 'setParameter(int, Calendar, TemporalType)' is missing an @Override annotation. 3 263266
LinguisticNaming Linguistics Antipattern - The setter 'setParameter' should not return any type except void linguistically 3 273276
CommentRequired Public method and constructor comments are required 3 273276
MissingOverride The method 'setParameter(int, Date, TemporalType)' is missing an @Override annotation. 3 273276
MissingOverride The method 'getParameters()' is missing an @Override annotation. 3 283286
CommentRequired Public method and constructor comments are required 3 283286
CommentRequired Public method and constructor comments are required 3 293296
MissingOverride The method 'getParameter(String)' is missing an @Override annotation. 3 293296
MissingOverride The method 'getParameter(String, Class)' is missing an @Override annotation. 3 303306
CommentRequired Public method and constructor comments are required 3 303306
CommentRequired Public method and constructor comments are required 3 313316
MissingOverride The method 'getParameter(int)' is missing an @Override annotation. 3 313316
MissingOverride The method 'getParameter(int, Class)' is missing an @Override annotation. 3 323326
CommentRequired Public method and constructor comments are required 3 323326
MissingOverride The method 'isBound(Parameter)' is missing an @Override annotation. 3 333336
CommentRequired Public method and constructor comments are required 3 333336
CommentRequired Public method and constructor comments are required 3 343346
MissingOverride The method 'getParameterValue(Parameter)' is missing an @Override annotation. 3 343346
CommentRequired Public method and constructor comments are required 3 353356
MissingOverride The method 'getParameterValue(String)' is missing an @Override annotation. 3 353356
CommentRequired Public method and constructor comments are required 3 363366
MissingOverride The method 'getParameterValue(int)' is missing an @Override annotation. 3 363366
CommentRequired Public method and constructor comments are required 3 373376
LinguisticNaming Linguistics Antipattern - The setter 'setFlushMode' should not return any type except void linguistically 3 373376
MissingOverride The method 'setFlushMode(FlushModeType)' is missing an @Override annotation. 3 373376
MissingOverride The method 'getFlushMode()' is missing an @Override annotation. 3 383386
CommentRequired Public method and constructor comments are required 3 383386
MissingOverride The method 'setLockMode(LockModeType)' is missing an @Override annotation. 3 393396
LinguisticNaming Linguistics Antipattern - The setter 'setLockMode' should not return any type except void linguistically 3 393396
CommentRequired Public method and constructor comments are required 3 393396
MissingOverride The method 'getLockMode()' is missing an @Override annotation. 3 403406
CommentRequired Public method and constructor comments are required 3 403406
MissingOverride The method 'unwrap(Class)' is missing an @Override annotation. 3 413416
CommentRequired Public method and constructor comments are required 3 413416

fr/paris/lutece/plugins/stock/commons/dao/PaginationPropertiesAdapterDataTable.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like p 3 52

fr/paris/lutece/plugins/stock/commons/dao/PaginationPropertiesImpl.java

Rule Violation Priority Line
MissingOverride The method 'getFirstResult()' is missing an @Override annotation. 3 7881
MissingOverride The method 'getPageSize()' is missing an @Override annotation. 3 8689

fr/paris/lutece/plugins/stock/commons/exception/BusinessException.java

Rule Violation Priority Line
DataClass The class 'BusinessException' is suspected to be a Data Class (WOC=14.286%, NOPA=0, NOAM=4, WMC=9) 3 44142
ArrayIsStoredDirectly The user-supplied array 'arguments' is stored directly. 3 74
MethodReturnsInternalArray Returning '_arguments' may expose an internal array. 3 109
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 118
ArrayIsStoredDirectly The user-supplied array 'arguments' is stored directly. 3 118
MissingOverride The method 'getMessage()' is missing an @Override annotation. 3 128141

fr/paris/lutece/plugins/stock/commons/exception/FunctionnalException.java

Rule Violation Priority Line
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5760

fr/paris/lutece/plugins/stock/commons/exception/ValidationException.java

Rule Violation Priority Line
FieldNamingConventions The field name 'constraintViolationList' doesn't match '_[a-z][a-zA-Z0-9]*' 1 57
MissingOverride The method 'getMessage()' is missing an @Override annotation. 3 124138

fr/paris/lutece/plugins/stock/commons/validator/AfterCurrentDateValidator.java

Rule Violation Priority Line
FieldNamingConventions The field name 'sdf' doesn't match '_[a-z][a-zA-Z0-9]*' 1 53
SingularField Perhaps 'sdf' could be replaced by a local variable. 3 53
MissingOverride The method 'initialize(AfterCurrentDate)' is missing an @Override annotation. 3 5862
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 60
MissingOverride The method 'isValid(String, ConstraintValidatorContext)' is missing an @Override annotation. 3 6778
CollapsibleIfStatements These nested if statements could be combined 3 7275

fr/paris/lutece/plugins/stock/commons/validator/DateFormatValidator.java

Rule Violation Priority Line
FieldNamingConventions The field name 'format' doesn't match '_[a-z][a-zA-Z0-9]*' 1 53
SingularField Perhaps 'format' could be replaced by a local variable. 3 53
FieldNamingConventions The field name 'sdf' doesn't match '_[a-z][a-zA-Z0-9]*' 1 54
MissingOverride The method 'initialize(DateFormat)' is missing an @Override annotation. 3 5964
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 62
MissingOverride The method 'isValid(String, ConstraintValidatorContext)' is missing an @Override annotation. 3 6984

fr/paris/lutece/plugins/stock/commons/validator/HexColorCodeValidator.java

Rule Violation Priority Line
FieldNamingConventions The final field name '_pattern' doesn't match '[a-z][a-zA-Z0-9]*' 1 50
MissingOverride The method 'initialize(HexColorCode)' is missing an @Override annotation. 3 5557
UncommentedEmptyMethodBody Document empty method body 3 5657
MissingOverride The method 'isValid(String, ConstraintValidatorContext)' is missing an @Override annotation. 3 6265

fr/paris/lutece/plugins/stock/commons/validator/ListEmailValidator.java

Rule Violation Priority Line
ImmutableField Private field 'pattern' could be made final; it is only initialized in the declaration or constructor. 3 58
FieldNamingConventions The field name 'pattern' doesn't match '_[a-z][a-zA-Z0-9]*' 1 58
MissingOverride The method 'initialize(ListEmail)' is missing an @Override annotation. 3 6466
UncommentedEmptyMethodBody Document empty method body 3 6566
MissingOverride The method 'isValid(String, ConstraintValidatorContext)' is missing an @Override annotation. 3 7188
ShortVariable Avoid variables with short names like m 3 80

fr/paris/lutece/plugins/stock/commons/validator/ValidIdValidator.java

Rule Violation Priority Line
MissingOverride The method 'initialize(ValidId)' is missing an @Override annotation. 3 5254
UncommentedEmptyMethodBody Document empty method body 3 5354
MissingOverride The method 'isValid(AbstractDTO, ConstraintValidatorContext)' is missing an @Override annotation. 3 7078

fr/paris/lutece/plugins/stock/commons/validator/annotation/AfterCurrentDate.java

Rule Violation Priority Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 4850
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 51

fr/paris/lutece/plugins/stock/commons/validator/annotation/DateFormat.java

Rule Violation Priority Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 4850
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 51

fr/paris/lutece/plugins/stock/commons/validator/annotation/HexColorCode.java

Rule Violation Priority Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 4850
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 51

fr/paris/lutece/plugins/stock/commons/validator/annotation/ListEmail.java

Rule Violation Priority Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 4850
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 51

fr/paris/lutece/plugins/stock/commons/validator/annotation/ValidId.java

Rule Violation Priority Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 4850
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 51

fr/paris/lutece/plugins/stock/service/impl/AbstractService.java

Rule Violation Priority Line
AbstractClassWithoutAnyMethod No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 1 4548
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 3 4548

fr/paris/lutece/plugins/stock/utils/CsvUtils.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 54158
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 55158
CyclomaticComplexity The method 'ecrireCsv(String, ResultList, OutputStream)' has a cyclomatic complexity of 16. 3 81157
LinguisticNaming Linguistics Antipattern - The variable 'isProprieteCsv' indicates linguistically it is a boolean, but it is 'InputStream' 3 88
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 88
ShortVariable Avoid variables with short names like i 3 122
AvoidDuplicateLiterals The String literal "Problème lors de l'édition du fichier CSV : " appears 4 times in this file; the first occurrence is on line 140 3 140
IdenticalCatchBranches 'catch' branch identical to 'IOException' branch 3 142145
IdenticalCatchBranches 'catch' branch identical to 'IOException' branch 3 146149
IdenticalCatchBranches 'catch' branch identical to 'IOException' branch 3 150153

fr/paris/lutece/plugins/stock/utils/DateUtils.java

Rule Violation Priority Line
GodClass Possible God Class (WMC=49, ATFD=116, TCC=2.105%) 3 52549
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 87
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'timeStamp' 3 120
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strDate' 3 137
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'strDate' 3 154
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 166
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 178
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 212
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'timeStamp' 3 245
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 271
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 272
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 288
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 315322
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 319
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 333
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 336
ShortVariable Avoid variables with short names like c 3 342
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 347
CyclomaticComplexity The method 'valideDateEntreLeEtLeOuLe(List, boolean)' has a cyclomatic complexity of 11. 3 365414
ConfusingTernary Avoid if (x != y) ..; else ..; 3 369412
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 430
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'timeStamp' 3 451
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'timeStamp' 3 521
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'timeStamp' 3 547

fr/paris/lutece/plugins/stock/utils/EntityBean.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like id 3 55

fr/paris/lutece/plugins/stock/utils/FileUtils.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 49111
ShortVariable Avoid variables with short names like is 3 69
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 73
AssignmentInOperand Avoid assignments in operands 3 76
AvoidReassigningParameters Avoid reassigning parameters such as 'file' 2 96
ShortVariable Avoid variables with short names like i 3 99

fr/paris/lutece/plugins/stock/utils/FloatConverter.java

Rule Violation Priority Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 55
MissingOverride The method 'convert(Class, Object)' is missing an @Override annotation. 3 5582
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 6272
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 68

fr/paris/lutece/plugins/stock/utils/ImageUtils.java

Rule Violation Priority Line
GuardLogStatement Logger calls should be surrounded by log level guards. 2 80
GuardLogStatement Logger calls should be surrounded by log level guards. 2 109
ConfusingTernary Avoid if (x != y) ..; else ..; 3 113

fr/paris/lutece/plugins/stock/utils/IntegerConverter.java

Rule Violation Priority Line
MissingOverride The method 'convert(Class, Object)' is missing an @Override annotation. 3 5582
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 55
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 6272
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 68

fr/paris/lutece/plugins/stock/utils/ListUtils.java

Rule Violation Priority Line
AvoidDuplicateLiterals The String literal "Erreur lors de la création d'une liste pour combo : " appears 4 times in this file; the first occurrence is on line 99 3 99
IdenticalCatchBranches 'catch' branch identical to 'IllegalAccessException' branch 3 101104
IdenticalCatchBranches 'catch' branch identical to 'IllegalAccessException' branch 3 105108
IdenticalCatchBranches 'catch' branch identical to 'IllegalAccessException' branch 3 109112
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 109

fr/paris/lutece/plugins/stock/utils/MapConverter.java

Rule Violation Priority Line
MissingOverride The method 'convert(Class, Object)' is missing an @Override annotation. 3 5999
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 59
CollapsibleIfStatements These nested if statements could be combined 3 6679
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 6679

fr/paris/lutece/plugins/stock/utils/MultiPartFormOutputStream.java

Rule Violation Priority Line
GodClass Possible God Class (WMC=47, ATFD=36, TCC=4.412%) 3 58490
TooManyMethods This class has too many methods, consider refactoring it. 3 59490
ImmutableField Private field '_out' could be made final; it is only initialized in the declaration or constructor. 3 74
ImmutableField Private field '_boundary' could be made final; it is only initialized in the declaration or constructor. 3 79
ShortVariable Avoid variables with short names like os 3 93
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 4 117
UnnecessaryConversionTemporary Avoid unnecessary temporaries when converting primitives to Strings 3 119
BooleanInstantiation Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 2 119
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 4 132
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 4 147
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 4 162
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 4 177
AvoidUsingShortType Do not use the short type 1 192
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 4 192
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 4 207
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 4 222
AvoidReassigningParameters Avoid reassigning parameters such as 'value' 2 222
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 4 261
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 275
ShortVariable Avoid variables with short names like is 3 292
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 4 292
UselessStringValueOf No need to call String.valueOf to append to a string. 3 304
UselessStringValueOf No need to call String.valueOf to append to a string. 3 304
UselessStringValueOf No need to call String.valueOf to append to a string. 3 305
UselessStringValueOf No need to call String.valueOf to append to a string. 3 305
UselessStringValueOf No need to call String.valueOf to append to a string. 3 306
UselessStringValueOf No need to call String.valueOf to append to a string. 3 306
ShortVariable Avoid variables with short names like r 3 326
AssignmentInOperand Avoid assignments in operands 3 327
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 336
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 4 359
UselessStringValueOf No need to call String.valueOf to append to a string. 3 371
UselessStringValueOf No need to call String.valueOf to append to a string. 3 371
UselessStringValueOf No need to call String.valueOf to append to a string. 3 372
UselessStringValueOf No need to call String.valueOf to append to a string. 3 372
UselessStringValueOf No need to call String.valueOf to append to a string. 3 373
UselessStringValueOf No need to call String.valueOf to append to a string. 3 373
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 4 403
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 4 416
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' 4 448

fr/paris/lutece/plugins/stock/utils/NumberUtils.java

Rule Violation Priority Line
AvoidReassigningParameters Avoid reassigning parameters such as 'str' 2 70
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 121
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 142
ShortVariable Avoid variables with short names like n 3 156
ShortVariable Avoid variables with short names like a 3 156
ShortVariable Avoid variables with short names like p 3 158
ShortVariable Avoid variables with short names like a 3 169
ShortVariable Avoid variables with short names like nf 3 171
ShortVariable Avoid variables with short names like df 3 172
ShortVariable Avoid variables with short names like p 3 189
ShortVariable Avoid variables with short names like m 3 190
ShortVariable Avoid variables with short names like p 3 204
ShortVariable Avoid variables with short names like m 3 205

fr/paris/lutece/plugins/stock/utils/QrCodeFactory.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'QrCodeFactory' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 5494
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 83
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 87

fr/paris/lutece/plugins/stock/utils/TimestampConverter.java

Rule Violation Priority Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 59
MissingOverride The method 'convert(Class, Object)' is missing an @Override annotation. 3 5999
CollapsibleIfStatements These nested if statements could be combined 3 6679
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 6679

fr/paris/lutece/plugins/stock/utils/TimestampValidation.java

Rule Violation Priority Line
ConstructorCallsOverridableMethod Overridable method 'setErrorValue' called during object construction 1 58
UselessOverridingMethod Overriding method merely calls super 3 128131
ShortVariable Avoid variables with short names like o 3 128
UselessOverridingMethod Overriding method merely calls super 3 134137

fr/paris/lutece/plugins/stock/utils/dozer/CustomDTODozerConverter.java

Rule Violation Priority Line
MissingOverride The method 'convert(Object, Object, Class, Class)' is missing an @Override annotation. 3 6199
CyclomaticComplexity The method 'convert(Object, Object, Class, Class)' has a cyclomatic complexity of 13. 3 6199
ShortVariable Avoid variables with short names like id 3 71
AvoidDuplicateLiterals The String literal "Problème lors de la conversion d'un " appears 4 times in this file; the first occurrence is on line 82 3 82
IdenticalCatchBranches 'catch' branch identical to 'NumberFormatException' branch 3 8487
IdenticalCatchBranches 'catch' branch identical to 'NumberFormatException' branch 3 8891
IdenticalCatchBranches 'catch' branch identical to 'NumberFormatException' branch 3 9295

fr/paris/lutece/plugins/stock/utils/dozer/CustomIdDozerConverter.java

Rule Violation Priority Line
MissingOverride The method 'convert(Object, Object, Class, Class)' is missing an @Override annotation. 3 5799
ConfusingTernary Avoid if (x != y) ..; else ..; 3 6097
ShortVariable Avoid variables with short names like id 3 65
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 69
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 96