Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/elasticdata/modules/appointment/business/AppointmentHistoryDataObject.java

Rule Violation Ligne
ConstructorCallsOverridableMethod Overridable method 'setId' called during object construction 57

fr/paris/lutece/plugins/elasticdata/modules/appointment/service/AppointmentSlotUtil.java

Rule Violation Ligne
FieldNamingConventions The constant name '_stateService' doesn't match '[A-Z][A-Z_0-9]*' 88

fr/paris/lutece/plugins/elasticdata/modules/appointment/service/IndexingAppointmentService.java

Rule Violation Ligne
FieldNamingConventions The constant name '_nBatchSize' doesn't match '[A-Z][A-Z_0-9]*' 91

fr/paris/lutece/plugins/elasticdata/modules/appointment/service/IndexingSlotService.java

Rule Violation Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 65336
FieldNamingConventions The constant name '_nBatchSize' doesn't match '[A-Z][A-Z_0-9]*' 68

Priority 2

fr/paris/lutece/plugins/elasticdata/modules/appointment/service/AppointmentSlotUtil.java

Rule Violation Ligne
AvoidReassigningParameters Avoid reassigning parameters such as 'listSlots' 290
AvoidReassigningParameters Avoid reassigning parameters such as 'listAvailableSlots' 329

Priority 3

fr/paris/lutece/plugins/elasticdata/modules/appointment/business/AppointmentDataObject.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 6568
CommentRequired Public method and constructor comments are required 6568
UncommentedEmptyConstructor Document empty constructor 6568
CallSuperInConstructor It is a good practice to call super() in a constructor 7086
CommentRequired Public method and constructor comments are required 7086

fr/paris/lutece/plugins/elasticdata/modules/appointment/business/AppointmentForm.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 5574

fr/paris/lutece/plugins/elasticdata/modules/appointment/business/AppointmentHistoryDataObject.java

Rule Violation Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 5559
CommentRequired Public method and constructor comments are required 5559
MissingOverride The method 'getId()' is missing an @Override annotation. 6669
MissingOverride The method 'setId(String)' is missing an @Override annotation. 7780

fr/paris/lutece/plugins/elasticdata/modules/appointment/business/AppointmentPartialDataObject.java

Rule Violation Ligne
CommentRequired Public method and constructor comments are required 4955

fr/paris/lutece/plugins/elasticdata/modules/appointment/business/AppointmentSlotDataObject.java

Rule Violation Ligne
CommentRequired Header comments are required 49304

fr/paris/lutece/plugins/elasticdata/modules/appointment/service/AppointmentHistoryDataSource.java

Rule Violation Ligne
DefaultPackage Use explicit scoping instead of the default package private level 4950
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _resourceHistoryService field if you want a default access modifier 50

fr/paris/lutece/plugins/elasticdata/modules/appointment/service/AppointmentSlotUtil.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34388
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 59 characters appended. 243
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 55 characters appended. 272
CommentRequired Public method and constructor comments are required 359368

fr/paris/lutece/plugins/elasticdata/modules/appointment/service/IndexingAppointmentService.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34554
GodClass Possible God Class (WMC=49, ATFD=74, TCC=8.333%) 79554
CommentRequired Header comments are required 79554
TooManyMethods This class has too many methods, consider refactoring it. 80554
ImmutableField Private field '_resourceHistoryService' could be made final; it is only initialized in the declaration or constructor. 82
ImmutableField Private field '_stateService' could be made final; it is only initialized in the declaration or constructor. 83
ImmutableField Private field '_resourceWorkflowService' could be made final; it is only initialized in the declaration or constructor. 84
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 228
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 231
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 234
ConfusingTernary Avoid if (x != y) ..; else ..; 250
ControlStatementBraces This statement should have braces 422
ConfusingTernary Avoid if (x != y) ..; else ..; 443
ConfusingTernary Avoid if (x != y) ..; else ..; 534
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 545

fr/paris/lutece/plugins/elasticdata/modules/appointment/service/IndexingSlotService.java

Rule Violation Ligne
CommentRequired Header comments are required 65336
ControlStatementBraces This statement should have braces 267
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 304
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 324328
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 330334

Priority 4

fr/paris/lutece/plugins/elasticdata/modules/appointment/business/AppointmentDataObject.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 135138
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 324327

fr/paris/lutece/plugins/elasticdata/modules/appointment/business/AppointmentForm.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 144147
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 165168

fr/paris/lutece/plugins/elasticdata/modules/appointment/business/AppointmentPartialDataObject.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 104107

fr/paris/lutece/plugins/elasticdata/modules/appointment/business/AppointmentSlotDataObject.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 267270

fr/paris/lutece/plugins/elasticdata/modules/appointment/service/AppointmentSlotUtil.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'java.time.temporal.ChronoUnit' 42

fr/paris/lutece/plugins/elasticdata/modules/appointment/service/IndexingAppointmentService.java

Rule Violation Ligne
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 400
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 400

Fichiers

fr/paris/lutece/plugins/elasticdata/modules/appointment/business/AppointmentDataObject.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 6568
CommentRequired Public method and constructor comments are required 3 6568
UncommentedEmptyConstructor Document empty constructor 3 6568
CallSuperInConstructor It is a good practice to call super() in a constructor 3 7086
CommentRequired Public method and constructor comments are required 3 7086
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 135138
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 324327

fr/paris/lutece/plugins/elasticdata/modules/appointment/business/AppointmentForm.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 5574
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 144147
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 165168

fr/paris/lutece/plugins/elasticdata/modules/appointment/business/AppointmentHistoryDataObject.java

Rule Violation Priority Ligne
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5559
CommentRequired Public method and constructor comments are required 3 5559
ConstructorCallsOverridableMethod Overridable method 'setId' called during object construction 1 57
MissingOverride The method 'getId()' is missing an @Override annotation. 3 6669
MissingOverride The method 'setId(String)' is missing an @Override annotation. 3 7780

fr/paris/lutece/plugins/elasticdata/modules/appointment/business/AppointmentPartialDataObject.java

Rule Violation Priority Ligne
CommentRequired Public method and constructor comments are required 3 4955
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 104107

fr/paris/lutece/plugins/elasticdata/modules/appointment/business/AppointmentSlotDataObject.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 49304
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 267270

fr/paris/lutece/plugins/elasticdata/modules/appointment/service/AppointmentHistoryDataSource.java

Rule Violation Priority Ligne
DefaultPackage Use explicit scoping instead of the default package private level 3 4950
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _resourceHistoryService field if you want a default access modifier 3 50

fr/paris/lutece/plugins/elasticdata/modules/appointment/service/AppointmentSlotUtil.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34388
UnusedImports Avoid unused imports such as 'java.time.temporal.ChronoUnit' 4 42
FieldNamingConventions The constant name '_stateService' doesn't match '[A-Z][A-Z_0-9]*' 1 88
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 59 characters appended. 3 243
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 55 characters appended. 3 272
AvoidReassigningParameters Avoid reassigning parameters such as 'listSlots' 2 290
AvoidReassigningParameters Avoid reassigning parameters such as 'listAvailableSlots' 2 329
CommentRequired Public method and constructor comments are required 3 359368

fr/paris/lutece/plugins/elasticdata/modules/appointment/service/IndexingAppointmentService.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34554
GodClass Possible God Class (WMC=49, ATFD=74, TCC=8.333%) 3 79554
CommentRequired Header comments are required 3 79554
TooManyMethods This class has too many methods, consider refactoring it. 3 80554
ImmutableField Private field '_resourceHistoryService' could be made final; it is only initialized in the declaration or constructor. 3 82
ImmutableField Private field '_stateService' could be made final; it is only initialized in the declaration or constructor. 3 83
ImmutableField Private field '_resourceWorkflowService' could be made final; it is only initialized in the declaration or constructor. 3 84
FieldNamingConventions The constant name '_nBatchSize' doesn't match '[A-Z][A-Z_0-9]*' 1 91
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 228
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 231
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 234
ConfusingTernary Avoid if (x != y) ..; else ..; 3 250
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 4 400
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' 4 400
ControlStatementBraces This statement should have braces 3 422
ConfusingTernary Avoid if (x != y) ..; else ..; 3 443
ConfusingTernary Avoid if (x != y) ..; else ..; 3 534
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 545

fr/paris/lutece/plugins/elasticdata/modules/appointment/service/IndexingSlotService.java

Rule Violation Priority Ligne
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 65336
CommentRequired Header comments are required 3 65336
FieldNamingConventions The constant name '_nBatchSize' doesn't match '[A-Z][A-Z_0-9]*' 1 68
ControlStatementBraces This statement should have braces 3 267
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 304
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 324328
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 330334