Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 3

fr/paris/lutece/plugins/extend/modules/actionbar/business/ActionButtonDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 47348
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 166
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 192
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 240
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 241
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 252
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 320

fr/paris/lutece/plugins/extend/modules/actionbar/business/ActionButtonHome.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 6265
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 9397
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 154172
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 157
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 161

fr/paris/lutece/plugins/extend/modules/actionbar/business/IActionButtonDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 45140

fr/paris/lutece/plugins/extend/modules/actionbar/business/config/ActionbarExtenderConfig.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 47

fr/paris/lutece/plugins/extend/modules/actionbar/business/config/ActionbarExtenderConfigDAO.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'plugin'. 69
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 71
UnusedFormalParameter Avoid unused method parameters such as 'plugin'. 101
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 103
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 114
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 191

fr/paris/lutece/plugins/extend/modules/actionbar/service/ActionbarResourceIdService.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 7275
ShortVariable Avoid variables with short names like rt 83
ShortVariable Avoid variables with short names like p 89

fr/paris/lutece/plugins/extend/modules/actionbar/web/ActionbarJspBean.java

Rule Violation Line
ImmutableField Private field '_actionbarService' could be made final; it is only initialized in the declaration or constructor. 133
ImmutableField Private field '_resourceTypeService' could be made final; it is only initialized in the declaration or constructor. 134
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 149151
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 159
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 159
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 164
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 164
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 211
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 211
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 317
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 317

fr/paris/lutece/plugins/extend/modules/actionbar/web/action/ActionbarInstallerPluginAction.java

Rule Violation Line
UncommentedEmptyMethodBody Document empty method body 7475

fr/paris/lutece/plugins/extend/modules/actionbar/web/component/ActionbarResourceExtenderComponent.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 125
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 125
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 138
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 138
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 176

Priority 4

fr/paris/lutece/plugins/extend/modules/actionbar/business/config/ActionbarExtenderConfig.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 7679

Files

fr/paris/lutece/plugins/extend/modules/actionbar/business/ActionButtonDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 47348
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 166
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 192
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 240
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 241
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 252
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 320

fr/paris/lutece/plugins/extend/modules/actionbar/business/ActionButtonHome.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 6265
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 9397
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 154172
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 157
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 161

fr/paris/lutece/plugins/extend/modules/actionbar/business/IActionButtonDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 45140

fr/paris/lutece/plugins/extend/modules/actionbar/business/config/ActionbarExtenderConfig.java

Rule Violation Priority Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 47
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 7679

fr/paris/lutece/plugins/extend/modules/actionbar/business/config/ActionbarExtenderConfigDAO.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'plugin'. 3 69
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 71
UnusedFormalParameter Avoid unused method parameters such as 'plugin'. 3 101
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 103
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 114
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 191

fr/paris/lutece/plugins/extend/modules/actionbar/service/ActionbarResourceIdService.java

Rule Violation Priority Line
CallSuperInConstructor It is a good practice to call super() in a constructor 3 7275
ShortVariable Avoid variables with short names like rt 3 83
ShortVariable Avoid variables with short names like p 3 89

fr/paris/lutece/plugins/extend/modules/actionbar/web/ActionbarJspBean.java

Rule Violation Priority Line
ImmutableField Private field '_actionbarService' could be made final; it is only initialized in the declaration or constructor. 3 133
ImmutableField Private field '_resourceTypeService' could be made final; it is only initialized in the declaration or constructor. 3 134
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 149151
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 159
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 159
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 164
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 164
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 211
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 211
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 317
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 317

fr/paris/lutece/plugins/extend/modules/actionbar/web/action/ActionbarInstallerPluginAction.java

Rule Violation Priority Line
UncommentedEmptyMethodBody Document empty method body 3 7475

fr/paris/lutece/plugins/extend/modules/actionbar/web/component/ActionbarResourceExtenderComponent.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 125
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 125
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 138
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 138
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 176