Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/poll/business/PollData.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_labelName' doesn't match '[a-z][a-zA-Z0-9]*' 48
FormalParameterNamingConventions The method parameter name '_nSize' doesn't match '[a-z][a-zA-Z0-9]*' 48
FormalParameterNamingConventions The method parameter name '_labelName' doesn't match '[a-z][a-zA-Z0-9]*' 59
FormalParameterNamingConventions The method parameter name '_nSize' doesn't match '[a-z][a-zA-Z0-9]*' 69

fr/paris/lutece/plugins/poll/business/PollVisualization.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' 49
FormalParameterNamingConventions The method parameter name '_strTitle' doesn't match '[a-z][a-zA-Z0-9]*' 49
FormalParameterNamingConventions The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' 60
FormalParameterNamingConventions The method parameter name '_strTitle' doesn't match '[a-z][a-zA-Z0-9]*' 70
FormalParameterNamingConventions The method parameter name '_type' doesn't match '[a-z][a-zA-Z0-9]*' 80

Priority 3

fr/paris/lutece/plugins/poll/business/PollData.java

Rule Violation Line
CommentRequired Header comments are required 3674
CommentRequired Public method and constructor comments are required 4446
UncommentedEmptyConstructor Document empty constructor 4446
CommentRequired Public method and constructor comments are required 4852
CommentRequired Public method and constructor comments are required 6467
CommentRequired Public method and constructor comments are required 6972

fr/paris/lutece/plugins/poll/business/PollFormQuestion.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 6064

fr/paris/lutece/plugins/poll/business/PollFormQuestionDAO.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 235
MissingOverride The method 'loadByQuestionId(int, int, Plugin)' is missing an @Override annotation. 261283

fr/paris/lutece/plugins/poll/business/PollVisualization.java

Rule Violation Line
CommentRequired Header comments are required 3695
UncommentedEmptyConstructor Document empty constructor 4447
CommentRequired Public method and constructor comments are required 4447
CommentRequired Public method and constructor comments are required 4953
CommentRequired Public method and constructor comments are required 5558
CommentRequired Public method and constructor comments are required 6063
CommentRequired Public method and constructor comments are required 6568
CommentRequired Public method and constructor comments are required 7073
CommentRequired Public method and constructor comments are required 7578
CommentRequired Public method and constructor comments are required 8083
CommentRequired Public method and constructor comments are required 8588
CommentRequired Public method and constructor comments are required 9093

fr/paris/lutece/plugins/poll/service/PollFormService.java

Rule Violation Line
CommentRequired Header comments are required 56116
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 57116
CommentRequired Public method and constructor comments are required 59114
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 62
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 71
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 87

fr/paris/lutece/plugins/poll/web/PollFormJspBean.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'INFO_POLLFORM_QUESTION_REMOVED'. 134
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 149
ConfusingTernary Avoid if (x != y) ..; else ..; 165
ConfusingTernary Avoid if (x != y) ..; else ..; 330337
LinguisticNaming Linguistics Antipattern - The variable 'isToolBox' indicates linguistically it is a boolean, but it is 'String' 387
ConfusingTernary Avoid if (x != y) ..; else ..; 391398

Priority 4

fr/paris/lutece/plugins/poll/business/PollForm.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 6568
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 191194

fr/paris/lutece/plugins/poll/business/PollFormQuestion.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 134137
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 155158

Files

fr/paris/lutece/plugins/poll/business/PollData.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3674
CommentRequired Public method and constructor comments are required 3 4446
UncommentedEmptyConstructor Document empty constructor 3 4446
FormalParameterNamingConventions The method parameter name '_labelName' doesn't match '[a-z][a-zA-Z0-9]*' 1 48
FormalParameterNamingConventions The method parameter name '_nSize' doesn't match '[a-z][a-zA-Z0-9]*' 1 48
CommentRequired Public method and constructor comments are required 3 4852
FormalParameterNamingConventions The method parameter name '_labelName' doesn't match '[a-z][a-zA-Z0-9]*' 1 59
CommentRequired Public method and constructor comments are required 3 6467
FormalParameterNamingConventions The method parameter name '_nSize' doesn't match '[a-z][a-zA-Z0-9]*' 1 69
CommentRequired Public method and constructor comments are required 3 6972

fr/paris/lutece/plugins/poll/business/PollForm.java

Rule Violation Priority Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 6568
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 191194

fr/paris/lutece/plugins/poll/business/PollFormQuestion.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 6064
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 134137
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 155158

fr/paris/lutece/plugins/poll/business/PollFormQuestionDAO.java

Rule Violation Priority Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 235
MissingOverride The method 'loadByQuestionId(int, int, Plugin)' is missing an @Override annotation. 3 261283

fr/paris/lutece/plugins/poll/business/PollVisualization.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3695
UncommentedEmptyConstructor Document empty constructor 3 4447
CommentRequired Public method and constructor comments are required 3 4447
FormalParameterNamingConventions The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' 1 49
CommentRequired Public method and constructor comments are required 3 4953
FormalParameterNamingConventions The method parameter name '_strTitle' doesn't match '[a-z][a-zA-Z0-9]*' 1 49
CommentRequired Public method and constructor comments are required 3 5558
FormalParameterNamingConventions The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' 1 60
CommentRequired Public method and constructor comments are required 3 6063
CommentRequired Public method and constructor comments are required 3 6568
FormalParameterNamingConventions The method parameter name '_strTitle' doesn't match '[a-z][a-zA-Z0-9]*' 1 70
CommentRequired Public method and constructor comments are required 3 7073
CommentRequired Public method and constructor comments are required 3 7578
FormalParameterNamingConventions The method parameter name '_type' doesn't match '[a-z][a-zA-Z0-9]*' 1 80
CommentRequired Public method and constructor comments are required 3 8083
CommentRequired Public method and constructor comments are required 3 8588
CommentRequired Public method and constructor comments are required 3 9093

fr/paris/lutece/plugins/poll/service/PollFormService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 56116
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 57116
CommentRequired Public method and constructor comments are required 3 59114
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 62
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 71
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 87

fr/paris/lutece/plugins/poll/web/PollFormJspBean.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'INFO_POLLFORM_QUESTION_REMOVED'. 3 134
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 149
ConfusingTernary Avoid if (x != y) ..; else ..; 3 165
ConfusingTernary Avoid if (x != y) ..; else ..; 3 330337
LinguisticNaming Linguistics Antipattern - The variable 'isToolBox' indicates linguistically it is a boolean, but it is 'String' 3 387
ConfusingTernary Avoid if (x != y) ..; else ..; 3 391398