The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_bMandatory' doesn't match '[a-z][a-zA-Z0-9]*' | 198 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_lastUpdateDate' doesn't match '[a-z][a-zA-Z0-9]*' | 474 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 73–639 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 43–198 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 84–951 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 53–56 |
| UncommentedEmptyConstructor | Document empty constructor | 53–56 |
| CommentRequired | Public method and constructor comments are required | 58–67 |
| CommentRequired | Public method and constructor comments are required | 69–76 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 73 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 74 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 75 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–528 |
| ImmutableField | Private field '_mapAttributes' could be made final; it is only initialized in the declaration or constructor. | 49 |
| CommentRequired | Public method and constructor comments are required | 53–56 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 55 |
| Rule | Violation | Line |
|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 113–140 |
| ShortVariable | Avoid variables with short names like i | 120 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 154 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 165 |
| ExcessiveMethodLength | Avoid really long methods. | 224–361 |
| NPathComplexity | The method 'checkDashboardIdentityFields(DashboardIdentity, HttpServletRequest, boolean, AttributeCategory)' has an NPath complexity of 2147483647 | 224–361 |
| CyclomaticComplexity | The method 'checkDashboardIdentityFields(DashboardIdentity, HttpServletRequest, boolean, AttributeCategory)' has a cyclomatic complexity of 66. | 224–361 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 227 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 227 |
| CyclomaticComplexity | The method 'checkDashboardIdentityFieldsFromServiceContract(DashboardIdentity, HttpServletRequest, boolean, String)' has a cyclomatic complexity of 13. | 367–404 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 369 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 369 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 384–389 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 394–397 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 410 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 420 |
| CyclomaticComplexity | The method 'getErrorValidation(HttpServletRequest, String, String, String, boolean, AttributeCategory)' has a cyclomatic complexity of 14. | 488–529 |
| CyclomaticComplexity | The method 'getErrorValidation(DashboardAttribute, String, String)' has a cyclomatic complexity of 13. | 539–573 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 605 |
| Rule | Violation | Line |
|---|---|---|
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 61 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 71 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 108 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 119 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 167 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–951 |
| CyclomaticComplexity | The class 'DashboardIdentityUtils' has a total cyclomatic complexity of 127 (highest 15). | 84–951 |
| GodClass | Possible God Class (WMC=127, ATFD=109, TCC=2.102%) | 84–951 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 85–951 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 104 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 105 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 106 |
| CommentRequired | Public method and constructor comments are required | 148–178 |
| NonThreadSafeSingleton | Singleton is not thread safe | 150–176 |
| ShortVariable | Avoid variables with short names like i | 156 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 225 |
| CommentRequired | Public method and constructor comments are required | 245–267 |
| CyclomaticComplexity | The method 'convertToIdentityDto(DashboardIdentity, boolean, AttributeCategory)' has a cyclomatic complexity of 10. | 297–329 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 302 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 303 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 388–406 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 415 |
| CyclomaticComplexity | The method 'updateIdentity(IdentityDto)' has a cyclomatic complexity of 14. | 572–604 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 572 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 578–598 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 583 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 593 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 663–670 |
| NPathComplexity | The method 'updateDashboardIdentityInSession(DashboardIdentity, DashboardIdentity)' has an NPath complexity of 2187 | 850–888 |
| CyclomaticComplexity | The method 'updateDashboardIdentityInSession(DashboardIdentity, DashboardIdentity)' has a cyclomatic complexity of 15. | 850–888 |
| ShortVariable | Avoid variables with short names like o | 937 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 55–88 |
| SingularField | Perhaps '_dashboardIdentity' could be replaced by a local variable. | 66 |
| CommentRequired | Public method and constructor comments are required | 68–87 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 77 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_securityTokenService' could be made final; it is only initialized in the declaration or constructor. | 114 |
| ImmutableField | Private field '_dashboardPropertiesGroup' could be made final; it is only initialized in the declaration or constructor. | 115 |
| ImmutableField | Private field '_lstGenderList' could be made final; it is only initialized in the declaration or constructor. | 116 |
| ShortVariable | Avoid variables with short names like i | 127 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 206 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 287 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 298 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 345 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 364 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–954 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 80–954 |
| UnusedPrivateField | Avoid unused private fields such as 'PROPERTY_FC_CERTIFIER_CODE'. | 148 |
| ImmutableField | Private field '_lstContactModeList' could be made final; it is only initialized in the declaration or constructor. | 152 |
| ImmutableField | Private field '_lstGenderList' could be made final; it is only initialized in the declaration or constructor. | 153 |
| UnusedPrivateField | Avoid unused private fields such as '_identityService'. | 162 |
| ImmutableField | Private field '_identityService' could be made final; it is only initialized in the declaration or constructor. | 162 |
| SingularField | Perhaps '_identityService' could be replaced by a local variable. | 162 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_bReInitAppCode' | 163 |
| UnusedPrivateField | Avoid unused private fields such as '_bReInitAppCode'. | 163 |
| ImmutableField | Private field '_securityTokenService' could be made final; it is only initialized in the declaration or constructor. | 165 |
| ShortVariable | Avoid variables with short names like i | 177 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 242 |
| CyclomaticComplexity | The method 'getModifyIdentity(HttpServletRequest)' has a cyclomatic complexity of 10. | 264–311 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 301 |
| CyclomaticComplexity | The method 'getCheckIdentity(HttpServletRequest)' has a cyclomatic complexity of 19. | 340–439 |
| NPathComplexity | The method 'getCheckIdentity(HttpServletRequest)' has an NPath complexity of 2480 | 340–439 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 384 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 400–410 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 402–405 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 495 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 506 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 507 |
| CyclomaticComplexity | The method 'doCheckIdentity(HttpServletRequest)' has a cyclomatic complexity of 10. | 526–584 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 571 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 578 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 579 |
| CommentRequired | Public method and constructor comments are required | 895–914 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 897 |
| CommentRequired | Public method and constructor comments are required | 917–952 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 58–129 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 81 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 81 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 42–71 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 42–71 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.security.UserNotSignedException' | 69 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.security.UserNotSignedException' | 49 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' | 51 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 53–56 |
| UncommentedEmptyConstructor | Document empty constructor | 3 | 53–56 |
| CommentRequired | Public method and constructor comments are required | 3 | 58–67 |
| CommentRequired | Public method and constructor comments are required | 3 | 69–76 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 73 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 74 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 75 |
| FormalParameterNamingConventions | The method parameter name '_bMandatory' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 198 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 34–528 |
| ImmutableField | Private field '_mapAttributes' could be made final; it is only initialized in the declaration or constructor. | 3 | 49 |
| CommentRequired | Public method and constructor comments are required | 3 | 53–56 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 55 |
| FormalParameterNamingConventions | The method parameter name '_lastUpdateDate' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 474 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 73–639 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 113–140 |
| ShortVariable | Avoid variables with short names like i | 3 | 120 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 154 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 165 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 224–361 |
| NPathComplexity | The method 'checkDashboardIdentityFields(DashboardIdentity, HttpServletRequest, boolean, AttributeCategory)' has an NPath complexity of 2147483647 | 3 | 224–361 |
| CyclomaticComplexity | The method 'checkDashboardIdentityFields(DashboardIdentity, HttpServletRequest, boolean, AttributeCategory)' has a cyclomatic complexity of 66. | 3 | 224–361 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 227 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 227 |
| CyclomaticComplexity | The method 'checkDashboardIdentityFieldsFromServiceContract(DashboardIdentity, HttpServletRequest, boolean, String)' has a cyclomatic complexity of 13. | 3 | 367–404 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 369 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 369 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 384–389 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 394–397 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 410 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 420 |
| CyclomaticComplexity | The method 'getErrorValidation(HttpServletRequest, String, String, String, boolean, AttributeCategory)' has a cyclomatic complexity of 14. | 3 | 488–529 |
| CyclomaticComplexity | The method 'getErrorValidation(DashboardAttribute, String, String)' has a cyclomatic complexity of 13. | 3 | 539–573 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 605 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 61 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 71 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 108 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 119 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 167 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 43–198 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–951 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.security.UserNotSignedException' | 4 | 69 |
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 84–951 |
| CyclomaticComplexity | The class 'DashboardIdentityUtils' has a total cyclomatic complexity of 127 (highest 15). | 3 | 84–951 |
| GodClass | Possible God Class (WMC=127, ATFD=109, TCC=2.102%) | 3 | 84–951 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 85–951 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 104 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 105 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 106 |
| CommentRequired | Public method and constructor comments are required | 3 | 148–178 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 150–176 |
| ShortVariable | Avoid variables with short names like i | 3 | 156 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 225 |
| CommentRequired | Public method and constructor comments are required | 3 | 245–267 |
| CyclomaticComplexity | The method 'convertToIdentityDto(DashboardIdentity, boolean, AttributeCategory)' has a cyclomatic complexity of 10. | 3 | 297–329 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 302 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 303 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 388–406 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 415 |
| CyclomaticComplexity | The method 'updateIdentity(IdentityDto)' has a cyclomatic complexity of 14. | 3 | 572–604 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 572 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 578–598 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 583 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 593 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 663–670 |
| NPathComplexity | The method 'updateDashboardIdentityInSession(DashboardIdentity, DashboardIdentity)' has an NPath complexity of 2187 | 3 | 850–888 |
| CyclomaticComplexity | The method 'updateDashboardIdentityInSession(DashboardIdentity, DashboardIdentity)' has a cyclomatic complexity of 15. | 3 | 850–888 |
| ShortVariable | Avoid variables with short names like o | 3 | 937 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.security.UserNotSignedException' | 4 | 49 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' | 4 | 51 |
| CommentRequired | Header comments are required | 3 | 55–88 |
| SingularField | Perhaps '_dashboardIdentity' could be replaced by a local variable. | 3 | 66 |
| CommentRequired | Public method and constructor comments are required | 3 | 68–87 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 77 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImmutableField | Private field '_securityTokenService' could be made final; it is only initialized in the declaration or constructor. | 3 | 114 |
| ImmutableField | Private field '_dashboardPropertiesGroup' could be made final; it is only initialized in the declaration or constructor. | 3 | 115 |
| ImmutableField | Private field '_lstGenderList' could be made final; it is only initialized in the declaration or constructor. | 3 | 116 |
| ShortVariable | Avoid variables with short names like i | 3 | 127 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 206 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 287 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 298 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 345 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 364 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–954 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 80–954 |
| UnusedPrivateField | Avoid unused private fields such as 'PROPERTY_FC_CERTIFIER_CODE'. | 3 | 148 |
| ImmutableField | Private field '_lstContactModeList' could be made final; it is only initialized in the declaration or constructor. | 3 | 152 |
| ImmutableField | Private field '_lstGenderList' could be made final; it is only initialized in the declaration or constructor. | 3 | 153 |
| UnusedPrivateField | Avoid unused private fields such as '_identityService'. | 3 | 162 |
| ImmutableField | Private field '_identityService' could be made final; it is only initialized in the declaration or constructor. | 3 | 162 |
| SingularField | Perhaps '_identityService' could be replaced by a local variable. | 3 | 162 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_bReInitAppCode' | 3 | 163 |
| UnusedPrivateField | Avoid unused private fields such as '_bReInitAppCode'. | 3 | 163 |
| ImmutableField | Private field '_securityTokenService' could be made final; it is only initialized in the declaration or constructor. | 3 | 165 |
| ShortVariable | Avoid variables with short names like i | 3 | 177 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 242 |
| CyclomaticComplexity | The method 'getModifyIdentity(HttpServletRequest)' has a cyclomatic complexity of 10. | 3 | 264–311 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 301 |
| CyclomaticComplexity | The method 'getCheckIdentity(HttpServletRequest)' has a cyclomatic complexity of 19. | 3 | 340–439 |
| NPathComplexity | The method 'getCheckIdentity(HttpServletRequest)' has an NPath complexity of 2480 | 3 | 340–439 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 384 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 400–410 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 402–405 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 495 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 506 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 507 |
| CyclomaticComplexity | The method 'doCheckIdentity(HttpServletRequest)' has a cyclomatic complexity of 10. | 3 | 526–584 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 571 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 578 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 579 |
| CommentRequired | Public method and constructor comments are required | 3 | 895–914 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 897 |
| CommentRequired | Public method and constructor comments are required | 3 | 917–952 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 58–129 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 81 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 81 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 42–71 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 42–71 |
