Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 5.3.5.

Fichiers

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/SAMLAuthentication.java

Violation Ligne
New exception is thrown in catch block, original stack trace may be lost 134
New exception is thrown in catch block, original stack trace may be lost 139
New exception is thrown in catch block, original stack trace may be lost 144
New exception is thrown in catch block, original stack trace may be lost 149
New exception is thrown in catch block, original stack trace may be lost 154
New exception is thrown in catch block, original stack trace may be lost 159
Document empty method 170171
Avoid variables with short names like it 181
Return an empty array rather than null. 203206

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/checkers/CertificateChecker.java

Violation Ligne
New exception is thrown in catch block, original stack trace may be lost 78
New exception is thrown in catch block, original stack trace may be lost 85

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/checkers/SAMLAssertionChecker.java

Violation Ligne
Avoid declaring a variable if it is unreferenced before a possible exit point. 124
Avoid instantiating Integer objects. Call Integer.valueOf() instead. 126127

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/checkers/SAMLChecker.java

Violation Ligne
Avoid modifiers which are implied by the context 4344

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/checkers/SignatureChecker.java

Violation Ligne
New exception is thrown in catch block, original stack trace may be lost 71
New exception is thrown in catch block, original stack trace may be lost 100
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 102
New exception is thrown in catch block, original stack trace may be lost 106

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/config/ConfigProperties.java

Violation Ligne
Avoid using redundant field initializer for 'instance' 50
Avoid using redundant field initializer for 'isTest' 51
Field isTest has the same name as a method 51
It is a good practice to call super() in a constructor 5371
A method/constructor shouldnt explicitly throw java.lang.Exception 83
A method/constructor shouldnt explicitly throw java.lang.Exception 83
Singleton is not thread safe 8588
Singleton is not thread safe 9396

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/config/Constants.java

Violation Ligne
An Interface should be used only to model a behaviour; consider converting this to a class. 3645
Avoid modifiers which are implied by the context 38
Avoid modifiers which are implied by the context 39
Avoid modifiers which are implied by the context 40
Avoid modifiers which are implied by the context 41
Avoid modifiers which are implied by the context 42
Avoid modifiers which are implied by the context 43
Avoid modifiers which are implied by the context 44

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/engine/BootStrap.java

Violation Ligne
Avoid using redundant field initializer for 'instance' 57
Avoid using redundant field initializer for 'idpMetaDataManager' 58
Avoid using redundant field initializer for 'spMetaDataManager' 59
Avoid using redundant field initializer for 'trustEngine' 60
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 81
Singleton is not thread safe 111114
Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 122
Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 153

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/engine/SAMLResponseManager.java

Violation Ligne
A high number of imports can indicate a high degree of coupling within an object. 34543
The class 'SAMLResponseManager' has a Standard Cyclomatic Complexity of 3 (Highest = 16). 76543
The class 'SAMLResponseManager' has a Cyclomatic Complexity of 3 (Highest = 18). 76543
The class 'SAMLResponseManager' has a Modified Cyclomatic Complexity of 3 (Highest = 16). 76543
Avoid using redundant field initializer for 'response' 78
Overridable method 'initialize' called during object construction 87
New exception is thrown in catch block, original stack trace may be lost 133
Avoid really long methods. 142296
The method validateResponseContent() has an NPath complexity of 73728 142296
The method 'validateResponseContent' has a Cyclomatic Complexity of 18. 142296
The method 'validateResponseContent' has a Standard Cyclomatic Complexity of 16. 142296
The method 'validateResponseContent' has a Modified Cyclomatic Complexity of 16. 142296
Avoid using Literals in Conditional Statements 157
Avoid using Literals in Conditional Statements 188
Avoid using Literals in Conditional Statements 199
Avoid using Literals in Conditional Statements 220
Avoid using Literals in Conditional Statements 267
Avoid using Literals in Conditional Statements 278
Avoid using Literals in Conditional Statements 289
Avoid using Literals in Conditional Statements 311
New exception is thrown in catch block, original stack trace may be lost 381
New exception is thrown in catch block, original stack trace may be lost 388
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 455

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/engine/SAMLTokenExtractor.java

Violation Ligne
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 61125
Avoid declaring a variable if it is unreferenced before a possible exit point. 71
New exception is thrown in catch block, original stack trace may be lost 87
New exception is thrown in catch block, original stack trace may be lost 114
New exception is thrown in catch block, original stack trace may be lost 120

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/engine/SAMLTokenHandler.java

Violation Ligne
Avoid using redundant field initializer for 'responseManager' 55

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/metadata/IDPMetadataManager.java

Violation Ligne
It is a good practice to call super() in a constructor 6366
Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 74
Avoid reassigning parameters such as 'inFilePath' 74
Avoid using Literals in Conditional Statements 102
Avoid using Literals in Conditional Statements 113
Avoid using Literals in Conditional Statements 123
New exception is thrown in catch block, original stack trace may be lost 159
New exception is thrown in catch block, original stack trace may be lost 166

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/metadata/MetadataManager.java

Violation Ligne
Abstract classes should be named AbstractXXX 60136
The Logger variable declaration does not contain the static and final modifiers 62
Avoid using redundant field initializer for 'metaData' 63
Avoid unnecessary constructors - the compiler will generate these for you 6567
Document empty constructor 6567
Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 128

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/metadata/SPMetadataManager.java

Violation Ligne
The Logger variable declaration does not contain the static and final modifiers 56
Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 59
Avoid reassigning parameters such as 'inFilePath' 59
Avoid using Literals in Conditional Statements 90
Avoid using Literals in Conditional Statements 100

fr/paris/lutece/plugins/mylutece/modules/saml/authentication/util/X509CertificateHelper.java

Violation Ligne
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4966
Avoid variables with short names like rc 53
Avoid variables with short names like in 54
Avoid variables with short names like cf 59