The following document contains the results of PMD 5.3.5.
| Violation | Line |
|---|---|
| New exception is thrown in catch block, original stack trace may be lost | 134 |
| New exception is thrown in catch block, original stack trace may be lost | 139 |
| New exception is thrown in catch block, original stack trace may be lost | 144 |
| New exception is thrown in catch block, original stack trace may be lost | 149 |
| New exception is thrown in catch block, original stack trace may be lost | 154 |
| New exception is thrown in catch block, original stack trace may be lost | 159 |
| Document empty method | 170–171 |
| Avoid variables with short names like it | 181 |
| Return an empty array rather than null. | 203–206 |
| Violation | Line |
|---|---|
| New exception is thrown in catch block, original stack trace may be lost | 78 |
| New exception is thrown in catch block, original stack trace may be lost | 85 |
| Violation | Line |
|---|---|
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 124 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 126–127 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 43–44 |
| Violation | Line |
|---|---|
| New exception is thrown in catch block, original stack trace may be lost | 71 |
| New exception is thrown in catch block, original stack trace may be lost | 100 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 102 |
| New exception is thrown in catch block, original stack trace may be lost | 106 |
| Violation | Line |
|---|---|
| Avoid using redundant field initializer for 'instance' | 50 |
| Avoid using redundant field initializer for 'isTest' | 51 |
| Field isTest has the same name as a method | 51 |
| It is a good practice to call super() in a constructor | 53–71 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 83 |
| A method/constructor shouldnt explicitly throw java.lang.Exception | 83 |
| Singleton is not thread safe | 85–88 |
| Singleton is not thread safe | 93–96 |
| Violation | Line |
|---|---|
| An Interface should be used only to model a behaviour; consider converting this to a class. | 36–45 |
| Avoid modifiers which are implied by the context | 38 |
| Avoid modifiers which are implied by the context | 39 |
| Avoid modifiers which are implied by the context | 40 |
| Avoid modifiers which are implied by the context | 41 |
| Avoid modifiers which are implied by the context | 42 |
| Avoid modifiers which are implied by the context | 43 |
| Avoid modifiers which are implied by the context | 44 |
| Violation | Line |
|---|---|
| Avoid using redundant field initializer for 'instance' | 57 |
| Avoid using redundant field initializer for 'idpMetaDataManager' | 58 |
| Avoid using redundant field initializer for 'spMetaDataManager' | 59 |
| Avoid using redundant field initializer for 'trustEngine' | 60 |
| Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 81 |
| Singleton is not thread safe | 111–114 |
| Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. | 122 |
| Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. | 153 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 34–543 |
| The class 'SAMLResponseManager' has a Standard Cyclomatic Complexity of 3 (Highest = 16). | 76–543 |
| The class 'SAMLResponseManager' has a Cyclomatic Complexity of 3 (Highest = 18). | 76–543 |
| The class 'SAMLResponseManager' has a Modified Cyclomatic Complexity of 3 (Highest = 16). | 76–543 |
| Avoid using redundant field initializer for 'response' | 78 |
| Overridable method 'initialize' called during object construction | 87 |
| New exception is thrown in catch block, original stack trace may be lost | 133 |
| Avoid really long methods. | 142–296 |
| The method validateResponseContent() has an NPath complexity of 73728 | 142–296 |
| The method 'validateResponseContent' has a Cyclomatic Complexity of 18. | 142–296 |
| The method 'validateResponseContent' has a Standard Cyclomatic Complexity of 16. | 142–296 |
| The method 'validateResponseContent' has a Modified Cyclomatic Complexity of 16. | 142–296 |
| Avoid using Literals in Conditional Statements | 157 |
| Avoid using Literals in Conditional Statements | 188 |
| Avoid using Literals in Conditional Statements | 199 |
| Avoid using Literals in Conditional Statements | 220 |
| Avoid using Literals in Conditional Statements | 267 |
| Avoid using Literals in Conditional Statements | 278 |
| Avoid using Literals in Conditional Statements | 289 |
| Avoid using Literals in Conditional Statements | 311 |
| New exception is thrown in catch block, original stack trace may be lost | 381 |
| New exception is thrown in catch block, original stack trace may be lost | 388 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 455 |
| Violation | Line |
|---|---|
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 61–125 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 71 |
| New exception is thrown in catch block, original stack trace may be lost | 87 |
| New exception is thrown in catch block, original stack trace may be lost | 114 |
| New exception is thrown in catch block, original stack trace may be lost | 120 |
| Violation | Line |
|---|---|
| Avoid using redundant field initializer for 'responseManager' | 55 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 63–66 |
| Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. | 74 |
| Avoid reassigning parameters such as 'inFilePath' | 74 |
| Avoid using Literals in Conditional Statements | 102 |
| Avoid using Literals in Conditional Statements | 113 |
| Avoid using Literals in Conditional Statements | 123 |
| New exception is thrown in catch block, original stack trace may be lost | 159 |
| New exception is thrown in catch block, original stack trace may be lost | 166 |
| Violation | Line |
|---|---|
| Abstract classes should be named AbstractXXX | 60–136 |
| The Logger variable declaration does not contain the static and final modifiers | 62 |
| Avoid using redundant field initializer for 'metaData' | 63 |
| Avoid unnecessary constructors - the compiler will generate these for you | 65–67 |
| Document empty constructor | 65–67 |
| Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. | 128 |
| Violation | Line |
|---|---|
| The Logger variable declaration does not contain the static and final modifiers | 56 |
| Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. | 59 |
| Avoid reassigning parameters such as 'inFilePath' | 59 |
| Avoid using Literals in Conditional Statements | 90 |
| Avoid using Literals in Conditional Statements | 100 |
| Violation | Line |
|---|---|
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 49–66 |
| Avoid variables with short names like rc | 53 |
| Avoid variables with short names like in | 54 |
| Avoid variables with short names like cf | 59 |
