Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/fccertifier/web/FranceConnectCertifierApp.java

Rule Violation Line
FieldNamingConventions The final field name '_certifierService' doesn't match '[a-z][a-zA-Z0-9]*' 99

Priority 3

fr/paris/lutece/plugins/fccertifier/business/FcIdentity.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 45161

fr/paris/lutece/plugins/fccertifier/service/CertifierService.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 35544
GodClass Possible God Class (WMC=56, ATFD=77, TCC=4.396%) 83544
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 83544
UnusedPrivateField Avoid unused private fields such as 'PROPERTY_SUSPICIOUS_LIST_RULE_STRIC'. 105
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 110
ConfusingTernary Avoid if (x != y) ..; else ..; 183247
ConfusingTernary Avoid if (x != y) ..; else ..; 225
ConfusingTernary Avoid if (x != y) ..; else ..; 227
ConfusingTernary Avoid if (x != y) ..; else ..; 297304
ConfusingTernary Avoid if (x != y) ..; else ..; 327334
UseUnderscoresInNumericLiterals Number 60000L should separate every third digit with an underscore 346
ConfusingTernary Avoid if (x != y) ..; else ..; 409
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 460
CyclomaticComplexity The method 'existStrictSuspiciousIdentities(FcIdentity, String)' has a cyclomatic complexity of 10. 506523
ShortVariable Avoid variables with short names like o 530

fr/paris/lutece/plugins/fccertifier/util/DateUtils.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 6376

fr/paris/lutece/plugins/fccertifier/util/InseeUtils.java

Rule Violation Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 84
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 112

fr/paris/lutece/plugins/fccertifier/web/FranceConnectCertifierApp.java

Rule Violation Line
DataClass The class 'FranceConnectCertifierApp' is suspected to be a Data Class (WOC=0.000%, NOPA=5, NOAM=0, WMC=5) 66269
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 258

Priority 4

fr/paris/lutece/plugins/fccertifier/service/CertifierService.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.util.Collections' 40

Files

fr/paris/lutece/plugins/fccertifier/business/FcIdentity.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 45161

fr/paris/lutece/plugins/fccertifier/service/CertifierService.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 35544
UnusedImports Avoid unused imports such as 'java.util.Collections' 4 40
GodClass Possible God Class (WMC=56, ATFD=77, TCC=4.396%) 3 83544
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 83544
UnusedPrivateField Avoid unused private fields such as 'PROPERTY_SUSPICIOUS_LIST_RULE_STRIC'. 3 105
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 110
ConfusingTernary Avoid if (x != y) ..; else ..; 3 183247
ConfusingTernary Avoid if (x != y) ..; else ..; 3 225
ConfusingTernary Avoid if (x != y) ..; else ..; 3 227
ConfusingTernary Avoid if (x != y) ..; else ..; 3 297304
ConfusingTernary Avoid if (x != y) ..; else ..; 3 327334
UseUnderscoresInNumericLiterals Number 60000L should separate every third digit with an underscore 3 346
ConfusingTernary Avoid if (x != y) ..; else ..; 3 409
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 460
CyclomaticComplexity The method 'existStrictSuspiciousIdentities(FcIdentity, String)' has a cyclomatic complexity of 10. 3 506523
ShortVariable Avoid variables with short names like o 3 530

fr/paris/lutece/plugins/fccertifier/util/DateUtils.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 6376

fr/paris/lutece/plugins/fccertifier/util/InseeUtils.java

Rule Violation Priority Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 84
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 112

fr/paris/lutece/plugins/fccertifier/web/FranceConnectCertifierApp.java

Rule Violation Priority Line
DataClass The class 'FranceConnectCertifierApp' is suspected to be a Data Class (WOC=0.000%, NOPA=5, NOAM=0, WMC=5) 3 66269
FieldNamingConventions The final field name '_certifierService' doesn't match '[a-z][a-zA-Z0-9]*' 1 99
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 258