Fork me on GitHub

FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is

Effort is max

Summary

Classes Bugs Errors Missing Classes
361 34 0 80

Files

Class Bugs
fr.paris.lutece.plugins.forms.business.Form 8
fr.paris.lutece.plugins.forms.business.FormResponse 6
fr.paris.lutece.plugins.forms.export.pdf.AbstractPdfFileGenerator 2
fr.paris.lutece.plugins.forms.export.pdf.PdfFileGenerator 1
fr.paris.lutece.plugins.forms.export.pdffull.PdfFullFileGenerator 1
fr.paris.lutece.plugins.forms.service.search.LuceneFormSearchEngine 1
fr.paris.lutece.plugins.forms.service.search.LuceneFormSearchIndexer 1
fr.paris.lutece.plugins.forms.validation.AbstractPatternValidator 2
fr.paris.lutece.plugins.forms.web.FormResponseData 2
fr.paris.lutece.plugins.forms.web.TermsOfServiceXPage 3
fr.paris.lutece.plugins.forms.web.admin.FormResponseJspBean 1
fr.paris.lutece.plugins.forms.web.admin.MultiviewFormResponseDetailsJspBean 1
fr.paris.lutece.plugins.forms.web.admin.MultiviewFormsJspBean 3
fr.paris.lutece.plugins.forms.web.file.FormsDownloadFile 1
fr.paris.lutece.plugins.forms.web.form.column.display.impl.FormColumnDisplayEntryCartography 1

fr.paris.lutece.plugins.forms.business.Form

Bug Category Details Line Priority
fr.paris.lutece.plugins.forms.business.Form.getAvailabilityEndDate() may expose internal representation by returning Form._dateAvailabilityEndDate MALICIOUS_CODE EI_EXPOSE_REP 314 Medium
fr.paris.lutece.plugins.forms.business.Form.getAvailabilityStartDate() may expose internal representation by returning Form._dateAvailabilityStartDate MALICIOUS_CODE EI_EXPOSE_REP 293 Medium
fr.paris.lutece.plugins.forms.business.Form.getCreationDate() may expose internal representation by returning Form._dateCreation MALICIOUS_CODE EI_EXPOSE_REP 250 Medium
fr.paris.lutece.plugins.forms.business.Form.getUpdateDate() may expose internal representation by returning Form._dateUpdate MALICIOUS_CODE EI_EXPOSE_REP 271 Medium
fr.paris.lutece.plugins.forms.business.Form.setAvailabilityEndDate(Timestamp) may expose internal representation by storing an externally mutable object into Form._dateAvailabilityEndDate MALICIOUS_CODE EI_EXPOSE_REP2 325 Medium
fr.paris.lutece.plugins.forms.business.Form.setAvailabilityStartDate(Timestamp) may expose internal representation by storing an externally mutable object into Form._dateAvailabilityStartDate MALICIOUS_CODE EI_EXPOSE_REP2 304 Medium
fr.paris.lutece.plugins.forms.business.Form.setCreationDate(Timestamp) may expose internal representation by storing an externally mutable object into Form._dateCreation MALICIOUS_CODE EI_EXPOSE_REP2 261 Medium
fr.paris.lutece.plugins.forms.business.Form.setUpdateDate(Timestamp) may expose internal representation by storing an externally mutable object into Form._dateUpdate MALICIOUS_CODE EI_EXPOSE_REP2 283 Medium

fr.paris.lutece.plugins.forms.business.FormResponse

Bug Category Details Line Priority
fr.paris.lutece.plugins.forms.business.FormResponse.getCreation() may expose internal representation by returning FormResponse._dateCreation MALICIOUS_CODE EI_EXPOSE_REP 153 Medium
fr.paris.lutece.plugins.forms.business.FormResponse.getUpdate() may expose internal representation by returning FormResponse._dateUpdate MALICIOUS_CODE EI_EXPOSE_REP 170 Medium
fr.paris.lutece.plugins.forms.business.FormResponse.getUpdateStatus() may expose internal representation by returning FormResponse._dateUpdateStatus MALICIOUS_CODE EI_EXPOSE_REP 221 Medium
fr.paris.lutece.plugins.forms.business.FormResponse.setDateCreation(Timestamp) may expose internal representation by storing an externally mutable object into FormResponse._dateCreation MALICIOUS_CODE EI_EXPOSE_REP2 162 Medium
fr.paris.lutece.plugins.forms.business.FormResponse.setUpdate(Timestamp) may expose internal representation by storing an externally mutable object into FormResponse._dateUpdate MALICIOUS_CODE EI_EXPOSE_REP2 179 Medium
fr.paris.lutece.plugins.forms.business.FormResponse.setUpdateStatus(Timestamp) may expose internal representation by storing an externally mutable object into FormResponse._dateUpdateStatus MALICIOUS_CODE EI_EXPOSE_REP2 230 Medium

fr.paris.lutece.plugins.forms.export.pdf.AbstractPdfFileGenerator

Bug Category Details Line Priority
Found reliance on default encoding in fr.paris.lutece.plugins.forms.export.pdf.AbstractPdfFileGenerator.getTemplateExportPDF(Map): new String(byte[]) I18N DM_DEFAULT_ENCODING 115 High
fr.paris.lutece.plugins.forms.export.pdf.AbstractPdfFileGenerator.createCellsForGroup(FormResponseStep, FormDisplay) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 235 Medium

fr.paris.lutece.plugins.forms.export.pdf.PdfFileGenerator

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdir() ignored in fr.paris.lutece.plugins.forms.export.pdf.PdfFileGenerator.generateFile() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 79 Medium

fr.paris.lutece.plugins.forms.export.pdffull.PdfFullFileGenerator

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdir() ignored in fr.paris.lutece.plugins.forms.export.pdffull.PdfFullFileGenerator.generateFile() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 113 Medium

fr.paris.lutece.plugins.forms.service.search.LuceneFormSearchEngine

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in fr.paris.lutece.plugins.forms.service.search.LuceneFormSearchEngine.getSearchResults(FormSearchConfig) STYLE REC_CATCH_EXCEPTION 142 Medium

fr.paris.lutece.plugins.forms.service.search.LuceneFormSearchIndexer

Bug Category Details Line Priority
Redundant nullcheck of doc, which is known to be non-null in fr.paris.lutece.plugins.forms.service.search.LuceneFormSearchIndexer.getDocuments(String) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 378 Medium

fr.paris.lutece.plugins.forms.validation.AbstractPatternValidator

Bug Category Details Line Priority
Boxing/unboxing to parse a primitive fr.paris.lutece.plugins.forms.validation.AbstractPatternValidator.getJavascriptControlValue(Control) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 103 High
Boxing/unboxing to parse a primitive fr.paris.lutece.plugins.forms.validation.AbstractPatternValidator.validate(FormQuestionResponse, Control) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 111 High

fr.paris.lutece.plugins.forms.web.FormResponseData

Bug Category Details Line Priority
fr.paris.lutece.plugins.forms.web.FormResponseData.getDateUpdate() may expose internal representation by returning FormResponseData._dateUpdate MALICIOUS_CODE EI_EXPOSE_REP 101 Medium
fr.paris.lutece.plugins.forms.web.FormResponseData.setDateUpdate(Date) may expose internal representation by storing an externally mutable object into FormResponseData._dateUpdate MALICIOUS_CODE EI_EXPOSE_REP2 110 Medium

fr.paris.lutece.plugins.forms.web.TermsOfServiceXPage

Bug Category Details Line Priority
Possible null pointer dereference of entry in fr.paris.lutece.plugins.forms.web.TermsOfServiceXPage.findTermsOfServiceFromEntry(HttpServletRequest) CORRECTNESS NP_NULL_ON_SOME_PATH 135 High
Possible null pointer dereference of fieldTermsOfService in fr.paris.lutece.plugins.forms.web.TermsOfServiceXPage.findTermsOfServiceFromEntry(HttpServletRequest) CORRECTNESS NP_NULL_ON_SOME_PATH 142 High
Possible null pointer dereference of response in fr.paris.lutece.plugins.forms.web.TermsOfServiceXPage.findTermsOfServiceFromResponse(HttpServletRequest) CORRECTNESS NP_NULL_ON_SOME_PATH 225 Medium

fr.paris.lutece.plugins.forms.web.admin.FormResponseJspBean

Bug Category Details Line Priority
Dead store to arrayIterationInfo in fr.paris.lutece.plugins.forms.web.admin.FormResponseJspBean.doRemoveIteration(HttpServletRequest) STYLE DLS_DEAD_LOCAL_STORE 477 Medium

fr.paris.lutece.plugins.forms.web.admin.MultiviewFormResponseDetailsJspBean

Bug Category Details Line Priority
The field fr.paris.lutece.plugins.forms.web.admin.MultiviewFormResponseDetailsJspBean._formsMultiviewAuthorizationService is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available Medium

fr.paris.lutece.plugins.forms.web.admin.MultiviewFormsJspBean

Bug Category Details Line Priority
The field fr.paris.lutece.plugins.forms.web.admin.MultiviewFormsJspBean._formPanelDisplayActive is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available Medium
The field fr.paris.lutece.plugins.forms.web.admin.MultiviewFormsJspBean._listFormColumn is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available Medium
The field fr.paris.lutece.plugins.forms.web.admin.MultiviewFormsJspBean._strFormSelectedValue is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available Medium

fr.paris.lutece.plugins.forms.web.file.FormsDownloadFile

Bug Category Details Line Priority
Null passed for non-null parameter of fr.paris.lutece.plugins.forms.util.FormsResponseUtils.isAuthorized(FormResponse, LuteceUser) in fr.paris.lutece.plugins.forms.web.file.FormsDownloadFile.doDownloadFileFO(HttpServletRequest, HttpServletResponse) CORRECTNESS NP_NULL_PARAM_DEREF 130 Medium

fr.paris.lutece.plugins.forms.web.form.column.display.impl.FormColumnDisplayEntryCartography

Bug Category Details Line Priority
Dead store to strEntryGeoJSON in fr.paris.lutece.plugins.forms.web.form.column.display.impl.FormColumnDisplayEntryCartography.buildFormColumnCellTemplate(FormColumnCell, Locale) STYLE DLS_DEAD_LOCAL_STORE 100 Medium