Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 5.3.5.

Fichiers

fr/paris/lutece/plugins/jsr168/business/portlet/Jsr168Portlet.java

Violation Ligne
It is a good practice to call super() in a constructor 6669

fr/paris/lutece/plugins/jsr168/business/portlet/Jsr168PortletDAO.java

Violation Ligne
Use explicit scoping instead of the default package private level 6770
Avoid variables with short names like p 82
Avoid variables with short names like p 136

fr/paris/lutece/plugins/jsr168/business/portlet/Jsr168PortletHome.java

Violation Ligne
Possible unsafe assignment to a non-final static field in a constructor. 47
Avoid using redundant field initializer for '_singleton' 47
It is a good practice to call super() in a constructor 5258
Singleton is not thread safe 8083

fr/paris/lutece/plugins/jsr168/pluto/Buttons.java

Violation Ligne
Use explicit scoping instead of the default package private level 83142

fr/paris/lutece/plugins/jsr168/pluto/LuteceHttpServletResponse.java

Violation Ligne
Private field '_servletOutputStream' could be made final; it is only initialized in the declaration or constructor. 57
Private field '_printWriter' could be made final; it is only initialized in the declaration or constructor. 58
Private field '_buffer' could be made final; it is only initialized in the declaration or constructor. 59
Avoid variables with short names like b 74
Avoid throwing raw exception types. 99
New exception is thrown in catch block, original stack trace may be lost 99
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 281
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 296

fr/paris/lutece/plugins/jsr168/pluto/LutecePlutoConstant.java

Violation Ligne
Avoid excessively long variable names like CONFIG_SERVICES_PORTLETDEF_WEBXML_RESSOURCE_DEFAULT 79
Avoid excessively long variable names like CONFIG_SERVICES_PORTLETDEF_PORTLETXML_MAPPING_DEFAULT 83
Avoid excessively long variable names like CONFIG_SERVICES_PORTLETDEF_PORTLETXML_RESSOURCE_DEFAULT 85

fr/paris/lutece/plugins/jsr168/pluto/LuteceToPlutoConnector.java

Violation Ligne
A high number of imports can indicate a high degree of coupling within an object. 34492
A catch statement should never catch throwable since it includes errors. 181
Document empty method 204205
Avoid declaring a variable if it is unreferenced before a possible exit point. 218
Avoid declaring a variable if it is unreferenced before a possible exit point. 219
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 227
A catch statement should never catch throwable since it includes errors. 259
Avoid declaring a variable if it is unreferenced before a possible exit point. 297
Avoid variables with short names like it 312
Avoid declaring a variable if it is unreferenced before a possible exit point. 390
Avoid declaring a variable if it is unreferenced before a possible exit point. 391
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 398
A catch statement should never catch throwable since it includes errors. 431
Avoid declaring a variable if it is unreferenced before a possible exit point. 450

fr/paris/lutece/plugins/jsr168/pluto/PlutoSession.java

Violation Ligne
Use block level rather than method level synchronization 7589
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 85

fr/paris/lutece/plugins/jsr168/pluto/PortletContainerImpl.java

Violation Ligne
The field name indicates a constant but its modifiers do not 92
The Logger variable declaration does not contain the static and final modifiers 96
Avoid using redundant field initializer for 'log' 96
Avoid variables with short names like b 112
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 173
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 246
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 260

fr/paris/lutece/plugins/jsr168/pluto/core/DynamicInformationProviderImpl.java

Violation Ligne
Perhaps '_env' could be replaced by a local variable. 117
Private field '_env' could be made final; it is only initialized in the declaration or constructor. 117
Avoid unused private fields such as '_env'. 117

fr/paris/lutece/plugins/jsr168/pluto/core/InformationProviderServiceFactoryImpl.java

Violation Ligne
Private field '_staticProvider' could be made final; it is only initialized in the declaration or constructor. 111
A method/constructor shouldnt explicitly throw java.lang.Exception 150
A method/constructor shouldnt explicitly throw java.lang.Exception 150
Document empty method 151152
A method/constructor shouldnt explicitly throw java.lang.Exception 157
A method/constructor shouldnt explicitly throw java.lang.Exception 157
Document empty method 158159

fr/paris/lutece/plugins/jsr168/pluto/core/PortalContextProviderImpl.java

Violation Ligne
Private field '_properties' could be made final; it is only initialized in the declaration or constructor. 119
Avoid variables with short names like m 191
Avoid calling toString() on String objects; this is unnecessary. 198
Avoid variables with short names like s 211
Avoid calling toString() on String objects; this is unnecessary. 218
Avoid unused private methods such as 'reset(String)'. 232
Avoid instantiating String objects; this is usually unnecessary. 234

fr/paris/lutece/plugins/jsr168/pluto/core/PortalURL.java

Violation Ligne
The class 'PortalURL' has a Cyclomatic Complexity of 2 (Highest = 11). 53457
The method buildParams() has an NPath complexity of 243 172219
The method 'buildParams' has a Cyclomatic Complexity of 11. 172219

fr/paris/lutece/plugins/jsr168/pluto/core/PortletContainerEnvironment.java

Violation Ligne
Private field '_services' could be made final; it is only initialized in the declaration or constructor. 47

fr/paris/lutece/plugins/jsr168/pluto/core/PortletURLProviderImpl.java

Violation Ligne
Avoid using Literals in Conditional Statements 80
Avoid using Literals in Conditional Statements 91
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 100
Avoid unused private fields such as '_provider'. 101
Perhaps '_provider' could be replaced by a local variable. 101
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 101
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 102
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 107
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 112
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 118
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 123
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 124
Avoid unused private fields such as '_clearParameters'. 124
Perhaps '_clearParameters' could be replaced by a local variable. 124
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 125
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 199
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 200
Use explicit scoping instead of the default package private level 242245
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 259
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 260
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 296
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 297

fr/paris/lutece/plugins/jsr168/pluto/core/ResourceURLProviderImpl.java

Violation Ligne
Perhaps '_portletWindow' could be replaced by a local variable. 103
Avoid unused private fields such as '_portletWindow'. 103
Private field '_portletWindow' could be made final; it is only initialized in the declaration or constructor. 103
Private field '_strBase' could be made final; it is only initialized in the declaration or constructor. 105
Avoid unused constructor parameters such as 'provider'. 113
Avoid using Literals in Conditional Statements 142
New exception is thrown in catch block, original stack trace may be lost 150

fr/paris/lutece/plugins/jsr168/pluto/core/StaticInformationProviderImpl.java

Violation Ligne
Private field '_provider' could be made final; it is only initialized in the declaration or constructor. 103

fr/paris/lutece/plugins/jsr168/pluto/services/factorymanager/FactoryManagerServiceImpl.java

Violation Ligne
The class 'FactoryManagerServiceImpl' has a Cyclomatic Complexity of 3 (Highest = 10). 112292
Private field '_mapFactory' could be made final; it is only initialized in the declaration or constructor. 114
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 114
Private field '_lstFactory' could be made final; it is only initialized in the declaration or constructor. 115
The method 'init' has a Cyclomatic Complexity of 10. 128227
A method/constructor shouldnt explicitly throw java.lang.Exception 129
A method/constructor shouldnt explicitly throw java.lang.Exception 129
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 133
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 134
Avoid using final local variables, turn them into fields 174
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 219
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 246
Avoid variables with short names like t 288

fr/paris/lutece/plugins/jsr168/pluto/services/log/LogServiceImpl.java

Violation Ligne
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 112
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 120

fr/paris/lutece/plugins/jsr168/pluto/services/portletdefinitionregistry/PortletDefinitionRegistryServiceFileImpl.java

Violation Ligne
A high number of imports can indicate a high degree of coupling within an object. 34266
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.DescriptionImpl' 42
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.DescriptionImpl' 42
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.DescriptionSetImpl' 43
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.DescriptionSetImpl' 43
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.DisplayNameImpl' 44
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.DisplayNameImpl' 44
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.DisplayNameSetImpl' 45
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.DisplayNameSetImpl' 45
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.LanguageSetImpl' 46
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.LanguageSetImpl' 46
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.ParameterImpl' 47
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.ParameterImpl' 47
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.PreferenceImpl' 48
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.PreferenceImpl' 48
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.PreferenceSetImpl' 49
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.common.impl.PreferenceSetImpl' 49
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.portlet.impl.ContentTypeImpl' 50
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.portlet.impl.ContentTypeImpl' 50
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.portlet.impl.PortletDefinitionImpl' 53
Avoid unused imports such as 'org.apache.pluto.portalImpl.om.portlet.impl.PortletDefinitionImpl' 53
It is a good practice to call super() in a constructor 101105
A method/constructor shouldnt explicitly throw java.lang.Exception 111
A method/constructor shouldnt explicitly throw java.lang.Exception 111
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 129
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 150
Avoid variables with short names like id 172
A method/constructor shouldnt explicitly throw java.lang.Exception 185
A method/constructor shouldnt explicitly throw java.lang.Exception 185
Use ArrayList instead of Vector 214
Consider replacing this Vector with the newer java.util.List 214

fr/paris/lutece/plugins/jsr168/pluto/services/portletentityregistry/PortletEntityRegistryServiceFileImpl.java

Violation Ligne
It is a good practice to call super() in a constructor 146149
A method/constructor shouldnt explicitly throw java.lang.Exception 155
A method/constructor shouldnt explicitly throw java.lang.Exception 155
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 173
Avoid variables with short names like id 194
Avoid variables with short names like f 206
New exception is thrown in catch block, original stack trace may be lost 230
New exception is thrown in catch block, original stack trace may be lost 235
New exception is thrown in catch block, original stack trace may be lost 240
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 242
New exception is thrown in catch block, original stack trace may be lost 245
New exception is thrown in catch block, original stack trace may be lost 298
New exception is thrown in catch block, original stack trace may be lost 303
New exception is thrown in catch block, original stack trace may be lost 308
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 310
New exception is thrown in catch block, original stack trace may be lost 313

fr/paris/lutece/plugins/jsr168/pluto/servlet/ServletRequestFactoryImpl.java

Violation Ligne
Document empty method 108109
Document empty method 115116

fr/paris/lutece/plugins/jsr168/pluto/servlet/ServletRequestImpl.java

Violation Ligne
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 120
Overridable method 'getParameterNames' called during object construction 130
Overridable method 'getParameterValues' called during object construction 134
Avoid using final local variables, turn them into fields 136
Prefer StringBuffer over += for concatenating strings 165

fr/paris/lutece/plugins/jsr168/pluto/xml/ServiceXML.java

Violation Ligne
Use explicit scoping instead of the default package private level 6972

fr/paris/lutece/plugins/jsr168/pluto/xml/ServicesXML.java

Violation Ligne
Use explicit scoping instead of the default package private level 6366

fr/paris/lutece/plugins/jsr168/pluto/xml/ServicesXMLHandler.java

Violation Ligne
It is a good practice to call super() in a constructor 5458
Use explicit scoping instead of the default package private level 6568

fr/paris/lutece/plugins/jsr168/web/portlet/Jsr168PortletJspBean.java

Violation Ligne
Avoid unused private fields such as 'COMBO_PORTLETS_LIST'. 75
It is a good practice to call super() in a constructor 8082
Document empty constructor 8082
Avoid unnecessary constructors - the compiler will generate these for you 8082
System.out.println is used 102
System.out.println is used 108
System.out.println is used 109
System.out.println is used 115
System.out.println is used 116
System.out.println is used 117
Avoid using Literals in Conditional Statements 159
Avoid using Literals in Conditional Statements 199
Use explicit scoping instead of the default package private level 240249

org/apache/pluto/core/impl/PortletModeHelper.java

Violation Ligne
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4877
Avoid declaring a variable if it is unreferenced before a possible exit point. 53
Avoid variables with short names like ct 54

org/apache/pluto/invoker/impl/PortletInvokerImpl.java

Violation Ligne
A high number of imports can indicate a high degree of coupling within an object. 37298
Avoid unused imports such as 'javax.servlet.RequestDispatcher' 69
Avoid unused imports such as 'javax.servlet.RequestDispatcher' 69
The class 'PortletInvokerImpl' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 80298
The class 'PortletInvokerImpl' has a Cyclomatic Complexity of 2 (Highest = 10). 80298
The class 'PortletInvokerImpl' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 80298
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 83
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 84
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 85
Private field 'servletConfig' could be made final; it is only initialized in the declaration or constructor. 86
Private field 'portletDefinition' could be made final; it is only initialized in the declaration or constructor. 87
Avoid using redundant field initializer for 'log' 95
The Logger variable declaration does not contain the static and final modifiers 95
Unnecessary use of fully qualified name 'javax.servlet.ServletConfig' due to existing import 'javax.servlet.ServletConfig' 97
The method 'invoke' has a Cyclomatic Complexity of 10. 136249
Avoid really long methods. 136249
The method 'invoke' has a Standard Cyclomatic Complexity of 10. 136249
The method 'invoke' has a Modified Cyclomatic Complexity of 10. 136249
Avoid declaring a variable if it is unreferenced before a possible exit point. 144
Avoid declaring a variable if it is unreferenced before a possible exit point. 146
Avoid declaring a variable if it is unreferenced before a possible exit point. 148
Avoid unused local variables such as 'servletDefinition'. 148
Avoid unused local variables such as 'servletContext'. 149
Avoid declaring a variable if it is unreferenced before a possible exit point. 149
Avoid empty if statements 241243

org/apache/pluto/portalImpl/Deploy.java

Violation Ligne
Package name contains upper case characters 34
A high number of imports can indicate a high degree of coupling within an object. 34653
The class 'Deploy' has a Modified Cyclomatic Complexity of 11 (Highest = 22). 99653
The class 'Deploy' has a Standard Cyclomatic Complexity of 11 (Highest = 22). 99653
The class 'Deploy' has a Cyclomatic Complexity of 12 (Highest = 23). 99653
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 100653
Avoid using redundant field initializer for 'debug' 101
The String literal "WEB-INF" appears 4 times in this file; the first occurrence is on line 103 103
The method 'deployArchive' has a Modified Cyclomatic Complexity of 11. 108194
The method 'deployArchive' has a Standard Cyclomatic Complexity of 11. 108194
The method 'deployArchive' has a Cyclomatic Complexity of 13. 108194
String.indexOf(char) is faster than String.indexOf(String). 113
String.indexOf(char) is faster than String.indexOf(String). 115
String.indexOf(char) is faster than String.indexOf(String). 125
System.out.println is used 128
Avoid variables with short names like is 144
Avoid variables with short names like r 145
Avoid variables with short names like st 146
Position literals first in String comparisons 157
Deeply nested if..then statements are hard to read 157164
System.out.println is used 159
System.out.println is used 193
The method prepareWebArchive() has an NCSS line count of 145 196500
Avoid really long methods. 196500
The method 'prepareWebArchive' has a Standard Cyclomatic Complexity of 22. 196500
The method prepareWebArchive() has an NPath complexity of 258592 196500
The method 'prepareWebArchive' has a Modified Cyclomatic Complexity of 22. 196500
The method 'prepareWebArchive' has a Cyclomatic Complexity of 23. 196500
A method/constructor shouldnt explicitly throw java.lang.Exception 197
A method/constructor shouldnt explicitly throw java.lang.Exception 197
String.indexOf(char) is faster than String.indexOf(String). 201
String.indexOf(char) is faster than String.indexOf(String). 203
String.indexOf(char) is faster than String.indexOf(String). 213
System.out.println is used 216
Avoid declaring a variable if it is unreferenced before a possible exit point. 219
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 230
System.out.println is used 232
New exception is thrown in catch block, original stack trace may be lost 233234
Avoid declaring a variable if it is unreferenced before a possible exit point. 237
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 248
New exception is thrown in catch block, original stack trace may be lost 250251
Use ArrayList instead of Vector 270
Consider replacing this Vector with the newer java.util.List 270
System.out.println is used 278
System.out.println is used 335
Avoid variables with short names like p 423
System.out.println is used 432
System.out.println is used 445
System.out.println is used 459
Avoid variables with short names like of 462
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 479
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 493
System.out.println is used 499
Avoid variables with short names like to 502
Avoid variables with short names like f 504
The method 'main' has a Modified Cyclomatic Complexity of 14. 520604
Consider using varargs for methods or constructors which take an array the last parameter. 520
The method main() has an NPath complexity of 7488 520604
The method 'main' has a Cyclomatic Complexity of 18. 520604
The method 'main' has a Standard Cyclomatic Complexity of 14. 520604
Avoid declaring a variable if it is unreferenced before a possible exit point. 522
Avoid using Literals in Conditional Statements 524
System.out.println is used 526
System.out.println is used 527
Avoid using Literals in Conditional Statements 533
These nested if statements could be combined 535538
System.out.println is used 545
Avoid using Literals in Conditional Statements 572
A catch statement that catches an exception only to rethrow it should be avoided. 595598
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 599
Consider using varargs for methods or constructors which take an array the last parameter. 606
Avoid variables with short names like o 611
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 647

org/apache/pluto/portalImpl/om/window/impl/PortletWindowImpl.java

Violation Ligne
Package name contains upper case characters 34
Avoid variables with short names like id 64
Use block level rather than method level synchronization 99142
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 106
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 108
Avoid declaring a variable if it is unreferenced before a possible exit point. 119
Avoid variables with short names like id 211
Assigning an Object to null is a code smell. Consider refactoring. 214

org/apache/pluto/portalImpl/services/ServiceManager.java

Violation Ligne
Package name contains upper case characters 37
The class 'ServiceManager' has a Modified Cyclomatic Complexity of 6 (Highest = 14). 96413
The class 'ServiceManager' has a Cyclomatic Complexity of 6 (Highest = 14). 96413
The class 'ServiceManager' has a Standard Cyclomatic Complexity of 6 (Highest = 14). 96413
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 97413
Use of modifier volatile is not recommended. 98
Avoid using redundant field initializer for '_bInitialized' 98
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 99
A method/constructor shouldnt explicitly throw java.lang.Exception 114
A method/constructor shouldnt explicitly throw java.lang.Exception 114
The method 'init' has a Modified Cyclomatic Complexity of 14. 133280
The method init() has an NPath complexity of 1344 133280
The method 'init' has a Cyclomatic Complexity of 14. 133280
The method 'init' has a Standard Cyclomatic Complexity of 14. 133280
Avoid really long methods. 133280
Avoid throwing null pointer exceptions. 138
Avoid throwing null pointer exceptions. 145
Avoid using final local variables, turn them into fields 168
Avoid using final local variables, turn them into fields 192
Avoid using final local variables, turn them into fields 206
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 252
The String literal " successful)." appears 6 times in this file; the first occurrence is on line 271 271
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 324
Avoid unused local variables such as 'context'. 371
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 387

org/apache/pluto/portalImpl/util/NameValuePairs.java

Violation Ligne
Package name contains upper case characters 34
Possible God class (WMC=54, ATFD=14, TCC=0.03508771929824561) 34423
Abstract classes should be named AbstractXXX 50423
This abstract class does not have any abstract methods 50423
Private field 'iEntries' could be made final; it is only initialized in the declaration or constructor. 53
Document empty constructor 5658
This statement may have some unnecessary parentheses 68
This statement may have some unnecessary parentheses 82
This statement may have some unnecessary parentheses 105
This statement may have some unnecessary parentheses 128
This statement may have some unnecessary parentheses 133
This statement may have some unnecessary parentheses 147
This statement may have some unnecessary parentheses 161
This statement may have some unnecessary parentheses 166
This statement may have some unnecessary parentheses 180
This statement may have some unnecessary parentheses 185
Avoid instantiation through private constructors from outside of the constructors class. 190
This statement may have some unnecessary parentheses 190
This statement may have some unnecessary parentheses 195
This statement may have some unnecessary parentheses 205
Consider using varargs for methods or constructors which take an array the last parameter. 215
This statement may have some unnecessary parentheses 219
This statement may have some unnecessary parentheses 224
This statement may have some unnecessary parentheses 231
This statement may have some unnecessary parentheses 258
This statement may have some unnecessary parentheses 280
This statement may have some unnecessary parentheses 287
This statement may have some unnecessary parentheses 323
Use explicit scoping instead of the default package private level 326329
Use explicit scoping instead of the default package private level 331334
Use explicit scoping instead of the default package private level 338
Use explicit scoping instead of the default package private level 339
The user-supplied array 'aValues' is stored directly. 341
Consider using varargs for methods or constructors which take an array the last parameter. 341
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 351
This statement may have some unnecessary parentheses 364
This statement may have some unnecessary parentheses 387
This statement may have some unnecessary parentheses 397

org/apache/pluto/portalImpl/xml/XmlParser.java

Violation Ligne
Package name contains upper case characters 37
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 56176
Unnecessary use of fully qualified name 'org.w3c.dom.Document' due to existing import 'org.w3c.dom.Document' 57
System.out.println is used 71
Unnecessary use of fully qualified name 'org.w3c.dom.Document' due to existing import 'org.w3c.dom.Document' 90
Avoid using redundant field initializer for 'publicDTD' 136
Consider using varargs for methods or constructors which take an array the last parameter. 147
The user-supplied array 'resourceDTDNames' is stored directly. 147
The user-supplied array 'resourceDTDs' is stored directly. 147
Avoid variables with short names like is 161
Unnecessary use of fully qualified name 'java.io.InputStream' due to existing import 'java.io.InputStream' 161