Fork me on GitHub

Checkstyle Results

The following document contains the results of Checkstyle 8.19 with build-config/lutece_checks.xml ruleset. 

rss feed

Summary

Files
 Info
 Warnings
 Errors
26 0 1 198

Files

File
 I
 W
 E
fr/paris/lutece/plugins/oauth2/business/AuthClientConf.java 0 0 16
fr/paris/lutece/plugins/oauth2/business/AuthServerConf.java 0 0 5
fr/paris/lutece/plugins/oauth2/business/IDToken.java 0 0 1
fr/paris/lutece/plugins/oauth2/business/RegisteredClient.java 0 0 1
fr/paris/lutece/plugins/oauth2/business/ServerConfiguration.java 0 0 1
fr/paris/lutece/plugins/oauth2/business/Token.java 0 0 1
fr/paris/lutece/plugins/oauth2/dataclient/AbstractDataClient.java 0 0 7
fr/paris/lutece/plugins/oauth2/dataclient/DataClient.java 0 0 2
fr/paris/lutece/plugins/oauth2/dataclient/LogUserInfoDataClient.java 0 0 1
fr/paris/lutece/plugins/oauth2/jwt/JWTParser.java 0 0 1
fr/paris/lutece/plugins/oauth2/jwt/JjwtJWTParser.java 0 0 1
fr/paris/lutece/plugins/oauth2/jwt/MitreJWTParser.java 0 0 1
fr/paris/lutece/plugins/oauth2/jwt/TokenValidationException.java 0 0 1
fr/paris/lutece/plugins/oauth2/service/BearerTokenAuthenticator.java 0 0 5
fr/paris/lutece/plugins/oauth2/service/CallbackHandlerService.java 0 0 3
fr/paris/lutece/plugins/oauth2/service/DataClientService.java 0 0 5
fr/paris/lutece/plugins/oauth2/service/MapperService.java 0 0 1
fr/paris/lutece/plugins/oauth2/service/OauthUtils.java 0 0 3
fr/paris/lutece/plugins/oauth2/service/PkceUtil.java 0 0 22
fr/paris/lutece/plugins/oauth2/service/TokenService.java 0 1 28
fr/paris/lutece/plugins/oauth2/web/CallbackHandler.java 0 0 87
fr/paris/lutece/plugins/oauth2/web/Constants.java 0 0 1
fr/paris/lutece/plugins/oauth2/web/OAuthCallbackServlet.java 0 0 3
fr/paris/lutece/plugins/oauth2/web/OAuthLogoutServlet.java 0 0 1

Rules

Category Rule Violations Severity
blocks LeftCurly
  • option: "nl"
15
 Error
RightCurly
  • option: "alone"
3
 Error
coding DeclarationOrder 4
 Error
HiddenField 5
 Error
ParameterAssignment 1
 Error
design FinalClass 1
 Error
HideUtilityClassConstructor 2
 Error
VisibilityModifier 3
 Error
header Header
  • fileExtensions: "java"
  • headerFile: "/opt/datas/jenkins/home/jobs/admin-github-build/workspace/target/checkstyle-header.txt"
24
 Error
imports UnusedImports 7
 Error
javadoc JavadocMethod 37
 Error
JavadocType 2
 Error
naming LocalVariableName
  • format: "^[a-z][a-zA-Z0-9]*$"
1
 Error
ParameterName
  • format: "^[a-z][a-zA-Z0-9]*$"
7
 Error
sizes ParameterNumber 1
 Warning
whitespace ParenPad
  • option: "space"
74
 Error
WhitespaceAround
  • tokens: "ASSIGN,EQUAL"
12
 Error

Details

fr/paris/lutece/plugins/oauth2/business/AuthClientConf.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocMethod Missing a Javadoc comment. 125
 Error
blocks LeftCurly '{' at column 28 should be on a new line. 125
 Error
javadoc JavadocMethod Missing a Javadoc comment. 129
 Error
whitespace ParenPad '(' is not followed by whitespace. 129
 Error
coding HiddenField '_bPublic' hides a field. 129
 Error
naming ParameterName Name '_bPublic' must match pattern '^[a-z][a-zA-Z0-9]*$'. 129
 Error
whitespace ParenPad ')' is not preceded with whitespace. 129
 Error
blocks LeftCurly '{' at column 42 should be on a new line. 129
 Error
javadoc JavadocMethod Missing a Javadoc comment. 133
 Error
blocks LeftCurly '{' at column 26 should be on a new line. 133
 Error
javadoc JavadocMethod Missing a Javadoc comment. 137
 Error
whitespace ParenPad '(' is not followed by whitespace. 137
 Error
naming ParameterName Name '_bPKCE' must match pattern '^[a-z][a-zA-Z0-9]*$'. 137
 Error
whitespace ParenPad ')' is not preceded with whitespace. 137
 Error
blocks LeftCurly '{' at column 38 should be on a new line. 137

fr/paris/lutece/plugins/oauth2/business/AuthServerConf.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocMethod Unused @param tag for '_strName'. 62
 Error
javadoc JavadocMethod Expected @param tag for 'strName'. 65
 Error
coding HiddenField '_bEnableJwtParser' hides a field. 168
 Error
naming ParameterName Name '_bEnableJwtParser' must match pattern '^[a-z][a-zA-Z0-9]*$'. 168

fr/paris/lutece/plugins/oauth2/business/IDToken.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/oauth2/business/RegisteredClient.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/oauth2/business/ServerConfiguration.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/oauth2/business/Token.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/oauth2/dataclient/AbstractDataClient.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
design VisibilityModifier Variable '_logger' must be private and have accessor methods. 60
 Error
javadoc JavadocMethod Missing a Javadoc comment. 263
 Error
javadoc JavadocMethod Missing a Javadoc comment. 278
 Error
javadoc JavadocMethod Missing a Javadoc comment. 283
 Error
coding HiddenField '_bDefault' hides a field. 283
 Error
naming ParameterName Name '_bDefault' must match pattern '^[a-z][a-zA-Z0-9]*$'. 283

fr/paris/lutece/plugins/oauth2/dataclient/DataClient.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
naming ParameterName Name '_bDefault' must match pattern '^[a-z][a-zA-Z0-9]*$'. 178

fr/paris/lutece/plugins/oauth2/dataclient/LogUserInfoDataClient.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/oauth2/jwt/JWTParser.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/oauth2/jwt/JjwtJWTParser.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/oauth2/jwt/MitreJWTParser.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/oauth2/jwt/TokenValidationException.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/oauth2/service/BearerTokenAuthenticator.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
whitespace ParenPad '(' is not followed by whitespace. 79
 Error
whitespace ParenPad ')' is not preceded with whitespace. 79
 Error
blocks LeftCurly '{' at column 84 should be on a new line. 79
 Error
whitespace ParenPad '(' is not followed by whitespace. 81

fr/paris/lutece/plugins/oauth2/service/CallbackHandlerService.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
imports UnusedImports Unused import - fr.paris.lutece.util.url.UrlItem. 44
 Error
design FinalClass Class CallbackHandlerService should be declared as final. 51

fr/paris/lutece/plugins/oauth2/service/DataClientService.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocMethod Unused @param tag for 'strName'. 110
 Error
javadoc JavadocMethod Expected @param tag for 'request'. 114
 Error
javadoc JavadocMethod Unused @param tag for 'strName'. 149
 Error
javadoc JavadocMethod Expected @param tag for 'request'. 153

fr/paris/lutece/plugins/oauth2/service/MapperService.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/oauth2/service/OauthUtils.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 38
 Error
design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 38

fr/paris/lutece/plugins/oauth2/service/PkceUtil.java

Severity Category Rule Message Line
 Error
header Header Missing a header - not enough lines in file. 1
 Error
javadoc JavadocType Missing a Javadoc comment. 9
 Error
design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 9
 Error
blocks LeftCurly '{' at column 23 should be on a new line. 9
 Error
javadoc JavadocMethod Missing a Javadoc comment. 11
 Error
blocks LeftCurly '{' at column 84 should be on a new line. 11
 Error
whitespace ParenPad '(' is not followed by whitespace. 14
 Error
whitespace ParenPad ')' is not preceded with whitespace. 14
 Error
whitespace ParenPad '(' is not followed by whitespace. 16
 Error
whitespace ParenPad ')' is not preceded with whitespace. 16
 Error
javadoc JavadocMethod Missing a Javadoc comment. 19
 Error
whitespace ParenPad '(' is not followed by whitespace. 19
 Error
whitespace ParenPad ')' is not preceded with whitespace. 19
 Error
blocks LeftCurly '{' at column 130 should be on a new line. 19
 Error
whitespace ParenPad '(' is not followed by whitespace. 20
 Error
whitespace ParenPad ')' is not preceded with whitespace. 20
 Error
whitespace ParenPad '(' is not followed by whitespace. 21
 Error
whitespace ParenPad ')' is not preceded with whitespace. 21
 Error
whitespace ParenPad '(' is not followed by whitespace. 22
 Error
whitespace ParenPad ')' is not preceded with whitespace. 22
 Error
whitespace ParenPad '(' is not followed by whitespace. 25
 Error
whitespace ParenPad ')' is not preceded with whitespace. 25

fr/paris/lutece/plugins/oauth2/service/TokenService.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
design VisibilityModifier Variable '_defaultClientConfig' must be private and have accessor methods. 60
 Error
design VisibilityModifier Variable '_defaultauthServerConfig' must be private and have accessor methods. 61
 Error
coding DeclarationOrder Static variable definition in wrong order. 63
 Error
coding DeclarationOrder Static variable definition in wrong order. 65
 Error
coding DeclarationOrder Static variable definition in wrong order. 66
 Error
coding DeclarationOrder Static variable definition in wrong order. 68
 Error
javadoc JavadocMethod Expected @param tag for 'defaultClientConfig'. 80
 Error
javadoc JavadocMethod Expected @param tag for 'defaultauthServerConfig'. 80
 Error
javadoc JavadocMethod Expected @param tag for 'jWTParser'. 101
 Error
javadoc JavadocMethod Expected @param tag for 'strStoredNonce'. 101
 Error
javadoc JavadocMethod Unused @param tag for 'the'. 111
 Warning
sizes ParameterNumber More than 7 parameters (found 8). 125
 Error
javadoc JavadocMethod Expected @param tag for 'strRedirectUri'. 125
 Error
javadoc JavadocMethod Expected @param tag for 'clientConfig'. 125
 Error
javadoc JavadocMethod Expected @param tag for 'authServerConf'. 125
 Error
javadoc JavadocMethod Expected @param tag for 'jWTParser'. 126
 Error
javadoc JavadocMethod Expected @param tag for 'strStoredNonce'. 126
 Error
javadoc JavadocMethod Expected @param tag for 'strCodeVerifier'. 126
 Error
coding ParameterAssignment Assignment of parameter 'strRedirectUri' is not allowed. 132
 Error
whitespace ParenPad '(' is not followed by whitespace. 138
 Error
whitespace ParenPad ')' is not preceded with whitespace. 138
 Error
whitespace ParenPad ')' is not preceded with whitespace. 143
 Error
javadoc JavadocMethod Unused @param tag for 'clientConfig'. 172
 Error
javadoc JavadocMethod Unused @param tag for 'authServerConf'. 174
 Error
javadoc JavadocMethod Unused @param tag for 'clientConfig'. 234
 Error
javadoc JavadocMethod Unused @param tag for 'authServerConf'. 236
 Error
javadoc JavadocMethod Expected @param tag for 'jwtParser'. 319
 Error
javadoc JavadocMethod Missing a Javadoc comment. 347

fr/paris/lutece/plugins/oauth2/web/CallbackHandler.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
imports UnusedImports Unused import - java.util.ArrayList. 43
 Error
imports UnusedImports Unused import - java.util.Arrays. 44
 Error
imports UnusedImports Unused import - java.util.Iterator. 45
 Error
imports UnusedImports Unused import - java.util.List. 46
 Error
whitespace ParenPad '(' is not followed by whitespace. 206
 Error
whitespace ParenPad ')' is not preceded with whitespace. 206
 Error
whitespace WhitespaceAround '=' is not followed by whitespace. 208
 Error
whitespace WhitespaceAround '=' is not preceded with whitespace. 208
 Error
whitespace ParenPad '(' is not followed by whitespace. 208
 Error
whitespace ParenPad ')' is not preceded with whitespace. 208
 Error
whitespace WhitespaceAround '=' is not followed by whitespace. 209
 Error
whitespace WhitespaceAround '=' is not preceded with whitespace. 209
 Error
whitespace ParenPad '(' is not followed by whitespace. 209
 Error
whitespace ParenPad ')' is not preceded with whitespace. 209
 Error
whitespace ParenPad '(' is not followed by whitespace. 210
 Error
whitespace ParenPad ')' is not preceded with whitespace. 210
 Error
whitespace ParenPad '(' is not followed by whitespace. 211
 Error
whitespace ParenPad ')' is not preceded with whitespace. 211
 Error
whitespace ParenPad '(' is not followed by whitespace. 218
 Error
whitespace ParenPad ')' is not preceded with whitespace. 218
 Error
javadoc JavadocMethod Unused @param tag for 'the'. 291
 Error
javadoc JavadocMethod Expected @param tag for 'strRedirectUri'. 305
 Error
whitespace ParenPad '(' is not followed by whitespace. 310
 Error
whitespace ParenPad ')' is not preceded with whitespace. 310
 Error
whitespace ParenPad '(' is not followed by whitespace. 340
 Error
javadoc JavadocMethod Expected @param tag for 'strCodeVerifier'. 340
 Error
whitespace WhitespaceAround '=' is not followed by whitespace. 343
 Error
whitespace WhitespaceAround '=' is not preceded with whitespace. 343
 Error
blocks LeftCurly '{' at column 7 should be on a new line. 344
 Error
whitespace ParenPad '(' is not followed by whitespace. 345
 Error
whitespace ParenPad ')' is not preceded with whitespace. 345
 Error
whitespace ParenPad '(' is not followed by whitespace. 347
 Error
whitespace ParenPad ')' is not preceded with whitespace. 347
 Error
blocks RightCurly '}' at column 3 should be alone on a line. 349
 Error
whitespace ParenPad '(' is not followed by whitespace. 349
 Error
whitespace ParenPad ')' is not preceded with whitespace. 349
 Error
blocks LeftCurly '{' at column 70 should be on a new line. 349
 Error
whitespace ParenPad '(' is not followed by whitespace. 350
 Error
whitespace ParenPad ')' is not preceded with whitespace. 350
 Error
naming LocalVariableName Name 'StrCodeVerifier' must match pattern '^[a-z][a-zA-Z0-9]*$'. 367
 Error
whitespace WhitespaceAround '=' is not followed by whitespace. 367
 Error
whitespace WhitespaceAround '=' is not preceded with whitespace. 367
 Error
blocks LeftCurly '{' at column 7 should be on a new line. 368
 Error
blocks RightCurly '}' at column 3 should be alone on a line. 370
 Error
whitespace ParenPad '(' is not followed by whitespace. 370
 Error
whitespace ParenPad ')' is not preceded with whitespace. 370
 Error
blocks LeftCurly '{' at column 44 should be on a new line. 370
 Error
whitespace ParenPad '(' is not followed by whitespace. 371
 Error
whitespace ParenPad ')' is not preceded with whitespace. 371
 Error
coding HiddenField '_handlerName' hides a field. 554
 Error
naming ParameterName Name '_handlerName' must match pattern '^[a-z][a-zA-Z0-9]*$'. 554
 Error
coding HiddenField '_bDefault' hides a field. 592
 Error
naming ParameterName Name '_bDefault' must match pattern '^[a-z][a-zA-Z0-9]*$'. 592
 Error
javadoc JavadocMethod Missing a Javadoc comment. 597
 Error
whitespace ParenPad '(' is not followed by whitespace. 605
 Error
whitespace ParenPad ')' is not preceded with whitespace. 605
 Error
blocks LeftCurly '{' at column 66 should be on a new line. 605
 Error
whitespace ParenPad '(' is not followed by whitespace. 607
 Error
whitespace ParenPad ')' is not preceded with whitespace. 607
 Error
javadoc JavadocMethod Missing a Javadoc comment. 630
 Error
whitespace WhitespaceAround '=' is not preceded with whitespace. 632
 Error
whitespace ParenPad ')' is not preceded with whitespace. 632
 Error
whitespace ParenPad ')' is not preceded with whitespace. 634
 Error
whitespace ParenPad '(' is not followed by whitespace. 665
 Error
whitespace ParenPad ')' is not preceded with whitespace. 665
 Error
whitespace WhitespaceAround '=' is not followed by whitespace. 670
 Error
whitespace WhitespaceAround '=' is not preceded with whitespace. 670
 Error
whitespace ParenPad '(' is not followed by whitespace. 670
 Error
whitespace ParenPad ')' is not preceded with whitespace. 670
 Error
whitespace ParenPad '(' is not followed by whitespace. 677
 Error
whitespace ParenPad ')' is not preceded with whitespace. 677
 Error
whitespace ParenPad '(' is not followed by whitespace. 680
 Error
whitespace ParenPad ')' is not preceded with whitespace. 680
 Error
whitespace WhitespaceAround '=' is not preceded with whitespace. 685
 Error
whitespace ParenPad ')' is not preceded with whitespace. 685
 Error
whitespace ParenPad ')' is not preceded with whitespace. 687
 Error
blocks LeftCurly '{' at column 8 should be on a new line. 690
 Error
whitespace ParenPad '(' is not followed by whitespace. 692
 Error
whitespace ParenPad '(' is not followed by whitespace. 692
 Error
whitespace ParenPad ')' is not preceded with whitespace. 692
 Error
whitespace ParenPad ')' is not preceded with whitespace. 692
 Error
blocks RightCurly '}' at column 4 should be alone on a line. 694
 Error
whitespace ParenPad '(' is not followed by whitespace. 694
 Error
whitespace ParenPad ')' is not preceded with whitespace. 694
 Error
blocks LeftCurly '{' at column 45 should be on a new line. 694
 Error
whitespace ParenPad ')' is not preceded with whitespace. 696

fr/paris/lutece/plugins/oauth2/web/Constants.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/oauth2/web/OAuthCallbackServlet.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
imports UnusedImports Unused import - java.util.List. 37
 Error
imports UnusedImports Unused import - fr.paris.lutece.portal.service.spring.SpringContextService. 47

fr/paris/lutece/plugins/oauth2/web/OAuthLogoutServlet.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2