Fork me on GitHub
Built by Maven

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/referencelist/service/ReferenceItemListenerService.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 44–104

fr/paris/lutece/plugins/referencelist/service/ReferenceItemPrepareImport.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 49–230

Priority 3

fr/paris/lutece/plugins/referencelist/business/CompareResult.java

Rule Violation Line
DataClass The class 'CompareResult' is suspected to be a Data Class (WOC=14.286%, NOPA=0, NOAM=5, WMC=10) 44–120
ImmutableField Private field '_updateListCandidateReferenceItems' could be made final; it is only initialized in the declaration or constructor. 53
ImmutableField Private field '_duplicateListCandidateReferenceItems' could be made final; it is only initialized in the declaration or constructor. 54
ImmutableField Private field '_insertListCandidateReferenceItems' could be made final; it is only initialized in the declaration or constructor. 55
CommentRequired Public method and constructor comments are required 97–119
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 106
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 111
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 115

fr/paris/lutece/plugins/referencelist/business/IReferenceItemDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 44–157

fr/paris/lutece/plugins/referencelist/business/ReferenceItemDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 50–325

fr/paris/lutece/plugins/referencelist/business/ReferenceItemHome.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 186–230

fr/paris/lutece/plugins/referencelist/service/ReferenceIdService.java

Rule Violation Line
CommentRequired Header comments are required 47–96
ShortVariable Avoid variables with short names like rt 58
ShortVariable Avoid variables with short names like p 64

fr/paris/lutece/plugins/referencelist/service/ReferenceItemListService.java

Rule Violation Line
NonThreadSafeSingleton Singleton is not thread safe 62–65

fr/paris/lutece/plugins/referencelist/service/ReferenceItemListenerService.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 52–55
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 64
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 80
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 96

fr/paris/lutece/plugins/referencelist/service/ReferenceItemPrepareImport.java

Rule Violation Line
CommentRequired Header comments are required 49–230
LinguisticNaming Linguistics Antipattern - The method 'isErrorInCSVFile' indicates linguistically it returns a boolean, but it returns 'String' 105–156
ShortVariable Avoid variables with short names like i 112
CommentRequired Public method and constructor comments are required 195–210

fr/paris/lutece/plugins/referencelist/service/ReferenceListService.java

Rule Violation Line
NonThreadSafeSingleton Singleton is not thread safe 65–68

fr/paris/lutece/plugins/referencelist/web/ReferenceItemJspBean.java

Rule Violation Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 135
ConfusingTernary Avoid if (x != y) ..; else ..; 157
ConfusingTernary Avoid if (x != y) ..; else ..; 269–281
ConfusingTernary Avoid if (x != y) ..; else ..; 296

fr/paris/lutece/plugins/referencelist/web/ReferenceJspBean.java

Rule Violation Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 101
ConfusingTernary Avoid if (x != y) ..; else ..; 117

fr/paris/lutece/plugins/referencelist/web/TranslationItemJspBean.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 238–246

Priority 4

fr/paris/lutece/plugins/referencelist/business/ReferenceItemDAO.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.util.HashMap' 42
UnusedImports Avoid unused imports such as 'java.util.Map' 44

Files

fr/paris/lutece/plugins/referencelist/business/CompareResult.java

Rule Violation Priority Line
DataClass The class 'CompareResult' is suspected to be a Data Class (WOC=14.286%, NOPA=0, NOAM=5, WMC=10) 3 44–120
ImmutableField Private field '_updateListCandidateReferenceItems' could be made final; it is only initialized in the declaration or constructor. 3 53
ImmutableField Private field '_duplicateListCandidateReferenceItems' could be made final; it is only initialized in the declaration or constructor. 3 54
ImmutableField Private field '_insertListCandidateReferenceItems' could be made final; it is only initialized in the declaration or constructor. 3 55
CommentRequired Public method and constructor comments are required 3 97–119
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 106
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 111
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 115

fr/paris/lutece/plugins/referencelist/business/IReferenceItemDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 44–157

fr/paris/lutece/plugins/referencelist/business/ReferenceItemDAO.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.util.HashMap' 4 42
UnusedImports Avoid unused imports such as 'java.util.Map' 4 44
TooManyMethods This class has too many methods, consider refactoring it. 3 50–325

fr/paris/lutece/plugins/referencelist/business/ReferenceItemHome.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 186–230

fr/paris/lutece/plugins/referencelist/service/ReferenceIdService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 47–96
ShortVariable Avoid variables with short names like rt 3 58
ShortVariable Avoid variables with short names like p 3 64

fr/paris/lutece/plugins/referencelist/service/ReferenceItemListService.java

Rule Violation Priority Line
NonThreadSafeSingleton Singleton is not thread safe 3 62–65

fr/paris/lutece/plugins/referencelist/service/ReferenceItemListenerService.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 44–104
CommentRequired Public method and constructor comments are required 3 52–55
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 64
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 80
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 96

fr/paris/lutece/plugins/referencelist/service/ReferenceItemPrepareImport.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 49–230
CommentRequired Header comments are required 3 49–230
LinguisticNaming Linguistics Antipattern - The method 'isErrorInCSVFile' indicates linguistically it returns a boolean, but it returns 'String' 3 105–156
ShortVariable Avoid variables with short names like i 3 112
CommentRequired Public method and constructor comments are required 3 195–210

fr/paris/lutece/plugins/referencelist/service/ReferenceListService.java

Rule Violation Priority Line
NonThreadSafeSingleton Singleton is not thread safe 3 65–68

fr/paris/lutece/plugins/referencelist/web/ReferenceItemJspBean.java

Rule Violation Priority Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 135
ConfusingTernary Avoid if (x != y) ..; else ..; 3 157
ConfusingTernary Avoid if (x != y) ..; else ..; 3 269–281
ConfusingTernary Avoid if (x != y) ..; else ..; 3 296

fr/paris/lutece/plugins/referencelist/web/ReferenceJspBean.java

Rule Violation Priority Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 101
ConfusingTernary Avoid if (x != y) ..; else ..; 3 117

fr/paris/lutece/plugins/referencelist/web/TranslationItemJspBean.java

Rule Violation Priority Line
ConfusingTernary Avoid if (x != y) ..; else ..; 3 238–246