Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/strois/service/StockageService.java

Rule Violation Line
FieldNamingConventions The final field name '_s3Url' doesn't match '[a-z][a-zA-Z0-9]*' 81
FieldNamingConventions The final field name '_s3Bucket' doesn't match '[a-z][a-zA-Z0-9]*' 82
FieldNamingConventions The final field name '_s3Key' doesn't match '[a-z][a-zA-Z0-9]*' 83
FieldNamingConventions The final field name '_s3Password' doesn't match '[a-z][a-zA-Z0-9]*' 84

fr/paris/lutece/plugins/strois/util/S3Util.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 37107

Priority 2

fr/paris/lutece/plugins/strois/service/StockageService.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 357
GuardLogStatement Logger calls should be surrounded by log level guards. 380
GuardLogStatement Logger calls should be surrounded by log level guards. 460
GuardLogStatement Logger calls should be surrounded by log level guards. 464
GuardLogStatement Logger calls should be surrounded by log level guards. 468
GuardLogStatement Logger calls should be surrounded by log level guards. 475
GuardLogStatement Logger calls should be surrounded by log level guards. 479
AvoidReassigningParameters Avoid reassigning parameters such as 'path' 488
AvoidReassigningParameters Avoid reassigning parameters such as 'path' 488

Priority 3

fr/paris/lutece/plugins/strois/service/StockageService.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 35504
CommentRequired Header comments are required 76504
GodClass Possible God Class (WMC=59, ATFD=18, TCC=10.458%) 76504
TooManyMethods This class has too many methods, consider refactoring it. 77504
UseUnderscoresInNumericLiterals Number 10485760L should separate every third digit with an underscore 89
CommentRequired Public method and constructor comments are required 9197
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 125
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 126
ShortVariable Avoid variables with short names like is 152
AvoidDuplicateLiterals The String literal "Erreur chargement du fichier " appears 6 times in this file; the first occurrence is on line 160 160
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 161
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 167
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 173
CyclomaticComplexity The method 'saveFileToNetAppServer(InputStream, long, String, Multimap)' has a cyclomatic complexity of 10. 246289
AvoidDuplicateLiterals The String literal "Erreur de sauvegarde du fichier " appears 11 times in this file; the first occurrence is on line 272 272
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 273
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 279
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 285
CommentRequired Public method and constructor comments are required 302336
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 322
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 328
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 334
AvoidDuplicateLiterals The String literal "Erreur de récupération des tags du fichier " appears 6 times in this file; the first occurrence is on line 398 398
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 400
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 407
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 412
ShortVariable Avoid variables with short names like e 456
ShortVariable Avoid variables with short names like e 471

fr/paris/lutece/plugins/strois/util/S3Util.java

Rule Violation Line
CommentRequired Header comments are required 37107
CommentRequired Public method and constructor comments are required 4457
CommentRequired Public method and constructor comments are required 59106
CyclomaticComplexity The method 'matches(String, String)' has a cyclomatic complexity of 13. 59106
NPathComplexity The method 'matches(String, String)' has an NPath complexity of 245 59106
ShortVariable Avoid variables with short names like c 70
ShortVariable Avoid variables with short names like p 75

Files

fr/paris/lutece/plugins/strois/service/StockageService.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 35504
CommentRequired Header comments are required 3 76504
GodClass Possible God Class (WMC=59, ATFD=18, TCC=10.458%) 3 76504
TooManyMethods This class has too many methods, consider refactoring it. 3 77504
FieldNamingConventions The final field name '_s3Url' doesn't match '[a-z][a-zA-Z0-9]*' 1 81
FieldNamingConventions The final field name '_s3Bucket' doesn't match '[a-z][a-zA-Z0-9]*' 1 82
FieldNamingConventions The final field name '_s3Key' doesn't match '[a-z][a-zA-Z0-9]*' 1 83
FieldNamingConventions The final field name '_s3Password' doesn't match '[a-z][a-zA-Z0-9]*' 1 84
UseUnderscoresInNumericLiterals Number 10485760L should separate every third digit with an underscore 3 89
CommentRequired Public method and constructor comments are required 3 9197
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 125
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 126
ShortVariable Avoid variables with short names like is 3 152
AvoidDuplicateLiterals The String literal "Erreur chargement du fichier " appears 6 times in this file; the first occurrence is on line 160 3 160
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 161
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 167
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 173
CyclomaticComplexity The method 'saveFileToNetAppServer(InputStream, long, String, Multimap)' has a cyclomatic complexity of 10. 3 246289
AvoidDuplicateLiterals The String literal "Erreur de sauvegarde du fichier " appears 11 times in this file; the first occurrence is on line 272 3 272
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 273
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 279
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 285
CommentRequired Public method and constructor comments are required 3 302336
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 322
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 328
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 334
GuardLogStatement Logger calls should be surrounded by log level guards. 2 357
GuardLogStatement Logger calls should be surrounded by log level guards. 2 380
AvoidDuplicateLiterals The String literal "Erreur de récupération des tags du fichier " appears 6 times in this file; the first occurrence is on line 398 3 398
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 400
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 407
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 412
ShortVariable Avoid variables with short names like e 3 456
GuardLogStatement Logger calls should be surrounded by log level guards. 2 460
GuardLogStatement Logger calls should be surrounded by log level guards. 2 464
GuardLogStatement Logger calls should be surrounded by log level guards. 2 468
ShortVariable Avoid variables with short names like e 3 471
GuardLogStatement Logger calls should be surrounded by log level guards. 2 475
GuardLogStatement Logger calls should be surrounded by log level guards. 2 479
AvoidReassigningParameters Avoid reassigning parameters such as 'path' 2 488
AvoidReassigningParameters Avoid reassigning parameters such as 'path' 2 488

fr/paris/lutece/plugins/strois/util/S3Util.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 37107
CommentRequired Header comments are required 3 37107
CommentRequired Public method and constructor comments are required 3 4457
CommentRequired Public method and constructor comments are required 3 59106
CyclomaticComplexity The method 'matches(String, String)' has a cyclomatic complexity of 13. 3 59106
NPathComplexity The method 'matches(String, String)' has an NPath complexity of 245 3 59106
ShortVariable Avoid variables with short names like c 3 70
ShortVariable Avoid variables with short names like p 3 75