Fork me on GitHub

PMD Results

The following document contains the results of PMD 5.3.5.

Files

fr/paris/lutece/plugins/upload/web/UploadJspBean.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 34662
The class 'UploadJspBean' has a Standard Cyclomatic Complexity of 4 (Highest = 10). 85662
The class 'UploadJspBean' has a Cyclomatic Complexity of 4 (Highest = 11). 85662
The class 'UploadJspBean' has a Modified Cyclomatic Complexity of 4 (Highest = 10). 85662
Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. 143
Private field '_htDirectories' could be made final; it is only initialized in the declaration or constructor. 145
Avoid using implementation types like 'Hashtable'; use the interface instead 145
Avoid using implementation types like 'Hashtable'; use the interface instead 145
Consider replacing this Hashtable with the newer java.util.Map 145
Private field '_listDirectories' could be made final; it is only initialized in the declaration or constructor. 146
Avoid unnecessary constructors - the compiler will generate these for you 151153
Document empty constructor 151153
It is a good practice to call super() in a constructor 151153
Avoid really long methods. 161279
The method 'getFiles' has a Cyclomatic Complexity of 11. 161279
The method 'getFiles' has a Standard Cyclomatic Complexity of 10. 161279
The method getFiles() has an NPath complexity of 288 161279
The method 'getFiles' has a Modified Cyclomatic Complexity of 10. 161279
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 206
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 206
Do not add empty strings 270
Avoid variables with short names like i 294
Avoid really long methods. 330471
The method 'doCreateFile' has a Standard Cyclomatic Complexity of 10. 330471
The method 'doCreateFile' has a Cyclomatic Complexity of 11. 330471
The method 'doCreateFile' has a Modified Cyclomatic Complexity of 10. 330471
This statement may have some unnecessary parentheses 348
This statement may have some unnecessary parentheses 388
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 426
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 442
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 447
Consider using varargs for methods or constructors which take an array the last parameter. 480
Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 553
Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 553