Fork me on GitHub

Rapport FindBugs de détection des bugs

Le document suivant contient les résultats du FindBugs

La version de FindBugs est 3.0.1

La limite est

L'effort est max

Résumé

Classes Bugs Erreurs Classes Manquantes
20 18 0 0

Fichiers

Classe Bugs
fr.paris.lutece.plugins.greetingscard.business.GreetingsCard 3
fr.paris.lutece.plugins.greetingscard.business.GreetingsCardArchiveDAO 2
fr.paris.lutece.plugins.greetingscard.business.GreetingsCardTemplateHome 4
fr.paris.lutece.plugins.greetingscard.web.GreetingsCardApp 3
fr.paris.lutece.plugins.greetingscard.web.GreetingsCardJspBean 6

fr.paris.lutece.plugins.greetingscard.business.GreetingsCard

Bug Catégorie Détails Ligne Priorité
fr.paris.lutece.plugins.greetingscard.business.GreetingsCard.getDate() may expose internal representation by returning GreetingsCard._date MALICIOUS_CODE EI_EXPOSE_REP 224 Medium
fr.paris.lutece.plugins.greetingscard.business.GreetingsCard.setDate(Date) may expose internal representation by storing an externally mutable object into GreetingsCard._date MALICIOUS_CODE EI_EXPOSE_REP2 214 Medium
Nullcheck of GreetingsCard._strRecipientEmail at line 321 of value previously dereferenced in fr.paris.lutece.plugins.greetingscard.business.GreetingsCard.isInternal() CORRECTNESS RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE 319 Medium

fr.paris.lutece.plugins.greetingscard.business.GreetingsCardArchiveDAO

Bug Catégorie Détails Ligne Priorité
Dead store to archive in fr.paris.lutece.plugins.greetingscard.business.GreetingsCardArchiveDAO.findByTemplateIdAndYear(int, int, Plugin) STYLE DLS_DEAD_LOCAL_STORE 134 Medium
Dead store to archive in fr.paris.lutece.plugins.greetingscard.business.GreetingsCardArchiveDAO.findByYear(int, Plugin) STYLE DLS_DEAD_LOCAL_STORE 160 Medium

fr.paris.lutece.plugins.greetingscard.business.GreetingsCardTemplateHome

Bug Catégorie Détails Ligne Priorité
fr.paris.lutece.plugins.greetingscard.business.GreetingsCardTemplateHome.addGreetingsCardTemplate(FileItem, File) may fail to clean up java.io.OutputStream on checked exception EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE 148 Medium
Exceptional return value of java.io.File.mkdir() ignored in fr.paris.lutece.plugins.greetingscard.business.GreetingsCardTemplateHome.addDirectory(String) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 200 Medium
Exceptional return value of java.io.File.delete() ignored in fr.paris.lutece.plugins.greetingscard.business.GreetingsCardTemplateHome.removeDirectory(String) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 243 Medium
Exceptional return value of java.io.File.delete() ignored in fr.paris.lutece.plugins.greetingscard.business.GreetingsCardTemplateHome.removeGreetingsCardTemplate(String) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 177 Medium

fr.paris.lutece.plugins.greetingscard.web.GreetingsCardApp

Bug Catégorie Détails Ligne Priorité
Dead store to greetingsCardTemplate in fr.paris.lutece.plugins.greetingscard.web.GreetingsCardApp.getPage(HttpServletRequest, int, Plugin) STYLE DLS_DEAD_LOCAL_STORE 221 Medium
fr.paris.lutece.plugins.greetingscard.web.GreetingsCardApp.doSendGreetingsCard(HttpServletRequest, Plugin, String) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 522 Medium
Class fr.paris.lutece.plugins.greetingscard.web.GreetingsCardApp defines non-transient non-serializable instance field _captchaService BAD_PRACTICE SE_BAD_FIELD Non disponible Medium

fr.paris.lutece.plugins.greetingscard.web.GreetingsCardJspBean

Bug Catégorie Détails Ligne Priorité
Found reliance on default encoding in fr.paris.lutece.plugins.greetingscard.web.GreetingsCardJspBean.getMaiListFromCSV(FileItem): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 2042 High
Result of integer multiplication cast to long in fr.paris.lutece.plugins.greetingscard.web.GreetingsCardJspBean.doRemoveGreetingsCards(HttpServletRequest) STYLE ICAST_INTEGER_MULTIPLY_CAST_TO_LONG 1423 High
Redundant nullcheck of listMail, which is known to be non-null in fr.paris.lutece.plugins.greetingscard.web.GreetingsCardJspBean.doSendGreetingsCard(HttpServletRequest) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 1516 Medium
Class fr.paris.lutece.plugins.greetingscard.web.GreetingsCardJspBean defines non-transient non-serializable instance field _greetingsCardService BAD_PRACTICE SE_BAD_FIELD Non disponible Medium
Write to static field fr.paris.lutece.plugins.greetingscard.web.GreetingsCardJspBean._strWorkGroup from instance method fr.paris.lutece.plugins.greetingscard.web.GreetingsCardJspBean.doCreateGreetingsCardTemplate(HttpServletRequest) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 455 Medium
fr.paris.lutece.plugins.greetingscard.web.GreetingsCardJspBean.getGlobalStatistics(HttpServletRequest) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 1044 Medium