Fork me on GitHub

FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is

Effort is max

Summary

Classes Bugs Errors Missing Classes
11 10 0 0

Files

Class Bugs
fr.paris.lutece.plugins.geocode.v1.web.rs.dto.City 4
fr.paris.lutece.plugins.geocode.v1.web.rs.dto.Country 2
fr.paris.lutece.plugins.geocode.v1.web.rs.service.AbstractTransportRest 1
fr.paris.lutece.plugins.geocode.v1.web.rs.service.HttpAccessTransport 3

fr.paris.lutece.plugins.geocode.v1.web.rs.dto.City

Bug Category Details Line Priority
fr.paris.lutece.plugins.geocode.v1.web.rs.dto.City.getDateValidityEnd() may expose internal representation by returning City._dateValidityEnd MALICIOUS_CODE EI_EXPOSE_REP 167 Medium
fr.paris.lutece.plugins.geocode.v1.web.rs.dto.City.getDateValidityStart() may expose internal representation by returning City._dateValidityStart MALICIOUS_CODE EI_EXPOSE_REP 140 Medium
fr.paris.lutece.plugins.geocode.v1.web.rs.dto.City.setDateValidityEnd(Date) may expose internal representation by storing an externally mutable object into City._dateValidityEnd MALICIOUS_CODE EI_EXPOSE_REP2 185 Medium
fr.paris.lutece.plugins.geocode.v1.web.rs.dto.City.setDateValidityStart(Date) may expose internal representation by storing an externally mutable object into City._dateValidityStart MALICIOUS_CODE EI_EXPOSE_REP2 159 Medium

fr.paris.lutece.plugins.geocode.v1.web.rs.dto.Country

Bug Category Details Line Priority
fr.paris.lutece.plugins.geocode.v1.web.rs.dto.Country.getDateLastUpdate() may expose internal representation by returning Country._dateLastUpdate MALICIOUS_CODE EI_EXPOSE_REP 92 Medium
fr.paris.lutece.plugins.geocode.v1.web.rs.dto.Country.setDateLastUpdate(Date) may expose internal representation by storing an externally mutable object into Country._dateLastUpdate MALICIOUS_CODE EI_EXPOSE_REP2 100 Medium

fr.paris.lutece.plugins.geocode.v1.web.rs.service.AbstractTransportRest

Bug Category Details Line Priority
fr.paris.lutece.plugins.geocode.v1.web.rs.service.AbstractTransportRest._mapper isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 54 High

fr.paris.lutece.plugins.geocode.v1.web.rs.service.HttpAccessTransport

Bug Category Details Line Priority
instanceof will always return true for all non-null values in fr.paris.lutece.plugins.geocode.v1.web.rs.service.HttpAccessTransport.handleExceptionGeocode(Exception), since all Exception are instances of Exception STYLE BC_VACUOUS_INSTANCEOF 146 Medium
fr.paris.lutece.plugins.geocode.v1.web.rs.service.HttpAccessTransport.doGet(String, Map, Map, Class, ObjectMapper) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 84 Medium
fr.paris.lutece.plugins.geocode.v1.web.rs.service.HttpAccessTransport.doGetList(String, Map, Map, Class, ObjectMapper) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 115 Medium