Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/grubusiness/business/customer/Customer.java

Rule Violation Line
FieldNamingConventions The final field name '_mapAttributes' doesn't match '[a-z][a-zA-Z0-9]*' 120

fr/paris/lutece/plugins/grubusiness/business/customer/CustomerService.java

Rule Violation Line
FieldNamingConventions The final field name '_daoCustomer' doesn't match '[a-z][a-zA-Z0-9]*' 45

fr/paris/lutece/plugins/grubusiness/business/demand/DemandType.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' 70

fr/paris/lutece/plugins/grubusiness/business/mock/MockCustomerDAO.java

Rule Violation Line
FieldNamingConventions The final field name '_mapMockCustomer' doesn't match '[a-z][a-zA-Z0-9]*' 52

fr/paris/lutece/plugins/grubusiness/business/mock/MockDemandDAO.java

Rule Violation Line
FieldNamingConventions The final field name '_mapMockDemand' doesn't match '[a-z][a-zA-Z0-9]*' 52

fr/paris/lutece/plugins/grubusiness/business/mock/MockDemandListener.java

Rule Violation Line
FieldNamingConventions The final field name '_listLogAction' doesn't match '[a-z][a-zA-Z0-9]*' 47

fr/paris/lutece/plugins/grubusiness/business/mock/MockNotificationDAO.java

Rule Violation Line
FieldNamingConventions The final field name '_listMockNotification' doesn't match '[a-z][a-zA-Z0-9]*' 52

fr/paris/lutece/plugins/grubusiness/business/mock/MockNotificationListener.java

Rule Violation Line
FieldNamingConventions The final field name '_listLogAction' doesn't match '[a-z][a-zA-Z0-9]*' 47

fr/paris/lutece/plugins/grubusiness/business/notification/Event.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_strType' doesn't match '[a-z][a-zA-Z0-9]*' 119
FormalParameterNamingConventions The method parameter name '_strStatus' doesn't match '[a-z][a-zA-Z0-9]*' 139
FormalParameterNamingConventions The method parameter name '_strReason' doesn't match '[a-z][a-zA-Z0-9]*' 159
FormalParameterNamingConventions The method parameter name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' 179

fr/paris/lutece/plugins/grubusiness/business/notification/NotificationConstants.java

Rule Violation Line
ClassNamingConventions The utility class name 'NotificationConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 39–57

fr/paris/lutece/plugins/grubusiness/business/notification/NotificationFilter.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_lStartDate' doesn't match '[a-z][a-zA-Z0-9]*' 232
FormalParameterNamingConventions The method parameter name '_lEndDate' doesn't match '[a-z][a-zA-Z0-9]*' 262

fr/paris/lutece/plugins/grubusiness/business/notification/StatusMessage.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' 28
FormalParameterNamingConventions The method parameter name '_strStatus' doesn't match '[a-z][a-zA-Z0-9]*' 28
FormalParameterNamingConventions The method parameter name '_strReason' doesn't match '[a-z][a-zA-Z0-9]*' 28
FormalParameterNamingConventions The method parameter name '_strType' doesn't match '[a-z][a-zA-Z0-9]*' 28
FormalParameterNamingConventions The method parameter name '_strType' doesn't match '[a-z][a-zA-Z0-9]*' 53
FormalParameterNamingConventions The method parameter name '_strStatus' doesn't match '[a-z][a-zA-Z0-9]*' 73
FormalParameterNamingConventions The method parameter name '_strReason' doesn't match '[a-z][a-zA-Z0-9]*' 93
FormalParameterNamingConventions The method parameter name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' 113

fr/paris/lutece/plugins/grubusiness/business/web/rs/responseStatus/ResponseStatus.java

Rule Violation Line
FieldNamingConventions The field name 'message' doesn't match '_[a-z][a-zA-Z0-9]*' 59
FieldNamingConventions The field name 'messageKey' doesn't match '_[a-z][a-zA-Z0-9]*' 60

fr/paris/lutece/plugins/grubusiness/business/web/rs/responseStatus/ResponseStatusFactory.java

Rule Violation Line
ClassNamingConventions The utility class name 'ResponseStatusFactory' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 13–88

Priority 3

fr/paris/lutece/plugins/grubusiness/business/customer/Customer.java

Rule Violation Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 53
TooManyFields Too many fields 54–514

fr/paris/lutece/plugins/grubusiness/business/demand/Demand.java

Rule Violation Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 50
TooManyFields Too many fields 54–441
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 65

fr/paris/lutece/plugins/grubusiness/business/demand/DemandType.java

Rule Violation Line
CommentRequired Header comments are required 38–188

fr/paris/lutece/plugins/grubusiness/business/demand/IDemandDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 46–173

fr/paris/lutece/plugins/grubusiness/business/demand/IDemandServiceProvider.java

Rule Violation Line
CommentRequired Header comments are required 46–202
UnnecessaryModifier Unnecessary modifier 'public' on method 'setDemandDao': the method is declared in an interface type 54
UnnecessaryModifier Unnecessary modifier 'public' on method 'setDemandTypeDao': the method is declared in an interface type 61
UnnecessaryModifier Unnecessary modifier 'public' on method 'setNotificationDao': the method is declared in an interface type 68
UnnecessaryModifier Unnecessary modifier 'public' on method 'setNotificationEventDao': the method is declared in an interface type 75
UnnecessaryModifier Unnecessary modifier 'public' on method 'setStatusDao': the method is declared in an interface type 82
UnnecessaryModifier Unnecessary modifier 'public' on method 'findByCustomerId': the method is declared in an interface type 91
UnnecessaryModifier Unnecessary modifier 'public' on method 'findByReference': the method is declared in an interface type 100
UnnecessaryModifier Unnecessary modifier 'public' on method 'findByPrimaryKey': the method is declared in an interface type 111
UnnecessaryModifier Unnecessary modifier 'public' on method 'create': the method is declared in an interface type 120
UnnecessaryModifier Unnecessary modifier 'public' on method 'create': the method is declared in an interface type 129
UnnecessaryModifier Unnecessary modifier 'public' on method 'create': the method is declared in an interface type 137
UnnecessaryModifier Unnecessary modifier 'public' on method 'update': the method is declared in an interface type 146
UnnecessaryModifier Unnecessary modifier 'public' on method 'remove': the method is declared in an interface type 156
UnnecessaryModifier Unnecessary modifier 'public' on method 'findEventsByDateAndDemandTypeIdAndStatus': the method is declared in an interface type 168
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDemandTypesList': the method is declared in an interface type 175
ShortVariable Avoid variables with short names like id 183
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDemandType': the method is declared in an interface type 183
UnnecessaryModifier Unnecessary modifier 'public' on method 'getIdsByCustomerIdAndDemandTypeId': the method is declared in an interface type 193
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStatusByLabel': the method is declared in an interface type 201

fr/paris/lutece/plugins/grubusiness/business/mock/MockCustomerDAO.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 52
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 52
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 72

fr/paris/lutece/plugins/grubusiness/business/mock/MockDemandDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 51–190
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 52
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 52
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 60
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 77

fr/paris/lutece/plugins/grubusiness/business/mock/MockDemandListener.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 47
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 85–105

fr/paris/lutece/plugins/grubusiness/business/mock/MockNotificationDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 50–284
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 52
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 61
CyclomaticComplexity The method 'loadByFilter(NotificationFilter)' has a cyclomatic complexity of 16. 77–117
NPathComplexity The method 'loadByFilter(NotificationFilter)' has an NPath complexity of 2917 77–117
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 79
CyclomaticComplexity The method 'loadIdsByFilter(NotificationFilter)' has a cyclomatic complexity of 16. 157–197
NPathComplexity The method 'loadIdsByFilter(NotificationFilter)' has an NPath complexity of 2917 157–197
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 219
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 234
ShortVariable Avoid variables with short names like id 260

fr/paris/lutece/plugins/grubusiness/business/mock/MockNotificationEventDAO.java

Rule Violation Line
DefaultPackage Use explicit scoping instead of the default package private level 49
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _eventList field if you want a default access modifier 49
ControlStatementBraces This statement should have braces 71

fr/paris/lutece/plugins/grubusiness/business/mock/MockNotificationListener.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 47
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 85–120

fr/paris/lutece/plugins/grubusiness/business/notification/BackofficeNotification.java

Rule Violation Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 46

fr/paris/lutece/plugins/grubusiness/business/notification/BillingAccountBasedSMSNotification.java

Rule Violation Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 43
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strBillingAccount field if you want a default access modifier 49
DefaultPackage Use explicit scoping instead of the default package private level 49
DefaultPackage Use explicit scoping instead of the default package private level 50
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strBillingGroup field if you want a default access modifier 50

fr/paris/lutece/plugins/grubusiness/business/notification/BroadcastNotification.java

Rule Violation Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 55
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 149
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 235
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 275

fr/paris/lutece/plugins/grubusiness/business/notification/EmailAddress.java

Rule Violation Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 47
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 87

fr/paris/lutece/plugins/grubusiness/business/notification/EmailNotification.java

Rule Violation Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 53

fr/paris/lutece/plugins/grubusiness/business/notification/Event.java

Rule Violation Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 45

fr/paris/lutece/plugins/grubusiness/business/notification/INotificationDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 44–152
ShortVariable Avoid variables with short names like id 52
ShortVariable Avoid variables with short names like id 151

fr/paris/lutece/plugins/grubusiness/business/notification/INotificationEventDAO.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'loadByNotification': the method is declared in an interface type 73

fr/paris/lutece/plugins/grubusiness/business/notification/MyDashboardNotification.java

Rule Violation Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 49

fr/paris/lutece/plugins/grubusiness/business/notification/Notification.java

Rule Violation Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 60
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 283

fr/paris/lutece/plugins/grubusiness/business/notification/NotificationEvent.java

Rule Violation Line
ImportFromSamePackage No need to import a type that lives in the same package 42
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 48

fr/paris/lutece/plugins/grubusiness/business/notification/NotificationFilter.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 43–304

fr/paris/lutece/plugins/grubusiness/business/notification/NotifyGruResponse.java

Rule Violation Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 44

fr/paris/lutece/plugins/grubusiness/business/notification/SMSNotification.java

Rule Violation Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 47

fr/paris/lutece/plugins/grubusiness/business/web/rs/EnumGenericStatus.java

Rule Violation Line
CommentRequired Enum comments are required 36–128
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'EnumGenericStatus(Integer, String, boolean)': enum constructors are implicitly private 55–60

fr/paris/lutece/plugins/grubusiness/business/web/rs/SearchResult.java

Rule Violation Line
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 46–133
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 59
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 69

fr/paris/lutece/plugins/grubusiness/business/web/rs/responseStatus/ResponseStatus.java

Rule Violation Line
PackageCase Package name contains upper case characters 34
CommentRequired Header comments are required 47–130
CommentRequired Public method and constructor comments are required 66–70
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 72
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 78
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 84
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 90
CommentRequired Public method and constructor comments are required 91–95
LinguisticNaming Linguistics Antipattern - The setter 'setMessage' should not return any type except void linguistically 91–95
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 97
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 103
LinguisticNaming Linguistics Antipattern - The setter 'setMessageKey' should not return any type except void linguistically 104–108
CommentRequired Public method and constructor comments are required 104–108
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 111
ShortVariable Avoid variables with short names like o 111

fr/paris/lutece/plugins/grubusiness/business/web/rs/responseStatus/ResponseStatusFactory.java

Rule Violation Line
PackageCase Package name contains upper case characters 1
TooManyStaticImports Too many static imports may lead to messy code 1–88
CommentRequired Header comments are required 13–88
TooManyMethods This class has too many methods, consider refactoring it. 14–88
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 14–88
CommentRequired Public method and constructor comments are required 16–19
ShortMethodName Avoid using short method names 16
CommentRequired Public method and constructor comments are required 21–24
CommentRequired Public method and constructor comments are required 26–29
CommentRequired Public method and constructor comments are required 31–34
CommentRequired Public method and constructor comments are required 36–39
CommentRequired Public method and constructor comments are required 41–44
CommentRequired Public method and constructor comments are required 46–49
CommentRequired Public method and constructor comments are required 51–54
CommentRequired Public method and constructor comments are required 56–59
CommentRequired Public method and constructor comments are required 61–64
CommentRequired Public method and constructor comments are required 66–87

fr/paris/lutece/plugins/grubusiness/business/web/rs/responseStatus/ResponseStatusType.java

Rule Violation Line
PackageCase Package name contains upper case characters 1
CommentRequired Enum comments are required 3–14

fr/paris/lutece/plugins/grubusiness/service/notification/INotifyerServiceProvider.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'process': the method is declared in an interface type 51
UnnecessaryModifier Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type 58

fr/paris/lutece/plugins/grubusiness/service/notification/NotificationException.java

Rule Violation Line
ShortVariable Avoid variables with short names like e 67

Priority 4

fr/paris/lutece/plugins/grubusiness/business/customer/Customer.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 244–247
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 357–360
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 421–424

fr/paris/lutece/plugins/grubusiness/business/demand/Demand.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 419–422

fr/paris/lutece/plugins/grubusiness/business/demand/IDemandServiceProvider.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.grubusiness.business.notification.INotificationListener' 42

fr/paris/lutece/plugins/grubusiness/business/web/rs/responseStatus/ResponseStatus.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'com.fasterxml.jackson.annotation.JsonPropertyOrder' 38
UnusedImports Avoid unused imports such as 'java.util.ArrayList' 41
UnusedImports Avoid unused imports such as 'java.util.List' 42

Files

fr/paris/lutece/plugins/grubusiness/business/customer/Customer.java

Rule Violation Priority Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 53
TooManyFields Too many fields 3 54–514
FieldNamingConventions The final field name '_mapAttributes' doesn't match '[a-z][a-zA-Z0-9]*' 1 120
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 244–247
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 357–360
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 421–424

fr/paris/lutece/plugins/grubusiness/business/customer/CustomerService.java

Rule Violation Priority Line
FieldNamingConventions The final field name '_daoCustomer' doesn't match '[a-z][a-zA-Z0-9]*' 1 45

fr/paris/lutece/plugins/grubusiness/business/demand/Demand.java

Rule Violation Priority Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 50
TooManyFields Too many fields 3 54–441
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 65
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 419–422

fr/paris/lutece/plugins/grubusiness/business/demand/DemandType.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 38–188
FormalParameterNamingConventions The method parameter name '_nId' doesn't match '[a-z][a-zA-Z0-9]*' 1 70

fr/paris/lutece/plugins/grubusiness/business/demand/IDemandDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 46–173

fr/paris/lutece/plugins/grubusiness/business/demand/IDemandServiceProvider.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.grubusiness.business.notification.INotificationListener' 4 42
CommentRequired Header comments are required 3 46–202
UnnecessaryModifier Unnecessary modifier 'public' on method 'setDemandDao': the method is declared in an interface type 3 54
UnnecessaryModifier Unnecessary modifier 'public' on method 'setDemandTypeDao': the method is declared in an interface type 3 61
UnnecessaryModifier Unnecessary modifier 'public' on method 'setNotificationDao': the method is declared in an interface type 3 68
UnnecessaryModifier Unnecessary modifier 'public' on method 'setNotificationEventDao': the method is declared in an interface type 3 75
UnnecessaryModifier Unnecessary modifier 'public' on method 'setStatusDao': the method is declared in an interface type 3 82
UnnecessaryModifier Unnecessary modifier 'public' on method 'findByCustomerId': the method is declared in an interface type 3 91
UnnecessaryModifier Unnecessary modifier 'public' on method 'findByReference': the method is declared in an interface type 3 100
UnnecessaryModifier Unnecessary modifier 'public' on method 'findByPrimaryKey': the method is declared in an interface type 3 111
UnnecessaryModifier Unnecessary modifier 'public' on method 'create': the method is declared in an interface type 3 120
UnnecessaryModifier Unnecessary modifier 'public' on method 'create': the method is declared in an interface type 3 129
UnnecessaryModifier Unnecessary modifier 'public' on method 'create': the method is declared in an interface type 3 137
UnnecessaryModifier Unnecessary modifier 'public' on method 'update': the method is declared in an interface type 3 146
UnnecessaryModifier Unnecessary modifier 'public' on method 'remove': the method is declared in an interface type 3 156
UnnecessaryModifier Unnecessary modifier 'public' on method 'findEventsByDateAndDemandTypeIdAndStatus': the method is declared in an interface type 3 168
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDemandTypesList': the method is declared in an interface type 3 175
ShortVariable Avoid variables with short names like id 3 183
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDemandType': the method is declared in an interface type 3 183
UnnecessaryModifier Unnecessary modifier 'public' on method 'getIdsByCustomerIdAndDemandTypeId': the method is declared in an interface type 3 193
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStatusByLabel': the method is declared in an interface type 3 201

fr/paris/lutece/plugins/grubusiness/business/mock/MockCustomerDAO.java

Rule Violation Priority Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 52
FieldNamingConventions The final field name '_mapMockCustomer' doesn't match '[a-z][a-zA-Z0-9]*' 1 52
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 52
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 72

fr/paris/lutece/plugins/grubusiness/business/mock/MockDemandDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 51–190
FieldNamingConventions The final field name '_mapMockDemand' doesn't match '[a-z][a-zA-Z0-9]*' 1 52
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 52
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 52
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 60
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 77

fr/paris/lutece/plugins/grubusiness/business/mock/MockDemandListener.java

Rule Violation Priority Line
FieldNamingConventions The final field name '_listLogAction' doesn't match '[a-z][a-zA-Z0-9]*' 1 47
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 47
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 85–105

fr/paris/lutece/plugins/grubusiness/business/mock/MockNotificationDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 50–284
FieldNamingConventions The final field name '_listMockNotification' doesn't match '[a-z][a-zA-Z0-9]*' 1 52
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 52
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 61
CyclomaticComplexity The method 'loadByFilter(NotificationFilter)' has a cyclomatic complexity of 16. 3 77–117
NPathComplexity The method 'loadByFilter(NotificationFilter)' has an NPath complexity of 2917 3 77–117
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 79
CyclomaticComplexity The method 'loadIdsByFilter(NotificationFilter)' has a cyclomatic complexity of 16. 3 157–197
NPathComplexity The method 'loadIdsByFilter(NotificationFilter)' has an NPath complexity of 2917 3 157–197
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 219
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 234
ShortVariable Avoid variables with short names like id 3 260

fr/paris/lutece/plugins/grubusiness/business/mock/MockNotificationEventDAO.java

Rule Violation Priority Line
DefaultPackage Use explicit scoping instead of the default package private level 3 49
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _eventList field if you want a default access modifier 3 49
ControlStatementBraces This statement should have braces 3 71

fr/paris/lutece/plugins/grubusiness/business/mock/MockNotificationListener.java

Rule Violation Priority Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 47
FieldNamingConventions The final field name '_listLogAction' doesn't match '[a-z][a-zA-Z0-9]*' 1 47
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 85–120

fr/paris/lutece/plugins/grubusiness/business/notification/BackofficeNotification.java

Rule Violation Priority Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 46

fr/paris/lutece/plugins/grubusiness/business/notification/BillingAccountBasedSMSNotification.java

Rule Violation Priority Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 43
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strBillingAccount field if you want a default access modifier 3 49
DefaultPackage Use explicit scoping instead of the default package private level 3 49
DefaultPackage Use explicit scoping instead of the default package private level 3 50
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strBillingGroup field if you want a default access modifier 3 50

fr/paris/lutece/plugins/grubusiness/business/notification/BroadcastNotification.java

Rule Violation Priority Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 55
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 149
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 235
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 275

fr/paris/lutece/plugins/grubusiness/business/notification/EmailAddress.java

Rule Violation Priority Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 47
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 87

fr/paris/lutece/plugins/grubusiness/business/notification/EmailNotification.java

Rule Violation Priority Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 53

fr/paris/lutece/plugins/grubusiness/business/notification/Event.java

Rule Violation Priority Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 45
FormalParameterNamingConventions The method parameter name '_strType' doesn't match '[a-z][a-zA-Z0-9]*' 1 119
FormalParameterNamingConventions The method parameter name '_strStatus' doesn't match '[a-z][a-zA-Z0-9]*' 1 139
FormalParameterNamingConventions The method parameter name '_strReason' doesn't match '[a-z][a-zA-Z0-9]*' 1 159
FormalParameterNamingConventions The method parameter name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' 1 179

fr/paris/lutece/plugins/grubusiness/business/notification/INotificationDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 44–152
ShortVariable Avoid variables with short names like id 3 52
ShortVariable Avoid variables with short names like id 3 151

fr/paris/lutece/plugins/grubusiness/business/notification/INotificationEventDAO.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'loadByNotification': the method is declared in an interface type 3 73

fr/paris/lutece/plugins/grubusiness/business/notification/MyDashboardNotification.java

Rule Violation Priority Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 49

fr/paris/lutece/plugins/grubusiness/business/notification/Notification.java

Rule Violation Priority Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 60
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 283

fr/paris/lutece/plugins/grubusiness/business/notification/NotificationConstants.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'NotificationConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 39–57

fr/paris/lutece/plugins/grubusiness/business/notification/NotificationEvent.java

Rule Violation Priority Line
ImportFromSamePackage No need to import a type that lives in the same package 3 42
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 48

fr/paris/lutece/plugins/grubusiness/business/notification/NotificationFilter.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 43–304
FormalParameterNamingConventions The method parameter name '_lStartDate' doesn't match '[a-z][a-zA-Z0-9]*' 1 232
FormalParameterNamingConventions The method parameter name '_lEndDate' doesn't match '[a-z][a-zA-Z0-9]*' 1 262

fr/paris/lutece/plugins/grubusiness/business/notification/NotifyGruResponse.java

Rule Violation Priority Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 44

fr/paris/lutece/plugins/grubusiness/business/notification/SMSNotification.java

Rule Violation Priority Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 47

fr/paris/lutece/plugins/grubusiness/business/notification/StatusMessage.java

Rule Violation Priority Line
FormalParameterNamingConventions The method parameter name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' 1 28
FormalParameterNamingConventions The method parameter name '_strStatus' doesn't match '[a-z][a-zA-Z0-9]*' 1 28
FormalParameterNamingConventions The method parameter name '_strReason' doesn't match '[a-z][a-zA-Z0-9]*' 1 28
FormalParameterNamingConventions The method parameter name '_strType' doesn't match '[a-z][a-zA-Z0-9]*' 1 28
FormalParameterNamingConventions The method parameter name '_strType' doesn't match '[a-z][a-zA-Z0-9]*' 1 53
FormalParameterNamingConventions The method parameter name '_strStatus' doesn't match '[a-z][a-zA-Z0-9]*' 1 73
FormalParameterNamingConventions The method parameter name '_strReason' doesn't match '[a-z][a-zA-Z0-9]*' 1 93
FormalParameterNamingConventions The method parameter name '_strMessage' doesn't match '[a-z][a-zA-Z0-9]*' 1 113

fr/paris/lutece/plugins/grubusiness/business/web/rs/EnumGenericStatus.java

Rule Violation Priority Line
CommentRequired Enum comments are required 3 36–128
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'EnumGenericStatus(Integer, String, boolean)': enum constructors are implicitly private 3 55–60

fr/paris/lutece/plugins/grubusiness/business/web/rs/SearchResult.java

Rule Violation Priority Line
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 3 46–133
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 59
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 69

fr/paris/lutece/plugins/grubusiness/business/web/rs/responseStatus/ResponseStatus.java

Rule Violation Priority Line
PackageCase Package name contains upper case characters 3 34
UnusedImports Avoid unused imports such as 'com.fasterxml.jackson.annotation.JsonPropertyOrder' 4 38
UnusedImports Avoid unused imports such as 'java.util.ArrayList' 4 41
UnusedImports Avoid unused imports such as 'java.util.List' 4 42
CommentRequired Header comments are required 3 47–130
FieldNamingConventions The field name 'message' doesn't match '_[a-z][a-zA-Z0-9]*' 1 59
FieldNamingConventions The field name 'messageKey' doesn't match '_[a-z][a-zA-Z0-9]*' 1 60
CommentRequired Public method and constructor comments are required 3 66–70
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 72
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 78
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 84
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 90
CommentRequired Public method and constructor comments are required 3 91–95
LinguisticNaming Linguistics Antipattern - The setter 'setMessage' should not return any type except void linguistically 3 91–95
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 97
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 103
LinguisticNaming Linguistics Antipattern - The setter 'setMessageKey' should not return any type except void linguistically 3 104–108
CommentRequired Public method and constructor comments are required 3 104–108
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 3 111
ShortVariable Avoid variables with short names like o 3 111

fr/paris/lutece/plugins/grubusiness/business/web/rs/responseStatus/ResponseStatusFactory.java

Rule Violation Priority Line
PackageCase Package name contains upper case characters 3 1
TooManyStaticImports Too many static imports may lead to messy code 3 1–88
CommentRequired Header comments are required 3 13–88
ClassNamingConventions The utility class name 'ResponseStatusFactory' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 13–88
TooManyMethods This class has too many methods, consider refactoring it. 3 14–88
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 14–88
CommentRequired Public method and constructor comments are required 3 16–19
ShortMethodName Avoid using short method names 3 16
CommentRequired Public method and constructor comments are required 3 21–24
CommentRequired Public method and constructor comments are required 3 26–29
CommentRequired Public method and constructor comments are required 3 31–34
CommentRequired Public method and constructor comments are required 3 36–39
CommentRequired Public method and constructor comments are required 3 41–44
CommentRequired Public method and constructor comments are required 3 46–49
CommentRequired Public method and constructor comments are required 3 51–54
CommentRequired Public method and constructor comments are required 3 56–59
CommentRequired Public method and constructor comments are required 3 61–64
CommentRequired Public method and constructor comments are required 3 66–87

fr/paris/lutece/plugins/grubusiness/business/web/rs/responseStatus/ResponseStatusType.java

Rule Violation Priority Line
PackageCase Package name contains upper case characters 3 1
CommentRequired Enum comments are required 3 3–14

fr/paris/lutece/plugins/grubusiness/service/notification/INotifyerServiceProvider.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'process': the method is declared in an interface type 3 51
UnnecessaryModifier Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type 3 58

fr/paris/lutece/plugins/grubusiness/service/notification/NotificationException.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like e 3 67