Fork me on GitHub

FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is

Effort is max

Summary

Classes Bugs Errors Missing Classes
8 10 0 33

Files

Class Bugs
fr.paris.lutece.util.httpaccess.HttpAccess 6
fr.paris.lutece.util.httpaccess.HttpAccessService 1
fr.paris.lutece.util.httpaccess.MemoryFileItem 3

fr.paris.lutece.util.httpaccess.HttpAccess

Bug Category Details Line Priority
Redundant nullcheck of StringBuilder.toString(), which is known to be non-null in fr.paris.lutece.util.httpaccess.HttpAccess.validateResponseStatus(int, String, CloseableHttpResponse, String) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 1223 Medium
Nullcheck of response at line 1126 of value previously dereferenced in fr.paris.lutece.util.httpaccess.HttpAccess.downloadFile(String) CORRECTNESS RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE 1126 Medium
Nullcheck of response at line 1009 of value previously dereferenced in fr.paris.lutece.util.httpaccess.HttpAccess.downloadFile(String, OutputStream) CORRECTNESS RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE 1009 Medium
Nullcheck of response at line 1069 of value previously dereferenced in fr.paris.lutece.util.httpaccess.HttpAccess.getFileName(String) CORRECTNESS RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE 1069 Medium
Nullcheck of httpClient at line 1326 of value previously dereferenced in fr.paris.lutece.util.httpaccess.HttpAccess.getResponseBody(HttpUriRequestBase, String, Map) CORRECTNESS RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE 1326 Medium
Nullcheck of response at line 1328 of value previously dereferenced in fr.paris.lutece.util.httpaccess.HttpAccess.getResponseBody(HttpUriRequestBase, String, Map) CORRECTNESS RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE 1328 Medium

fr.paris.lutece.util.httpaccess.HttpAccessService

Bug Category Details Line Priority
Incorrect lazy initialization and update of static field fr.paris.lutece.util.httpaccess.HttpAccessService._singleton in fr.paris.lutece.util.httpaccess.HttpAccessService.getInstance() MT_CORRECTNESS LI_LAZY_INIT_UPDATE_STATIC 142-144 High

fr.paris.lutece.util.httpaccess.MemoryFileItem

Bug Category Details Line Priority
Found reliance on default encoding in fr.paris.lutece.util.httpaccess.MemoryFileItem.getString(): new String(byte[]) I18N DM_DEFAULT_ENCODING 149 High
fr.paris.lutece.util.httpaccess.MemoryFileItem.get() may expose internal representation by returning MemoryFileItem._data MALICIOUS_CODE EI_EXPOSE_REP 91 Medium
new fr.paris.lutece.util.httpaccess.MemoryFileItem(byte[], String, long, String) may expose internal representation by storing an externally mutable object into MemoryFileItem._data MALICIOUS_CODE EI_EXPOSE_REP2 72 Medium