Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/identitystore/v1/web/request/IdentityStoreGetRequest.java

Rule Violation Line
FieldNamingConventions The final field name '_strConnectionId' doesn't match '[a-z][a-zA-Z0-9]*' 50
FieldNamingConventions The final field name '_strCustomerId' doesn't match '[a-z][a-zA-Z0-9]*' 51
FieldNamingConventions The final field name '_strClientAppCode' doesn't match '[a-z][a-zA-Z0-9]*' 52
FieldNamingConventions The final field name '_objectMapper' doesn't match '[a-z][a-zA-Z0-9]*' 53

fr/paris/lutece/plugins/identitystore/v1/web/rs/DtoConverter.java

Rule Violation Line
ClassNamingConventions The utility class name 'DtoConverter' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 49129

fr/paris/lutece/plugins/identitystore/v1/web/rs/IdentityStoreRestService.java

Rule Violation Line
FieldNamingConventions The final field name '_objectMapper' doesn't match '[a-z][a-zA-Z0-9]*' 63

fr/paris/lutece/plugins/identitystore/v1/web/rs/swagger/Constants.java

Rule Violation Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3957

fr/paris/lutece/plugins/identitystore/v2/web/request/IdentityStoreGetRequest.java

Rule Violation Line
FieldNamingConventions The final field name '_strConnectionId' doesn't match '[a-z][a-zA-Z0-9]*' 52
FieldNamingConventions The final field name '_strCustomerId' doesn't match '[a-z][a-zA-Z0-9]*' 53
FieldNamingConventions The final field name '_strClientAppCode' doesn't match '[a-z][a-zA-Z0-9]*' 54
FieldNamingConventions The final field name '_objectMapper' doesn't match '[a-z][a-zA-Z0-9]*' 55

fr/paris/lutece/plugins/identitystore/v2/web/rs/DtoConverter.java

Rule Violation Line
ClassNamingConventions The utility class name 'DtoConverter' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 49104

fr/paris/lutece/plugins/identitystore/v2/web/rs/IdentityStoreRestService.java

Rule Violation Line
FieldNamingConventions The final field name '_objectMapper' doesn't match '[a-z][a-zA-Z0-9]*' 63

fr/paris/lutece/plugins/identitystore/v2/web/rs/swagger/Constants.java

Rule Violation Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3987

Priority 2

fr/paris/lutece/plugins/identitystore/v1/web/rs/IdentityStoreRestService.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 123

fr/paris/lutece/plugins/identitystore/v2/web/rs/IdentityStoreRestService.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 123

Priority 3

fr/paris/lutece/plugins/identitystore/v1/web/rs/DtoConverter.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 72
ConfusingTernary Avoid if (x != y) ..; else ..; 97110
CommentRequired Public method and constructor comments are required 113128

fr/paris/lutece/plugins/identitystore/v1/web/rs/IdentityRequestValidator.java

Rule Violation Line
NonThreadSafeSingleton Singleton is not thread safe 7080
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 76
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 93
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 118

fr/paris/lutece/plugins/identitystore/v1/web/rs/IdentityStoreRestService.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'ERROR_NO_IDENTITY_TO_UPDATE'. 61
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 9395
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 104
ShortVariable Avoid variables with short names like e 117

fr/paris/lutece/plugins/identitystore/v1/web/rs/swagger/Constants.java

Rule Violation Line
ShortVariable Avoid variables with short names like ID 47

fr/paris/lutece/plugins/identitystore/v1/web/rs/swagger/SwaggerRest.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 136
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 146
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 149

fr/paris/lutece/plugins/identitystore/v2/web/rs/DtoConverter.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 73

fr/paris/lutece/plugins/identitystore/v2/web/rs/IdentityRequestValidator.java

Rule Violation Line
NonThreadSafeSingleton Singleton is not thread safe 6979
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 75

fr/paris/lutece/plugins/identitystore/v2/web/rs/IdentityStoreRestService.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'ERROR_NO_IDENTITY_TO_UPDATE'. 61
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 9395
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 104

fr/paris/lutece/plugins/identitystore/v2/web/rs/swagger/Constants.java

Rule Violation Line
ShortVariable Avoid variables with short names like ID 47

fr/paris/lutece/plugins/identitystore/v2/web/rs/swagger/SwaggerRest.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 143
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 153
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 156

Priority 4

fr/paris/lutece/plugins/identitystore/v2/web/request/IdentityStoreGetRequest.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v2.web.rs.dto.IdentityDto' 41

Files

fr/paris/lutece/plugins/identitystore/v1/web/request/IdentityStoreGetRequest.java

Rule Violation Priority Line
FieldNamingConventions The final field name '_strConnectionId' doesn't match '[a-z][a-zA-Z0-9]*' 1 50
FieldNamingConventions The final field name '_strCustomerId' doesn't match '[a-z][a-zA-Z0-9]*' 1 51
FieldNamingConventions The final field name '_strClientAppCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 52
FieldNamingConventions The final field name '_objectMapper' doesn't match '[a-z][a-zA-Z0-9]*' 1 53

fr/paris/lutece/plugins/identitystore/v1/web/rs/DtoConverter.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'DtoConverter' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 49129
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 72
ConfusingTernary Avoid if (x != y) ..; else ..; 3 97110
CommentRequired Public method and constructor comments are required 3 113128

fr/paris/lutece/plugins/identitystore/v1/web/rs/IdentityRequestValidator.java

Rule Violation Priority Line
NonThreadSafeSingleton Singleton is not thread safe 3 7080
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 76
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 93
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 118

fr/paris/lutece/plugins/identitystore/v1/web/rs/IdentityStoreRestService.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'ERROR_NO_IDENTITY_TO_UPDATE'. 3 61
FieldNamingConventions The final field name '_objectMapper' doesn't match '[a-z][a-zA-Z0-9]*' 1 63
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 9395
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 104
ShortVariable Avoid variables with short names like e 3 117
GuardLogStatement Logger calls should be surrounded by log level guards. 2 123

fr/paris/lutece/plugins/identitystore/v1/web/rs/swagger/Constants.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 3957
ShortVariable Avoid variables with short names like ID 3 47

fr/paris/lutece/plugins/identitystore/v1/web/rs/swagger/SwaggerRest.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 136
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 146
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 149

fr/paris/lutece/plugins/identitystore/v2/web/request/IdentityStoreGetRequest.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.identitystore.v2.web.rs.dto.IdentityDto' 4 41
FieldNamingConventions The final field name '_strConnectionId' doesn't match '[a-z][a-zA-Z0-9]*' 1 52
FieldNamingConventions The final field name '_strCustomerId' doesn't match '[a-z][a-zA-Z0-9]*' 1 53
FieldNamingConventions The final field name '_strClientAppCode' doesn't match '[a-z][a-zA-Z0-9]*' 1 54
FieldNamingConventions The final field name '_objectMapper' doesn't match '[a-z][a-zA-Z0-9]*' 1 55

fr/paris/lutece/plugins/identitystore/v2/web/rs/DtoConverter.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'DtoConverter' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 49104
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 73

fr/paris/lutece/plugins/identitystore/v2/web/rs/IdentityRequestValidator.java

Rule Violation Priority Line
NonThreadSafeSingleton Singleton is not thread safe 3 6979
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 75

fr/paris/lutece/plugins/identitystore/v2/web/rs/IdentityStoreRestService.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'ERROR_NO_IDENTITY_TO_UPDATE'. 3 61
FieldNamingConventions The final field name '_objectMapper' doesn't match '[a-z][a-zA-Z0-9]*' 1 63
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 9395
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 104
GuardLogStatement Logger calls should be surrounded by log level guards. 2 123

fr/paris/lutece/plugins/identitystore/v2/web/rs/swagger/Constants.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 3987
ShortVariable Avoid variables with short names like ID 3 47

fr/paris/lutece/plugins/identitystore/v2/web/rs/swagger/SwaggerRest.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 143
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 153
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 156