Fork me on GitHub
Built by Maven

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/util/signrequest/AbstractJWTRSAAuthenticator.java

Rule Violation Line
FieldNamingConventions The final field name 'DEFAULT_ENC_ALGO_NAME' doesn't match '[a-z][a-zA-Z0-9]*' 47

fr/paris/lutece/util/signrequest/BasicAuthorizationAuthenticator.java

Rule Violation Line
FieldNamingConventions The final field name '_strUsername' doesn't match '[a-z][a-zA-Z0-9]*' 53
FieldNamingConventions The final field name '_strPassword' doesn't match '[a-z][a-zA-Z0-9]*' 54

fr/paris/lutece/util/signrequest/JWTRSAKeyStoreFileAuthenticator.java

Rule Violation Line
FieldNamingConventions The final field name '_strKeystorePath' doesn't match '[a-z][a-zA-Z0-9]*' 54
FieldNamingConventions The final field name '_strKeystorePassword' doesn't match '[a-z][a-zA-Z0-9]*' 55
FieldNamingConventions The final field name '_strCertificatePassword' doesn't match '[a-z][a-zA-Z0-9]*' 56
FieldNamingConventions The final field name '_strAlias' doesn't match '[a-z][a-zA-Z0-9]*' 57
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 112

fr/paris/lutece/util/signrequest/JWTRSATrustStoreFileAuthenticator.java

Rule Violation Line
FieldNamingConventions The final field name '_strCacertPath' doesn't match '[a-z][a-zA-Z0-9]*' 50
FieldNamingConventions The final field name '_strCacertPassword' doesn't match '[a-z][a-zA-Z0-9]*' 51
FieldNamingConventions The final field name '_strAlias' doesn't match '[a-z][a-zA-Z0-9]*' 52
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 86

fr/paris/lutece/util/signrequest/JWTSecretKeyAuthenticator.java

Rule Violation Line
FieldNamingConventions The final field name 'DEFAULT_ENC_ALGO_NAME' doesn't match '[a-z][a-zA-Z0-9]*' 48

fr/paris/lutece/util/signrequest/servlet/AbstractRequestFilter.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 127–129

Priority 2

fr/paris/lutece/util/signrequest/security/Sha1HashService.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 49

fr/paris/lutece/util/signrequest/security/Sha512HashService.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 49

Priority 3

fr/paris/lutece/util/signrequest/AbstractAuthenticator.java

Rule Violation Line
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 144

fr/paris/lutece/util/signrequest/AbstractJWTAuthenticator.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 66–71
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 87–90
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'expirationDate' 103

fr/paris/lutece/util/signrequest/AbstractJWTRSAAuthenticator.java

Rule Violation Line
CommentRequired Header comments are required 44–104
FinalFieldCouldBeStatic This final field could be made static 47

fr/paris/lutece/util/signrequest/AuthenticateRequestInformations.java

Rule Violation Line
ImmutableField Private field '_securityHeaders' could be made final; it is only initialized in the declaration or constructor. 13
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 13
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 13
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 16
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 16
ImmutableField Private field '_securityParameters' could be made final; it is only initialized in the declaration or constructor. 16

fr/paris/lutece/util/signrequest/ClientHeaderHashAuthenticator.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 104

fr/paris/lutece/util/signrequest/HeaderHashAuthenticator.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 74

fr/paris/lutece/util/signrequest/JWTNoEncryptionAuthenticator.java

Rule Violation Line
CommentRequired Header comments are required 43–77
UselessOverridingMethod Overriding method merely calls super 62–66

fr/paris/lutece/util/signrequest/JWTRSAKeyStoreFileAuthenticator.java

Rule Violation Line
CommentRequired Header comments are required 52–130
UselessOverridingMethod Overriding method merely calls super 63–72
ShortVariable Avoid variables with short names like is 112

fr/paris/lutece/util/signrequest/JWTRSAPlainTextAuthenticator.java

Rule Violation Line
CommentRequired Header comments are required 48–118
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strPlainTextPublicKey field if you want a default access modifier 50
DefaultPackage Use explicit scoping instead of the default package private level 50
DefaultPackage Use explicit scoping instead of the default package private level 51
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strPlainTextPrivateKey field if you want a default access modifier 51
ShortVariable Avoid variables with short names like kf 88

fr/paris/lutece/util/signrequest/JWTRSATrustStoreFileAuthenticator.java

Rule Violation Line
CommentRequired Header comments are required 48–114
ShortVariable Avoid variables with short names like is 86

fr/paris/lutece/util/signrequest/JWTSecretKeyAuthenticator.java

Rule Violation Line
CommentRequired Header comments are required 44–104
ImmutableField Private field '_strSecretKey' could be made final; it is only initialized in the declaration or constructor. 46
FinalFieldCouldBeStatic This final field could be made static 48

fr/paris/lutece/util/signrequest/RequestHashAuthenticator.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 75

fr/paris/lutece/util/signrequest/security/Sha1HashService.java

Rule Violation Line
ShortVariable Avoid variables with short names like sb 89
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 91–95
ShortVariable Avoid variables with short names like b 93

fr/paris/lutece/util/signrequest/security/Sha512HashService.java

Rule Violation Line
ShortVariable Avoid variables with short names like sb 89
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 91–95
ShortVariable Avoid variables with short names like b 93

fr/paris/lutece/util/signrequest/service/BasicClientKeyService.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 45
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 45

fr/paris/lutece/util/signrequest/servlet/AbstractRequestFilter.java

Rule Violation Line
ShortVariable Avoid variables with short names like st 92
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 93
UncommentedEmptyMethodBody Document empty method body 128–129

fr/paris/lutece/util/signrequest/servlet/HeaderHashRequestFilter.java

Rule Violation Line
MissingOverride The method 'getAuthenticator()' is missing an @Override annotation. 47–50

fr/paris/lutece/util/signrequest/servlet/ParameterHashRequestFilter.java

Rule Violation Line
MissingOverride The method 'getAuthenticator()' is missing an @Override annotation. 47–50

Priority 4

fr/paris/lutece/util/signrequest/RequestHashAuthenticator.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.util.Map' 39

Files

fr/paris/lutece/util/signrequest/AbstractAuthenticator.java

Rule Violation Priority Line
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 144

fr/paris/lutece/util/signrequest/AbstractJWTAuthenticator.java

Rule Violation Priority Line
CallSuperInConstructor It is a good practice to call super() in a constructor 3 66–71
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 87–90
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'expirationDate' 3 103

fr/paris/lutece/util/signrequest/AbstractJWTRSAAuthenticator.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 44–104
FieldNamingConventions The final field name 'DEFAULT_ENC_ALGO_NAME' doesn't match '[a-z][a-zA-Z0-9]*' 1 47
FinalFieldCouldBeStatic This final field could be made static 3 47

fr/paris/lutece/util/signrequest/AuthenticateRequestInformations.java

Rule Violation Priority Line
ImmutableField Private field '_securityHeaders' could be made final; it is only initialized in the declaration or constructor. 3 13
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 13
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 13
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 16
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 16
ImmutableField Private field '_securityParameters' could be made final; it is only initialized in the declaration or constructor. 3 16

fr/paris/lutece/util/signrequest/BasicAuthorizationAuthenticator.java

Rule Violation Priority Line
FieldNamingConventions The final field name '_strUsername' doesn't match '[a-z][a-zA-Z0-9]*' 1 53
FieldNamingConventions The final field name '_strPassword' doesn't match '[a-z][a-zA-Z0-9]*' 1 54

fr/paris/lutece/util/signrequest/ClientHeaderHashAuthenticator.java

Rule Violation Priority Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 104

fr/paris/lutece/util/signrequest/HeaderHashAuthenticator.java

Rule Violation Priority Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 74

fr/paris/lutece/util/signrequest/JWTNoEncryptionAuthenticator.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 43–77
UselessOverridingMethod Overriding method merely calls super 3 62–66

fr/paris/lutece/util/signrequest/JWTRSAKeyStoreFileAuthenticator.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 52–130
FieldNamingConventions The final field name '_strKeystorePath' doesn't match '[a-z][a-zA-Z0-9]*' 1 54
FieldNamingConventions The final field name '_strKeystorePassword' doesn't match '[a-z][a-zA-Z0-9]*' 1 55
FieldNamingConventions The final field name '_strCertificatePassword' doesn't match '[a-z][a-zA-Z0-9]*' 1 56
FieldNamingConventions The final field name '_strAlias' doesn't match '[a-z][a-zA-Z0-9]*' 1 57
UselessOverridingMethod Overriding method merely calls super 3 63–72
ShortVariable Avoid variables with short names like is 3 112
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 112

fr/paris/lutece/util/signrequest/JWTRSAPlainTextAuthenticator.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 48–118
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strPlainTextPublicKey field if you want a default access modifier 3 50
DefaultPackage Use explicit scoping instead of the default package private level 3 50
DefaultPackage Use explicit scoping instead of the default package private level 3 51
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _strPlainTextPrivateKey field if you want a default access modifier 3 51
ShortVariable Avoid variables with short names like kf 3 88

fr/paris/lutece/util/signrequest/JWTRSATrustStoreFileAuthenticator.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 48–114
FieldNamingConventions The final field name '_strCacertPath' doesn't match '[a-z][a-zA-Z0-9]*' 1 50
FieldNamingConventions The final field name '_strCacertPassword' doesn't match '[a-z][a-zA-Z0-9]*' 1 51
FieldNamingConventions The final field name '_strAlias' doesn't match '[a-z][a-zA-Z0-9]*' 1 52
ShortVariable Avoid variables with short names like is 3 86
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 86

fr/paris/lutece/util/signrequest/JWTSecretKeyAuthenticator.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 44–104
ImmutableField Private field '_strSecretKey' could be made final; it is only initialized in the declaration or constructor. 3 46
FinalFieldCouldBeStatic This final field could be made static 3 48
FieldNamingConventions The final field name 'DEFAULT_ENC_ALGO_NAME' doesn't match '[a-z][a-zA-Z0-9]*' 1 48

fr/paris/lutece/util/signrequest/RequestHashAuthenticator.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.util.Map' 4 39
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 75

fr/paris/lutece/util/signrequest/security/Sha1HashService.java

Rule Violation Priority Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 49
ShortVariable Avoid variables with short names like sb 3 89
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 91–95
ShortVariable Avoid variables with short names like b 3 93

fr/paris/lutece/util/signrequest/security/Sha512HashService.java

Rule Violation Priority Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 49
ShortVariable Avoid variables with short names like sb 3 89
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 91–95
ShortVariable Avoid variables with short names like b 3 93

fr/paris/lutece/util/signrequest/service/BasicClientKeyService.java

Rule Violation Priority Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 45
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 45

fr/paris/lutece/util/signrequest/servlet/AbstractRequestFilter.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like st 3 92
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 93
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 127–129
UncommentedEmptyMethodBody Document empty method body 3 128–129

fr/paris/lutece/util/signrequest/servlet/HeaderHashRequestFilter.java

Rule Violation Priority Line
MissingOverride The method 'getAuthenticator()' is missing an @Override annotation. 3 47–50

fr/paris/lutece/util/signrequest/servlet/ParameterHashRequestFilter.java

Rule Violation Priority Line
MissingOverride The method 'getAuthenticator()' is missing an @Override annotation. 3 47–50