Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/workflowcore/service/action/ActionStateService.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_strUidAction' doesn't match '[a-z][a-zA-Z0-9]*' 52

fr/paris/lutece/plugins/workflowcore/service/action/IActionStateService.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_strUidAction' doesn't match '[a-z][a-zA-Z0-9]*' 52

fr/paris/lutece/plugins/workflowcore/service/provider/AbstractProviderManager.java

Rule Violation Line
FieldNamingConventions The final field name '_strId' doesn't match '[a-z][a-zA-Z0-9]*' 49

fr/paris/lutece/plugins/workflowcore/service/provider/ProviderDescription.java

Rule Violation Line
FieldNamingConventions The final field name '_strId' doesn't match '[a-z][a-zA-Z0-9]*' 47
FieldNamingConventions The final field name '_strLabel' doesn't match '[a-z][a-zA-Z0-9]*' 49

fr/paris/lutece/plugins/workflowcore/service/task/SimpleTask.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 5052
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 5861
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 6769
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 7577

fr/paris/lutece/plugins/workflowcore/web/task/SimpleTaskComponent.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 5760
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 6669
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 7578
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 8487

Priority 2

fr/paris/lutece/plugins/workflowcore/service/config/TaskConfigService.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 51

fr/paris/lutece/plugins/workflowcore/web/task/TaskComponent.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 64

Priority 3

fr/paris/lutece/plugins/workflowcore/business/action/Action.java

Rule Violation Line
TooManyFields Too many fields 53499
MissingOverride The method 'getId()' is missing an @Override annotation. 9093
MissingOverride The method 'getName()' is missing an @Override annotation. 132135
MissingOverride The method 'getResourceTypeCode()' is missing an @Override annotation. 242245
MissingOverride The method 'getResourceId()' is missing an @Override annotation. 253256

fr/paris/lutece/plugins/workflowcore/business/action/ActionFilter.java

Rule Violation Line
LinguisticNaming Linguistics Antipattern - The method 'isAutomaticReflexiveAction' indicates linguistically it returns a boolean, but it returns 'int' 244247

fr/paris/lutece/plugins/workflowcore/business/action/IActionDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 43221

fr/paris/lutece/plugins/workflowcore/business/action/IActionStateDAO.java

Rule Violation Line
CommentRequired Header comments are required 542

fr/paris/lutece/plugins/workflowcore/business/icon/Icon.java

Rule Violation Line
MissingOverride The method 'getId()' is missing an @Override annotation. 5659
MissingOverride The method 'getName()' is missing an @Override annotation. 7780
MethodReturnsInternalArray Returning '_byValue' may expose an internal array. 100
ArrayIsStoredDirectly The user-supplied array 'value' is stored directly. 109

fr/paris/lutece/plugins/workflowcore/business/resource/IResourceHistoryDAO.java

Rule Violation Line
AvoidDuplicateLiterals The String literal "Not supported yet." appears 4 times in this file; the first occurrence is on line 127 127

fr/paris/lutece/plugins/workflowcore/business/resource/IResourceWorkflowDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 47226

fr/paris/lutece/plugins/workflowcore/business/resource/ResourceUserHistory.java

Rule Violation Line
UncommentedEmptyConstructor Document empty constructor 5659

fr/paris/lutece/plugins/workflowcore/business/state/IStateDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 44151

fr/paris/lutece/plugins/workflowcore/business/state/State.java

Rule Violation Line
MissingOverride The method 'getId()' is missing an @Override annotation. 7679
MissingOverride The method 'getName()' is missing an @Override annotation. 142145
MissingOverride The method 'getResourceTypeCode()' is missing an @Override annotation. 248251
MissingOverride The method 'getResourceId()' is missing an @Override annotation. 258261

fr/paris/lutece/plugins/workflowcore/business/workflow/Workflow.java

Rule Violation Line
MissingOverride The method 'getId()' is missing an @Override annotation. 8285
MissingOverride The method 'getName()' is missing an @Override annotation. 127130
MissingOverride The method 'getWorkgroup()' is missing an @Override annotation. 214217

fr/paris/lutece/plugins/workflowcore/business/workflow/WorkflowFilter.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for '_strName' 51
CommentRequired Public method and constructor comments are required 5356
CommentRequired Public method and constructor comments are required 5861
CommentRequired Public method and constructor comments are required 121125

fr/paris/lutece/plugins/workflowcore/exception/WorkflowRuntimeException.java

Rule Violation Line
CommentRequired Header comments are required 3645
CommentRequired Public method and constructor comments are required 4144
ShortVariable Avoid variables with short names like e 41

fr/paris/lutece/plugins/workflowcore/service/action/ActionService.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 57296
ConfusingTernary Avoid if (x != y) ..; else ..; 90

fr/paris/lutece/plugins/workflowcore/service/action/ActionStateService.java

Rule Violation Line
CommentRequired Header comments are required 855

fr/paris/lutece/plugins/workflowcore/service/action/IActionService.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 48226

fr/paris/lutece/plugins/workflowcore/service/action/IActionStateService.java

Rule Violation Line
CommentRequired Header comments are required 554
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'BEAN_SERVICE': the field is declared in an interface type 7

fr/paris/lutece/plugins/workflowcore/service/config/ITaskConfigService.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 69

fr/paris/lutece/plugins/workflowcore/service/config/TaskConfigService.java

Rule Violation Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 124

fr/paris/lutece/plugins/workflowcore/service/prerequisite/IPrerequisiteManagementService.java

Rule Violation Line
UncommentedEmptyMethodBody Document empty method body 103104
UncommentedEmptyMethodBody Document empty method body 115116
UncommentedEmptyMethodBody Document empty method body 125126
UncommentedEmptyMethodBody Document empty method body 135136
UncommentedEmptyMethodBody Document empty method body 145146
UncommentedEmptyMethodBody Document empty method body 155156
UncommentedEmptyMethodBody Document empty method body 167168

fr/paris/lutece/plugins/workflowcore/service/provider/InfoMarker.java

Rule Violation Line
ImmutableField Private field '_strMarker' could be made final; it is only initialized in the declaration or constructor. 52

fr/paris/lutece/plugins/workflowcore/service/resource/IResourceHistoryService.java

Rule Violation Line
AvoidDuplicateLiterals The String literal "Not supported yet." appears 4 times in this file; the first occurrence is on line 144 144

fr/paris/lutece/plugins/workflowcore/service/task/AsynchronousSimpleTask.java

Rule Violation Line
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 61

fr/paris/lutece/plugins/workflowcore/service/task/ITask.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getActionUid': the method is declared in an interface type 88
UnnecessaryModifier Unnecessary modifier 'public' on method 'setActionUid': the method is declared in an interface type 94

fr/paris/lutece/plugins/workflowcore/service/task/SimpleTask.java

Rule Violation Line
UncommentedEmptyMethodBody Document empty method body 5152
UncommentedEmptyMethodBody Document empty method body 6869
UncommentedEmptyMethodBody Document empty method body 7677

fr/paris/lutece/plugins/workflowcore/service/task/Task.java

Rule Violation Line
MissingOverride The method 'getId()' is missing an @Override annotation. 6467
MissingOverride The method 'setId(int)' is missing an @Override annotation. 7376
MissingOverride The method 'getAction()' is missing an @Override annotation. 118121
MissingOverride The method 'setAction(Action)' is missing an @Override annotation. 127130
MissingOverride The method 'getOrder()' is missing an @Override annotation. 137140
MissingOverride The method 'setOrder(int)' is missing an @Override annotation. 148151

fr/paris/lutece/plugins/workflowcore/service/workflow/IWorkflowService.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 54406

fr/paris/lutece/plugins/workflowcore/service/workflow/WorkflowService.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34784
TooManyMethods This class has too many methods, consider refactoring it. 80784
ConfusingTernary Avoid if (x != y) ..; else ..; 186203
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 223
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 249
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 365
CyclomaticComplexity The method 'doProcessAction(int, String, int, Integer, HttpServletRequest, Locale, boolean, String, User)' has a cyclomatic complexity of 17. 457556
NPathComplexity The method 'doProcessAction(int, String, int, Integer, HttpServletRequest, Locale, boolean, String, User)' has an NPath complexity of 1152 457556
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 502

fr/paris/lutece/plugins/workflowcore/web/task/TaskComponent.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 102138

Priority 4

fr/paris/lutece/plugins/workflowcore/business/icon/Icon.java

Rule Violation Line
ShortClassName Avoid short class names like Icon 43168

fr/paris/lutece/plugins/workflowcore/business/resource/IResourceWorkflowDAO.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.business.state.State' 39

fr/paris/lutece/plugins/workflowcore/service/task/Task.java

Rule Violation Line
ShortClassName Avoid short class names like Task 49170

Files

fr/paris/lutece/plugins/workflowcore/business/action/Action.java

Rule Violation Priority Line
TooManyFields Too many fields 3 53499
MissingOverride The method 'getId()' is missing an @Override annotation. 3 9093
MissingOverride The method 'getName()' is missing an @Override annotation. 3 132135
MissingOverride The method 'getResourceTypeCode()' is missing an @Override annotation. 3 242245
MissingOverride The method 'getResourceId()' is missing an @Override annotation. 3 253256

fr/paris/lutece/plugins/workflowcore/business/action/ActionFilter.java

Rule Violation Priority Line
LinguisticNaming Linguistics Antipattern - The method 'isAutomaticReflexiveAction' indicates linguistically it returns a boolean, but it returns 'int' 3 244247

fr/paris/lutece/plugins/workflowcore/business/action/IActionDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 43221

fr/paris/lutece/plugins/workflowcore/business/action/IActionStateDAO.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 542

fr/paris/lutece/plugins/workflowcore/business/icon/Icon.java

Rule Violation Priority Line
ShortClassName Avoid short class names like Icon 4 43168
MissingOverride The method 'getId()' is missing an @Override annotation. 3 5659
MissingOverride The method 'getName()' is missing an @Override annotation. 3 7780
MethodReturnsInternalArray Returning '_byValue' may expose an internal array. 3 100
ArrayIsStoredDirectly The user-supplied array 'value' is stored directly. 3 109

fr/paris/lutece/plugins/workflowcore/business/resource/IResourceHistoryDAO.java

Rule Violation Priority Line
AvoidDuplicateLiterals The String literal "Not supported yet." appears 4 times in this file; the first occurrence is on line 127 3 127

fr/paris/lutece/plugins/workflowcore/business/resource/IResourceWorkflowDAO.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.business.state.State' 4 39
TooManyMethods This class has too many methods, consider refactoring it. 3 47226

fr/paris/lutece/plugins/workflowcore/business/resource/ResourceUserHistory.java

Rule Violation Priority Line
UncommentedEmptyConstructor Document empty constructor 3 5659

fr/paris/lutece/plugins/workflowcore/business/state/IStateDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 44151

fr/paris/lutece/plugins/workflowcore/business/state/State.java

Rule Violation Priority Line
MissingOverride The method 'getId()' is missing an @Override annotation. 3 7679
MissingOverride The method 'getName()' is missing an @Override annotation. 3 142145
MissingOverride The method 'getResourceTypeCode()' is missing an @Override annotation. 3 248251
MissingOverride The method 'getResourceId()' is missing an @Override annotation. 3 258261

fr/paris/lutece/plugins/workflowcore/business/workflow/Workflow.java

Rule Violation Priority Line
MissingOverride The method 'getId()' is missing an @Override annotation. 3 8285
MissingOverride The method 'getName()' is missing an @Override annotation. 3 127130
MissingOverride The method 'getWorkgroup()' is missing an @Override annotation. 3 214217

fr/paris/lutece/plugins/workflowcore/business/workflow/WorkflowFilter.java

Rule Violation Priority Line
RedundantFieldInitializer Avoid using redundant field initializer for '_strName' 3 51
CommentRequired Public method and constructor comments are required 3 5356
CommentRequired Public method and constructor comments are required 3 5861
CommentRequired Public method and constructor comments are required 3 121125

fr/paris/lutece/plugins/workflowcore/exception/WorkflowRuntimeException.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3645
CommentRequired Public method and constructor comments are required 3 4144
ShortVariable Avoid variables with short names like e 3 41

fr/paris/lutece/plugins/workflowcore/service/action/ActionService.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 57296
ConfusingTernary Avoid if (x != y) ..; else ..; 3 90

fr/paris/lutece/plugins/workflowcore/service/action/ActionStateService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 855
FormalParameterNamingConventions The method parameter name '_strUidAction' doesn't match '[a-z][a-zA-Z0-9]*' 1 52

fr/paris/lutece/plugins/workflowcore/service/action/IActionService.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 48226

fr/paris/lutece/plugins/workflowcore/service/action/IActionStateService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 554
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'BEAN_SERVICE': the field is declared in an interface type 3 7
FormalParameterNamingConventions The method parameter name '_strUidAction' doesn't match '[a-z][a-zA-Z0-9]*' 1 52

fr/paris/lutece/plugins/workflowcore/service/config/ITaskConfigService.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 69

fr/paris/lutece/plugins/workflowcore/service/config/TaskConfigService.java

Rule Violation Priority Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 51
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 124

fr/paris/lutece/plugins/workflowcore/service/prerequisite/IPrerequisiteManagementService.java

Rule Violation Priority Line
UncommentedEmptyMethodBody Document empty method body 3 103104
UncommentedEmptyMethodBody Document empty method body 3 115116
UncommentedEmptyMethodBody Document empty method body 3 125126
UncommentedEmptyMethodBody Document empty method body 3 135136
UncommentedEmptyMethodBody Document empty method body 3 145146
UncommentedEmptyMethodBody Document empty method body 3 155156
UncommentedEmptyMethodBody Document empty method body 3 167168

fr/paris/lutece/plugins/workflowcore/service/provider/AbstractProviderManager.java

Rule Violation Priority Line
FieldNamingConventions The final field name '_strId' doesn't match '[a-z][a-zA-Z0-9]*' 1 49

fr/paris/lutece/plugins/workflowcore/service/provider/InfoMarker.java

Rule Violation Priority Line
ImmutableField Private field '_strMarker' could be made final; it is only initialized in the declaration or constructor. 3 52

fr/paris/lutece/plugins/workflowcore/service/provider/ProviderDescription.java

Rule Violation Priority Line
FieldNamingConventions The final field name '_strId' doesn't match '[a-z][a-zA-Z0-9]*' 1 47
FieldNamingConventions The final field name '_strLabel' doesn't match '[a-z][a-zA-Z0-9]*' 1 49

fr/paris/lutece/plugins/workflowcore/service/resource/IResourceHistoryService.java

Rule Violation Priority Line
AvoidDuplicateLiterals The String literal "Not supported yet." appears 4 times in this file; the first occurrence is on line 144 3 144

fr/paris/lutece/plugins/workflowcore/service/task/AsynchronousSimpleTask.java

Rule Violation Priority Line
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 61

fr/paris/lutece/plugins/workflowcore/service/task/ITask.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getActionUid': the method is declared in an interface type 3 88
UnnecessaryModifier Unnecessary modifier 'public' on method 'setActionUid': the method is declared in an interface type 3 94

fr/paris/lutece/plugins/workflowcore/service/task/SimpleTask.java

Rule Violation Priority Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 5052
UncommentedEmptyMethodBody Document empty method body 3 5152
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 5861
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 6769
UncommentedEmptyMethodBody Document empty method body 3 6869
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 7577
UncommentedEmptyMethodBody Document empty method body 3 7677

fr/paris/lutece/plugins/workflowcore/service/task/Task.java

Rule Violation Priority Line
ShortClassName Avoid short class names like Task 4 49170
MissingOverride The method 'getId()' is missing an @Override annotation. 3 6467
MissingOverride The method 'setId(int)' is missing an @Override annotation. 3 7376
MissingOverride The method 'getAction()' is missing an @Override annotation. 3 118121
MissingOverride The method 'setAction(Action)' is missing an @Override annotation. 3 127130
MissingOverride The method 'getOrder()' is missing an @Override annotation. 3 137140
MissingOverride The method 'setOrder(int)' is missing an @Override annotation. 3 148151

fr/paris/lutece/plugins/workflowcore/service/workflow/IWorkflowService.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 54406

fr/paris/lutece/plugins/workflowcore/service/workflow/WorkflowService.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34784
TooManyMethods This class has too many methods, consider refactoring it. 3 80784
ConfusingTernary Avoid if (x != y) ..; else ..; 3 186203
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 223
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 249
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 365
CyclomaticComplexity The method 'doProcessAction(int, String, int, Integer, HttpServletRequest, Locale, boolean, String, User)' has a cyclomatic complexity of 17. 3 457556
NPathComplexity The method 'doProcessAction(int, String, int, Integer, HttpServletRequest, Locale, boolean, String, User)' has an NPath complexity of 1152 3 457556
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 502

fr/paris/lutece/plugins/workflowcore/web/task/SimpleTaskComponent.java

Rule Violation Priority Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 5760
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 6669
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 7578
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 8487

fr/paris/lutece/plugins/workflowcore/web/task/TaskComponent.java

Rule Violation Priority Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 64
ConfusingTernary Avoid if (x != y) ..; else ..; 3 102138