Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/workflowcore/service/action/ActionStateService.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_strUidAction' doesn't match '[a-z][a-zA-Z0-9]*' 52

fr/paris/lutece/plugins/workflowcore/service/action/IActionStateService.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_strUidAction' doesn't match '[a-z][a-zA-Z0-9]*' 52

fr/paris/lutece/plugins/workflowcore/service/provider/AbstractProviderManager.java

Rule Violation Line
FieldNamingConventions The final field name '_strId' doesn't match '[a-z][a-zA-Z0-9]*' 49

fr/paris/lutece/plugins/workflowcore/service/provider/ProviderDescription.java

Rule Violation Line
FieldNamingConventions The final field name '_strId' doesn't match '[a-z][a-zA-Z0-9]*' 47
FieldNamingConventions The final field name '_strLabel' doesn't match '[a-z][a-zA-Z0-9]*' 49

fr/paris/lutece/plugins/workflowcore/service/task/SimpleTask.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 50–52
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 58–61
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 67–69
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 75–77

fr/paris/lutece/plugins/workflowcore/web/task/SimpleTaskComponent.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 57–60
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 66–69
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 75–78
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 84–87

Priority 2

fr/paris/lutece/plugins/workflowcore/service/config/TaskConfigService.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 51

fr/paris/lutece/plugins/workflowcore/web/task/TaskComponent.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 64

Priority 3

fr/paris/lutece/plugins/workflowcore/business/action/Action.java

Rule Violation Line
TooManyFields Too many fields 53–499
MissingOverride The method 'getId()' is missing an @Override annotation. 90–93
MissingOverride The method 'getName()' is missing an @Override annotation. 132–135
MissingOverride The method 'getResourceTypeCode()' is missing an @Override annotation. 242–245
MissingOverride The method 'getResourceId()' is missing an @Override annotation. 253–256

fr/paris/lutece/plugins/workflowcore/business/action/ActionFilter.java

Rule Violation Line
LinguisticNaming Linguistics Antipattern - The method 'isAutomaticReflexiveAction' indicates linguistically it returns a boolean, but it returns 'int' 244–247

fr/paris/lutece/plugins/workflowcore/business/action/IActionDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 43–221

fr/paris/lutece/plugins/workflowcore/business/action/IActionStateDAO.java

Rule Violation Line
CommentRequired Header comments are required 5–42

fr/paris/lutece/plugins/workflowcore/business/icon/Icon.java

Rule Violation Line
MissingOverride The method 'getId()' is missing an @Override annotation. 56–59
MissingOverride The method 'getName()' is missing an @Override annotation. 77–80
MethodReturnsInternalArray Returning '_byValue' may expose an internal array. 100
ArrayIsStoredDirectly The user-supplied array 'value' is stored directly. 109

fr/paris/lutece/plugins/workflowcore/business/resource/IResourceHistoryDAO.java

Rule Violation Line
AvoidDuplicateLiterals The String literal "Not supported yet." appears 4 times in this file; the first occurrence is on line 127 127

fr/paris/lutece/plugins/workflowcore/business/resource/IResourceWorkflowDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 47–226

fr/paris/lutece/plugins/workflowcore/business/resource/ResourceUserHistory.java

Rule Violation Line
UncommentedEmptyConstructor Document empty constructor 56–59

fr/paris/lutece/plugins/workflowcore/business/state/IStateDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 44–151

fr/paris/lutece/plugins/workflowcore/business/state/State.java

Rule Violation Line
MissingOverride The method 'getId()' is missing an @Override annotation. 76–79
MissingOverride The method 'getName()' is missing an @Override annotation. 142–145
MissingOverride The method 'getResourceTypeCode()' is missing an @Override annotation. 248–251
MissingOverride The method 'getResourceId()' is missing an @Override annotation. 258–261

fr/paris/lutece/plugins/workflowcore/business/workflow/Workflow.java

Rule Violation Line
MissingOverride The method 'getId()' is missing an @Override annotation. 82–85
MissingOverride The method 'getName()' is missing an @Override annotation. 127–130
MissingOverride The method 'getWorkgroup()' is missing an @Override annotation. 214–217

fr/paris/lutece/plugins/workflowcore/business/workflow/WorkflowFilter.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for '_strName' 51
CommentRequired Public method and constructor comments are required 53–56
CommentRequired Public method and constructor comments are required 58–61
CommentRequired Public method and constructor comments are required 121–125

fr/paris/lutece/plugins/workflowcore/exception/WorkflowRuntimeException.java

Rule Violation Line
CommentRequired Header comments are required 36–45
CommentRequired Public method and constructor comments are required 41–44
ShortVariable Avoid variables with short names like e 41

fr/paris/lutece/plugins/workflowcore/service/action/ActionService.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 57–298
ConfusingTernary Avoid if (x != y) ..; else ..; 90

fr/paris/lutece/plugins/workflowcore/service/action/ActionStateService.java

Rule Violation Line
CommentRequired Header comments are required 8–55

fr/paris/lutece/plugins/workflowcore/service/action/IActionService.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 48–226

fr/paris/lutece/plugins/workflowcore/service/action/IActionStateService.java

Rule Violation Line
CommentRequired Header comments are required 5–54
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'BEAN_SERVICE': the field is declared in an interface type 7

fr/paris/lutece/plugins/workflowcore/service/config/ITaskConfigService.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 69

fr/paris/lutece/plugins/workflowcore/service/config/TaskConfigService.java

Rule Violation Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 124

fr/paris/lutece/plugins/workflowcore/service/prerequisite/IPrerequisiteManagementService.java

Rule Violation Line
UncommentedEmptyMethodBody Document empty method body 103–104
UncommentedEmptyMethodBody Document empty method body 115–116
UncommentedEmptyMethodBody Document empty method body 125–126
UncommentedEmptyMethodBody Document empty method body 135–136
UncommentedEmptyMethodBody Document empty method body 145–146
UncommentedEmptyMethodBody Document empty method body 155–156
UncommentedEmptyMethodBody Document empty method body 167–168

fr/paris/lutece/plugins/workflowcore/service/provider/InfoMarker.java

Rule Violation Line
ImmutableField Private field '_strMarker' could be made final; it is only initialized in the declaration or constructor. 52

fr/paris/lutece/plugins/workflowcore/service/resource/IResourceHistoryService.java

Rule Violation Line
AvoidDuplicateLiterals The String literal "Not supported yet." appears 4 times in this file; the first occurrence is on line 144 144

fr/paris/lutece/plugins/workflowcore/service/task/AsynchronousSimpleTask.java

Rule Violation Line
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 61

fr/paris/lutece/plugins/workflowcore/service/task/ITask.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getActionUid': the method is declared in an interface type 88
UnnecessaryModifier Unnecessary modifier 'public' on method 'setActionUid': the method is declared in an interface type 94

fr/paris/lutece/plugins/workflowcore/service/task/SimpleTask.java

Rule Violation Line
UncommentedEmptyMethodBody Document empty method body 51–52
UncommentedEmptyMethodBody Document empty method body 68–69
UncommentedEmptyMethodBody Document empty method body 76–77

fr/paris/lutece/plugins/workflowcore/service/task/Task.java

Rule Violation Line
MissingOverride The method 'getId()' is missing an @Override annotation. 64–67
MissingOverride The method 'setId(int)' is missing an @Override annotation. 73–76
MissingOverride The method 'getAction()' is missing an @Override annotation. 118–121
MissingOverride The method 'setAction(Action)' is missing an @Override annotation. 127–130
MissingOverride The method 'getOrder()' is missing an @Override annotation. 137–140
MissingOverride The method 'setOrder(int)' is missing an @Override annotation. 148–151

fr/paris/lutece/plugins/workflowcore/service/workflow/IWorkflowService.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 54–406

fr/paris/lutece/plugins/workflowcore/service/workflow/WorkflowService.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–784
TooManyMethods This class has too many methods, consider refactoring it. 80–784
ConfusingTernary Avoid if (x != y) ..; else ..; 186–203
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 223
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 249
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 365
NPathComplexity The method 'doProcessAction(int, String, int, Integer, HttpServletRequest, Locale, boolean, String, User)' has an NPath complexity of 1152 457–556
CyclomaticComplexity The method 'doProcessAction(int, String, int, Integer, HttpServletRequest, Locale, boolean, String, User)' has a cyclomatic complexity of 17. 457–556
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 502

fr/paris/lutece/plugins/workflowcore/web/task/TaskComponent.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 102–138

Priority 4

fr/paris/lutece/plugins/workflowcore/business/icon/Icon.java

Rule Violation Line
ShortClassName Avoid short class names like Icon 43–168

fr/paris/lutece/plugins/workflowcore/business/resource/IResourceWorkflowDAO.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.business.state.State' 39

fr/paris/lutece/plugins/workflowcore/service/task/Task.java

Rule Violation Line
ShortClassName Avoid short class names like Task 49–170

Files

fr/paris/lutece/plugins/workflowcore/business/action/Action.java

Rule Violation Priority Line
TooManyFields Too many fields 3 53–499
MissingOverride The method 'getId()' is missing an @Override annotation. 3 90–93
MissingOverride The method 'getName()' is missing an @Override annotation. 3 132–135
MissingOverride The method 'getResourceTypeCode()' is missing an @Override annotation. 3 242–245
MissingOverride The method 'getResourceId()' is missing an @Override annotation. 3 253–256

fr/paris/lutece/plugins/workflowcore/business/action/ActionFilter.java

Rule Violation Priority Line
LinguisticNaming Linguistics Antipattern - The method 'isAutomaticReflexiveAction' indicates linguistically it returns a boolean, but it returns 'int' 3 244–247

fr/paris/lutece/plugins/workflowcore/business/action/IActionDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 43–221

fr/paris/lutece/plugins/workflowcore/business/action/IActionStateDAO.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 5–42

fr/paris/lutece/plugins/workflowcore/business/icon/Icon.java

Rule Violation Priority Line
ShortClassName Avoid short class names like Icon 4 43–168
MissingOverride The method 'getId()' is missing an @Override annotation. 3 56–59
MissingOverride The method 'getName()' is missing an @Override annotation. 3 77–80
MethodReturnsInternalArray Returning '_byValue' may expose an internal array. 3 100
ArrayIsStoredDirectly The user-supplied array 'value' is stored directly. 3 109

fr/paris/lutece/plugins/workflowcore/business/resource/IResourceHistoryDAO.java

Rule Violation Priority Line
AvoidDuplicateLiterals The String literal "Not supported yet." appears 4 times in this file; the first occurrence is on line 127 3 127

fr/paris/lutece/plugins/workflowcore/business/resource/IResourceWorkflowDAO.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.business.state.State' 4 39
TooManyMethods This class has too many methods, consider refactoring it. 3 47–226

fr/paris/lutece/plugins/workflowcore/business/resource/ResourceUserHistory.java

Rule Violation Priority Line
UncommentedEmptyConstructor Document empty constructor 3 56–59

fr/paris/lutece/plugins/workflowcore/business/state/IStateDAO.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 44–151

fr/paris/lutece/plugins/workflowcore/business/state/State.java

Rule Violation Priority Line
MissingOverride The method 'getId()' is missing an @Override annotation. 3 76–79
MissingOverride The method 'getName()' is missing an @Override annotation. 3 142–145
MissingOverride The method 'getResourceTypeCode()' is missing an @Override annotation. 3 248–251
MissingOverride The method 'getResourceId()' is missing an @Override annotation. 3 258–261

fr/paris/lutece/plugins/workflowcore/business/workflow/Workflow.java

Rule Violation Priority Line
MissingOverride The method 'getId()' is missing an @Override annotation. 3 82–85
MissingOverride The method 'getName()' is missing an @Override annotation. 3 127–130
MissingOverride The method 'getWorkgroup()' is missing an @Override annotation. 3 214–217

fr/paris/lutece/plugins/workflowcore/business/workflow/WorkflowFilter.java

Rule Violation Priority Line
RedundantFieldInitializer Avoid using redundant field initializer for '_strName' 3 51
CommentRequired Public method and constructor comments are required 3 53–56
CommentRequired Public method and constructor comments are required 3 58–61
CommentRequired Public method and constructor comments are required 3 121–125

fr/paris/lutece/plugins/workflowcore/exception/WorkflowRuntimeException.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 36–45
CommentRequired Public method and constructor comments are required 3 41–44
ShortVariable Avoid variables with short names like e 3 41

fr/paris/lutece/plugins/workflowcore/service/action/ActionService.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 57–298
ConfusingTernary Avoid if (x != y) ..; else ..; 3 90

fr/paris/lutece/plugins/workflowcore/service/action/ActionStateService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 8–55
FormalParameterNamingConventions The method parameter name '_strUidAction' doesn't match '[a-z][a-zA-Z0-9]*' 1 52

fr/paris/lutece/plugins/workflowcore/service/action/IActionService.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 48–226

fr/paris/lutece/plugins/workflowcore/service/action/IActionStateService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 5–54
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'BEAN_SERVICE': the field is declared in an interface type 3 7
FormalParameterNamingConventions The method parameter name '_strUidAction' doesn't match '[a-z][a-zA-Z0-9]*' 1 52

fr/paris/lutece/plugins/workflowcore/service/config/ITaskConfigService.java

Rule Violation Priority Line
CommentRequired Public method and constructor comments are required 3 69

fr/paris/lutece/plugins/workflowcore/service/config/TaskConfigService.java

Rule Violation Priority Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 51
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 124

fr/paris/lutece/plugins/workflowcore/service/prerequisite/IPrerequisiteManagementService.java

Rule Violation Priority Line
UncommentedEmptyMethodBody Document empty method body 3 103–104
UncommentedEmptyMethodBody Document empty method body 3 115–116
UncommentedEmptyMethodBody Document empty method body 3 125–126
UncommentedEmptyMethodBody Document empty method body 3 135–136
UncommentedEmptyMethodBody Document empty method body 3 145–146
UncommentedEmptyMethodBody Document empty method body 3 155–156
UncommentedEmptyMethodBody Document empty method body 3 167–168

fr/paris/lutece/plugins/workflowcore/service/provider/AbstractProviderManager.java

Rule Violation Priority Line
FieldNamingConventions The final field name '_strId' doesn't match '[a-z][a-zA-Z0-9]*' 1 49

fr/paris/lutece/plugins/workflowcore/service/provider/InfoMarker.java

Rule Violation Priority Line
ImmutableField Private field '_strMarker' could be made final; it is only initialized in the declaration or constructor. 3 52

fr/paris/lutece/plugins/workflowcore/service/provider/ProviderDescription.java

Rule Violation Priority Line
FieldNamingConventions The final field name '_strId' doesn't match '[a-z][a-zA-Z0-9]*' 1 47
FieldNamingConventions The final field name '_strLabel' doesn't match '[a-z][a-zA-Z0-9]*' 1 49

fr/paris/lutece/plugins/workflowcore/service/resource/IResourceHistoryService.java

Rule Violation Priority Line
AvoidDuplicateLiterals The String literal "Not supported yet." appears 4 times in this file; the first occurrence is on line 144 3 144

fr/paris/lutece/plugins/workflowcore/service/task/AsynchronousSimpleTask.java

Rule Violation Priority Line
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 61

fr/paris/lutece/plugins/workflowcore/service/task/ITask.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getActionUid': the method is declared in an interface type 3 88
UnnecessaryModifier Unnecessary modifier 'public' on method 'setActionUid': the method is declared in an interface type 3 94

fr/paris/lutece/plugins/workflowcore/service/task/SimpleTask.java

Rule Violation Priority Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 50–52
UncommentedEmptyMethodBody Document empty method body 3 51–52
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 58–61
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 67–69
UncommentedEmptyMethodBody Document empty method body 3 68–69
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 75–77
UncommentedEmptyMethodBody Document empty method body 3 76–77

fr/paris/lutece/plugins/workflowcore/service/task/Task.java

Rule Violation Priority Line
ShortClassName Avoid short class names like Task 4 49–170
MissingOverride The method 'getId()' is missing an @Override annotation. 3 64–67
MissingOverride The method 'setId(int)' is missing an @Override annotation. 3 73–76
MissingOverride The method 'getAction()' is missing an @Override annotation. 3 118–121
MissingOverride The method 'setAction(Action)' is missing an @Override annotation. 3 127–130
MissingOverride The method 'getOrder()' is missing an @Override annotation. 3 137–140
MissingOverride The method 'setOrder(int)' is missing an @Override annotation. 3 148–151

fr/paris/lutece/plugins/workflowcore/service/workflow/IWorkflowService.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 54–406

fr/paris/lutece/plugins/workflowcore/service/workflow/WorkflowService.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–784
TooManyMethods This class has too many methods, consider refactoring it. 3 80–784
ConfusingTernary Avoid if (x != y) ..; else ..; 3 186–203
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 223
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 249
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 365
NPathComplexity The method 'doProcessAction(int, String, int, Integer, HttpServletRequest, Locale, boolean, String, User)' has an NPath complexity of 1152 3 457–556
CyclomaticComplexity The method 'doProcessAction(int, String, int, Integer, HttpServletRequest, Locale, boolean, String, User)' has a cyclomatic complexity of 17. 3 457–556
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 502

fr/paris/lutece/plugins/workflowcore/web/task/SimpleTaskComponent.java

Rule Violation Priority Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 57–60
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 66–69
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 75–78
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 84–87

fr/paris/lutece/plugins/workflowcore/web/task/TaskComponent.java

Rule Violation Priority Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 64
ConfusingTernary Avoid if (x != y) ..; else ..; 3 102–138