PMD Results
The following document contains the results of PMD 5.5.1.
Files
fr/paris/lutece/plugins/module/announce/subscribe/business/AnnounceSubscribtionDAO.java
| Violation |
Line |
| The class 'AnnounceSubscribtionDAO' has a Cyclomatic Complexity of 4 (Highest = 13). |
12–318 |
| The class 'AnnounceSubscribtionDAO' has a Modified Cyclomatic Complexity of 4 (Highest = 13). |
12–318 |
| The class 'AnnounceSubscribtionDAO' has a Standard Cyclomatic Complexity of 4 (Highest = 13). |
12–318 |
| Avoid unused private fields such as 'SQL_QUERY_SELECT_DISTINCT'. |
17 |
| Avoid unused private fields such as 'CONSTANT_COMMA'. |
34 |
| The method 'findByFilter' has a Cyclomatic Complexity of 13. |
163–249 |
| The method 'findByFilter' has a Standard Cyclomatic Complexity of 13. |
163–249 |
| The method 'findByFilter' has a Modified Cyclomatic Complexity of 13. |
163–249 |
| The method findByFilter() has an NPath complexity of 1728 |
163–249 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
285 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. |
286 |
fr/paris/lutece/plugins/module/announce/subscribe/business/AnnounceSubscribtionDTO.java
| Violation |
Line |
| Use explicit scoping instead of the default package private level |
7 |
| Document empty constructor |
9–10 |
| It is a good practice to call super() in a constructor |
9–10 |
fr/paris/lutece/plugins/module/announce/subscribe/service/AnnounceSubscribePlugin.java
| Violation |
Line |
| Avoid unused imports such as 'fr.paris.lutece.plugins.subscribe.service.SubscribePlugin' |
36 |
| Avoid unused imports such as 'fr.paris.lutece.plugins.subscribe.service.SubscribePlugin' |
36 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
46–66 |
| Use of modifier volatile is not recommended. |
49 |
| Singleton is not thread safe |
57–63 |
fr/paris/lutece/plugins/module/announce/subscribe/service/AnnounceSubscriptionService.java
| Violation |
Line |
| A class which only has private constructors should be final |
18–121 |
| Private field '_dao' could be made final; it is only initialized in the declaration or constructor. |
21 |
