Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/appcenter/modules/identitystore/service/IdentitystoreTask.java

Rule Violation Ligne
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 114

fr/paris/lutece/plugins/appcenter/modules/identitystore/web/IdentitystoreXPage.java

Rule Violation Ligne
FieldNamingConventions The final field name '_attributesProviderService' doesn't match '[a-z][a-zA-Z0-9]*' 81

Priority 2

fr/paris/lutece/plugins/appcenter/modules/identitystore/web/IdentitystoreTaskComponent.java

Rule Violation Ligne
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 111

Priority 3

fr/paris/lutece/plugins/appcenter/modules/identitystore/business/AttributeDAO.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 147
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 174

fr/paris/lutece/plugins/appcenter/modules/identitystore/business/AttributeRight.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 41110
DefaultPackage Use explicit scoping instead of the default package private level 43
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _bReadable field if you want a default access modifier 43
DefaultPackage Use explicit scoping instead of the default package private level 44
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _bWritable field if you want a default access modifier 44
DefaultPackage Use explicit scoping instead of the default package private level 45
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _bCertifiable field if you want a default access modifier 45

fr/paris/lutece/plugins/appcenter/modules/identitystore/business/IdentitystoreDemand.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 53145
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 91
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 91

fr/paris/lutece/plugins/appcenter/modules/identitystore/service/IAttributesProvider.java

Rule Violation Ligne
CommentRequired Header comments are required 3947

fr/paris/lutece/plugins/appcenter/modules/identitystore/service/IdentityStoreDemandService.java

Rule Violation Ligne
CommentRequired Header comments are required 47126
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 48126
CyclomaticComplexity The method 'getMapAttributeRights(HttpServletRequest)' has a cyclomatic complexity of 15. 62125
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 64
ShortVariable Avoid variables with short names like p 89
ShortVariable Avoid variables with short names like m 90
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 93120
CollapsibleIfStatements These nested if statements could be combined 93120
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 105
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 109
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 113

fr/paris/lutece/plugins/appcenter/modules/identitystore/service/IdentitystorePermissionProvider.java

Rule Violation Ligne
CommentRequired Header comments are required 4772

fr/paris/lutece/plugins/appcenter/modules/identitystore/service/IdentitystoreTask.java

Rule Violation Ligne
CommentRequired Header comments are required 57160
CommentRequired Public method and constructor comments are required 99117

fr/paris/lutece/plugins/appcenter/modules/identitystore/service/LocalAttributesProvider.java

Rule Violation Ligne
CommentRequired Header comments are required 4055
CommentRequired Public method and constructor comments are required 4245
UncommentedEmptyConstructor Document empty constructor 4245
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 4245

fr/paris/lutece/plugins/appcenter/modules/identitystore/web/AttributeJspBean.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 54241
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 110
ConfusingTernary Avoid if (x != y) ..; else ..; 127

fr/paris/lutece/plugins/appcenter/modules/identitystore/web/IdentitystoreTaskComponent.java

Rule Violation Ligne
CommentRequired Header comments are required 58138
UnusedPrivateField Avoid unused private fields such as '_resourceHistoryService'. 70
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 78
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 78
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 125
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 125

fr/paris/lutece/plugins/appcenter/modules/identitystore/web/IdentitystoreXPage.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 69181
UnusedPrivateField Avoid unused private fields such as 'MARK_ENVIRONMENT'. 78
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 127
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 138

Priority 4

fr/paris/lutece/plugins/appcenter/modules/identitystore/business/IdentitystoreData.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 136139

fr/paris/lutece/plugins/appcenter/modules/identitystore/business/IdentitystoreDatas.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'java.util.List' 37
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.service.DataSubset' 38
UnusedImports Avoid unused imports such as 'java.util.ArrayList' 39

fr/paris/lutece/plugins/appcenter/modules/identitystore/service/IdentityStoreDemandService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'java.util.Iterator' 40

fr/paris/lutece/plugins/appcenter/modules/identitystore/web/IdentitystoreXPage.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.Environment' 41
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.service.ApplicationService' 48
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.service.UserService' 50
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.web.Constants.MARK_USER' 53
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' 62
UnusedImports Avoid unused imports such as 'java.util.Arrays' 63

Fichiers

fr/paris/lutece/plugins/appcenter/modules/identitystore/business/AttributeDAO.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 147
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 174

fr/paris/lutece/plugins/appcenter/modules/identitystore/business/AttributeRight.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 41110
DefaultPackage Use explicit scoping instead of the default package private level 3 43
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _bReadable field if you want a default access modifier 3 43
DefaultPackage Use explicit scoping instead of the default package private level 3 44
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _bWritable field if you want a default access modifier 3 44
DefaultPackage Use explicit scoping instead of the default package private level 3 45
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _bCertifiable field if you want a default access modifier 3 45

fr/paris/lutece/plugins/appcenter/modules/identitystore/business/IdentitystoreData.java

Rule Violation Priority Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 136139

fr/paris/lutece/plugins/appcenter/modules/identitystore/business/IdentitystoreDatas.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'java.util.List' 4 37
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.service.DataSubset' 4 38
UnusedImports Avoid unused imports such as 'java.util.ArrayList' 4 39

fr/paris/lutece/plugins/appcenter/modules/identitystore/business/IdentitystoreDemand.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 53145
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 91
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 91

fr/paris/lutece/plugins/appcenter/modules/identitystore/service/IAttributesProvider.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 3947

fr/paris/lutece/plugins/appcenter/modules/identitystore/service/IdentityStoreDemandService.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'java.util.Iterator' 4 40
CommentRequired Header comments are required 3 47126
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 48126
CyclomaticComplexity The method 'getMapAttributeRights(HttpServletRequest)' has a cyclomatic complexity of 15. 3 62125
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 64
ShortVariable Avoid variables with short names like p 3 89
ShortVariable Avoid variables with short names like m 3 90
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 93120
CollapsibleIfStatements These nested if statements could be combined 3 93120
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 105
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 109
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 113

fr/paris/lutece/plugins/appcenter/modules/identitystore/service/IdentitystorePermissionProvider.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4772

fr/paris/lutece/plugins/appcenter/modules/identitystore/service/IdentitystoreTask.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 57160
CommentRequired Public method and constructor comments are required 3 99117
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 114

fr/paris/lutece/plugins/appcenter/modules/identitystore/service/LocalAttributesProvider.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 4055
CommentRequired Public method and constructor comments are required 3 4245
UncommentedEmptyConstructor Document empty constructor 3 4245
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 4245

fr/paris/lutece/plugins/appcenter/modules/identitystore/web/AttributeJspBean.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 54241
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 110
ConfusingTernary Avoid if (x != y) ..; else ..; 3 127

fr/paris/lutece/plugins/appcenter/modules/identitystore/web/IdentitystoreTaskComponent.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 58138
UnusedPrivateField Avoid unused private fields such as '_resourceHistoryService'. 3 70
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 78
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 78
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 111
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 125
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 125

fr/paris/lutece/plugins/appcenter/modules/identitystore/web/IdentitystoreXPage.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.Environment' 4 41
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.service.ApplicationService' 4 48
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.service.UserService' 4 50
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.web.Constants.MARK_USER' 4 53
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' 4 62
UnusedImports Avoid unused imports such as 'java.util.Arrays' 4 63
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 69181
UnusedPrivateField Avoid unused private fields such as 'MARK_ENVIRONMENT'. 3 78
FieldNamingConventions The final field name '_attributesProviderService' doesn't match '[a-z][a-zA-Z0-9]*' 1 81
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 127
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 138