Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/appcenter/modules/openam/business/OpenamAgentData.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_strName' doesn't match '[a-z][a-zA-Z0-9]*' 38
FormalParameterNamingConventions The method parameter name '_strPassword' doesn't match '[a-z][a-zA-Z0-9]*' 53
FormalParameterNamingConventions The method parameter name '_strServerUrl' doesn't match '[a-z][a-zA-Z0-9]*' 67
FormalParameterNamingConventions The method parameter name '_strAgentUrl' doesn't match '[a-z][a-zA-Z0-9]*' 81

fr/paris/lutece/plugins/appcenter/modules/openam/service/OpenamTask.java

Rule Violation Ligne
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 57

fr/paris/lutece/plugins/appcenter/modules/openam/service/client/rest/OpenamAgentDTO.java

Rule Violation Ligne
FormalParameterNamingConventions The method parameter name '_strCookiename' doesn't match '[a-z][a-zA-Z0-9]*' 242

Priority 2

fr/paris/lutece/plugins/appcenter/modules/openam/web/OpenamTaskComponent.java

Rule Violation Ligne
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 88

Priority 3

fr/paris/lutece/plugins/appcenter/modules/openam/business/OpenamAgentsData.java

Rule Violation Ligne
UnusedPrivateField Avoid unused private fields such as '_listOpenamAgents'. 49
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 49
ImmutableField Private field '_listOpenamAgents' could be made final; it is only initialized in the declaration or constructor. 49

fr/paris/lutece/plugins/appcenter/modules/openam/business/OpenamDemand.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 25137
CommentRequired Public method and constructor comments are required 4144
CommentRequired Public method and constructor comments are required 4649
CommentRequired Public method and constructor comments are required 5154
CommentRequired Public method and constructor comments are required 5659
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 85
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 85

fr/paris/lutece/plugins/appcenter/modules/openam/service/OpenamPermissionProvider.java

Rule Violation Ligne
CommentRequired Header comments are required 1439

fr/paris/lutece/plugins/appcenter/modules/openam/service/OpenamTask.java

Rule Violation Ligne
CommentRequired Header comments are required 2597

fr/paris/lutece/plugins/appcenter/modules/openam/service/client/rest/CreateAgentSerializer.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 1077
CommentRequired Header comments are required 1077
CommentRequired Public method and constructor comments are required 1214
ShortVariable Avoid variables with short names like t 16
CommentRequired Public method and constructor comments are required 1618

fr/paris/lutece/plugins/appcenter/modules/openam/service/client/rest/OpenamAgentDTO.java

Rule Violation Ligne
CommentRequired Header comments are required 11247
ConfusingTernary Avoid if (x != y) ..; else ..; 8194
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 100
CommentRequired Public method and constructor comments are required 236239
CommentRequired Public method and constructor comments are required 242245

fr/paris/lutece/plugins/appcenter/modules/openam/service/client/rest/OpenamAgentRestService.java

Rule Violation Ligne
CommentRequired Header comments are required 20122
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 20122
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 38
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 38
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 64
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 64
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'response' 76
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 91
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 91
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'response' 102
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 115
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 115
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'response' 120

fr/paris/lutece/plugins/appcenter/modules/openam/service/client/rest/UpdateAgentSerializer.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 1098
CommentRequired Header comments are required 1098
CommentRequired Public method and constructor comments are required 1214
ShortVariable Avoid variables with short names like t 16
CommentRequired Public method and constructor comments are required 1618
AvoidDuplicateLiterals The String literal "false" appears 6 times in this file; the first occurrence is on line 41 41
ShortVariable Avoid variables with short names like i 72

fr/paris/lutece/plugins/appcenter/modules/openam/web/OpenamAgentsXPage.java

Rule Violation Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 63149
CommentRequired Public method and constructor comments are required 7994
CommentRequired Public method and constructor comments are required 97123
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 108

fr/paris/lutece/plugins/appcenter/modules/openam/web/OpenamTaskComponent.java

Rule Violation Ligne
CommentRequired Header comments are required 32121
UnusedPrivateField Avoid unused private fields such as 'MESSAGE_MANDATORY_FIELD'. 39
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 52
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 52
UnusedLocalVariable Avoid unused local variables such as 'demand'. 104
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 104
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 107
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 107

Priority 4

fr/paris/lutece/plugins/appcenter/modules/openam/business/OpenamAgentData.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.Environment' 7
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 9093
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 109112

fr/paris/lutece/plugins/appcenter/modules/openam/business/OpenamDemand.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 6669

fr/paris/lutece/plugins/appcenter/modules/openam/service/client/rest/OpenamAgentDTO.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.Environment' 6

fr/paris/lutece/plugins/appcenter/modules/openam/web/OpenamAgentsXPage.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.Application' 41
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.Environment' 42
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.service.ApplicationService' 45
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.service.UserService' 47
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.web.Constants.MARK_USER' 50

fr/paris/lutece/plugins/appcenter/modules/openam/web/OpenamTaskComponent.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'org.apache.poi.ss.formula.functions.T' 12
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessage' 25
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessageService' 26

Fichiers

fr/paris/lutece/plugins/appcenter/modules/openam/business/OpenamAgentData.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.Environment' 4 7
FormalParameterNamingConventions The method parameter name '_strName' doesn't match '[a-z][a-zA-Z0-9]*' 1 38
FormalParameterNamingConventions The method parameter name '_strPassword' doesn't match '[a-z][a-zA-Z0-9]*' 1 53
FormalParameterNamingConventions The method parameter name '_strServerUrl' doesn't match '[a-z][a-zA-Z0-9]*' 1 67
FormalParameterNamingConventions The method parameter name '_strAgentUrl' doesn't match '[a-z][a-zA-Z0-9]*' 1 81
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 9093
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 109112

fr/paris/lutece/plugins/appcenter/modules/openam/business/OpenamAgentsData.java

Rule Violation Priority Ligne
UnusedPrivateField Avoid unused private fields such as '_listOpenamAgents'. 3 49
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 49
ImmutableField Private field '_listOpenamAgents' could be made final; it is only initialized in the declaration or constructor. 3 49

fr/paris/lutece/plugins/appcenter/modules/openam/business/OpenamDemand.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 25137
CommentRequired Public method and constructor comments are required 3 4144
CommentRequired Public method and constructor comments are required 3 4649
CommentRequired Public method and constructor comments are required 3 5154
CommentRequired Public method and constructor comments are required 3 5659
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 6669
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 85
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 85

fr/paris/lutece/plugins/appcenter/modules/openam/service/OpenamPermissionProvider.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 1439

fr/paris/lutece/plugins/appcenter/modules/openam/service/OpenamTask.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 2597
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 57

fr/paris/lutece/plugins/appcenter/modules/openam/service/client/rest/CreateAgentSerializer.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 1077
CommentRequired Header comments are required 3 1077
CommentRequired Public method and constructor comments are required 3 1214
ShortVariable Avoid variables with short names like t 3 16
CommentRequired Public method and constructor comments are required 3 1618

fr/paris/lutece/plugins/appcenter/modules/openam/service/client/rest/OpenamAgentDTO.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.Environment' 4 6
CommentRequired Header comments are required 3 11247
ConfusingTernary Avoid if (x != y) ..; else ..; 3 8194
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 100
CommentRequired Public method and constructor comments are required 3 236239
CommentRequired Public method and constructor comments are required 3 242245
FormalParameterNamingConventions The method parameter name '_strCookiename' doesn't match '[a-z][a-zA-Z0-9]*' 1 242

fr/paris/lutece/plugins/appcenter/modules/openam/service/client/rest/OpenamAgentRestService.java

Rule Violation Priority Ligne
CommentRequired Header comments are required 3 20122
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 20122
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 38
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 38
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 64
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 64
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'response' 3 76
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 91
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 91
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'response' 3 102
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 115
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 115
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'response' 3 120

fr/paris/lutece/plugins/appcenter/modules/openam/service/client/rest/UpdateAgentSerializer.java

Rule Violation Priority Ligne
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 1098
CommentRequired Header comments are required 3 1098
CommentRequired Public method and constructor comments are required 3 1214
ShortVariable Avoid variables with short names like t 3 16
CommentRequired Public method and constructor comments are required 3 1618
AvoidDuplicateLiterals The String literal "false" appears 6 times in this file; the first occurrence is on line 41 3 41
ShortVariable Avoid variables with short names like i 3 72

fr/paris/lutece/plugins/appcenter/modules/openam/web/OpenamAgentsXPage.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.Application' 4 41
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.business.Environment' 4 42
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.service.ApplicationService' 4 45
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.service.UserService' 4 47
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appcenter.web.Constants.MARK_USER' 4 50
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 63149
CommentRequired Public method and constructor comments are required 3 7994
CommentRequired Public method and constructor comments are required 3 97123
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 108

fr/paris/lutece/plugins/appcenter/modules/openam/web/OpenamTaskComponent.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'org.apache.poi.ss.formula.functions.T' 4 12
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessage' 4 25
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessageService' 4 26
CommentRequired Header comments are required 3 32121
UnusedPrivateField Avoid unused private fields such as 'MESSAGE_MANDATORY_FIELD'. 3 39
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 52
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 52
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 88
UnusedLocalVariable Avoid unused local variables such as 'demand'. 3 104
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 104
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 107
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 107