The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_stateService' doesn't match '[a-z][a-zA-Z0-9]*' | 127 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 46–160 |
| MissingOverride | The method 'insert(TaskNotifyReminderConfig)' is missing an @Override annotation. | 54 |
| MissingOverride | The method 'store(TaskNotifyReminderConfig)' is missing an @Override annotation. | 62 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 70 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 82 |
| ShortVariable | Avoid variables with short names like b | 115 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 49–564 |
| CollapsibleIfStatements | These nested if statements could be combined | 86–90 |
| ShortVariable | Avoid variables with short names like b | 233 |
| MissingOverride | The method 'loadListTaskNotifyConfig(int, Plugin)' is missing an @Override annotation. | 317–345 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 513 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_taskReminder' could be made final; it is only initialized in the declaration or constructor. | 63 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 106 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 55–57 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–461 |
| GodClass | Possible God Class (WMC=52, ATFD=90, TCC=3.571%) | 101–461 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 144 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _workflowService field if you want a default access modifier | 144 |
| CyclomaticComplexity | The method 'sendReminder(int, String, int, int)' has a cyclomatic complexity of 15. | 153–211 |
| CommentRequired | Public method and constructor comments are required | 153–211 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 184–207 |
| NPathComplexity | The method 'sendReminder(AppointmentDTO, ReminderAppointment, Date, long, int, TaskNotifyReminderConfig, String, int)' has an NPath complexity of 652 | 228–312 |
| CyclomaticComplexity | The method 'sendReminder(AppointmentDTO, ReminderAppointment, Date, long, int, TaskNotifyReminderConfig, String, int)' has a cyclomatic complexity of 20. | 228–312 |
| UnusedFormalParameter | Avoid unused method parameters such as 'startAppointment'. | 228 |
| UnusedFormalParameter | Avoid unused method parameters such as 'nIdAction'. | 229 |
| UnusedFormalParameter | Avoid unused method parameters such as 'strResourceType'. | 229 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 265 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 276–294 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 284 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 289 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 304 |
| CyclomaticComplexity | The method 'getSmsFromAppointment(AppointmentDTO, ReminderAppointment)' has a cyclomatic complexity of 10. | 323–365 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 61–63 |
| UncommentedEmptyMethodBody | Document empty method body | 67–69 |
| UncommentedEmptyMethodBody | Document empty method body | 79–81 |
| UncommentedEmptyMethodBody | Document empty method body | 85–87 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–432 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 184 |
| NcssCount | The method 'doSaveConfig(HttpServletRequest, Locale, ITask)' has a NCSS line count of 94. | 203–382 |
| NPathComplexity | The method 'doSaveConfig(HttpServletRequest, Locale, ITask)' has an NPath complexity of 2147483647 | 203–382 |
| CyclomaticComplexity | The method 'doSaveConfig(HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 54. | 203–382 |
| ExcessiveMethodLength | Avoid really long methods. | 203–382 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 207 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 208 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 210 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 212 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 268 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 270 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 271 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 272–273 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 274–275 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 276–277 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 278–279 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 280 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 281–282 |
| CollapsibleIfStatements | These nested if statements could be combined | 286–289 |
| CollapsibleIfStatements | These nested if statements could be combined | 293–296 |
| CollapsibleIfStatements | These nested if statements could be combined | 300–303 |
| CollapsibleIfStatements | These nested if statements could be combined | 307–310 |
| CollapsibleIfStatements | These nested if statements could be combined | 315–318 |
| CollapsibleIfStatements | These nested if statements could be combined | 323–326 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 360 |
| CollapsibleIfStatements | These nested if statements could be combined | 406–409 |
| CommentRequired | Public method and constructor comments are required | 421–424 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.business.state.State' | 42 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 46–160 |
| MissingOverride | The method 'insert(TaskNotifyReminderConfig)' is missing an @Override annotation. | 3 | 54 |
| MissingOverride | The method 'store(TaskNotifyReminderConfig)' is missing an @Override annotation. | 3 | 62 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 3 | 70 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 3 | 82 |
| ShortVariable | Avoid variables with short names like b | 3 | 115 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 49–564 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 86–90 |
| ShortVariable | Avoid variables with short names like b | 3 | 233 |
| MissingOverride | The method 'loadListTaskNotifyConfig(int, Plugin)' is missing an @Override annotation. | 3 | 317–345 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 513 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.business.state.State' | 4 | 42 |
| ImmutableField | Private field '_taskReminder' could be made final; it is only initialized in the declaration or constructor. | 3 | 63 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 106 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 3 | 55–57 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–461 |
| GodClass | Possible God Class (WMC=52, ATFD=90, TCC=3.571%) | 3 | 101–461 |
| FieldNamingConventions | The final field name '_stateService' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 127 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 144 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _workflowService field if you want a default access modifier | 3 | 144 |
| CyclomaticComplexity | The method 'sendReminder(int, String, int, int)' has a cyclomatic complexity of 15. | 3 | 153–211 |
| CommentRequired | Public method and constructor comments are required | 3 | 153–211 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 184–207 |
| NPathComplexity | The method 'sendReminder(AppointmentDTO, ReminderAppointment, Date, long, int, TaskNotifyReminderConfig, String, int)' has an NPath complexity of 652 | 3 | 228–312 |
| CyclomaticComplexity | The method 'sendReminder(AppointmentDTO, ReminderAppointment, Date, long, int, TaskNotifyReminderConfig, String, int)' has a cyclomatic complexity of 20. | 3 | 228–312 |
| UnusedFormalParameter | Avoid unused method parameters such as 'startAppointment'. | 3 | 228 |
| UnusedFormalParameter | Avoid unused method parameters such as 'nIdAction'. | 3 | 229 |
| UnusedFormalParameter | Avoid unused method parameters such as 'strResourceType'. | 3 | 229 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 265 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 276–294 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 284 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 289 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 304 |
| CyclomaticComplexity | The method 'getSmsFromAppointment(AppointmentDTO, ReminderAppointment)' has a cyclomatic complexity of 10. | 3 | 323–365 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 3 | 61–63 |
| UncommentedEmptyMethodBody | Document empty method body | 3 | 67–69 |
| UncommentedEmptyMethodBody | Document empty method body | 3 | 79–81 |
| UncommentedEmptyMethodBody | Document empty method body | 3 | 85–87 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–432 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 184 |
| NcssCount | The method 'doSaveConfig(HttpServletRequest, Locale, ITask)' has a NCSS line count of 94. | 3 | 203–382 |
| NPathComplexity | The method 'doSaveConfig(HttpServletRequest, Locale, ITask)' has an NPath complexity of 2147483647 | 3 | 203–382 |
| CyclomaticComplexity | The method 'doSaveConfig(HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 54. | 3 | 203–382 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 203–382 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 207 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 208 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 210 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 212 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 268 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 270 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 271 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 272–273 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 274–275 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 276–277 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 278–279 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 280 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 281–282 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 286–289 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 293–296 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 300–303 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 307–310 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 315–318 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 323–326 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 360 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 406–409 |
| CommentRequired | Public method and constructor comments are required | 3 | 421–424 |
