Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/appointment/modules/management/service/indexer/LuteceAppointmentSearchIndexer.java

Rule Violation Line
FieldNamingConventions The final field name '_idList' doesn't match '[a-z][a-zA-Z0-9]*' 375

fr/paris/lutece/plugins/appointment/modules/management/service/search/AppointmentSortConfig.java

Rule Violation Line
FieldNamingConventions The final field name '_strSortAttributeName' doesn't match '[a-z][a-zA-Z0-9]*' 38
FieldNamingConventions The final field name '_bDescSort' doesn't match '[a-z][a-zA-Z0-9]*' 39

Priority 2

fr/paris/lutece/plugins/appointment/modules/management/service/indexer/LuceneAppointmentIndexFactory.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'bCreateIndex' 75

Priority 3

fr/paris/lutece/plugins/appointment/modules/management/business/search/AppointmentSearchItem.java

Rule Violation Line
DataClass The class 'AppointmentSearchItem' is suspected to be a Data Class (WOC=0.000%, NOPA=19, NOAM=23, WMC=30) 51340
TooManyFields Too many fields 51340
ImmutableField Private field '_idAppointment' could be made final; it is only initialized in the declaration or constructor. 77
ImmutableField Private field '_idForm' could be made final; it is only initialized in the declaration or constructor. 78
ImmutableField Private field '_firstName' could be made final; it is only initialized in the declaration or constructor. 79
ImmutableField Private field '_lastName' could be made final; it is only initialized in the declaration or constructor. 80
ImmutableField Private field '_mail' could be made final; it is only initialized in the declaration or constructor. 81
ImmutableField Private field '_phoneNumber' could be made final; it is only initialized in the declaration or constructor. 82
ImmutableField Private field '_startDate' could be made final; it is only initialized in the declaration or constructor. 83
ImmutableField Private field '_endDate' could be made final; it is only initialized in the declaration or constructor. 84
ImmutableField Private field '_admin' could be made final; it is only initialized in the declaration or constructor. 85
ImmutableField Private field '_cancelled' could be made final; it is only initialized in the declaration or constructor. 86
ImmutableField Private field '_idState' could be made final; it is only initialized in the declaration or constructor. 87
ImmutableField Private field '_nbSeats' could be made final; it is only initialized in the declaration or constructor. 88
ImmutableField Private field '_dateAppointmentTaken' could be made final; it is only initialized in the declaration or constructor. 89
ImmutableField Private field '_dateOfTheAppointment' could be made final; it is only initialized in the declaration or constructor. 91
ImmutableField Private field '_startingTime' could be made final; it is only initialized in the declaration or constructor. 92
ImmutableField Private field '_endingTime' could be made final; it is only initialized in the declaration or constructor. 93
ImmutableField Private field '_idCategory' could be made final; it is only initialized in the declaration or constructor. 95
CommentRequired Public method and constructor comments are required 101123
ConfusingTernary Avoid if (x != y) ..; else ..; 111

fr/paris/lutece/plugins/appointment/modules/management/business/search/MultiviewFilter.java

Rule Violation Line
CommentRequired Header comments are required 4082

fr/paris/lutece/plugins/appointment/modules/management/service/AppointmentSearchService.java

Rule Violation Line
CommentRequired Header comments are required 58104
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 73

fr/paris/lutece/plugins/appointment/modules/management/service/IAppointmentSearchService.java

Rule Violation Line
CommentRequired Header comments are required 4246
CommentRequired Public method and constructor comments are required 45

fr/paris/lutece/plugins/appointment/modules/management/service/indexer/LuceneAppointmentIndexFactory.java

Rule Violation Line
CommentRequired Header comments are required 54132
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 61

fr/paris/lutece/plugins/appointment/modules/management/service/indexer/LuceneAppointmentListener.java

Rule Violation Line
CommentRequired Header comments are required 4474

fr/paris/lutece/plugins/appointment/modules/management/service/indexer/LuteceAppointmentSearchIndexer.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34566
CommentRequired Public method and constructor comments are required 113116
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 164
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 180
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 252
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 253
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 259
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 260
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 266
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 267
ConfusingTernary Avoid if (x != y) ..; else ..; 271
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 373
CommentRequired Header comments are required 373565
CommentRequired Public method and constructor comments are required 377380
CommentRequired Public method and constructor comments are required 382385
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 393
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 398
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 405
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 413
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 444
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 448
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 459
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 465
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 469
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 497
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 497
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 499
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 517
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 519
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 525
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 527
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 538
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 545
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 558
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 558

fr/paris/lutece/plugins/appointment/modules/management/service/search/AppointmentSearchEngine.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34249
CommentRequired Header comments are required 70249
ShortVariable Avoid variables with short names like ir 83
ConfusingTernary Avoid if (x != y) ..; else ..; 8895
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 139
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 145
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 151
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 157
ConfusingTernary Avoid if (x != y) ..; else ..; 199216
ConfusingTernary Avoid if (x != y) ..; else ..; 204216
ConfusingTernary Avoid if (x != y) ..; else ..; 209216

fr/paris/lutece/plugins/appointment/modules/management/service/search/AppointmentSortConfig.java

Rule Violation Line
CommentRequired Header comments are required 3662
CommentRequired Public method and constructor comments are required 4145

fr/paris/lutece/plugins/appointment/modules/management/service/search/IAppointmentSearchEngine.java

Rule Violation Line
CommentRequired Header comments are required 4150

fr/paris/lutece/plugins/appointment/modules/management/web/MultiviewAppointmentJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34309
CommentRequired Header comments are required 80309
ImmutableField Private field '_appointmentSearchService' could be made final; it is only initialized in the declaration or constructor. 123
ConfusingTernary Avoid if (x != y) ..; else ..; 142152
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 219

Files

fr/paris/lutece/plugins/appointment/modules/management/business/search/AppointmentSearchItem.java

Rule Violation Priority Line
DataClass The class 'AppointmentSearchItem' is suspected to be a Data Class (WOC=0.000%, NOPA=19, NOAM=23, WMC=30) 3 51340
TooManyFields Too many fields 3 51340
ImmutableField Private field '_idAppointment' could be made final; it is only initialized in the declaration or constructor. 3 77
ImmutableField Private field '_idForm' could be made final; it is only initialized in the declaration or constructor. 3 78
ImmutableField Private field '_firstName' could be made final; it is only initialized in the declaration or constructor. 3 79
ImmutableField Private field '_lastName' could be made final; it is only initialized in the declaration or constructor. 3 80
ImmutableField Private field '_mail' could be made final; it is only initialized in the declaration or constructor. 3 81
ImmutableField Private field '_phoneNumber' could be made final; it is only initialized in the declaration or constructor. 3 82
ImmutableField Private field '_startDate' could be made final; it is only initialized in the declaration or constructor. 3 83
ImmutableField Private field '_endDate' could be made final; it is only initialized in the declaration or constructor. 3 84
ImmutableField Private field '_admin' could be made final; it is only initialized in the declaration or constructor. 3 85
ImmutableField Private field '_cancelled' could be made final; it is only initialized in the declaration or constructor. 3 86
ImmutableField Private field '_idState' could be made final; it is only initialized in the declaration or constructor. 3 87
ImmutableField Private field '_nbSeats' could be made final; it is only initialized in the declaration or constructor. 3 88
ImmutableField Private field '_dateAppointmentTaken' could be made final; it is only initialized in the declaration or constructor. 3 89
ImmutableField Private field '_dateOfTheAppointment' could be made final; it is only initialized in the declaration or constructor. 3 91
ImmutableField Private field '_startingTime' could be made final; it is only initialized in the declaration or constructor. 3 92
ImmutableField Private field '_endingTime' could be made final; it is only initialized in the declaration or constructor. 3 93
ImmutableField Private field '_idCategory' could be made final; it is only initialized in the declaration or constructor. 3 95
CommentRequired Public method and constructor comments are required 3 101123
ConfusingTernary Avoid if (x != y) ..; else ..; 3 111

fr/paris/lutece/plugins/appointment/modules/management/business/search/MultiviewFilter.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4082

fr/paris/lutece/plugins/appointment/modules/management/service/AppointmentSearchService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 58104
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 73

fr/paris/lutece/plugins/appointment/modules/management/service/IAppointmentSearchService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4246
CommentRequired Public method and constructor comments are required 3 45

fr/paris/lutece/plugins/appointment/modules/management/service/indexer/LuceneAppointmentIndexFactory.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 54132
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 61
AvoidReassigningParameters Avoid reassigning parameters such as 'bCreateIndex' 2 75

fr/paris/lutece/plugins/appointment/modules/management/service/indexer/LuceneAppointmentListener.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4474

fr/paris/lutece/plugins/appointment/modules/management/service/indexer/LuteceAppointmentSearchIndexer.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34566
CommentRequired Public method and constructor comments are required 3 113116
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 164
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 180
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 252
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 253
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 259
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 260
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 266
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 267
ConfusingTernary Avoid if (x != y) ..; else ..; 3 271
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 373
CommentRequired Header comments are required 3 373565
FieldNamingConventions The final field name '_idList' doesn't match '[a-z][a-zA-Z0-9]*' 1 375
CommentRequired Public method and constructor comments are required 3 377380
CommentRequired Public method and constructor comments are required 3 382385
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 393
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 398
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 405
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 413
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 444
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 448
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 459
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 465
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 469
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 497
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 497
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 499
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 517
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 519
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 525
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 527
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 538
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 545
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 3 558
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 558

fr/paris/lutece/plugins/appointment/modules/management/service/search/AppointmentSearchEngine.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34249
CommentRequired Header comments are required 3 70249
ShortVariable Avoid variables with short names like ir 3 83
ConfusingTernary Avoid if (x != y) ..; else ..; 3 8895
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 139
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 145
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 151
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 157
ConfusingTernary Avoid if (x != y) ..; else ..; 3 199216
ConfusingTernary Avoid if (x != y) ..; else ..; 3 204216
ConfusingTernary Avoid if (x != y) ..; else ..; 3 209216

fr/paris/lutece/plugins/appointment/modules/management/service/search/AppointmentSortConfig.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 3662
FieldNamingConventions The final field name '_strSortAttributeName' doesn't match '[a-z][a-zA-Z0-9]*' 1 38
FieldNamingConventions The final field name '_bDescSort' doesn't match '[a-z][a-zA-Z0-9]*' 1 39
CommentRequired Public method and constructor comments are required 3 4145

fr/paris/lutece/plugins/appointment/modules/management/service/search/IAppointmentSearchEngine.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4150

fr/paris/lutece/plugins/appointment/modules/management/web/MultiviewAppointmentJspBean.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34309
CommentRequired Header comments are required 3 80309
ImmutableField Private field '_appointmentSearchService' could be made final; it is only initialized in the declaration or constructor. 3 123
ConfusingTernary Avoid if (x != y) ..; else ..; 3 142152
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 219