The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_idList' doesn't match '[a-z][a-zA-Z0-9]*' | 375 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_strSortAttributeName' doesn't match '[a-z][a-zA-Z0-9]*' | 38 |
| FieldNamingConventions | The final field name '_bDescSort' doesn't match '[a-z][a-zA-Z0-9]*' | 39 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'bCreateIndex' | 75 |
| Rule | Violation | Line |
|---|---|---|
| TooManyFields | Too many fields | 51–340 |
| DataClass | The class 'AppointmentSearchItem' is suspected to be a Data Class (WOC=0.000%, NOPA=19, NOAM=23, WMC=30) | 51–340 |
| ImmutableField | Private field '_idAppointment' could be made final; it is only initialized in the declaration or constructor. | 77 |
| ImmutableField | Private field '_idForm' could be made final; it is only initialized in the declaration or constructor. | 78 |
| ImmutableField | Private field '_firstName' could be made final; it is only initialized in the declaration or constructor. | 79 |
| ImmutableField | Private field '_lastName' could be made final; it is only initialized in the declaration or constructor. | 80 |
| ImmutableField | Private field '_mail' could be made final; it is only initialized in the declaration or constructor. | 81 |
| ImmutableField | Private field '_phoneNumber' could be made final; it is only initialized in the declaration or constructor. | 82 |
| ImmutableField | Private field '_startDate' could be made final; it is only initialized in the declaration or constructor. | 83 |
| ImmutableField | Private field '_endDate' could be made final; it is only initialized in the declaration or constructor. | 84 |
| ImmutableField | Private field '_admin' could be made final; it is only initialized in the declaration or constructor. | 85 |
| ImmutableField | Private field '_cancelled' could be made final; it is only initialized in the declaration or constructor. | 86 |
| ImmutableField | Private field '_idState' could be made final; it is only initialized in the declaration or constructor. | 87 |
| ImmutableField | Private field '_nbSeats' could be made final; it is only initialized in the declaration or constructor. | 88 |
| ImmutableField | Private field '_dateAppointmentTaken' could be made final; it is only initialized in the declaration or constructor. | 89 |
| ImmutableField | Private field '_dateOfTheAppointment' could be made final; it is only initialized in the declaration or constructor. | 91 |
| ImmutableField | Private field '_startingTime' could be made final; it is only initialized in the declaration or constructor. | 92 |
| ImmutableField | Private field '_endingTime' could be made final; it is only initialized in the declaration or constructor. | 93 |
| ImmutableField | Private field '_idCategory' could be made final; it is only initialized in the declaration or constructor. | 95 |
| CommentRequired | Public method and constructor comments are required | 101–123 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 111 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 40–82 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 58–104 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 73 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 42–46 |
| CommentRequired | Public method and constructor comments are required | 45 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 54–132 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 61 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 44–74 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–566 |
| CommentRequired | Public method and constructor comments are required | 113–116 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 164 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 180 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 252 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 253 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 259 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 260 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 266 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 267 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 271 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 373 |
| CommentRequired | Header comments are required | 373–565 |
| CommentRequired | Public method and constructor comments are required | 377–380 |
| CommentRequired | Public method and constructor comments are required | 382–385 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 398 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 527 |
| OptimizableToArrayCall | This call to Collection.toArray() may be optimizable | 558 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–249 |
| CommentRequired | Header comments are required | 70–249 |
| ShortVariable | Avoid variables with short names like ir | 83 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 88–95 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 139 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 145 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 151 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 157 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 199–216 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 204–216 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 209–216 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–62 |
| CommentRequired | Public method and constructor comments are required | 41–45 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–50 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–309 |
| CommentRequired | Header comments are required | 80–309 |
| ImmutableField | Private field '_appointmentSearchService' could be made final; it is only initialized in the declaration or constructor. | 123 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 142–152 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 219 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyFields | Too many fields | 3 | 51–340 |
| DataClass | The class 'AppointmentSearchItem' is suspected to be a Data Class (WOC=0.000%, NOPA=19, NOAM=23, WMC=30) | 3 | 51–340 |
| ImmutableField | Private field '_idAppointment' could be made final; it is only initialized in the declaration or constructor. | 3 | 77 |
| ImmutableField | Private field '_idForm' could be made final; it is only initialized in the declaration or constructor. | 3 | 78 |
| ImmutableField | Private field '_firstName' could be made final; it is only initialized in the declaration or constructor. | 3 | 79 |
| ImmutableField | Private field '_lastName' could be made final; it is only initialized in the declaration or constructor. | 3 | 80 |
| ImmutableField | Private field '_mail' could be made final; it is only initialized in the declaration or constructor. | 3 | 81 |
| ImmutableField | Private field '_phoneNumber' could be made final; it is only initialized in the declaration or constructor. | 3 | 82 |
| ImmutableField | Private field '_startDate' could be made final; it is only initialized in the declaration or constructor. | 3 | 83 |
| ImmutableField | Private field '_endDate' could be made final; it is only initialized in the declaration or constructor. | 3 | 84 |
| ImmutableField | Private field '_admin' could be made final; it is only initialized in the declaration or constructor. | 3 | 85 |
| ImmutableField | Private field '_cancelled' could be made final; it is only initialized in the declaration or constructor. | 3 | 86 |
| ImmutableField | Private field '_idState' could be made final; it is only initialized in the declaration or constructor. | 3 | 87 |
| ImmutableField | Private field '_nbSeats' could be made final; it is only initialized in the declaration or constructor. | 3 | 88 |
| ImmutableField | Private field '_dateAppointmentTaken' could be made final; it is only initialized in the declaration or constructor. | 3 | 89 |
| ImmutableField | Private field '_dateOfTheAppointment' could be made final; it is only initialized in the declaration or constructor. | 3 | 91 |
| ImmutableField | Private field '_startingTime' could be made final; it is only initialized in the declaration or constructor. | 3 | 92 |
| ImmutableField | Private field '_endingTime' could be made final; it is only initialized in the declaration or constructor. | 3 | 93 |
| ImmutableField | Private field '_idCategory' could be made final; it is only initialized in the declaration or constructor. | 3 | 95 |
| CommentRequired | Public method and constructor comments are required | 3 | 101–123 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 111 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 40–82 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 58–104 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 73 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 42–46 |
| CommentRequired | Public method and constructor comments are required | 3 | 45 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 54–132 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 61 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'bCreateIndex' | 2 | 75 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 44–74 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–566 |
| CommentRequired | Public method and constructor comments are required | 3 | 113–116 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 3 | 164 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 3 | 180 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 252 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 253 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 259 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 260 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 266 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 267 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 271 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 3 | 373 |
| CommentRequired | Header comments are required | 3 | 373–565 |
| FieldNamingConventions | The final field name '_idList' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 375 |
| CommentRequired | Public method and constructor comments are required | 3 | 377–380 |
| CommentRequired | Public method and constructor comments are required | 3 | 382–385 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 398 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 527 |
| OptimizableToArrayCall | This call to Collection.toArray() may be optimizable | 3 | 558 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–249 |
| CommentRequired | Header comments are required | 3 | 70–249 |
| ShortVariable | Avoid variables with short names like ir | 3 | 83 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 88–95 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 139 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 145 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 151 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 157 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 199–216 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 204–216 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 209–216 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–62 |
| FieldNamingConventions | The final field name '_strSortAttributeName' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 38 |
| FieldNamingConventions | The final field name '_bDescSort' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 39 |
| CommentRequired | Public method and constructor comments are required | 3 | 41–45 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–50 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–309 |
| CommentRequired | Header comments are required | 3 | 80–309 |
| ImmutableField | Private field '_appointmentSearchService' could be made final; it is only initialized in the declaration or constructor. | 3 | 123 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 142–152 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 219 |
