Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentFormResourceTypeHome.java

Rule Violation Ligne
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 49

Priority 2

fr/paris/lutece/plugins/appointment/modules/resource/service/AppointmentResourceService.java

Rule Violation Ligne
AvoidUsingVolatile Use of modifier volatile is not recommended. 54

Priority 3

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentFormResourceTypeDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 87101

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentResourceDTO.java

Rule Violation Ligne
DataClass The class 'AppointmentResourceDTO' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=5) 41101
CallSuperInConstructor It is a good practice to call super() in a constructor 5358

fr/paris/lutece/plugins/appointment/modules/resource/business/calendar/CalendarAppointmentResourceDTO.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like o 249
ShortVariable Avoid variables with short names like o 258
UselessOverridingMethod Overriding method merely calls super 272275

fr/paris/lutece/plugins/appointment/modules/resource/business/calendar/CalendarDayDTO.java

Rule Violation Ligne
DataClass The class 'CalendarDayDTO' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=4) 42135
ShortVariable Avoid variables with short names like o 93
ShortVariable Avoid variables with short names like o 117
UselessOverridingMethod Overriding method merely calls super 131134

fr/paris/lutece/plugins/appointment/modules/resource/business/form/FormResourceCalendar.java

Rule Violation Ligne
UncommentedEmptyConstructor Document empty constructor 7274
CommentRequired Public method and constructor comments are required 97100
CommentRequired Public method and constructor comments are required 102105
CommentRequired Public method and constructor comments are required 127130
CommentRequired Public method and constructor comments are required 132135

fr/paris/lutece/plugins/appointment/modules/resource/business/workflow/SetAppointmentResourceHistoryDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 114128

fr/paris/lutece/plugins/appointment/modules/resource/business/workflow/TaskSetAppointmentResourceConfigDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 5971

fr/paris/lutece/plugins/appointment/modules/resource/service/AppointmentResourceAddonService.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 69
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 85
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 85

fr/paris/lutece/plugins/appointment/modules/resource/service/AppointmentResourceService.java

Rule Violation Ligne
NonThreadSafeSingleton Singleton is not thread safe 6366

fr/paris/lutece/plugins/appointment/modules/resource/service/workflow/TaskSetAppointmentResource.java

Rule Violation Ligne
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 88
ConfusingTernary Avoid if (x != y) ..; else ..; 104116
ConfusingTernary Avoid if (x != y) ..; else ..; 142

fr/paris/lutece/plugins/appointment/modules/resource/web/AppointmentFormResourcesJspBean.java

Rule Violation Ligne
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 140
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 143
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 152
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 193
ConfusingTernary Avoid if (x != y) ..; else ..; 199216
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 202
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 214
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 249
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 285
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 295
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 333
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 386
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 427

fr/paris/lutece/plugins/appointment/modules/resource/web/AppointmentResourceJspBean.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34533
NPathComplexity The method 'getWeekResourceCalendar(IResource, int, Locale)' has an NPath complexity of 676 266411
NcssCount The method 'getWeekResourceCalendar(IResource, int, Locale)' has a NCSS line count of 83. 266411
CyclomaticComplexity The method 'getWeekResourceCalendar(IResource, int, Locale)' has a cyclomatic complexity of 13. 266411
ExcessiveMethodLength Avoid really long methods. 266411
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 269
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 288
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 450
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 516

fr/paris/lutece/plugins/appointment/modules/resource/web/AppointmentUserCalendarDashboardComponent.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 80

fr/paris/lutece/plugins/appointment/modules/resource/web/workflow/SetAppointmentResourceTaskComponent.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34352
CyclomaticComplexity The method 'getDisplayConfigForm(HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 10. 111174
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 113
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 128
ConfusingTernary Avoid if (x != y) ..; else ..; 143151
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 244
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 244

Priority 4

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentFormResourceType.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 148151
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 169172

fr/paris/lutece/plugins/appointment/modules/resource/business/workflow/TaskSetAppointmentResourceConfig.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 7275

fr/paris/lutece/plugins/appointment/modules/resource/service/AppointmentResourceService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.appointment.Appointment' 36
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.slot.Slot' 37
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.service.SlotService' 40

Fichiers

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentFormResourceType.java

Rule Violation Priority Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 148151
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 169172

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentFormResourceTypeDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 87101

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentFormResourceTypeHome.java

Rule Violation Priority Ligne
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 1 49

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentResourceDTO.java

Rule Violation Priority Ligne
DataClass The class 'AppointmentResourceDTO' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=5) 3 41101
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5358

fr/paris/lutece/plugins/appointment/modules/resource/business/calendar/CalendarAppointmentResourceDTO.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like o 3 249
ShortVariable Avoid variables with short names like o 3 258
UselessOverridingMethod Overriding method merely calls super 3 272275

fr/paris/lutece/plugins/appointment/modules/resource/business/calendar/CalendarDayDTO.java

Rule Violation Priority Ligne
DataClass The class 'CalendarDayDTO' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=4) 3 42135
ShortVariable Avoid variables with short names like o 3 93
ShortVariable Avoid variables with short names like o 3 117
UselessOverridingMethod Overriding method merely calls super 3 131134

fr/paris/lutece/plugins/appointment/modules/resource/business/form/FormResourceCalendar.java

Rule Violation Priority Ligne
UncommentedEmptyConstructor Document empty constructor 3 7274
CommentRequired Public method and constructor comments are required 3 97100
CommentRequired Public method and constructor comments are required 3 102105
CommentRequired Public method and constructor comments are required 3 127130
CommentRequired Public method and constructor comments are required 3 132135

fr/paris/lutece/plugins/appointment/modules/resource/business/workflow/SetAppointmentResourceHistoryDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 114128

fr/paris/lutece/plugins/appointment/modules/resource/business/workflow/TaskSetAppointmentResourceConfig.java

Rule Violation Priority Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 7275

fr/paris/lutece/plugins/appointment/modules/resource/business/workflow/TaskSetAppointmentResourceConfigDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 5971

fr/paris/lutece/plugins/appointment/modules/resource/service/AppointmentResourceAddonService.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 69
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 85
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 85

fr/paris/lutece/plugins/appointment/modules/resource/service/AppointmentResourceService.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.appointment.Appointment' 4 36
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.slot.Slot' 4 37
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.service.SlotService' 4 40
AvoidUsingVolatile Use of modifier volatile is not recommended. 2 54
NonThreadSafeSingleton Singleton is not thread safe 3 6366

fr/paris/lutece/plugins/appointment/modules/resource/service/workflow/TaskSetAppointmentResource.java

Rule Violation Priority Ligne
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 88
ConfusingTernary Avoid if (x != y) ..; else ..; 3 104116
ConfusingTernary Avoid if (x != y) ..; else ..; 3 142

fr/paris/lutece/plugins/appointment/modules/resource/web/AppointmentFormResourcesJspBean.java

Rule Violation Priority Ligne
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 140
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 143
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 152
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 193
ConfusingTernary Avoid if (x != y) ..; else ..; 3 199216
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 202
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 214
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 249
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 285
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 295
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 333
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 386
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 427

fr/paris/lutece/plugins/appointment/modules/resource/web/AppointmentResourceJspBean.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34533
NPathComplexity The method 'getWeekResourceCalendar(IResource, int, Locale)' has an NPath complexity of 676 3 266411
NcssCount The method 'getWeekResourceCalendar(IResource, int, Locale)' has a NCSS line count of 83. 3 266411
CyclomaticComplexity The method 'getWeekResourceCalendar(IResource, int, Locale)' has a cyclomatic complexity of 13. 3 266411
ExcessiveMethodLength Avoid really long methods. 3 266411
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 269
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 288
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 450
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 3 516

fr/paris/lutece/plugins/appointment/modules/resource/web/AppointmentUserCalendarDashboardComponent.java

Rule Violation Priority Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 80

fr/paris/lutece/plugins/appointment/modules/resource/web/workflow/SetAppointmentResourceTaskComponent.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34352
CyclomaticComplexity The method 'getDisplayConfigForm(HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 10. 3 111174
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 113
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 128
ConfusingTernary Avoid if (x != y) ..; else ..; 3 143151
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 244
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 244