Fork me on GitHub

Résultats PMD

Le document suivant contient les résultats de PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentFormResourceTypeHome.java

Rule Violation Ligne
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 49

Priority 2

fr/paris/lutece/plugins/appointment/modules/resource/service/AppointmentResourceService.java

Rule Violation Ligne
AvoidUsingVolatile Use of modifier volatile is not recommended. 54

Priority 3

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentFormResourceTypeDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 88101
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 177

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentResourceDAO.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 121
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 235

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentResourceDTO.java

Rule Violation Ligne
DataClass The class 'AppointmentResourceDTO' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=5) 41101
CallSuperInConstructor It is a good practice to call super() in a constructor 5358

fr/paris/lutece/plugins/appointment/modules/resource/business/calendar/CalendarAppointmentResourceDTO.java

Rule Violation Ligne
ShortVariable Avoid variables with short names like o 249
ShortVariable Avoid variables with short names like o 258
UselessOverridingMethod Overriding method merely calls super 272275

fr/paris/lutece/plugins/appointment/modules/resource/business/calendar/CalendarDayDTO.java

Rule Violation Ligne
DataClass The class 'CalendarDayDTO' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=4) 42135
ShortVariable Avoid variables with short names like o 93
ShortVariable Avoid variables with short names like o 117
UselessOverridingMethod Overriding method merely calls super 131134

fr/paris/lutece/plugins/appointment/modules/resource/business/workflow/SetAppointmentResourceHistoryDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 115128
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 154
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 184

fr/paris/lutece/plugins/appointment/modules/resource/business/workflow/TaskSetAppointmentResourceConfigDAO.java

Rule Violation Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 5971

fr/paris/lutece/plugins/appointment/modules/resource/service/AppointmentResourceAddonService.java

Rule Violation Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 69
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 85
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 85

fr/paris/lutece/plugins/appointment/modules/resource/service/AppointmentResourceService.java

Rule Violation Ligne
NonThreadSafeSingleton Singleton is not thread safe 6366

fr/paris/lutece/plugins/appointment/modules/resource/service/workflow/TaskSetAppointmentResource.java

Rule Violation Ligne
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 88
ConfusingTernary Avoid if (x != y) ..; else ..; 104116
ConfusingTernary Avoid if (x != y) ..; else ..; 142

fr/paris/lutece/plugins/appointment/modules/resource/web/AppointmentFormResourcesJspBean.java

Rule Violation Ligne
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 139
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 142
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 151
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 192
ConfusingTernary Avoid if (x != y) ..; else ..; 198215
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 201
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 213
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 248
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 284
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 294
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 332
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 385
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 426

fr/paris/lutece/plugins/appointment/modules/resource/web/AppointmentResourceJspBean.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34495
NcssCount The method 'getResourceCalendar(HttpServletRequest, IResource, int, Locale)' has a NCSS line count of 82. 261398
CyclomaticComplexity The method 'getResourceCalendar(HttpServletRequest, IResource, int, Locale)' has a cyclomatic complexity of 13. 261398
ExcessiveMethodLength Avoid really long methods. 261398
NPathComplexity The method 'getResourceCalendar(HttpServletRequest, IResource, int, Locale)' has an NPath complexity of 676 261398
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 264
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 264
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 279
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 281
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 281
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 336
EmptyStatementNotInLoop An empty statement (semicolon) not part of a loop 355
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 411
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 411
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 477

fr/paris/lutece/plugins/appointment/modules/resource/web/AppointmentUserCalendarDashboardComponent.java

Rule Violation Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 74
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 74

fr/paris/lutece/plugins/appointment/modules/resource/web/workflow/SetAppointmentResourceTaskComponent.java

Rule Violation Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34361
CyclomaticComplexity The method 'getDisplayConfigForm(HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 10. 111174
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 113
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 113
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 128
ConfusingTernary Avoid if (x != y) ..; else ..; 143151
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 244
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 244

Priority 4

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentFormResourceType.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 148151
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 169172

fr/paris/lutece/plugins/appointment/modules/resource/business/workflow/TaskSetAppointmentResourceConfig.java

Rule Violation Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 7275

fr/paris/lutece/plugins/appointment/modules/resource/service/AppointmentResourceService.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.appointment.Appointment' 36
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.slot.Slot' 37
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.service.SlotService' 40

fr/paris/lutece/plugins/appointment/modules/resource/web/AppointmentResourceJspBean.java

Rule Violation Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.slot.Slot' 52
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.service.SlotService' 58

Fichiers

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentFormResourceType.java

Rule Violation Priority Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 148151
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 169172

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentFormResourceTypeDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 88101
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 177

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentFormResourceTypeHome.java

Rule Violation Priority Ligne
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 1 49

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentResourceDAO.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 121
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 235

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentResourceDTO.java

Rule Violation Priority Ligne
DataClass The class 'AppointmentResourceDTO' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=5) 3 41101
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5358

fr/paris/lutece/plugins/appointment/modules/resource/business/calendar/CalendarAppointmentResourceDTO.java

Rule Violation Priority Ligne
ShortVariable Avoid variables with short names like o 3 249
ShortVariable Avoid variables with short names like o 3 258
UselessOverridingMethod Overriding method merely calls super 3 272275

fr/paris/lutece/plugins/appointment/modules/resource/business/calendar/CalendarDayDTO.java

Rule Violation Priority Ligne
DataClass The class 'CalendarDayDTO' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=4) 3 42135
ShortVariable Avoid variables with short names like o 3 93
ShortVariable Avoid variables with short names like o 3 117
UselessOverridingMethod Overriding method merely calls super 3 131134

fr/paris/lutece/plugins/appointment/modules/resource/business/workflow/SetAppointmentResourceHistoryDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 115128
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 154
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 184

fr/paris/lutece/plugins/appointment/modules/resource/business/workflow/TaskSetAppointmentResourceConfig.java

Rule Violation Priority Ligne
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 7275

fr/paris/lutece/plugins/appointment/modules/resource/business/workflow/TaskSetAppointmentResourceConfigDAO.java

Rule Violation Priority Ligne
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 5971

fr/paris/lutece/plugins/appointment/modules/resource/service/AppointmentResourceAddonService.java

Rule Violation Priority Ligne
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 69
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 85
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 85

fr/paris/lutece/plugins/appointment/modules/resource/service/AppointmentResourceService.java

Rule Violation Priority Ligne
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.appointment.Appointment' 4 36
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.slot.Slot' 4 37
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.service.SlotService' 4 40
AvoidUsingVolatile Use of modifier volatile is not recommended. 2 54
NonThreadSafeSingleton Singleton is not thread safe 3 6366

fr/paris/lutece/plugins/appointment/modules/resource/service/workflow/TaskSetAppointmentResource.java

Rule Violation Priority Ligne
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 88
ConfusingTernary Avoid if (x != y) ..; else ..; 3 104116
ConfusingTernary Avoid if (x != y) ..; else ..; 3 142

fr/paris/lutece/plugins/appointment/modules/resource/web/AppointmentFormResourcesJspBean.java

Rule Violation Priority Ligne
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 139
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 142
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 151
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 192
ConfusingTernary Avoid if (x != y) ..; else ..; 3 198215
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 201
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 213
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 248
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 284
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 294
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 332
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 385
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 426

fr/paris/lutece/plugins/appointment/modules/resource/web/AppointmentResourceJspBean.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34495
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.slot.Slot' 4 52
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.service.SlotService' 4 58
NcssCount The method 'getResourceCalendar(HttpServletRequest, IResource, int, Locale)' has a NCSS line count of 82. 3 261398
CyclomaticComplexity The method 'getResourceCalendar(HttpServletRequest, IResource, int, Locale)' has a cyclomatic complexity of 13. 3 261398
ExcessiveMethodLength Avoid really long methods. 3 261398
NPathComplexity The method 'getResourceCalendar(HttpServletRequest, IResource, int, Locale)' has an NPath complexity of 676 3 261398
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 264
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 264
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 279
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 281
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 281
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 336
EmptyStatementNotInLoop An empty statement (semicolon) not part of a loop 3 355
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 411
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 411
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 3 477

fr/paris/lutece/plugins/appointment/modules/resource/web/AppointmentUserCalendarDashboardComponent.java

Rule Violation Priority Ligne
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 74
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 74

fr/paris/lutece/plugins/appointment/modules/resource/web/workflow/SetAppointmentResourceTaskComponent.java

Rule Violation Priority Ligne
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34361
CyclomaticComplexity The method 'getDisplayConfigForm(HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 10. 3 111174
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 113
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 113
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 128
ConfusingTernary Avoid if (x != y) ..; else ..; 3 143151
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 244
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 244