Fork me on GitHub
Built by Maven

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentFormResourceTypeHome.java

Rule Violation Line
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 49

Priority 2

fr/paris/lutece/plugins/appointment/modules/resource/service/AppointmentResourceService.java

Rule Violation Line
AvoidUsingVolatile Use of modifier volatile is not recommended. 54

Priority 3

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentFormResourceTypeDAO.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 87–101

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentResourceDTO.java

Rule Violation Line
DataClass The class 'AppointmentResourceDTO' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=5) 41–101
CallSuperInConstructor It is a good practice to call super() in a constructor 53–58

fr/paris/lutece/plugins/appointment/modules/resource/business/calendar/CalendarAppointmentResourceDTO.java

Rule Violation Line
ShortVariable Avoid variables with short names like o 249
ShortVariable Avoid variables with short names like o 258
UselessOverridingMethod Overriding method merely calls super 272–275

fr/paris/lutece/plugins/appointment/modules/resource/business/calendar/CalendarDayDTO.java

Rule Violation Line
DataClass The class 'CalendarDayDTO' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=4) 42–135
ShortVariable Avoid variables with short names like o 93
ShortVariable Avoid variables with short names like o 117
UselessOverridingMethod Overriding method merely calls super 131–134

fr/paris/lutece/plugins/appointment/modules/resource/business/form/FormResourceCalendar.java

Rule Violation Line
UncommentedEmptyConstructor Document empty constructor 72–74
CommentRequired Public method and constructor comments are required 97–100
CommentRequired Public method and constructor comments are required 102–105
CommentRequired Public method and constructor comments are required 127–130
CommentRequired Public method and constructor comments are required 132–135

fr/paris/lutece/plugins/appointment/modules/resource/business/workflow/SetAppointmentResourceHistoryDAO.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 114–128

fr/paris/lutece/plugins/appointment/modules/resource/business/workflow/TaskSetAppointmentResourceConfigDAO.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 59–71

fr/paris/lutece/plugins/appointment/modules/resource/service/AppointmentResourceAddonService.java

Rule Violation Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 69
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 85
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 85

fr/paris/lutece/plugins/appointment/modules/resource/service/AppointmentResourceService.java

Rule Violation Line
NonThreadSafeSingleton Singleton is not thread safe 63–66

fr/paris/lutece/plugins/appointment/modules/resource/service/workflow/TaskSetAppointmentResource.java

Rule Violation Line
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 88
ConfusingTernary Avoid if (x != y) ..; else ..; 104–116
ConfusingTernary Avoid if (x != y) ..; else ..; 142

fr/paris/lutece/plugins/appointment/modules/resource/web/AppointmentFormResourcesJspBean.java

Rule Violation Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 140
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 143
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 152
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 193
ConfusingTernary Avoid if (x != y) ..; else ..; 199–216
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 202
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 214
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 249
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 285
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 295
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 333
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 386
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 427

fr/paris/lutece/plugins/appointment/modules/resource/web/AppointmentResourceJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–533
NPathComplexity The method 'getWeekResourceCalendar(IResource, int, Locale)' has an NPath complexity of 676 266–411
NcssCount The method 'getWeekResourceCalendar(IResource, int, Locale)' has a NCSS line count of 83. 266–411
CyclomaticComplexity The method 'getWeekResourceCalendar(IResource, int, Locale)' has a cyclomatic complexity of 13. 266–411
ExcessiveMethodLength Avoid really long methods. 266–411
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 269
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 288
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 450
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 516

fr/paris/lutece/plugins/appointment/modules/resource/web/AppointmentUserCalendarDashboardComponent.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 80

fr/paris/lutece/plugins/appointment/modules/resource/web/workflow/SetAppointmentResourceTaskComponent.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–352
CyclomaticComplexity The method 'getDisplayConfigForm(HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 10. 111–174
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 113
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 128
ConfusingTernary Avoid if (x != y) ..; else ..; 143–151
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 244
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 244

Priority 4

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentFormResourceType.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 148–151
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 169–172

fr/paris/lutece/plugins/appointment/modules/resource/business/workflow/TaskSetAppointmentResourceConfig.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 72–75

fr/paris/lutece/plugins/appointment/modules/resource/service/AppointmentResourceService.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.appointment.Appointment' 36
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.slot.Slot' 37
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.service.SlotService' 40

Files

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentFormResourceType.java

Rule Violation Priority Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 148–151
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 169–172

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentFormResourceTypeDAO.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 87–101

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentFormResourceTypeHome.java

Rule Violation Priority Line
FieldNamingConventions The constant name '_dao' doesn't match '[A-Z][A-Z_0-9]*' 1 49

fr/paris/lutece/plugins/appointment/modules/resource/business/AppointmentResourceDTO.java

Rule Violation Priority Line
DataClass The class 'AppointmentResourceDTO' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=5) 3 41–101
CallSuperInConstructor It is a good practice to call super() in a constructor 3 53–58

fr/paris/lutece/plugins/appointment/modules/resource/business/calendar/CalendarAppointmentResourceDTO.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like o 3 249
ShortVariable Avoid variables with short names like o 3 258
UselessOverridingMethod Overriding method merely calls super 3 272–275

fr/paris/lutece/plugins/appointment/modules/resource/business/calendar/CalendarDayDTO.java

Rule Violation Priority Line
DataClass The class 'CalendarDayDTO' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=4, WMC=4) 3 42–135
ShortVariable Avoid variables with short names like o 3 93
ShortVariable Avoid variables with short names like o 3 117
UselessOverridingMethod Overriding method merely calls super 3 131–134

fr/paris/lutece/plugins/appointment/modules/resource/business/form/FormResourceCalendar.java

Rule Violation Priority Line
UncommentedEmptyConstructor Document empty constructor 3 72–74
CommentRequired Public method and constructor comments are required 3 97–100
CommentRequired Public method and constructor comments are required 3 102–105
CommentRequired Public method and constructor comments are required 3 127–130
CommentRequired Public method and constructor comments are required 3 132–135

fr/paris/lutece/plugins/appointment/modules/resource/business/workflow/SetAppointmentResourceHistoryDAO.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 114–128

fr/paris/lutece/plugins/appointment/modules/resource/business/workflow/TaskSetAppointmentResourceConfig.java

Rule Violation Priority Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 72–75

fr/paris/lutece/plugins/appointment/modules/resource/business/workflow/TaskSetAppointmentResourceConfigDAO.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 59–71

fr/paris/lutece/plugins/appointment/modules/resource/service/AppointmentResourceAddonService.java

Rule Violation Priority Line
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 69
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 85
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 85

fr/paris/lutece/plugins/appointment/modules/resource/service/AppointmentResourceService.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.appointment.Appointment' 4 36
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.business.slot.Slot' 4 37
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.appointment.service.SlotService' 4 40
AvoidUsingVolatile Use of modifier volatile is not recommended. 2 54
NonThreadSafeSingleton Singleton is not thread safe 3 63–66

fr/paris/lutece/plugins/appointment/modules/resource/service/workflow/TaskSetAppointmentResource.java

Rule Violation Priority Line
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 88
ConfusingTernary Avoid if (x != y) ..; else ..; 3 104–116
ConfusingTernary Avoid if (x != y) ..; else ..; 3 142

fr/paris/lutece/plugins/appointment/modules/resource/web/AppointmentFormResourcesJspBean.java

Rule Violation Priority Line
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 140
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 143
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 152
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 193
ConfusingTernary Avoid if (x != y) ..; else ..; 3 199–216
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 202
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 214
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 249
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 285
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 295
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 333
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 386
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 427

fr/paris/lutece/plugins/appointment/modules/resource/web/AppointmentResourceJspBean.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–533
NPathComplexity The method 'getWeekResourceCalendar(IResource, int, Locale)' has an NPath complexity of 676 3 266–411
NcssCount The method 'getWeekResourceCalendar(IResource, int, Locale)' has a NCSS line count of 83. 3 266–411
CyclomaticComplexity The method 'getWeekResourceCalendar(IResource, int, Locale)' has a cyclomatic complexity of 13. 3 266–411
ExcessiveMethodLength Avoid really long methods. 3 266–411
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 269
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 288
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 450
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 3 516

fr/paris/lutece/plugins/appointment/modules/resource/web/AppointmentUserCalendarDashboardComponent.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 80

fr/paris/lutece/plugins/appointment/modules/resource/web/workflow/SetAppointmentResourceTaskComponent.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–352
CyclomaticComplexity The method 'getDisplayConfigForm(HttpServletRequest, Locale, ITask)' has a cyclomatic complexity of 10. 3 111–174
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 113
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 128
ConfusingTernary Avoid if (x != y) ..; else ..; 3 143–151
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 244
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 244