Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/appointment/modules/solrsearchapp/service/SolrQueryService.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 52208

fr/paris/lutece/plugins/appointment/modules/solrsearchapp/service/Utilities.java

Rule Violation Line
ClassNamingConventions The utility class name 'Utilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 47144
FieldNamingConventions The public constant name 'inputFormatter' doesn't match '[A-Z][A-Z_0-9]*' 65
FieldNamingConventions The public constant name 'outputFormatter' doesn't match '[A-Z][A-Z_0-9]*' 67

Priority 3

fr/paris/lutece/plugins/appointment/modules/solrsearchapp/service/SolrQueryService.java

Rule Violation Line
CommentRequired Header comments are required 52208
CommentRequired Public method and constructor comments are required 87178
CyclomaticComplexity The method 'getCommonFilteredQuery(HttpServletRequest, Map, Map)' has a cyclomatic complexity of 13. 87178
NPathComplexity The method 'getCommonFilteredQuery(HttpServletRequest, Map, Map)' has an NPath complexity of 1536 87178
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 116
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 132
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 146
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 204
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 204

fr/paris/lutece/plugins/appointment/modules/solrsearchapp/service/Utilities.java

Rule Violation Line
CommentRequired Header comments are required 47144
CommentRequired Public method and constructor comments are required 94106
ConfusingTernary Avoid if (x != y) ..; else ..; 97105
CommentRequired Public method and constructor comments are required 108117
CommentRequired Public method and constructor comments are required 119128
CommentRequired Public method and constructor comments are required 130142
ConfusingTernary Avoid if (x != y) ..; else ..; 133141

fr/paris/lutece/plugins/appointment/modules/solrsearchapp/web/AppointmentSearchApp.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34536
CommentRequired Header comments are required 81536
TooManyMethods This class has too many methods, consider refactoring it. 82536
UseUnderscoresInNumericLiterals Number 10000000 should separate every third digit with an underscore 86
CyclomaticComplexity The method 'viewSearch(HttpServletRequest)' has a cyclomatic complexity of 11. 157252
NcssCount The method 'viewSearch(HttpServletRequest)' has a NCSS line count of 61. 157252
NPathComplexity The method 'viewSearch(HttpServletRequest)' has an NPath complexity of 576 157252
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 159
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 168
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 353
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 384
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 420
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 450
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 470
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 494
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 506
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 521
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 529

Files

fr/paris/lutece/plugins/appointment/modules/solrsearchapp/service/SolrQueryService.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 52208
CommentRequired Header comments are required 3 52208
CommentRequired Public method and constructor comments are required 3 87178
CyclomaticComplexity The method 'getCommonFilteredQuery(HttpServletRequest, Map, Map)' has a cyclomatic complexity of 13. 3 87178
NPathComplexity The method 'getCommonFilteredQuery(HttpServletRequest, Map, Map)' has an NPath complexity of 1536 3 87178
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 116
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 132
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 146
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 204
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 204

fr/paris/lutece/plugins/appointment/modules/solrsearchapp/service/Utilities.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'Utilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 47144
CommentRequired Header comments are required 3 47144
FieldNamingConventions The public constant name 'inputFormatter' doesn't match '[A-Z][A-Z_0-9]*' 1 65
FieldNamingConventions The public constant name 'outputFormatter' doesn't match '[A-Z][A-Z_0-9]*' 1 67
CommentRequired Public method and constructor comments are required 3 94106
ConfusingTernary Avoid if (x != y) ..; else ..; 3 97105
CommentRequired Public method and constructor comments are required 3 108117
CommentRequired Public method and constructor comments are required 3 119128
CommentRequired Public method and constructor comments are required 3 130142
ConfusingTernary Avoid if (x != y) ..; else ..; 3 133141

fr/paris/lutece/plugins/appointment/modules/solrsearchapp/web/AppointmentSearchApp.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34536
CommentRequired Header comments are required 3 81536
TooManyMethods This class has too many methods, consider refactoring it. 3 82536
UseUnderscoresInNumericLiterals Number 10000000 should separate every third digit with an underscore 3 86
CyclomaticComplexity The method 'viewSearch(HttpServletRequest)' has a cyclomatic complexity of 11. 3 157252
NcssCount The method 'viewSearch(HttpServletRequest)' has a NCSS line count of 61. 3 157252
NPathComplexity The method 'viewSearch(HttpServletRequest)' has an NPath complexity of 576 3 157252
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 159
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 168
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 353
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 384
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 420
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 450
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 470
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 494
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 506
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 521
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 529