Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/appointment/modules/solrsearchapp/service/SolrQueryService.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 51208

fr/paris/lutece/plugins/appointment/modules/solrsearchapp/service/Utilities.java

Rule Violation Line
ClassNamingConventions The utility class name 'Utilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 47144
FieldNamingConventions The public constant name 'inputFormatter' doesn't match '[A-Z][A-Z_0-9]*' 65
FieldNamingConventions The public constant name 'outputFormatter' doesn't match '[A-Z][A-Z_0-9]*' 67

Priority 3

fr/paris/lutece/plugins/appointment/modules/solrsearchapp/service/SolrQueryService.java

Rule Violation Line
CommentRequired Header comments are required 51208
CommentRequired Public method and constructor comments are required 86177
NPathComplexity The method 'getCommonFilteredQuery(HttpServletRequest, Map, Map)' has an NPath complexity of 1536 86177
CyclomaticComplexity The method 'getCommonFilteredQuery(HttpServletRequest, Map, Map)' has a cyclomatic complexity of 13. 86177
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 115
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 131
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 145
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 204
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 204

fr/paris/lutece/plugins/appointment/modules/solrsearchapp/service/Utilities.java

Rule Violation Line
CommentRequired Header comments are required 47144
CommentRequired Public method and constructor comments are required 94106
ConfusingTernary Avoid if (x != y) ..; else ..; 97105
CommentRequired Public method and constructor comments are required 108117
CommentRequired Public method and constructor comments are required 119128
CommentRequired Public method and constructor comments are required 130142
ConfusingTernary Avoid if (x != y) ..; else ..; 133141

fr/paris/lutece/plugins/appointment/modules/solrsearchapp/web/AppointmentSearchApp.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34535
CommentRequired Header comments are required 81535
TooManyMethods This class has too many methods, consider refactoring it. 82535
UseUnderscoresInNumericLiterals Number 10000000 should separate every third digit with an underscore 86
NcssCount The method 'viewSearch(HttpServletRequest)' has a NCSS line count of 61. 156251
NPathComplexity The method 'viewSearch(HttpServletRequest)' has an NPath complexity of 576 156251
CyclomaticComplexity The method 'viewSearch(HttpServletRequest)' has a cyclomatic complexity of 11. 156251
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 158
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 167
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 352
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 383
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 419
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 449
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 469
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 493
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 505
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 520
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 528

Files

fr/paris/lutece/plugins/appointment/modules/solrsearchapp/service/SolrQueryService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 51208
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 51208
CommentRequired Public method and constructor comments are required 3 86177
NPathComplexity The method 'getCommonFilteredQuery(HttpServletRequest, Map, Map)' has an NPath complexity of 1536 3 86177
CyclomaticComplexity The method 'getCommonFilteredQuery(HttpServletRequest, Map, Map)' has a cyclomatic complexity of 13. 3 86177
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 115
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 131
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 145
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 204
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 204

fr/paris/lutece/plugins/appointment/modules/solrsearchapp/service/Utilities.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 47144
ClassNamingConventions The utility class name 'Utilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 47144
FieldNamingConventions The public constant name 'inputFormatter' doesn't match '[A-Z][A-Z_0-9]*' 1 65
FieldNamingConventions The public constant name 'outputFormatter' doesn't match '[A-Z][A-Z_0-9]*' 1 67
CommentRequired Public method and constructor comments are required 3 94106
ConfusingTernary Avoid if (x != y) ..; else ..; 3 97105
CommentRequired Public method and constructor comments are required 3 108117
CommentRequired Public method and constructor comments are required 3 119128
CommentRequired Public method and constructor comments are required 3 130142
ConfusingTernary Avoid if (x != y) ..; else ..; 3 133141

fr/paris/lutece/plugins/appointment/modules/solrsearchapp/web/AppointmentSearchApp.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34535
CommentRequired Header comments are required 3 81535
TooManyMethods This class has too many methods, consider refactoring it. 3 82535
UseUnderscoresInNumericLiterals Number 10000000 should separate every third digit with an underscore 3 86
NcssCount The method 'viewSearch(HttpServletRequest)' has a NCSS line count of 61. 3 156251
NPathComplexity The method 'viewSearch(HttpServletRequest)' has an NPath complexity of 576 3 156251
CyclomaticComplexity The method 'viewSearch(HttpServletRequest)' has a cyclomatic complexity of 11. 3 156251
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 158
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 167
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 352
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 383
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 419
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 449
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 469
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 493
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 505
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 520
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 528