The following document contains the results of PMD 6.13.0.
Rule | Violation | Line |
---|---|---|
ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 51–210 |
Rule | Violation | Line |
---|---|---|
ClassNamingConventions | The utility class name 'Utilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 47–144 |
FieldNamingConventions | The public constant name 'inputFormatter' doesn't match '[A-Z][A-Z_0-9]*' | 65 |
FieldNamingConventions | The public constant name 'outputFormatter' doesn't match '[A-Z][A-Z_0-9]*' | 67 |
Rule | Violation | Line |
---|---|---|
CommentRequired | Header comments are required | 51–210 |
CyclomaticComplexity | The method 'getCommonFilteredQuery(HttpServletRequest, Map, Map)' has a cyclomatic complexity of 13. | 87–179 |
CommentRequired | Public method and constructor comments are required | 87–179 |
NPathComplexity | The method 'getCommonFilteredQuery(HttpServletRequest, Map, Map)' has an NPath complexity of 1536 | 87–179 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 116 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 132 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 146 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 206 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 206 |
Rule | Violation | Line |
---|---|---|
CommentRequired | Header comments are required | 47–144 |
CommentRequired | Public method and constructor comments are required | 94–106 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 97–105 |
CommentRequired | Public method and constructor comments are required | 108–117 |
CommentRequired | Public method and constructor comments are required | 119–128 |
CommentRequired | Public method and constructor comments are required | 130–142 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 133–141 |
Rule | Violation | Line |
---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–535 |
CommentRequired | Header comments are required | 81–535 |
TooManyMethods | This class has too many methods, consider refactoring it. | 82–535 |
UseUnderscoresInNumericLiterals | Number 10000000 should separate every third digit with an underscore | 86 |
NcssCount | The method 'viewSearch(HttpServletRequest)' has a NCSS line count of 61. | 156–251 |
CyclomaticComplexity | The method 'viewSearch(HttpServletRequest)' has a cyclomatic complexity of 11. | 156–251 |
NPathComplexity | The method 'viewSearch(HttpServletRequest)' has an NPath complexity of 576 | 156–251 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 158 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 167 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 352 |
LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 383 |
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 419 |
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 449 |
LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 469 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 493 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 505 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 520 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 528 |
Rule | Violation | Priority | Line |
---|---|---|---|
CommentRequired | Header comments are required | 3 | 51–210 |
ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 51–210 |
CyclomaticComplexity | The method 'getCommonFilteredQuery(HttpServletRequest, Map, Map)' has a cyclomatic complexity of 13. | 3 | 87–179 |
CommentRequired | Public method and constructor comments are required | 3 | 87–179 |
NPathComplexity | The method 'getCommonFilteredQuery(HttpServletRequest, Map, Map)' has an NPath complexity of 1536 | 3 | 87–179 |
AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 116 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 132 |
NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 146 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 206 |
UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 206 |
Rule | Violation | Priority | Line |
---|---|---|---|
ClassNamingConventions | The utility class name 'Utilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 47–144 |
CommentRequired | Header comments are required | 3 | 47–144 |
FieldNamingConventions | The public constant name 'inputFormatter' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 65 |
FieldNamingConventions | The public constant name 'outputFormatter' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 67 |
CommentRequired | Public method and constructor comments are required | 3 | 94–106 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 97–105 |
CommentRequired | Public method and constructor comments are required | 3 | 108–117 |
CommentRequired | Public method and constructor comments are required | 3 | 119–128 |
CommentRequired | Public method and constructor comments are required | 3 | 130–142 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 133–141 |
Rule | Violation | Priority | Line |
---|---|---|---|
ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–535 |
CommentRequired | Header comments are required | 3 | 81–535 |
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 82–535 |
UseUnderscoresInNumericLiterals | Number 10000000 should separate every third digit with an underscore | 3 | 86 |
NcssCount | The method 'viewSearch(HttpServletRequest)' has a NCSS line count of 61. | 3 | 156–251 |
CyclomaticComplexity | The method 'viewSearch(HttpServletRequest)' has a cyclomatic complexity of 11. | 3 | 156–251 |
NPathComplexity | The method 'viewSearch(HttpServletRequest)' has an NPath complexity of 576 | 3 | 156–251 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 158 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 167 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 352 |
LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 383 |
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 419 |
UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 449 |
LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 469 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 493 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 505 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 520 |
UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 528 |