Fork me on GitHub

PMD Results

The following document contains the results of PMD 5.5.1.

Files

fr/paris/lutece/plugins/genericalert/business/ITaskNotifyReminderConfigDAO.java

Violation Line
Avoid variables with short names like b 116

fr/paris/lutece/plugins/genericalert/business/TaskNotifyReminderConfigDAO.java

Violation Line
These nested if statements could be combined 8790
Avoid variables with short names like b 229
Assigning an Object to null is a code smell. Consider refactoring. 504

fr/paris/lutece/plugins/genericalert/daemon/AppointmentReminderDaemon.java

Violation Line
Private field '_taskReminder' could be made final; it is only initialized in the declaration or constructor. 62
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 102

fr/paris/lutece/plugins/genericalert/service/NotifyReminderPlugin.java

Violation Line
Document empty method 5557

fr/paris/lutece/plugins/genericalert/service/TaskNotifyReminder.java

Violation Line
Possible God class (WMC=51, ATFD=97, TCC=0.0) 34457
A high number of imports can indicate a high degree of coupling within an object. 34457
The class 'TaskNotifyReminder' has a Cyclomatic Complexity of 7 (Highest = 19). 102457
The class 'TaskNotifyReminder' has a Standard Cyclomatic Complexity of 5 (Highest = 11). 102457
The class 'TaskNotifyReminder' has a Modified Cyclomatic Complexity of 5 (Highest = 11). 102457
Use explicit scoping instead of the default package private level 140
The method 'sendReminder' has a Cyclomatic Complexity of 16. 149208
The method sendReminder() has an NPath complexity of 205 149208
The method 'sendReminder' has a Standard Cyclomatic Complexity of 11. 149208
The method 'sendReminder' has a Modified Cyclomatic Complexity of 11. 149208
Deeply nested if..then statements are hard to read 183205
The method sendReminder() has an NPath complexity of 652 225305
The method 'sendReminder' has a Modified Cyclomatic Complexity of 11. 225305
The method 'sendReminder' has a Standard Cyclomatic Complexity of 11. 225305
The method 'sendReminder' has a Cyclomatic Complexity of 19. 225305
Avoid unused method parameters such as 'startAppointment'. 225
Avoid unused method parameters such as 'strResourceType'. 226
Avoid unused method parameters such as 'nIdAction'. 226
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 262
Deeply nested if..then statements are hard to read 273287
Prefer StringBuffer over += for concatenating strings 277
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 282
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 297
The method 'getSmsFromAppointment' has a Cyclomatic Complexity of 10. 316359

fr/paris/lutece/plugins/genericalert/service/TaskNotifyReminderConfigService.java

Violation Line
Document empty method 6163
Document empty method 6769
Document empty method 7981
Document empty method 8587

fr/paris/lutece/plugins/genericalert/web/NotifyReminderTaskComponent.java

Violation Line
Possible God class (WMC=68, ATFD=105, TCC=0.047619047619047616) 34433
A high number of imports can indicate a high degree of coupling within an object. 34433
The class 'NotifyReminderTaskComponent' has a Cyclomatic Complexity of 10 (Highest = 54). 81433
The class 'NotifyReminderTaskComponent' has a Standard Cyclomatic Complexity of 7 (Highest = 35). 81433
The class 'NotifyReminderTaskComponent' has a Modified Cyclomatic Complexity of 7 (Highest = 35). 81433
The method getDisplayConfigForm() has an NPath complexity of 240 143197
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 184
The method 'doSaveConfig' has a Modified Cyclomatic Complexity of 35. 203382
The method 'doSaveConfig' has a Standard Cyclomatic Complexity of 35. 203382
Avoid really long methods. 203382
The method 'doSaveConfig' has a Cyclomatic Complexity of 54. 203382
Avoid declaring a variable if it is unreferenced before a possible exit point. 207
Avoid declaring a variable if it is unreferenced before a possible exit point. 208
Avoid declaring a variable if it is unreferenced before a possible exit point. 210
Avoid declaring a variable if it is unreferenced before a possible exit point. 212
Avoid declaring a variable if it is unreferenced before a possible exit point. 268
Avoid declaring a variable if it is unreferenced before a possible exit point. 270
Avoid declaring a variable if it is unreferenced before a possible exit point. 271
Avoid declaring a variable if it is unreferenced before a possible exit point. 272273
Avoid declaring a variable if it is unreferenced before a possible exit point. 274275
Avoid declaring a variable if it is unreferenced before a possible exit point. 276277
Avoid declaring a variable if it is unreferenced before a possible exit point. 278279
Avoid declaring a variable if it is unreferenced before a possible exit point. 280
Avoid declaring a variable if it is unreferenced before a possible exit point. 281282
These nested if statements could be combined 286289
These nested if statements could be combined 293296
These nested if statements could be combined 300303
These nested if statements could be combined 307310
These nested if statements could be combined 315318
These nested if statements could be combined 323326
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 360
These nested if statements could be combined 406409