Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/cartography/modules/solr/business/TemporaryFileExtract.java

Rule Violation Line
FieldNamingConventions The field name 'content' doesn't match '_[a-z][a-zA-Z0-9]*' 25

fr/paris/lutece/plugins/cartography/modules/solr/web/ExportDataLayerJspBean.java

Rule Violation Line
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 234

Priority 2

fr/paris/lutece/plugins/cartography/modules/solr/web/ExportDataLayerJspBean.java

Rule Violation Line
StringInstantiation Avoid instantiating String objects; this is usually unnecessary. 144

Priority 3

fr/paris/lutece/plugins/cartography/modules/solr/business/TemporaryFileExtract.java

Rule Violation Line
CommentRequired Header comments are required 1055
UnusedPrivateField Avoid unused private fields such as 'FLUSH_SIZE'. 14
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 25
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'extractFile' 31

fr/paris/lutece/plugins/cartography/modules/solr/indexer/SolrCoordinateIndexer.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_PAGE_ID'. 69
UnusedPrivateField Avoid unused private fields such as 'TYPE'. 72
UnusedPrivateField Avoid unused private fields such as 'CATEGORIE'. 73
UnusedPrivateField Avoid unused private fields such as 'BEAN_PAGE_SERVICE'. 75
MissingOverride The method 'indexDocuments()' is missing an @Override annotation. 91123
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 105
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 116
UnusedFormalParameter Avoid unused method parameters such as 'strUrl'. 137
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 222
ShortVariable Avoid variables with short names like sb 245

fr/paris/lutece/plugins/cartography/modules/solr/provider/CartoSolrMarkerProvider.java

Rule Violation Line
CommentRequired Header comments are required 59197
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 84
UnusedLocalVariable Avoid unused local variables such as 'searchResults'. 84
AvoidDuplicateLiterals The String literal "uid" appears 5 times in this file; the first occurrence is on line 89 89
ControlStatementBraces This statement should have braces 116
UnusedLocalVariable Avoid unused local variables such as 'listResults'. 143
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 143
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 162
UnusedLocalVariable Avoid unused local variables such as 'listMarkers'. 164
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 164
UnusedLocalVariable Avoid unused local variables such as 'lstfield'. 172
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 172

fr/paris/lutece/plugins/cartography/modules/solr/service/CartoSolrAppAddon.java

Rule Violation Line
CommentRequired Header comments are required 4462

fr/paris/lutece/plugins/cartography/modules/solr/service/CartographyService.java

Rule Violation Line
CommentRequired Header comments are required 68322
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 69322
CyclomaticComplexity The method 'getGeolocModel(List, DataLayer, DataLayerMapTemplate)' has a cyclomatic complexity of 11. 99181
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 103
ShortVariable Avoid variables with short names like h 118
ConfusingTernary Avoid if (x != y) ..; else ..; 155164
CommentRequired Public method and constructor comments are required 183198
ShortVariable Avoid variables with short names like h 189
CommentRequired Public method and constructor comments are required 201228
ConfusingTernary Avoid if (x != y) ..; else ..; 213224
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 223
ShortVariable Avoid variables with short names like x 240
ShortVariable Avoid variables with short names like y 240
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 297

fr/paris/lutece/plugins/cartography/modules/solr/web/AbstractManageCartoJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 49117
DefaultPackage Use explicit scoping instead of the default package private level 116
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 116

fr/paris/lutece/plugins/cartography/modules/solr/web/CoordinateXPage.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34523
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 91523
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_SOLR_GEOJSON'. 100
UnusedPrivateField Avoid unused private fields such as 'MARK_COORDONNEE_LIST'. 104
UnusedPrivateField Avoid unused private fields such as 'INFO_COORDONNEE_CREATED'. 123
UnusedPrivateField Avoid unused private fields such as 'MARK_POINTS'. 130
UnusedPrivateField Avoid unused private fields such as 'MARK_DATA_LAYER'. 136
UnusedPrivateField Avoid unused private fields such as 'MARK_LAYER_EDITABLE'. 137
UnusedPrivateField Avoid unused private fields such as 'MARK_MAP'. 138
UnusedPrivateField Avoid unused private fields such as 'MARK_BASEMAP'. 142
RedundantFieldInitializer Avoid using redundant field initializer for '_idMap' 146
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 158
UnusedPrivateMethod Avoid unused private methods such as 'getGeolocModel(List)'. 179
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 182
ShortVariable Avoid variables with short names like h 194
UnusedPrivateMethod Avoid unused private methods such as 'getGeolocModel(List,DataLayer,DataLayerMapTemplate)'. 243244
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 247
UnusedLocalVariable Avoid unused local variables such as 'iconKeysCache'. 247
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 247
ShortVariable Avoid variables with short names like h 259
ConfusingTernary Avoid if (x != y) ..; else ..; 292
CyclomaticComplexity The method 'doCreateCoordonnee(HttpServletRequest)' has a cyclomatic complexity of 12. 310369
ShortVariable Avoid variables with short names like x 327
ShortVariable Avoid variables with short names like y 328

fr/paris/lutece/plugins/cartography/modules/solr/web/ExportDataLayerJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 35326
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 98326
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 143
ConfusingTernary Avoid if (x != y) ..; else ..; 144
DefaultPackage Use explicit scoping instead of the default package private level 165172
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 166172
ConfusingTernary Avoid if (x != y) ..; else ..; 192
CommentRequired Public method and constructor comments are required 219289
ControlStatementBraces This statement should have braces 248
ControlStatementBraces This statement should have braces 250
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 285
ShortVariable Avoid variables with short names like h 314
UnusedLocalVariable Avoid unused local variables such as 'h'. 314

Priority 4

fr/paris/lutece/plugins/cartography/modules/solr/business/TemporaryFileExtract.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPropertiesService' 6

fr/paris/lutece/plugins/cartography/modules/solr/indexer/SolrCoordinateIndexer.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.xml.sax.ContentHandler' 39
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.search.solr.util.LuteceSolrException' 47
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.search.solr.util.TikaIndexerUtil' 50
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.business.page.Page' 51
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.business.page.PageHome' 52
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.page.IPageService' 54
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.spring.SpringContextService' 55
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppException' 56
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.url.UrlItem' 59

fr/paris/lutece/plugins/cartography/modules/solr/web/CoordinateXPage.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.carto.business.BasemapHome' 36
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.carto.business.DataLayerMapTemplateHome' 42
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.carto.business.IDataLayerDAO' 45
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.search.solr.business.SolrFacetedResult' 52
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.search.solr.business.SolrSearchAppConf' 53
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.search.solr.business.SolrSearchEngine' 54
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.search.solr.service.SolrSearchAppConfService' 58
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.search.solr.web.SolrIndexerJspBean' 59
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.business.state.State' 60
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.spring.SpringContextService' 71

fr/paris/lutece/plugins/cartography/modules/solr/web/ExportDataLayerJspBean.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessage' 37
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessageService' 38
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.business.file.File' 40
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.business.file.FileHome' 41
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.business.physicalfile.PhysicalFile' 42
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.file.FileService' 44
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.file.IFileStoreServiceProvider' 45
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppException' 46
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' 47
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPropertiesService' 48
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.url.UrlItem' 52
UnusedImports Avoid unused imports such as 'java.nio.file.Files' 59
UnusedImports Avoid unused imports such as 'java.util.Optional' 63
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' 68
UnusedImports Avoid unused imports such as 'com.fasterxml.jackson.core.JsonProcessingException' 70
UnusedImports Avoid unused imports such as 'com.fasterxml.jackson.databind.JsonMappingException' 71
UnusedImports Avoid unused imports such as 'com.fasterxml.jackson.databind.JsonNode' 72
UnusedImports Avoid unused imports such as 'com.fasterxml.jackson.databind.ObjectMapper' 73
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.carto.business.DataLayerMapTemplate' 79
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.carto.business.DataLayerMapTemplateHome' 80
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.carto.business.DataLayerType' 81
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.carto.business.DataLayerTypeHome' 82
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.cartography.modules.solr.service.CartographyService' 84
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.filegenerator.business.TemporaryFile' 85
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.leaflet.business.GeolocItem' 87
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.leaflet.business.GeolocItemPolygon' 88
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.leaflet.service.IconService' 89

Files

fr/paris/lutece/plugins/cartography/modules/solr/business/TemporaryFileExtract.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPropertiesService' 4 6
CommentRequired Header comments are required 3 1055
UnusedPrivateField Avoid unused private fields such as 'FLUSH_SIZE'. 3 14
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 25
FieldNamingConventions The field name 'content' doesn't match '_[a-z][a-zA-Z0-9]*' 1 25
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'extractFile' 3 31

fr/paris/lutece/plugins/cartography/modules/solr/indexer/SolrCoordinateIndexer.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.xml.sax.ContentHandler' 4 39
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.search.solr.util.LuteceSolrException' 4 47
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.search.solr.util.TikaIndexerUtil' 4 50
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.business.page.Page' 4 51
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.business.page.PageHome' 4 52
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.page.IPageService' 4 54
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.spring.SpringContextService' 4 55
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppException' 4 56
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.url.UrlItem' 4 59
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_PAGE_ID'. 3 69
UnusedPrivateField Avoid unused private fields such as 'TYPE'. 3 72
UnusedPrivateField Avoid unused private fields such as 'CATEGORIE'. 3 73
UnusedPrivateField Avoid unused private fields such as 'BEAN_PAGE_SERVICE'. 3 75
MissingOverride The method 'indexDocuments()' is missing an @Override annotation. 3 91123
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 105
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 116
UnusedFormalParameter Avoid unused method parameters such as 'strUrl'. 3 137
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 222
ShortVariable Avoid variables with short names like sb 3 245

fr/paris/lutece/plugins/cartography/modules/solr/provider/CartoSolrMarkerProvider.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 59197
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 84
UnusedLocalVariable Avoid unused local variables such as 'searchResults'. 3 84
AvoidDuplicateLiterals The String literal "uid" appears 5 times in this file; the first occurrence is on line 89 3 89
ControlStatementBraces This statement should have braces 3 116
UnusedLocalVariable Avoid unused local variables such as 'listResults'. 3 143
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 143
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 162
UnusedLocalVariable Avoid unused local variables such as 'listMarkers'. 3 164
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 164
UnusedLocalVariable Avoid unused local variables such as 'lstfield'. 3 172
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 172

fr/paris/lutece/plugins/cartography/modules/solr/service/CartoSolrAppAddon.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4462

fr/paris/lutece/plugins/cartography/modules/solr/service/CartographyService.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 68322
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 69322
CyclomaticComplexity The method 'getGeolocModel(List, DataLayer, DataLayerMapTemplate)' has a cyclomatic complexity of 11. 3 99181
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 103
ShortVariable Avoid variables with short names like h 3 118
ConfusingTernary Avoid if (x != y) ..; else ..; 3 155164
CommentRequired Public method and constructor comments are required 3 183198
ShortVariable Avoid variables with short names like h 3 189
CommentRequired Public method and constructor comments are required 3 201228
ConfusingTernary Avoid if (x != y) ..; else ..; 3 213224
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 223
ShortVariable Avoid variables with short names like x 3 240
ShortVariable Avoid variables with short names like y 3 240
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 297

fr/paris/lutece/plugins/cartography/modules/solr/web/AbstractManageCartoJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 49117
DefaultPackage Use explicit scoping instead of the default package private level 3 116
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 116

fr/paris/lutece/plugins/cartography/modules/solr/web/CoordinateXPage.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34523
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.carto.business.BasemapHome' 4 36
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.carto.business.DataLayerMapTemplateHome' 4 42
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.carto.business.IDataLayerDAO' 4 45
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.search.solr.business.SolrFacetedResult' 4 52
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.search.solr.business.SolrSearchAppConf' 4 53
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.search.solr.business.SolrSearchEngine' 4 54
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.search.solr.service.SolrSearchAppConfService' 4 58
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.search.solr.web.SolrIndexerJspBean' 4 59
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.business.state.State' 4 60
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.spring.SpringContextService' 4 71
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 91523
UnusedPrivateField Avoid unused private fields such as 'PARAMETER_SOLR_GEOJSON'. 3 100
UnusedPrivateField Avoid unused private fields such as 'MARK_COORDONNEE_LIST'. 3 104
UnusedPrivateField Avoid unused private fields such as 'INFO_COORDONNEE_CREATED'. 3 123
UnusedPrivateField Avoid unused private fields such as 'MARK_POINTS'. 3 130
UnusedPrivateField Avoid unused private fields such as 'MARK_DATA_LAYER'. 3 136
UnusedPrivateField Avoid unused private fields such as 'MARK_LAYER_EDITABLE'. 3 137
UnusedPrivateField Avoid unused private fields such as 'MARK_MAP'. 3 138
UnusedPrivateField Avoid unused private fields such as 'MARK_BASEMAP'. 3 142
RedundantFieldInitializer Avoid using redundant field initializer for '_idMap' 3 146
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 158
UnusedPrivateMethod Avoid unused private methods such as 'getGeolocModel(List)'. 3 179
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 182
ShortVariable Avoid variables with short names like h 3 194
UnusedPrivateMethod Avoid unused private methods such as 'getGeolocModel(List,DataLayer,DataLayerMapTemplate)'. 3 243244
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 247
UnusedLocalVariable Avoid unused local variables such as 'iconKeysCache'. 3 247
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 247
ShortVariable Avoid variables with short names like h 3 259
ConfusingTernary Avoid if (x != y) ..; else ..; 3 292
CyclomaticComplexity The method 'doCreateCoordonnee(HttpServletRequest)' has a cyclomatic complexity of 12. 3 310369
ShortVariable Avoid variables with short names like x 3 327
ShortVariable Avoid variables with short names like y 3 328

fr/paris/lutece/plugins/cartography/modules/solr/web/ExportDataLayerJspBean.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 35326
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessage' 4 37
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.message.AdminMessageService' 4 38
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.business.file.File' 4 40
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.business.file.FileHome' 4 41
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.business.physicalfile.PhysicalFile' 4 42
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.file.FileService' 4 44
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.file.IFileStoreServiceProvider' 4 45
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppException' 4 46
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' 4 47
UnusedImports Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPropertiesService' 4 48
UnusedImports Avoid unused imports such as 'fr.paris.lutece.util.url.UrlItem' 4 52
UnusedImports Avoid unused imports such as 'java.nio.file.Files' 4 59
UnusedImports Avoid unused imports such as 'java.util.Optional' 4 63
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' 4 68
UnusedImports Avoid unused imports such as 'com.fasterxml.jackson.core.JsonProcessingException' 4 70
UnusedImports Avoid unused imports such as 'com.fasterxml.jackson.databind.JsonMappingException' 4 71
UnusedImports Avoid unused imports such as 'com.fasterxml.jackson.databind.JsonNode' 4 72
UnusedImports Avoid unused imports such as 'com.fasterxml.jackson.databind.ObjectMapper' 4 73
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.carto.business.DataLayerMapTemplate' 4 79
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.carto.business.DataLayerMapTemplateHome' 4 80
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.carto.business.DataLayerType' 4 81
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.carto.business.DataLayerTypeHome' 4 82
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.cartography.modules.solr.service.CartographyService' 4 84
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.filegenerator.business.TemporaryFile' 4 85
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.leaflet.business.GeolocItem' 4 87
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.leaflet.business.GeolocItemPolygon' 4 88
UnusedImports Avoid unused imports such as 'fr.paris.lutece.plugins.leaflet.service.IconService' 4 89
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 98326
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 143
ConfusingTernary Avoid if (x != y) ..; else ..; 3 144
StringInstantiation Avoid instantiating String objects; this is usually unnecessary. 2 144
DefaultPackage Use explicit scoping instead of the default package private level 3 165172
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 166172
ConfusingTernary Avoid if (x != y) ..; else ..; 3 192
CommentRequired Public method and constructor comments are required 3 219289
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 234
ControlStatementBraces This statement should have braces 3 248
ControlStatementBraces This statement should have braces 3 250
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 3 285
ShortVariable Avoid variables with short names like h 3 314
UnusedLocalVariable Avoid unused local variables such as 'h'. 3 314