Lutece crm form module – Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle 6.11.2 with build-config/lutece_checks.xml ruleset.

Summary

Files	Info	Warnings	Errors
9	0	0	90

Files

File	I	W	E
fr/paris/lutece/plugins/crm/modules/form/business/CRMLocalParameters.java	0	0	14
fr/paris/lutece/plugins/crm/modules/form/service/CRMFormPlugin.java	0	0	1
fr/paris/lutece/plugins/crm/modules/form/service/CRMParametersService.java	0	0	53
fr/paris/lutece/plugins/crm/modules/form/service/ICRMParametersService.java	0	0	6
fr/paris/lutece/plugins/crm/modules/form/service/draft/CRMDraftBackupService.java	0	0	7
fr/paris/lutece/plugins/crm/modules/form/util/Constants.java	0	0	2
fr/paris/lutece/plugins/crm/modules/form/util/JSONUtils.java	0	0	7

Rules

Category	Rule	Violations	Severity
blocks	LeftCurly option: `"nl"`	10	Error
coding	DeclarationOrder	1	Error
	NestedIfDepth max: `"3"`	2	Error
header	Header fileExtensions: `"java"` headerFile: `"/opt/data/jenkins/home/jobs/gru-module-crm-form-doc-QA/workspace/target/checkstyle-header.txt"`	7	Error
javadoc	JavadocMethod	6	Error
	JavadocType	1	Error
whitespace	ParenPad option: `"space"`	42	Error
	WhitespaceAround tokens: `"ASSIGN,EQUAL"`	21	Error

Details

fr/paris/lutece/plugins/crm/modules/form/business/CRMLocalParameters.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of '/*'.	1
Error	blocks	LeftCurly	'{' at column 33 should be on a new line.	8
Error	blocks	LeftCurly	'{' at column 28 should be on a new line.	19
Error	whitespace	ParenPad	'(' is not followed by whitespace.	26
Error	whitespace	ParenPad	')' is not preceded with whitespace.	26
Error	blocks	LeftCurly	'{' at column 43 should be on a new line.	26
Error	blocks	LeftCurly	'{' at column 35 should be on a new line.	33
Error	whitespace	ParenPad	'(' is not followed by whitespace.	40
Error	whitespace	ParenPad	')' is not preceded with whitespace.	40
Error	blocks	LeftCurly	'{' at column 56 should be on a new line.	40
Error	blocks	LeftCurly	'{' at column 35 should be on a new line.	47
Error	whitespace	ParenPad	'(' is not followed by whitespace.	54
Error	whitespace	ParenPad	')' is not preceded with whitespace.	54
Error	blocks	LeftCurly	'{' at column 56 should be on a new line.	54

fr/paris/lutece/plugins/crm/modules/form/service/CRMFormPlugin.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2016, Mairie de Paris'.	2

fr/paris/lutece/plugins/crm/modules/form/service/CRMParametersService.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of '/*'.	1
Error	blocks	LeftCurly	'{' at column 68 should be on a new line.	21
Error	coding	DeclarationOrder	Static variable definition in wrong order.	25
Error	whitespace	WhitespaceAround	'=' is not preceded with whitespace.	25
Error	whitespace	WhitespaceAround	'=' is not followed by whitespace.	25
Error	whitespace	ParenPad	'(' is not followed by whitespace.	33
Error	whitespace	WhitespaceAround	'=' is not preceded with whitespace.	36
Error	whitespace	WhitespaceAround	'=' is not followed by whitespace.	36
Error	whitespace	ParenPad	'(' is not followed by whitespace.	38
Error	whitespace	ParenPad	')' is not preceded with whitespace.	38
Error	whitespace	WhitespaceAround	'=' is not followed by whitespace.	40
Error	whitespace	ParenPad	'(' is not followed by whitespace.	43
Error	whitespace	ParenPad	'(' is not followed by whitespace.	43
Error	whitespace	ParenPad	')' is not preceded with whitespace.	43
Error	whitespace	ParenPad	')' is not preceded with whitespace.	43
Error	whitespace	ParenPad	')' is not preceded with whitespace.	43
Error	whitespace	WhitespaceAround	'=' is not preceded with whitespace.	45
Error	whitespace	WhitespaceAround	'=' is not followed by whitespace.	45
Error	whitespace	ParenPad	'(' is not followed by whitespace.	45
Error	whitespace	ParenPad	'(' is not followed by whitespace.	45
Error	whitespace	ParenPad	')' is not preceded with whitespace.	45
Error	whitespace	ParenPad	')' is not preceded with whitespace.	45
Error	whitespace	WhitespaceAround	'=' is not preceded with whitespace.	46
Error	whitespace	WhitespaceAround	'=' is not followed by whitespace.	46
Error	whitespace	ParenPad	'(' is not followed by whitespace.	58
Error	whitespace	WhitespaceAround	'=' is not preceded with whitespace.	62
Error	whitespace	WhitespaceAround	'=' is not followed by whitespace.	62
Error	whitespace	ParenPad	'(' is not followed by whitespace.	63
Error	whitespace	ParenPad	')' is not preceded with whitespace.	63
Error	whitespace	WhitespaceAround	'=' is not preceded with whitespace.	65
Error	whitespace	ParenPad	'(' is not followed by whitespace.	68
Error	whitespace	ParenPad	'(' is not followed by whitespace.	68
Error	whitespace	ParenPad	')' is not preceded with whitespace.	68
Error	whitespace	ParenPad	')' is not preceded with whitespace.	68
Error	whitespace	ParenPad	')' is not preceded with whitespace.	68
Error	whitespace	WhitespaceAround	'=' is not preceded with whitespace.	70
Error	whitespace	WhitespaceAround	'=' is not followed by whitespace.	70
Error	whitespace	ParenPad	'(' is not followed by whitespace.	70
Error	whitespace	ParenPad	'(' is not followed by whitespace.	70
Error	whitespace	ParenPad	')' is not preceded with whitespace.	70
Error	whitespace	ParenPad	')' is not preceded with whitespace.	70
Error	whitespace	WhitespaceAround	'=' is not preceded with whitespace.	72
Error	whitespace	WhitespaceAround	'=' is not followed by whitespace.	72
Error	whitespace	WhitespaceAround	'=' is not preceded with whitespace.	98
Error	whitespace	WhitespaceAround	'=' is not followed by whitespace.	98
Error	whitespace	ParenPad	'(' is not followed by whitespace.	98
Error	whitespace	ParenPad	')' is not preceded with whitespace.	98
Error	whitespace	WhitespaceAround	'=' is not preceded with whitespace.	99
Error	whitespace	WhitespaceAround	'=' is not followed by whitespace.	99
Error	whitespace	ParenPad	'(' is not followed by whitespace.	101
Error	whitespace	ParenPad	')' is not preceded with whitespace.	101
Error	whitespace	ParenPad	'(' is not followed by whitespace.	103
Error	whitespace	ParenPad	')' is not preceded with whitespace.	105

fr/paris/lutece/plugins/crm/modules/form/service/ICRMParametersService.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of '/*'.	1
Error	blocks	LeftCurly	'{' at column 40 should be on a new line.	12
Error	whitespace	ParenPad	'(' is not followed by whitespace.	20
Error	whitespace	ParenPad	')' is not preceded with whitespace.	20
Error	whitespace	ParenPad	'(' is not followed by whitespace.	27
Error	whitespace	ParenPad	')' is not preceded with whitespace.	27

fr/paris/lutece/plugins/crm/modules/form/service/draft/CRMDraftBackupService.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2016, Mairie de Paris'.	2
Error	whitespace	ParenPad	')' is not preceded with whitespace.	331
Error	coding	NestedIfDepth	Nested if-else depth is 4 (max allowed is 3).	515
Error	coding	NestedIfDepth	Nested if-else depth is 4 (max allowed is 3).	527
Error	javadoc	JavadocMethod	Expected @param tag for 'form'.	726
Error	javadoc	JavadocMethod	Unused @param tag for '_crmParametersService'.	818
Error	javadoc	JavadocMethod	Expected @param tag for 'crmParametersService'.	820

fr/paris/lutece/plugins/crm/modules/form/util/Constants.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of ' * Copyright (c) 2002-2016, Mairie de Paris'.	2
Error	whitespace	WhitespaceAround	'=' is not preceded with whitespace.	67

fr/paris/lutece/plugins/crm/modules/form/util/JSONUtils.java

Severity	Category	Rule	Message	Line
Error	header	Header	Line does not match expected header line of '/*'.	1
Error	javadoc	JavadocType	Missing a Javadoc comment.	37
Error	blocks	LeftCurly	'{' at column 30 should be on a new line.	37
Error	whitespace	ParenPad	')' is not preceded with whitespace.	78
Error	javadoc	JavadocMethod	Unused @param tag for 'strJSONFields'.	232
Error	javadoc	JavadocMethod	Unused @param tag for 'field'.	233
Error	javadoc	JavadocMethod	Expected @param tag for 'json'.	236