The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'CrmNotifyGruConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 36–64 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_logger' doesn't match '[a-z][a-zA-Z0-9]*' | 83 |
| FieldNamingConventions | The final field name 'CHARECTER_REGEXP_FILTER' doesn't match '[a-z][a-zA-Z0-9]*' | 84 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 83 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 132 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–64 |
| ShortVariable | Avoid variables with short names like ID | 44 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–385 |
| CommentRequired | Header comments are required | 81–385 |
| FinalFieldCouldBeStatic | This final field could be made static | 84 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 141 |
| CyclomaticComplexity | The method 'store(fr.paris.lutece.plugins.grubusiness.business.notification.Notification, Locale)' has a cyclomatic complexity of 20. | 154–272 |
| NPathComplexity | The method 'store(fr.paris.lutece.plugins.grubusiness.business.notification.Notification, Locale)' has an NPath complexity of 2976 | 154–272 |
| ExcessiveMethodLength | Avoid really long methods. | 154–272 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 156 |
| UnusedLocalVariable | Avoid unused local variables such as 'jsonResponse'. | 156 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 193–263 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 236–247 |
| UseNotifyAllInsteadOfNotify | Call Thread.notifyAll() rather than Thread.notify() | 268 |
| ShortVariable | Avoid variables with short names like ex | 343 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 345–352 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'com.fasterxml.jackson.core.JsonParseException' | 37 |
| UnusedImports | Avoid unused imports such as 'com.fasterxml.jackson.databind.JsonMappingException' | 40 |
| UnusedImports | Avoid unused imports such as 'java.io.IOException' | 61 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 36–64 |
| ClassNamingConventions | The utility class name 'CrmNotifyGruConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 36–64 |
| ShortVariable | Avoid variables with short names like ID | 3 | 44 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–385 |
| UnusedImports | Avoid unused imports such as 'com.fasterxml.jackson.core.JsonParseException' | 4 | 37 |
| UnusedImports | Avoid unused imports such as 'com.fasterxml.jackson.databind.JsonMappingException' | 4 | 40 |
| UnusedImports | Avoid unused imports such as 'java.io.IOException' | 4 | 61 |
| CommentRequired | Header comments are required | 3 | 81–385 |
| FieldNamingConventions | The final field name '_logger' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 83 |
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 2 | 83 |
| FinalFieldCouldBeStatic | This final field could be made static | 3 | 84 |
| FieldNamingConventions | The final field name 'CHARECTER_REGEXP_FILTER' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 84 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 132 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 141 |
| CyclomaticComplexity | The method 'store(fr.paris.lutece.plugins.grubusiness.business.notification.Notification, Locale)' has a cyclomatic complexity of 20. | 3 | 154–272 |
| NPathComplexity | The method 'store(fr.paris.lutece.plugins.grubusiness.business.notification.Notification, Locale)' has an NPath complexity of 2976 | 3 | 154–272 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 154–272 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 156 |
| UnusedLocalVariable | Avoid unused local variables such as 'jsonResponse'. | 3 | 156 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 193–263 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 236–247 |
| UseNotifyAllInsteadOfNotify | Call Thread.notifyAll() rather than Thread.notify() | 3 | 268 |
| ShortVariable | Avoid variables with short names like ex | 3 | 343 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 345–352 |
