Fork me on GitHub

PMD Results

The following document contains the results of PMD 5.5.1.

Files

fr/paris/lutece/plugins/crm/modules/rest/rs/CRMDemandTypeRest.java

Violation Line
Private field '_objectMapper' could be made final; it is only initialized in the declaration or constructor. 56

fr/paris/lutece/plugins/crm/modules/rest/rs/CRMNotificationRest.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 34349
Rather than using a lot of String arguments, consider using a container object for those values. 99102
Rather than using a lot of String arguments, consider using a container object for those values. 167172
Avoid declaring a variable if it is unreferenced before a possible exit point. 316
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 323

fr/paris/lutece/plugins/crm/modules/rest/rs/CRMRest.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 34873
Possible God class (WMC=74, ATFD=276, TCC=0.0) 34873
The class 'CRMRest' has a Cyclomatic Complexity of 5 (Highest = 11). 84873
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 107
Avoid variables with short names like t 110
Rather than using a lot of String arguments, consider using a container object for those values. 136140
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 156
Rather than using a lot of String arguments, consider using a container object for those values. 197203
The method 'doCreateDemandByUserGuidV2' has a Cyclomatic Complexity of 11. 197268
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 221
Rather than using a lot of String arguments, consider using a container object for those values. 291295
The method 'doCreateDemandByIdCRMUser' has a Cyclomatic Complexity of 10. 291343
Rather than using a lot of String arguments, consider using a container object for those values. 364367
Rather than using a lot of String arguments, consider using a container object for those values. 432437
The method 'doUpdateDemandV2' has a Cyclomatic Complexity of 10. 432487

fr/paris/lutece/plugins/crm/modules/rest/util/StringUtil.java

Violation Line
Prefer StringBuffer over += for concatenating strings 71
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 81