Fork me on GitHub

PMD Results

The following document contains the results of PMD 5.3.5.

Files

fr/paris/lutece/plugins/directory/modules/rest/rs/DirectoryRest.java

Violation Line
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 112
Avoid variables with short names like t 115
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 154
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 181
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 256
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 300
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 336
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 380
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 408

fr/paris/lutece/plugins/directory/modules/rest/service/DirectoryRestService.java

Violation Line
Possible God class (WMC=89, ATFD=117, TCC=0.008658008658008658) 34770
A high number of imports can indicate a high degree of coupling within an object. 34770
Deeply nested if..then statements are hard to read 183186
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 300
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 360
These nested if statements could be combined 576579
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 755

fr/paris/lutece/plugins/directory/modules/rest/service/IDirectoryRestService.java

Violation Line
Avoid unused imports such as 'fr.paris.lutece.plugins.directory.business.Field' 37
Avoid unused imports such as 'fr.paris.lutece.plugins.directory.business.Field' 37

fr/paris/lutece/plugins/directory/modules/rest/service/formatters/RecordFormatterJson.java

Violation Line
The class 'RecordFormatterJson' has a Standard Cyclomatic Complexity of 5 (Highest = 10). 117460
The class 'RecordFormatterJson' has a Modified Cyclomatic Complexity of 5 (Highest = 10). 117460
The class 'RecordFormatterJson' has a Cyclomatic Complexity of 7 (Highest = 19). 117460
Private field '_locale' could be made final; it is only initialized in the declaration or constructor. 121
The method 'formatEntry' has a Cyclomatic Complexity of 12. 234272
The method 'formatRecordField' has a Modified Cyclomatic Complexity of 10. 307369
The method 'formatRecordField' has a Standard Cyclomatic Complexity of 10. 307369
The method 'formatRecordField' has a Cyclomatic Complexity of 19. 307369
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 403

fr/paris/lutece/plugins/directory/modules/rest/service/formatters/RecordFormatterXml.java

Violation Line
The class 'RecordFormatterXml' has a Cyclomatic Complexity of 5 (Highest = 16). 96459
The class 'RecordFormatterXml' has a Modified Cyclomatic Complexity of 4 (Highest = 12). 96459
The class 'RecordFormatterXml' has a Standard Cyclomatic Complexity of 4 (Highest = 12). 96459
Private field '_locale' could be made final; it is only initialized in the declaration or constructor. 100
The method 'getRecordFieldXml' has a Standard Cyclomatic Complexity of 12. 309378
The method 'getRecordFieldXml' has a Cyclomatic Complexity of 16. 309378
The method 'getRecordFieldXml' has a Modified Cyclomatic Complexity of 12. 309378
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 405

fr/paris/lutece/plugins/directory/modules/rest/service/http/DirectoryRestHttpServletRequest.java

Violation Line
Private field '_mapParameters' could be made final; it is only initialized in the declaration or constructor. 56
Return an empty array rather than null. 89116

fr/paris/lutece/plugins/directory/modules/rest/service/writers/DirectoryWriter.java

Violation Line
This statement may have some unnecessary parentheses 78

fr/paris/lutece/plugins/directory/modules/rest/service/writers/RecordWriter.java

Violation Line
This statement may have some unnecessary parentheses 78