The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| LocalVariableNamingConventions | The local variable name '_attribute' doesn't match '[a-z][a-zA-Z0-9]*' | 58 |
| Rule | Violation | Line |
|---|---|---|
| LocalVariableNamingConventions | The local variable name '_attribute' doesn't match '[a-z][a-zA-Z0-9]*' | 183 |
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 135 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 148–149 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 161–162 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 45–84 |
| CommentRequired | Public method and constructor comments are required | 50–83 |
| MissingOverride | The method 'getIcon(String)' is missing an @Override annotation. | 50–83 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 52 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 53 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 77 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–271 |
| CommentRequired | Header comments are required | 70–271 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_PLUGIN_NAME'. | 87 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_PORTLET'. | 88 |
| NPathComplexity | The method 'getPopup(HttpServletRequest, String, String)' has an NPath complexity of 912384 | 90–270 |
| ExcessiveMethodLength | Avoid really long methods. | 90–270 |
| NcssCount | The method 'getPopup(HttpServletRequest, String, String)' has a NCSS line count of 87. | 90–270 |
| CyclomaticComplexity | The method 'getPopup(HttpServletRequest, String, String)' has a cyclomatic complexity of 26. | 90–270 |
| MissingOverride | The method 'getPopup(HttpServletRequest, String, String)' is missing an @Override annotation. | 90–270 |
| CommentRequired | Public method and constructor comments are required | 90–270 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 117 |
| ShortVariable | Avoid variables with short names like p | 131 |
| CollapsibleIfStatements | These nested if statements could be combined | 146–152 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 146–152 |
| CollapsibleIfStatements | These nested if statements could be combined | 159–165 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 159–165 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 221 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 224 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 227 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 230 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 242 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 242 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 250 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'TAG_GEOLOC_RESOURCE'. | 78 |
| MissingOverride | The method 'getCreateTemplate()' is missing an @Override annotation. | 85–88 |
| MissingOverride | The method 'getModifyTemplate()' is missing an @Override annotation. | 95–98 |
| MissingOverride | The method 'getCreateParametersTemplate()' is missing an @Override annotation. | 105–108 |
| MissingOverride | The method 'getModifyParametersTemplate()' is missing an @Override annotation. | 115–118 |
| MissingOverride | The method 'getCreateParametersFormHtml(List, Locale)' is missing an @Override annotation. | 123–130 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 125 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 125 |
| MissingOverride | The method 'getModifyParametersFormHtml(Locale, int)' is missing an @Override annotation. | 135–142 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 137 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 137 |
| MissingOverride | The method 'validateValue(int, String, Locale)' is missing an @Override annotation. | 147–198 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 171–193 |
| ShortVariable | Avoid variables with short names like it | 177 |
| MissingOverride | The method 'getAttributeXmlValue(Document, DocumentAttribute)' is missing an @Override annotation. | 209–231 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.document.business.portlet.DocumentListPortletHome' | 42 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 45–84 |
| CommentRequired | Public method and constructor comments are required | 3 | 50–83 |
| MissingOverride | The method 'getIcon(String)' is missing an @Override annotation. | 3 | 50–83 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 3 | 52 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 3 | 53 |
| LocalVariableNamingConventions | The local variable name '_attribute' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 58 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 77 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–271 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.document.business.portlet.DocumentListPortletHome' | 4 | 42 |
| CommentRequired | Header comments are required | 3 | 70–271 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_PLUGIN_NAME'. | 3 | 87 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_PORTLET'. | 3 | 88 |
| NPathComplexity | The method 'getPopup(HttpServletRequest, String, String)' has an NPath complexity of 912384 | 3 | 90–270 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 90–270 |
| NcssCount | The method 'getPopup(HttpServletRequest, String, String)' has a NCSS line count of 87. | 3 | 90–270 |
| CyclomaticComplexity | The method 'getPopup(HttpServletRequest, String, String)' has a cyclomatic complexity of 26. | 3 | 90–270 |
| MissingOverride | The method 'getPopup(HttpServletRequest, String, String)' is missing an @Override annotation. | 3 | 90–270 |
| CommentRequired | Public method and constructor comments are required | 3 | 90–270 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 117 |
| ShortVariable | Avoid variables with short names like p | 3 | 131 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 135 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 146–152 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 146–152 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 148–149 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 159–165 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 159–165 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 161–162 |
| LocalVariableNamingConventions | The local variable name '_attribute' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 183 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 221 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 224 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 227 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 230 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 242 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 242 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 250 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'TAG_GEOLOC_RESOURCE'. | 3 | 78 |
| MissingOverride | The method 'getCreateTemplate()' is missing an @Override annotation. | 3 | 85–88 |
| MissingOverride | The method 'getModifyTemplate()' is missing an @Override annotation. | 3 | 95–98 |
| MissingOverride | The method 'getCreateParametersTemplate()' is missing an @Override annotation. | 3 | 105–108 |
| MissingOverride | The method 'getModifyParametersTemplate()' is missing an @Override annotation. | 3 | 115–118 |
| MissingOverride | The method 'getCreateParametersFormHtml(List, Locale)' is missing an @Override annotation. | 3 | 123–130 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 125 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 125 |
| MissingOverride | The method 'getModifyParametersFormHtml(Locale, int)' is missing an @Override annotation. | 3 | 135–142 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 137 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 137 |
| MissingOverride | The method 'validateValue(int, String, Locale)' is missing an @Override annotation. | 3 | 147–198 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 171–193 |
| ShortVariable | Avoid variables with short names like it | 3 | 177 |
| MissingOverride | The method 'getAttributeXmlValue(Document, DocumentAttribute)' is missing an @Override annotation. | 3 | 209–231 |
