Fork me on GitHub

PMD Results

The following document contains the results of PMD 5.3.5.

Files

fr/paris/lutece/plugins/document/modules/geoloc/service/DocumentIconProvider.java

Violation Line
String.indexOf(char) is faster than String.indexOf(String). 53
String.indexOf(char) is faster than String.indexOf(String). 54
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 80

fr/paris/lutece/plugins/document/modules/geoloc/service/DocumentPopupContentProvider.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 34281
Avoid unused imports such as 'fr.paris.lutece.plugins.document.business.portlet.DocumentListPortletHome' 42
Avoid unused imports such as 'fr.paris.lutece.plugins.document.business.portlet.DocumentListPortletHome' 42
The class 'DocumentPopupContentProvider' has a Standard Cyclomatic Complexity of 25 (Highest = 24). 71281
The class 'DocumentPopupContentProvider' has a Cyclomatic Complexity of 27 (Highest = 26). 71281
The class 'DocumentPopupContentProvider' has a Modified Cyclomatic Complexity of 25 (Highest = 24). 71281
Avoid unused private fields such as 'PARAMETER_PLUGIN_NAME'. 88
Avoid unused private fields such as 'PARAMETER_PORTLET'. 89
The method 'getPopup' has a Cyclomatic Complexity of 26. 91280
The method getPopup() has an NPath complexity of 71280000 91280
The method 'getPopup' has a Modified Cyclomatic Complexity of 24. 91280
The method 'getPopup' has a Standard Cyclomatic Complexity of 24. 91280
Avoid really long methods. 91280
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 118
Avoid variables with short names like p 132
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 136
Deeply nested if..then statements are hard to read 148154
These nested if statements could be combined 148154
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 150
These nested if statements could be combined 161167
Deeply nested if..then statements are hard to read 161167
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 163
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 250

fr/paris/lutece/plugins/document/modules/geoloc/service/attributes/GeolocManager.java

Violation Line
Avoid unused private fields such as 'TAG_GEOLOC_RESOURCE'. 82
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 131
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 150
Avoid variables with short names like it 192