The following document contains the results of PMD 5.3.5.
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 1–526 |
| Avoid unused imports such as 'fr.paris.lutece.plugins.document.business.DocumentHome' | 16 |
| Avoid unused imports such as 'fr.paris.lutece.plugins.document.business.DocumentHome' | 16 |
| The class 'DocumentimportService' has a Cyclomatic Complexity of 6 (Highest = 22). | 41–526 |
| The class 'DocumentimportService' has a Modified Cyclomatic Complexity of 5 (Highest = 19). | 41–526 |
| A class which only has private constructors should be final | 41–526 |
| The class 'DocumentimportService' has a Standard Cyclomatic Complexity of 5 (Highest = 19). | 41–526 |
| The method 'getDocumentData' has a Standard Cyclomatic Complexity of 19. | 74–281 |
| The method getDocumentData() has an NCSS line count of 111 | 74–281 |
| The method getDocumentData() has an NPath complexity of 82944 | 74–281 |
| Avoid using implementation types like 'HashMap'; use the interface instead | 74 |
| Avoid really long methods. | 74–281 |
| Avoid using implementation types like 'HashMap'; use the interface instead | 74 |
| The method 'getDocumentData' has a Modified Cyclomatic Complexity of 19. | 74–281 |
| The method 'getDocumentData' has a Cyclomatic Complexity of 22. | 74–281 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 78 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 79 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 80 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 82 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 84 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 86 |
| The String literal " > " appears 11 times in this file; the first occurrence is on line 93 | 93 |
| The String literal "<br/>" appears 11 times in this file; the first occurrence is on line 97 | 97 |
| These nested if statements could be combined | 227–239 |
| Avoid printStackTrace(); use a logger call instead. | 277 |
| Avoid unused method parameters such as 'document'. | 292 |
| Avoid using implementation types like 'HashMap'; use the interface instead | 292 |
| Avoid using implementation types like 'HashMap'; use the interface instead | 292 |
| Avoid really long methods. | 292–441 |
| Avoid using if statements without curly braces | 504 |
| Avoid using if statements without curly braces | 521 |
| Violation | Line |
|---|---|
| Avoid variables with short names like id | 20 |
| Violation | Line |
|---|---|
| StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 8 |
| StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 9 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 20–25 |
| It is a good practice to call super() in a constructor | 31–35 |
| Violation | Line |
|---|---|
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 5–45 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 1–428 |
| Avoid unused imports such as 'java.util.Arrays' | 6 |
| Avoid unused imports such as 'java.util.Arrays' | 6 |
| Avoid unused imports such as 'fr.paris.lutece.plugins.document.business.spaces.DocumentSpaceHome' | 22 |
| Avoid unused imports such as 'fr.paris.lutece.plugins.document.business.spaces.DocumentSpaceHome' | 22 |
| Avoid unused imports such as 'fr.paris.lutece.plugins.document.utils.IntegerUtils' | 23 |
| Avoid unused imports such as 'fr.paris.lutece.plugins.document.utils.IntegerUtils' | 23 |
| Avoid unused imports such as 'fr.paris.lutece.portal.util.mvc.admin.MVCAdminJspBean' | 36 |
| Avoid unused imports such as 'fr.paris.lutece.portal.util.mvc.admin.MVCAdminJspBean' | 36 |
| Avoid unused imports such as 'fr.paris.lutece.portal.util.mvc.admin.annotations.Controller' | 37 |
| Avoid unused imports such as 'fr.paris.lutece.portal.util.mvc.admin.annotations.Controller' | 37 |
| Avoid unused imports such as 'fr.paris.lutece.portal.util.mvc.commons.annotations.Action' | 38 |
| Avoid unused imports such as 'fr.paris.lutece.portal.util.mvc.commons.annotations.Action' | 38 |
| Avoid unused imports such as 'fr.paris.lutece.portal.util.mvc.commons.annotations.View' | 39 |
| Avoid unused imports such as 'fr.paris.lutece.portal.util.mvc.commons.annotations.View' | 39 |
| Avoid unused imports such as 'fr.paris.lutece.util.ReferenceItem' | 42 |
| Avoid unused imports such as 'fr.paris.lutece.util.ReferenceItem' | 42 |
| Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' | 43 |
| Avoid unused imports such as 'fr.paris.lutece.util.ReferenceList' | 43 |
| The class 'DocumentimportJspBean' has a Standard Cyclomatic Complexity of 4 (Highest = 14). | 51–428 |
| The class 'DocumentimportJspBean' has a Modified Cyclomatic Complexity of 4 (Highest = 14). | 51–428 |
| The class 'DocumentimportJspBean' has a Cyclomatic Complexity of 6 (Highest = 19). | 51–428 |
| Avoid unused private fields such as 'FIELD_FILE_IMPORT'. | 78 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 113 |
| The method 'doImportDocument' has a Standard Cyclomatic Complexity of 14. | 136–339 |
| Avoid really long methods. | 136–339 |
| The method 'doImportDocument' has a Cyclomatic Complexity of 19. | 136–339 |
| The method 'doImportDocument' has a Modified Cyclomatic Complexity of 14. | 136–339 |
| The method doImportDocument() has an NPath complexity of 320 | 136–339 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 140 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 141 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 143 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 144 |
| Avoid unused local variables such as '_strSpaceId'. | 144 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 148 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 166 |
| Avoid unused local variables such as 'nIdTypeDocument'. | 166 |
| The String literal " > " appears 5 times in this file; the first occurrence is on line 198 | 198 |
| The String literal "<br/>" appears 5 times in this file; the first occurrence is on line 202 | 202 |
| Avoid variables with short names like i | 370 |
| Avoid unused method parameters such as 'request'. | 387 |
| Avoid using if...else statements without curly braces | 422 |
| Avoid using if...else statements without curly braces | 423 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'fr.paris.lutece.pligins.documentimport.service.DocumentimportService' | 42 |
| Avoid unused imports such as 'fr.paris.lutece.pligins.documentimport.service.DocumentimportService' | 42 |
| Avoid unused imports such as 'fr.paris.lutece.portal.util.mvc.admin.MVCAdminJspBean' | 48 |
| Avoid unused imports such as 'fr.paris.lutece.portal.util.mvc.admin.MVCAdminJspBean' | 48 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 81 |
| Avoid empty if statements | 86–89 |
| Avoid variables with short names like dc | 92 |
