The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_listPrefixToRemove' doesn't match '[A-Z][A-Z_0-9]*' | 70 |
| FieldNamingConventions | The constant name '_listTypeAllowedForSearch' doesn't match '[A-Z][A-Z_0-9]*' | 71 |
| FormalParameterNamingConventions | The method parameter name 'SQL_QUERY_SELECTALL_ID' doesn't match '[a-z][a-zA-Z0-9]*' | 84 |
| LocalVariableNamingConventions | The local variable name 'WhereClauses' doesn't match '[a-z][a-zA-Z0-9]*' | 104 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_delegate' doesn't match '[a-z][a-zA-Z0-9]*' | 10 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 118 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 45–251 |
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 45–251 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 48 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_ASC'. | 60 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_DESC'. | 61 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 88 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 89 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 116–121 |
| CollapsibleIfStatements | These nested if statements could be combined | 116–121 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 144 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 145 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 70–73 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 233–236 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 8–30 |
| SingularField | Perhaps '_delegate' could be replaced by a local variable. | 10 |
| UnusedPrivateField | Avoid unused private fields such as '_delegate'. | 10 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 12–15 |
| CommentRequired | Public method and constructor comments are required | 12–15 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 51–177 |
| CommentRequired | Header comments are required | 51–177 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 117 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 117 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 119 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPluginDefaultNumberOfItemPerPage method if you want a default access modifier | 119 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 126 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 138 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 172 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 12–54 |
| SimplifyConditional | No need to check for null before an instanceof | 17 |
| SimplifyConditional | No need to check for null before an instanceof | 29 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 13–33 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _unitUserService field if you want a default access modifier | 16 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 16 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 17 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _unitService field if you want a default access modifier | 17 |
| CommentRequired | Public method and constructor comments are required | 19–32 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.ArrayList' | 37 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'javax.validation.constraints.NotEmpty' | 37 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPropertiesService' | 37 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.ArrayList' | 3 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.ArrayList' | 4 | 37 |
| CommentRequired | Header comments are required | 3 | 45–251 |
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 3 | 45–251 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 48 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_ASC'. | 3 | 60 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_DESC'. | 3 | 61 |
| FieldNamingConventions | The constant name '_listPrefixToRemove' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 70 |
| FieldNamingConventions | The constant name '_listTypeAllowedForSearch' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 71 |
| FormalParameterNamingConventions | The method parameter name 'SQL_QUERY_SELECTALL_ID' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 84 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 88 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 89 |
| LocalVariableNamingConventions | The local variable name 'WhereClauses' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 104 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 116–121 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 116–121 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 144 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 145 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'javax.validation.constraints.NotEmpty' | 4 | 37 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 70–73 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 233–236 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 8–30 |
| FieldNamingConventions | The final field name '_delegate' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 10 |
| SingularField | Perhaps '_delegate' could be replaced by a local variable. | 3 | 10 |
| UnusedPrivateField | Avoid unused private fields such as '_delegate'. | 3 | 10 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 12–15 |
| CommentRequired | Public method and constructor comments are required | 3 | 12–15 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 118 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppPropertiesService' | 4 | 37 |
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 51–177 |
| CommentRequired | Header comments are required | 3 | 51–177 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 117 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 117 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 119 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPluginDefaultNumberOfItemPerPage method if you want a default access modifier | 3 | 119 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 126 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 138 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 3 | 172 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 12–54 |
| SimplifyConditional | No need to check for null before an instanceof | 3 | 17 |
| SimplifyConditional | No need to check for null before an instanceof | 3 | 29 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.ArrayList' | 4 | 3 |
| CommentRequired | Header comments are required | 3 | 13–33 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _unitUserService field if you want a default access modifier | 3 | 16 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 16 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 17 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _unitService field if you want a default access modifier | 3 | 17 |
| CommentRequired | Public method and constructor comments are required | 3 | 19–32 |
