Fork me on GitHub

Checkstyle Results

The following document contains the results of Checkstyle 8.19 with build-config/lutece_checks.xml ruleset. 

rss feed

Summary

Files
 Info
 Warnings
 Errors
26 0 4 165

Files

File
 I
 W
 E
fr/paris/lutece/plugins/extend/modules/comment/business/AddCommentPosition.java 0 0 9
fr/paris/lutece/plugins/extend/modules/comment/business/Comment.java 0 0 8
fr/paris/lutece/plugins/extend/modules/comment/business/CommentDAO.java 0 0 5
fr/paris/lutece/plugins/extend/modules/comment/business/CommentFilter.java 0 0 11
fr/paris/lutece/plugins/extend/modules/comment/business/ICommentDAO.java 0 0 10
fr/paris/lutece/plugins/extend/modules/comment/business/config/CommentExtenderConfig.java 0 0 4
fr/paris/lutece/plugins/extend/modules/comment/business/config/CommentExtenderConfigDAO.java 0 0 1
fr/paris/lutece/plugins/extend/modules/comment/dashboard/PublicDashboardComment.java 0 0 8
fr/paris/lutece/plugins/extend/modules/comment/service/CommentAddOnService.java 0 0 1
fr/paris/lutece/plugins/extend/modules/comment/service/CommentAvatarService.java 0 0 1
fr/paris/lutece/plugins/extend/modules/comment/service/CommentListenerService.java 0 0 11
fr/paris/lutece/plugins/extend/modules/comment/service/CommentPlugin.java 0 0 14
fr/paris/lutece/plugins/extend/modules/comment/service/CommentService.java 0 2 13
fr/paris/lutece/plugins/extend/modules/comment/service/ICommentAvatarService.java 0 0 3
fr/paris/lutece/plugins/extend/modules/comment/service/ICommentListener.java 0 0 17
fr/paris/lutece/plugins/extend/modules/comment/service/ICommentService.java 0 2 13
fr/paris/lutece/plugins/extend/modules/comment/service/extender/CommentResourceExtender.java 0 0 1
fr/paris/lutece/plugins/extend/modules/comment/util/annotation/Email.java 0 0 4
fr/paris/lutece/plugins/extend/modules/comment/util/constants/CommentConstants.java 0 0 1
fr/paris/lutece/plugins/extend/modules/comment/util/validator/EmailValidator.java 0 0 1
fr/paris/lutece/plugins/extend/modules/comment/web/CommentApp.java 0 0 17
fr/paris/lutece/plugins/extend/modules/comment/web/CommentJspBean.java 0 0 10
fr/paris/lutece/plugins/extend/modules/comment/web/action/ManageCommentsPluginAction.java 0 0 1
fr/paris/lutece/plugins/extend/modules/comment/web/component/CommentResourceExtenderComponent.java 0 0 1

Rules

Category Rule Violations Severity
blocks LeftCurly
  • option: "nl"
4
 Error
coding ArrayTrailingComma 4
 Error
DeclarationOrder 7
 Error
HiddenField 8
 Error
ParameterAssignment 1
 Error
design FinalClass 1
 Error
HideUtilityClassConstructor 1
 Error
VisibilityModifier 1
 Error
header Header
  • fileExtensions: "java"
  • headerFile: "/opt/datas/jenkins/home/jobs/admin-github-build/workspace/target/checkstyle-header.txt"
24
 Error
imports UnusedImports 12
 Error
javadoc JavadocMethod 62
 Error
JavadocType 2
 Error
modifier RedundantModifier 3
 Error
naming MemberName
  • format: "^_[a-z](_?[a-zA-Z0-9])*$"
1
 Error
ParameterName
  • format: "^[a-z][a-zA-Z0-9]*$"
10
 Error
sizes ParameterNumber 4
 Warning
whitespace ParenPad
  • option: "space"
23
 Error
WhitespaceAround
  • tokens: "ASSIGN,EQUAL"
1
 Error

Details

fr/paris/lutece/plugins/extend/modules/comment/business/AddCommentPosition.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocType Missing a Javadoc comment. 39
 Error
design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 39
 Error
design VisibilityModifier Variable '_allPositions' must be private and have accessor methods. 42
 Error
coding DeclarationOrder Variable access definition in wrong order. 45
 Error
coding DeclarationOrder Variable access definition in wrong order. 47
 Error
coding DeclarationOrder Variable access definition in wrong order. 49
 Error
coding DeclarationOrder Variable access definition in wrong order. 51
 Error
coding DeclarationOrder Variable access definition in wrong order. 53

fr/paris/lutece/plugins/extend/modules/comment/business/Comment.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
coding HiddenField '_strLuteceUserName' hides a field. 456
 Error
naming ParameterName Name '_strLuteceUserName' must match pattern '^[a-z][a-zA-Z0-9]*$'. 456
 Error
coding HiddenField '_nCommentOrder' hides a field. 495
 Error
naming ParameterName Name '_nCommentOrder' must match pattern '^[a-z][a-zA-Z0-9]*$'. 495
 Error
coding HiddenField '_bIsImportant' hides a field. 514
 Error
naming ParameterName Name '_bIsImportant' must match pattern '^[a-z][a-zA-Z0-9]*$'. 514
 Error
javadoc JavadocMethod Expected @param tag for 'listWorkflowActions'. 534

fr/paris/lutece/plugins/extend/modules/comment/business/CommentDAO.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
imports UnusedImports Unused import - java.sql.ResultSet. 50
 Error
imports UnusedImports Unused import - java.sql.SQLException. 51
 Error
whitespace ParenPad '(' is not followed by whitespace. 349
 Error
whitespace ParenPad ')' is not preceded with whitespace. 349

fr/paris/lutece/plugins/extend/modules/comment/business/CommentFilter.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
coding HiddenField '_strSortedAttributeName' hides a field. 86
 Error
naming ParameterName Name '_strSortedAttributeName' must match pattern '^[a-z][a-zA-Z0-9]*$'. 86
 Error
coding HiddenField '_bAscSort' hides a field. 105
 Error
naming ParameterName Name '_bAscSort' must match pattern '^[a-z][a-zA-Z0-9]*$'. 105
 Error
coding HiddenField '_bPinned' hides a field. 125
 Error
naming ParameterName Name '_bPinned' must match pattern '^[a-z][a-zA-Z0-9]*$'. 125
 Error
coding HiddenField '_bImportant' hides a field. 144
 Error
naming ParameterName Name '_bImportant' must match pattern '^[a-z][a-zA-Z0-9]*$'. 144
 Error
coding HiddenField '_strLuteceUserName' hides a field. 164
 Error
naming ParameterName Name '_strLuteceUserName' must match pattern '^[a-z][a-zA-Z0-9]*$'. 164

fr/paris/lutece/plugins/extend/modules/comment/business/ICommentDAO.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
imports UnusedImports Unused import - java.util.Collection. 38
 Error
javadoc JavadocMethod Unused @param tag for 'strIdExtendableResource'. 151
 Error
javadoc JavadocMethod Expected @param tag for 'listIdExtendableResource'. 159
 Error
javadoc JavadocMethod Unused @param tag for 'CommentFilter'. 168
 Error
javadoc JavadocMethod Expected @param tag for 'commentFilter'. 178
 Error
javadoc JavadocMethod Unused @param tag for 'nItemsOffset'. 245
 Error
javadoc JavadocMethod Unused @param tag for 'nMaxItemsNumber'. 247
 Error
whitespace ParenPad '(' is not followed by whitespace. 253
 Error
whitespace ParenPad ')' is not preceded with whitespace. 253

fr/paris/lutece/plugins/extend/modules/comment/business/config/CommentExtenderConfig.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocMethod Expected @return tag. 201
 Error
javadoc JavadocMethod Unused Javadoc tag. 209
 Error
javadoc JavadocMethod Expected @param tag for 'nPosition'. 211

fr/paris/lutece/plugins/extend/modules/comment/business/config/CommentExtenderConfigDAO.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/extend/modules/comment/dashboard/PublicDashboardComment.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
naming MemberName Name 'strIdComponent' must match pattern '^_[a-z](_?[a-zA-Z0-9])*$'. 55
 Error
coding DeclarationOrder Static variable definition in wrong order. 56
 Error
coding DeclarationOrder Static variable definition in wrong order. 57
 Error
blocks LeftCurly '{' at column 57 should be on a new line. 60
 Error
blocks LeftCurly '{' at column 34 should be on a new line. 65
 Error
naming ParameterName Name 'user_id' must match pattern '^[a-z][a-zA-Z0-9]*$'. 76
 Error
naming ParameterName Name 'user_id' must match pattern '^[a-z][a-zA-Z0-9]*$'. 90

fr/paris/lutece/plugins/extend/modules/comment/service/CommentAddOnService.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/extend/modules/comment/service/CommentAvatarService.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/extend/modules/comment/service/CommentListenerService.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
design FinalClass Class CommentListenerService should be declared as final. 52
 Error
javadoc JavadocMethod Expected @return tag. 255
 Error
javadoc JavadocMethod Expected @param tag for 'comment'. 255
 Error
javadoc JavadocMethod Expected @param tag for 'strExtendableResourceType'. 255
 Error
javadoc JavadocMethod Expected @param tag for 'uidUser'. 255
 Error
javadoc JavadocMethod Expected @return tag. 299
 Error
javadoc JavadocMethod Expected @param tag for 'comment'. 299
 Error
javadoc JavadocMethod Expected @param tag for 'strExtendableResourceType'. 299
 Error
javadoc JavadocMethod Expected @param tag for 'strResourceId'. 299
 Error
javadoc JavadocMethod Expected @param tag for 'uidUser'. 299

fr/paris/lutece/plugins/extend/modules/comment/service/CommentPlugin.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
whitespace WhitespaceAround '=' is not preceded with whitespace. 73
 Error
whitespace ParenPad '(' is not followed by whitespace. 80
 Error
whitespace ParenPad ')' is not preceded with whitespace. 80
 Error
whitespace ParenPad '(' is not followed by whitespace. 80
 Error
whitespace ParenPad '(' is not followed by whitespace. 80
 Error
whitespace ParenPad ')' is not preceded with whitespace. 80
 Error
whitespace ParenPad ')' is not preceded with whitespace. 80
 Error
whitespace ParenPad '(' is not followed by whitespace. 82
 Error
whitespace ParenPad ')' is not preceded with whitespace. 82
 Error
whitespace ParenPad ')' is not preceded with whitespace. 82
 Error
whitespace ParenPad '(' is not followed by whitespace. 83
 Error
whitespace ParenPad ')' is not preceded with whitespace. 83
 Error
whitespace ParenPad ')' is not preceded with whitespace. 83

fr/paris/lutece/plugins/extend/modules/comment/service/CommentService.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Warning
sizes ParameterNumber More than 7 parameters (found 8). 256
 Error
coding ParameterAssignment Assignment of parameter 'nNbComments' is not allowed. 272
 Warning
sizes ParameterNumber More than 7 parameters (found 8). 299
 Error
javadoc JavadocMethod Missing a Javadoc comment. 499
 Error
javadoc JavadocMethod Missing a Javadoc comment. 522
 Error
whitespace ParenPad '(' is not followed by whitespace. 534
 Error
whitespace ParenPad ')' is not preceded with whitespace. 534
 Error
blocks LeftCurly '{' at column 115 should be on a new line. 534
 Error
whitespace ParenPad '(' is not followed by whitespace. 536
 Error
whitespace ParenPad '(' is not followed by whitespace. 540
 Error
whitespace ParenPad ')' is not preceded with whitespace. 540
 Error
blocks LeftCurly '{' at column 74 should be on a new line. 540
 Error
whitespace ParenPad '(' is not followed by whitespace. 541
 Error
whitespace ParenPad ')' is not preceded with whitespace. 541

fr/paris/lutece/plugins/extend/modules/comment/service/ICommentAvatarService.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocMethod Expected @param tag for 'comment'. 51
 Error
javadoc JavadocMethod Expected @param tag for 'comment'. 58

fr/paris/lutece/plugins/extend/modules/comment/service/ICommentListener.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
imports UnusedImports Unused import - java.util.Set. 37
 Error
imports UnusedImports Unused import - javax.validation.ConstraintViolation. 40
 Error
imports UnusedImports Unused import - fr.paris.lutece.plugins.extend.modules.comment.business.Comment. 42
 Error
javadoc JavadocType Unused @param tag for '<A>'. 48
 Error
javadoc JavadocMethod Expected @param tag for 'request'. 70
 Error
javadoc JavadocMethod Expected @return tag. 98
 Error
modifier RedundantModifier Redundant 'public' modifier. 98
 Error
javadoc JavadocMethod Expected @param tag for 'comment'. 98
 Error
javadoc JavadocMethod Expected @param tag for 'uidUser'. 98
 Error
javadoc JavadocMethod Expected @return tag. 109
 Error
modifier RedundantModifier Redundant 'public' modifier. 109
 Error
javadoc JavadocMethod Expected @param tag for 'comment'. 109
 Error
javadoc JavadocMethod Expected @param tag for 'uidUser'. 109
 Error
javadoc JavadocMethod Expected @param tag for 'strResourceType'. 109
 Error
javadoc JavadocMethod Expected @param tag for 'strResourceId'. 109
 Error
modifier RedundantModifier Redundant 'public' modifier. 122

fr/paris/lutece/plugins/extend/modules/comment/service/ICommentService.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
imports UnusedImports Unused import - java.util.Collection. 36
 Error
imports UnusedImports Unused import - fr.paris.lutece.portal.service.plugin.Plugin. 46
 Warning
sizes ParameterNumber More than 7 parameters (found 8). 209
 Warning
sizes ParameterNumber More than 7 parameters (found 8). 233
 Error
javadoc JavadocMethod Unused @param tag for 'bPublishedOnly'. 291
 Error
javadoc JavadocMethod Unused @param tag for 'add'. 297
 Error
javadoc JavadocMethod Expected @param tag for 'nCommentState'. 301
 Error
javadoc JavadocMethod Expected @param tag for 'strFilterUserName'. 302
 Error
javadoc JavadocMethod Unused @param tag for 'strIdExtendableResource'. 332
 Error
javadoc JavadocMethod Expected @param tag for 'listIdExtendableResource'. 338
 Error
javadoc JavadocMethod Expected @return tag. 374
 Error
javadoc JavadocMethod Expected @param tag for 'extendableResourceType'. 374
 Error
javadoc JavadocMethod Unused @param tag for 'nItemsOffset'. 381
 Error
javadoc JavadocMethod Unused @param tag for 'nMaxItemsNumber'. 383

fr/paris/lutece/plugins/extend/modules/comment/service/extender/CommentResourceExtender.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/extend/modules/comment/util/annotation/Email.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
javadoc JavadocMethod Expected @return tag. 59
 Error
javadoc JavadocMethod Expected @return tag. 64
 Error
javadoc JavadocMethod Expected @return tag. 69

fr/paris/lutece/plugins/extend/modules/comment/util/constants/CommentConstants.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/extend/modules/comment/util/validator/EmailValidator.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/extend/modules/comment/web/CommentApp.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
imports UnusedImports Unused import - fr.paris.lutece.portal.service.message.AdminMessage. 74
 Error
imports UnusedImports Unused import - fr.paris.lutece.portal.service.message.AdminMessageService. 75
 Error
imports UnusedImports Unused import - fr.paris.lutece.portal.util.mvc.commons.annotations.Action. 90
 Error
javadoc JavadocMethod Expected @throws tag for 'UserNotSignedException'. 381
 Error
javadoc JavadocMethod Expected @throws tag for 'UserNotSignedException'. 474
 Error
coding ArrayTrailingComma Array should contain trailing comma. 522
 Error
coding ArrayTrailingComma Array should contain trailing comma. 540
 Error
javadoc JavadocMethod Missing a Javadoc comment. 645
 Error
coding ArrayTrailingComma Array should contain trailing comma. 713
 Error
javadoc JavadocMethod Expected @return tag. 814
 Error
javadoc JavadocMethod Expected @param tag for 'request'. 814
 Error
javadoc JavadocMethod Expected @param tag for 'strIdExtendableResource'. 814
 Error
javadoc JavadocMethod Expected @param tag for 'strExtendableResourceType'. 814
 Error
javadoc JavadocMethod Expected @throws tag for 'SiteMessageException'. 815
 Error
javadoc JavadocMethod Expected @throws tag for 'UserNotSignedException'. 815
 Error
coding ArrayTrailingComma Array should contain trailing comma. 845

fr/paris/lutece/plugins/extend/modules/comment/web/CommentJspBean.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2
 Error
imports UnusedImports Unused import - fr.paris.lutece.plugins.extend.service.extender.config.IResourceExtenderConfigService. 56
 Error
javadoc JavadocMethod Missing a Javadoc comment. 391
 Error
javadoc JavadocMethod Missing a Javadoc comment. 405
 Error
javadoc JavadocMethod Expected @return tag. 469
 Error
javadoc JavadocMethod Expected @param tag for 'request'. 469
 Error
javadoc JavadocMethod Expected @param tag for 'request'. 501
 Error
javadoc JavadocMethod Expected @param tag for 'comment'. 546
 Error
javadoc JavadocMethod Expected @param tag for 'request'. 564
 Error
javadoc JavadocMethod Expected @param tag for 'comment'. 564

fr/paris/lutece/plugins/extend/modules/comment/web/action/ManageCommentsPluginAction.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2

fr/paris/lutece/plugins/extend/modules/comment/web/component/CommentResourceExtenderComponent.java

Severity Category Rule Message Line
 Error
header Header Line does not match expected header line of ' * Copyright (c) 2002-2020, City of Paris'. 2