Fork me on GitHub
Built by Maven

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/extend/modules/feedback/util/constants/FeedbackConstants.java

Rule Violation Line
ClassNamingConventions The utility class name 'FeedbackConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 42–116

Priority 3

fr/paris/lutece/plugins/extend/modules/feedback/business/ExtendFeedbackDAO.java

Rule Violation Line
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 286–287
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 332–333
NPathComplexity The method 'constructRequest(String, String, String, String, ResourceExtenderDTO)' has an NPath complexity of 576 332–364
CyclomaticComplexity The method 'constructRequest(String, String, String, String, ResourceExtenderDTO)' has a cyclomatic complexity of 14. 332–364

fr/paris/lutece/plugins/extend/modules/feedback/business/IExtendFeedbackDAO.java

Rule Violation Line
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 126

fr/paris/lutece/plugins/extend/modules/feedback/business/config/FeedbackExtenderConfigDAO.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 57–74

fr/paris/lutece/plugins/extend/modules/feedback/service/ExtendFeedbackService.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–281
TooManyMethods This class has too many methods, consider refactoring it. 80–281
DefaultPackage Use explicit scoping instead of the default package private level 87–88
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _extendFeedbackDAO field if you want a default access modifier 88
DefaultPackage Use explicit scoping instead of the default package private level 89–91
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _resourceHistoryService field if you want a default access modifier 91
DefaultPackage Use explicit scoping instead of the default package private level 92–94
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _configService field if you want a default access modifier 94
DefaultPackage Use explicit scoping instead of the default package private level 95–97
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _resourceExtenderService field if you want a default access modifier 97
ConfusingTernary Avoid if (x != y) ..; else ..; 195
ConfusingTernary Avoid if (x != y) ..; else ..; 196
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 219
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 259
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 259

fr/paris/lutece/plugins/extend/modules/feedback/service/extender/FeedbackResourceExtender.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 102–111

fr/paris/lutece/plugins/extend/modules/feedback/web/FeedbackApp.java

Rule Violation Line
ImmutableField Private field '_feedbackCaptchaService' could be made final; it is only initialized in the declaration or constructor. 75
ImmutableField Private field '_extendFeedbackService' could be made final; it is only initialized in the declaration or constructor. 76
ImmutableField Private field '_configService' could be made final; it is only initialized in the declaration or constructor. 77
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 93

fr/paris/lutece/plugins/extend/modules/feedback/web/FeedbackJspBean.java

Rule Violation Line
ImmutableField Private field '_extendFeedbackService' could be made final; it is only initialized in the declaration or constructor. 88
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 122
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 184

fr/paris/lutece/plugins/extend/modules/feedback/web/FeedbackTypeJspBean.java

Rule Violation Line
DefaultPackage Use explicit scoping instead of the default package private level 98
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _feedbackTypeService field if you want a default access modifier 98
CommentRequired Public method and constructor comments are required 101–111
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 113
CommentRequired Public method and constructor comments are required 114–134
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 136
CommentRequired Public method and constructor comments are required 137–152
ConfusingTernary Avoid if (x != y) ..; else ..; 142–149
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 154
CommentRequired Public method and constructor comments are required 155–184
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 186
CommentRequired Public method and constructor comments are required 187–215
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 224

fr/paris/lutece/plugins/extend/modules/feedback/web/action/FeedbackInstallerPluginAction.java

Rule Violation Line
UncommentedEmptyMethodBody Document empty method body 76–77

fr/paris/lutece/plugins/extend/modules/feedback/web/component/FeedbackResourceExtenderComponent.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–270
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 130
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 162
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 189

Priority 4

fr/paris/lutece/plugins/extend/modules/feedback/business/FeedbackType.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 109–112

Files

fr/paris/lutece/plugins/extend/modules/feedback/business/ExtendFeedbackDAO.java

Rule Violation Priority Line
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 286–287
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 332–333
NPathComplexity The method 'constructRequest(String, String, String, String, ResourceExtenderDTO)' has an NPath complexity of 576 3 332–364
CyclomaticComplexity The method 'constructRequest(String, String, String, String, ResourceExtenderDTO)' has a cyclomatic complexity of 14. 3 332–364

fr/paris/lutece/plugins/extend/modules/feedback/business/FeedbackType.java

Rule Violation Priority Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 109–112

fr/paris/lutece/plugins/extend/modules/feedback/business/IExtendFeedbackDAO.java

Rule Violation Priority Line
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 126

fr/paris/lutece/plugins/extend/modules/feedback/business/config/FeedbackExtenderConfigDAO.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 57–74

fr/paris/lutece/plugins/extend/modules/feedback/service/ExtendFeedbackService.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–281
TooManyMethods This class has too many methods, consider refactoring it. 3 80–281
DefaultPackage Use explicit scoping instead of the default package private level 3 87–88
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _extendFeedbackDAO field if you want a default access modifier 3 88
DefaultPackage Use explicit scoping instead of the default package private level 3 89–91
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _resourceHistoryService field if you want a default access modifier 3 91
DefaultPackage Use explicit scoping instead of the default package private level 3 92–94
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _configService field if you want a default access modifier 3 94
DefaultPackage Use explicit scoping instead of the default package private level 3 95–97
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _resourceExtenderService field if you want a default access modifier 3 97
ConfusingTernary Avoid if (x != y) ..; else ..; 3 195
ConfusingTernary Avoid if (x != y) ..; else ..; 3 196
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 219
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 3 259
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 259

fr/paris/lutece/plugins/extend/modules/feedback/service/extender/FeedbackResourceExtender.java

Rule Violation Priority Line
ConfusingTernary Avoid if (x != y) ..; else ..; 3 102–111

fr/paris/lutece/plugins/extend/modules/feedback/util/constants/FeedbackConstants.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'FeedbackConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 42–116

fr/paris/lutece/plugins/extend/modules/feedback/web/FeedbackApp.java

Rule Violation Priority Line
ImmutableField Private field '_feedbackCaptchaService' could be made final; it is only initialized in the declaration or constructor. 3 75
ImmutableField Private field '_extendFeedbackService' could be made final; it is only initialized in the declaration or constructor. 3 76
ImmutableField Private field '_configService' could be made final; it is only initialized in the declaration or constructor. 3 77
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 93

fr/paris/lutece/plugins/extend/modules/feedback/web/FeedbackJspBean.java

Rule Violation Priority Line
ImmutableField Private field '_extendFeedbackService' could be made final; it is only initialized in the declaration or constructor. 3 88
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 122
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 184

fr/paris/lutece/plugins/extend/modules/feedback/web/FeedbackTypeJspBean.java

Rule Violation Priority Line
DefaultPackage Use explicit scoping instead of the default package private level 3 98
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _feedbackTypeService field if you want a default access modifier 3 98
CommentRequired Public method and constructor comments are required 3 101–111
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 113
CommentRequired Public method and constructor comments are required 3 114–134
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 136
CommentRequired Public method and constructor comments are required 3 137–152
ConfusingTernary Avoid if (x != y) ..; else ..; 3 142–149
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 154
CommentRequired Public method and constructor comments are required 3 155–184
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 186
CommentRequired Public method and constructor comments are required 3 187–215
UnnecessaryAnnotationValueElement Avoid the use of value in annotations when its the only element 3 224

fr/paris/lutece/plugins/extend/modules/feedback/web/action/FeedbackInstallerPluginAction.java

Rule Violation Priority Line
UncommentedEmptyMethodBody Document empty method body 3 76–77

fr/paris/lutece/plugins/extend/modules/feedback/web/component/FeedbackResourceExtenderComponent.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–270
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 130
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 162
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 189