Fork me on GitHub

PMD Results

The following document contains the results of PMD 5.5.1.

Files

fr/paris/lutece/plugins/fdw/modules/wizard/business/FormWithDirectory.java

Violation Line
Avoid using redundant field initializer for '_form' 46
Avoid using redundant field initializer for '_directory' 47

fr/paris/lutece/plugins/fdw/modules/wizard/rights/Rights.java

Violation Line
Avoid reassigning parameters such as 'jsp' 86
Avoid using final local variables, turn them into fields 88
Position literals first in String comparisons 91
Avoid reassigning parameters such as 'jsp' 126
Avoid using final local variables, turn them into fields 128
Position literals first in String comparisons 131

fr/paris/lutece/plugins/fdw/modules/wizard/service/DuplicationManager.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4968

fr/paris/lutece/plugins/fdw/modules/wizard/service/DuplicationService.java

Violation Line
Abstract classes should be named AbstractXXX 4453

fr/paris/lutece/plugins/fdw/modules/wizard/service/ServiceWithPriority.java

Violation Line
Abstract classes should be named AbstractXXX 4267
Use explicit scoping instead of the default package private level 44
Avoid variables with short names like o 63

fr/paris/lutece/plugins/fdw/modules/wizard/service/WizardService.java

Violation Line
Document empty method 8788
Use block level rather than method level synchronization 95103
Avoid really long methods. 177279
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 183
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 184
Avoid variables with short names like it 321

fr/paris/lutece/plugins/fdw/modules/wizard/web/WizardJspBean.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 341289
Avoid really long classes. 811289
The class 'WizardJspBean' has a Standard Cyclomatic Complexity of 5 (Highest = 17). 811289
The class 'WizardJspBean' has a Modified Cyclomatic Complexity of 5 (Highest = 17). 811289
The class 'WizardJspBean' has a Cyclomatic Complexity of 5 (Highest = 17). 811289
Avoid excessively long variable names like PARAMETER_MESSAGE_SUCCESS_COPY_DIRECTORY_WITH_WORKFLOW 104
Avoid excessively long variable names like PARAMETER_MESSAGE_SUCCESS_COPY_FORM_WITH_DIRECTORY_AND_EXPORT 105
Avoid excessively long variable names like PARAMETER_MESSAGE_SUCCESS_COPY_FORM_WITH_DIRECTORY_AND_WORKFLOW 106
Avoid excessively long variable names like TEMPLATE_DUPLICATE_FORM_WITH_DIRECTORY_AND_WORKFLOW 145
Private field '_workflowService' could be made final; it is only initialized in the declaration or constructor. 177
Private field '_wizardService' could be made final; it is only initialized in the declaration or constructor. 178
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 187
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 266
Avoid declaring a variable if it is unreferenced before a possible exit point. 301
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 334
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 384
Avoid declaring a variable if it is unreferenced before a possible exit point. 405
The String literal "Directory not found for ID " appears 7 times in this file; the first occurrence is on line 414 414
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 417
The method 'doDuplicateDirectory' has a Cyclomatic Complexity of 14. 436566
The method 'doDuplicateDirectory' has a Standard Cyclomatic Complexity of 14. 436566
Avoid really long methods. 436566
The method 'doDuplicateDirectory' has a Modified Cyclomatic Complexity of 14. 436566
Avoid declaring a variable if it is unreferenced before a possible exit point. 458
Avoid declaring a variable if it is unreferenced before a possible exit point. 460
Avoid declaring a variable if it is unreferenced before a possible exit point. 461
Avoid declaring a variable if it is unreferenced before a possible exit point. 498
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 535
The String literal "true" appears 4 times in this file; the first occurrence is on line 557 557
Avoid declaring a variable if it is unreferenced before a possible exit point. 579
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 595
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 628
Avoid declaring a variable if it is unreferenced before a possible exit point. 648
Avoid declaring a variable if it is unreferenced before a possible exit point. 706
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 718
Avoid declaring a variable if it is unreferenced before a possible exit point. 743
The String literal "Form not found for ID " appears 8 times in this file; the first occurrence is on line 752 752
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 755
Avoid really long methods. 774927
The method 'doDuplicateForm' has a Cyclomatic Complexity of 17. 774927
The method 'doDuplicateForm' has a Standard Cyclomatic Complexity of 17. 774927
The method 'doDuplicateForm' has a Modified Cyclomatic Complexity of 17. 774927
Avoid declaring a variable if it is unreferenced before a possible exit point. 797
Avoid declaring a variable if it is unreferenced before a possible exit point. 799
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 901
Avoid declaring a variable if it is unreferenced before a possible exit point. 940
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 956
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 993
Avoid declaring a variable if it is unreferenced before a possible exit point. 1014
Avoid declaring a variable if it is unreferenced before a possible exit point. 1076
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1088
Avoid declaring a variable if it is unreferenced before a possible exit point. 1113
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1125
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1280
Assigning an Object to null is a code smell. Consider refactoring. 1283