The following document contains the results of PMD 5.3.5.
Violation | Line |
---|---|
Assigning an Object to null is a code smell. Consider refactoring. | 74 |
Assigning an Object to null is a code smell. Consider refactoring. | 83 |
Violation | Line |
---|---|
Avoid short class names like Rule | 42–178 |
Assigning an Object to null is a code smell. Consider refactoring. | 149 |
Assigning an Object to null is a code smell. Consider refactoring. | 158 |
Violation | Line |
---|---|
Avoid short class names like Unit | 40–99 |
Violation | Line |
---|---|
It is a good practice to call super() in a constructor | 70–73 |
Avoid variables with short names like rt | 80 |
Avoid variables with short names like p | 86 |
Violation | Line |
---|---|
Avoid unused private fields such as 'PLUGIN_FORM'. | 62 |
Violation | Line |
---|---|
A high number of imports can indicate a high degree of coupling within an object. | 34–538 |
Possible God class (WMC=58, ATFD=111, TCC=0.0) | 34–538 |
The class 'DateValidator' has a Standard Cyclomatic Complexity of 6 (Highest = 16). | 86–538 |
The class 'DateValidator' has a Cyclomatic Complexity of 7 (Highest = 19). | 86–538 |
The class 'DateValidator' has a Modified Cyclomatic Complexity of 6 (Highest = 16). | 86–538 |
Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 99 |
Singleton is not thread safe | 109–112 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 162 |
The method 'validateRuleEntry' has a Cyclomatic Complexity of 13. | 295–355 |
Avoid unused method parameters such as 'formPlugin'. | 295 |
The method 'validateRuleEntry' has a Standard Cyclomatic Complexity of 10. | 295–355 |
The method 'validateRuleEntry' has a Modified Cyclomatic Complexity of 10. | 295–355 |
Avoid unused method parameters such as 'formPlugin'. | 365 |
The method 'validateRuleDateCalculated' has a Modified Cyclomatic Complexity of 16. | 426–537 |
The method 'validateRuleDateCalculated' has a Cyclomatic Complexity of 19. | 426–537 |
The method validateRuleDateCalculated() has an NPath complexity of 720 | 426–537 |
Avoid really long methods. | 426–537 |
The method 'validateRuleDateCalculated' has a Standard Cyclomatic Complexity of 16. | 426–537 |
Avoid unused method parameters such as 'formPlugin'. | 426 |
Violation | Line |
---|---|
A high number of imports can indicate a high degree of coupling within an object. | 34–1332 |
Avoid really long classes. | 86–1332 |
The class 'DateValidatorsJspBean' has a Cyclomatic Complexity of 6 (Highest = 32). | 86–1332 |
The class 'DateValidatorsJspBean' has a Modified Cyclomatic Complexity of 5 (Highest = 16). | 86–1332 |
The class 'DateValidatorsJspBean' has a Standard Cyclomatic Complexity of 5 (Highest = 20). | 86–1332 |
Perhaps '_nDefaultItemsPerPage' could be replaced by a local variable. | 173 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 201 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 306 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 347 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 390 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 488 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 536 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 586 |
The method getRuleFields() has an NPath complexity of 732 | 665–824 |
The method 'getRuleFields' has a Modified Cyclomatic Complexity of 16. | 665–824 |
Avoid really long methods. | 665–824 |
The method 'getRuleFields' has a Standard Cyclomatic Complexity of 20. | 665–824 |
The method 'getRuleFields' has a Cyclomatic Complexity of 32. | 665–824 |
Use equals() to compare object references. | 727 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 945 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1033 |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1129 |
The method 'getDateCalculatedFields' has a Cyclomatic Complexity of 13. | 1201–1268 |
Avoid declaring a variable if it is unreferenced before a possible exit point. | 1206 |