The following document contains the results of PMD 5.3.5.
| Violation | Line |
|---|---|
| Singleton is not thread safe | 63–69 |
| Violation | Line |
|---|---|
| Avoid excessively long variable names like SQL_QUERY_SELECT_ENTRY_CONFIGURATION_BY_ID_DIRECTORY_ENTRY | 60 |
| Violation | Line |
|---|---|
| Deeply nested if..then statements are hard to read | 93–96 |
| Violation | Line |
|---|---|
| Avoid unnecessary if..then..else statements when returning booleans | 113–116 |
| Violation | Line |
|---|---|
| Singleton is not thread safe | 57–63 |
| Violation | Line |
|---|---|
| Avoid unnecessary if..then..else statements when returning booleans | 68–71 |
| Violation | Line |
|---|---|
| Use explicit scoping instead of the default package private level | 118–121 |
| Violation | Line |
|---|---|
| Document empty constructor | 15–18 |
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 34–735 |
| Possible God class (WMC=79, ATFD=156, TCC=0.26666666666666666) | 34–735 |
| The class 'ProcessorExportdirectory' has a Cyclomatic Complexity of 14 (Highest = 33). | 95–735 |
| The class 'ProcessorExportdirectory' has a Modified Cyclomatic Complexity of 11 (Highest = 25). | 95–735 |
| The class 'ProcessorExportdirectory' has a Standard Cyclomatic Complexity of 11 (Highest = 25). | 95–735 |
| The method 'getOutputConfigForm' has a Standard Cyclomatic Complexity of 25. | 160–406 |
| The method 'getOutputConfigForm' has a Modified Cyclomatic Complexity of 25. | 160–406 |
| The method getOutputConfigForm() has an NCSS line count of 142 | 160–406 |
| The method getOutputConfigForm() has an NPath complexity of 7608750 | 160–406 |
| The method 'getOutputConfigForm' has a Cyclomatic Complexity of 33. | 160–406 |
| Avoid really long methods. | 160–406 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 166 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 190 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 229 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 239 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 276 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 277 |
| Avoid using Literals in Conditional Statements | 279 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 311 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 413 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 416 |
| The method 'doActionCreateDirectory' has a Cyclomatic Complexity of 17. | 497–600 |
| The method 'doActionCreateDirectory' has a Modified Cyclomatic Complexity of 15. | 497–600 |
| The method 'doActionCreateDirectory' has a Standard Cyclomatic Complexity of 15. | 497–600 |
| Avoid really long methods. | 497–600 |
| The method doActionCreateDirectory() has an NPath complexity of 1520 | 497–600 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 506 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 507 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 508 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 519 |
| These nested if statements could be combined | 523–541 |
| Avoid using Literals in Conditional Statements | 544 |
| The method 'doActionUseDirectoryExist' has a Standard Cyclomatic Complexity of 14. | 615–715 |
| The method 'doActionUseDirectoryExist' has a Modified Cyclomatic Complexity of 14. | 615–715 |
| Avoid really long methods. | 615–715 |
| The method doActionUseDirectoryExist() has an NPath complexity of 581 | 615–715 |
| The method 'doActionUseDirectoryExist' has a Cyclomatic Complexity of 16. | 615–715 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 622 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 623 |
| If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 625 |
| Avoid unused method parameters such as 'request'. | 728 |
| Violation | Line |
|---|---|
| It is a good practice to call super() in a constructor | 61–64 |
| Avoid variables with short names like rt | 71 |
| Avoid variables with short names like p | 77 |
| Violation | Line |
|---|---|
| Possible God class (WMC=136, ATFD=270, TCC=0.02857142857142857) | 34–1224 |
| A high number of imports can indicate a high degree of coupling within an object. | 34–1224 |
| The class 'ExportDirectoryUtils' has a Cyclomatic Complexity of 8 (Highest = 47). | 103–1224 |
| Avoid really long classes. | 103–1224 |
| The class 'ExportDirectoryUtils' has a Modified Cyclomatic Complexity of 7 (Highest = 34). | 103–1224 |
| The class 'ExportDirectoryUtils' has a Standard Cyclomatic Complexity of 7 (Highest = 34). | 103–1224 |
| Avoid using Literals in Conditional Statements | 220 |
| Avoid really long methods. | 322–561 |
| The method createDirectoryEntry() has an NCSS line count of 124 | 322–561 |
| The method 'createDirectoryEntry' has a Modified Cyclomatic Complexity of 30. | 322–561 |
| The method 'createDirectoryEntry' has a Cyclomatic Complexity of 37. | 322–561 |
| The method createDirectoryEntry() has an NPath complexity of 227377161 | 322–561 |
| The method 'createDirectoryEntry' has a Standard Cyclomatic Complexity of 30. | 322–561 |
| Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.directory.business.IEntry' due to existing import 'fr.paris.lutece.plugins.directory.business.IEntry' | 323 |
| Avoid using Literals in Conditional Statements | 336 |
| Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.directory.business.IEntry' due to existing import 'fr.paris.lutece.plugins.directory.business.IEntry' | 357 |
| Avoid using Literals in Conditional Statements | 376 |
| StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 390 |
| Avoid appending characters as strings in StringBuffer.append. | 390 |
| Avoid declaring a variable if it is unreferenced before a possible exit point. | 480 |
| Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.directory.business.Field' due to existing import 'fr.paris.lutece.plugins.directory.business.Field' | 518 |
| Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.directory.business.FieldHome.create' due to existing import 'fr.paris.lutece.plugins.directory.business.FieldHome' | 524 |
| Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.directory.business.Field' due to existing import 'fr.paris.lutece.plugins.directory.business.Field' | 534 |
| Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.directory.business.FieldHome.create' due to existing import 'fr.paris.lutece.plugins.directory.business.FieldHome' | 539 |
| Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.directory.business.IEntry' due to existing import 'fr.paris.lutece.plugins.directory.business.IEntry' | 577 |
| Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.directory.business.FieldHome.create' due to existing import 'fr.paris.lutece.plugins.directory.business.FieldHome' | 603 |
| Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.directory.business.IEntry' due to existing import 'fr.paris.lutece.plugins.directory.business.IEntry' | 632 |
| Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.directory.business.Field' due to existing import 'fr.paris.lutece.plugins.directory.business.Field' | 637 |
| Unnecessary use of fully qualified name 'fr.paris.lutece.plugins.directory.business.FieldHome.create' due to existing import 'fr.paris.lutece.plugins.directory.business.FieldHome' | 664 |
| The method 'createDirectoryRecord' has a Modified Cyclomatic Complexity of 34. | 685–981 |
| Avoid really long methods. | 685–981 |
| The method createDirectoryRecord() has an NPath complexity of 1640 | 685–981 |
| The method 'createDirectoryRecord' has a Cyclomatic Complexity of 47. | 685–981 |
| The method createDirectoryRecord() has an NCSS line count of 145 | 685–981 |
| The method 'createDirectoryRecord' has a Standard Cyclomatic Complexity of 34. | 685–981 |
| These nested if statements could be combined | 886–891 |
