The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_listPrefixToRemove' doesn't match '[A-Z][A-Z_0-9]*' | 73 |
| FieldNamingConventions | The constant name '_listTypeAllowedForSearch' doesn't match '[A-Z][A-Z_0-9]*' | 74 |
| FormalParameterNamingConventions | The method parameter name 'SQL_QUERY_SELECTALL_ID' doesn't match '[a-z][a-zA-Z0-9]*' | 85 |
| LocalVariableNamingConventions | The local variable name 'WhereClauses' doesn't match '[a-z][a-zA-Z0-9]*' | 107 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 110 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 48–248 |
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 48–248 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 51 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_ASC'. | 63 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_DESC'. | 64 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 90 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 91 |
| CollapsibleIfStatements | These nested if statements could be combined | 119–124 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 119–124 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 148 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 149 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 71–74 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 233–235 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–257 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_ACTION_ERROR'. | 130 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_ERROR_TOKEN'. | 131 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_ACTION_SUCCESS'. | 132 |
| UnusedPrivateField | Avoid unused private fields such as 'ACTION_SAVE_TASK_FORM'. | 149 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_WORKFLOW_ACTION_LIST'. | 155 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_ID_FORM_RESPONSE'. | 156 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_ID_ACTION'. | 157 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_TASK_FORM'. | 158 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_LIST_FILE'. | 159 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_POINTS_GEOJSON'. | 169 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_POINTS_ID'. | 170 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_POINTS_FIELDCODE'. | 171 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_POINTS_TYPE'. | 172 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_ID_ACTION'. | 181 |
| CommentRequired | Public method and constructor comments are required | 185–255 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 194 |
| UnusedLocalVariable | Avoid unused local variables such as 'listResultsGeoloc'. | 201 |
| UnusedLocalVariable | Avoid unused local variables such as 'nCurrentItemsPerPage'. | 216 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 216 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 216 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 218 |
| AddEmptyString | Do not add empty strings | 244 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 59–150 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.ArrayList' | 38 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'javax.validation.constraints.Size' | 36 |
| UnusedImports | Avoid unused imports such as 'javax.validation.constraints.NotEmpty' | 37 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.io.IOException' | 36 |
| UnusedImports | Avoid unused imports such as 'java.util.Collection' | 38 |
| UnusedImports | Avoid unused imports such as 'java.util.LinkedHashMap' | 40 |
| UnusedImports | Avoid unused imports such as 'java.util.Objects' | 44 |
| UnusedImports | Avoid unused imports such as 'java.util.Map.Entry' | 46 |
| UnusedImports | Avoid unused imports such as 'java.util.stream.Collectors' | 47 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.business.FormQuestionResponse' | 50 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.business.FormResponseStep' | 51 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.service.EntryServiceManager' | 52 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.web.entrytype.DisplayType' | 53 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.web.entrytype.EntryTypeFileDisplayService' | 54 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.web.entrytype.IEntryDisplayService' | 55 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.genericattributes.business.Response' | 56 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.leaflet.business.GeolocItem' | 57 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.leaflet.service.IconService' | 58 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.search.solr.indexer.SolrItem' | 62 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.business.file.File' | 63 |
| UnusedImports | Avoid unused imports such as 'org.apache.commons.lang3.math.NumberUtils' | 64 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.api.user.User' | 66 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.business.Form' | 75 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.business.FormHome' | 76 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.service.upload.FormsAsynchronousUploadHandler' | 79 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.util.FormsConstants' | 80 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.util.FormsResponseUtils' | 81 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.business.action.Action' | 82 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.admin.AccessDeniedException' | 83 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.admin.AdminUserService' | 84 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.message.SiteMessage' | 86 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.message.SiteMessageService' | 88 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.search.SearchResult' | 89 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.security.LuteceUser' | 90 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.security.SecurityService' | 91 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' | 94 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.workflow.WorkflowService' | 96 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.html.DelegatePaginator' | 103 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.html.IPaginator' | 104 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.ArrayList' | 4 | 38 |
| CommentRequired | Header comments are required | 3 | 48–248 |
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 3 | 48–248 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 51 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_ASC'. | 3 | 63 |
| UnusedPrivateField | Avoid unused private fields such as 'SQL_DESC'. | 3 | 64 |
| FieldNamingConventions | The constant name '_listPrefixToRemove' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 73 |
| FieldNamingConventions | The constant name '_listTypeAllowedForSearch' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 74 |
| FormalParameterNamingConventions | The method parameter name 'SQL_QUERY_SELECTALL_ID' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 85 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 90 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 91 |
| LocalVariableNamingConventions | The local variable name 'WhereClauses' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 107 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 119–124 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 119–124 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 148 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 149 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'javax.validation.constraints.Size' | 4 | 36 |
| UnusedImports | Avoid unused imports such as 'javax.validation.constraints.NotEmpty' | 4 | 37 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 71–74 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 233–235 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 110 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–257 |
| UnusedImports | Avoid unused imports such as 'java.io.IOException' | 4 | 36 |
| UnusedImports | Avoid unused imports such as 'java.util.Collection' | 4 | 38 |
| UnusedImports | Avoid unused imports such as 'java.util.LinkedHashMap' | 4 | 40 |
| UnusedImports | Avoid unused imports such as 'java.util.Objects' | 4 | 44 |
| UnusedImports | Avoid unused imports such as 'java.util.Map.Entry' | 4 | 46 |
| UnusedImports | Avoid unused imports such as 'java.util.stream.Collectors' | 4 | 47 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.business.FormQuestionResponse' | 4 | 50 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.business.FormResponseStep' | 4 | 51 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.service.EntryServiceManager' | 4 | 52 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.web.entrytype.DisplayType' | 4 | 53 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.web.entrytype.EntryTypeFileDisplayService' | 4 | 54 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.web.entrytype.IEntryDisplayService' | 4 | 55 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.genericattributes.business.Response' | 4 | 56 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.leaflet.business.GeolocItem' | 4 | 57 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.leaflet.service.IconService' | 4 | 58 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.search.solr.indexer.SolrItem' | 4 | 62 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.business.file.File' | 4 | 63 |
| UnusedImports | Avoid unused imports such as 'org.apache.commons.lang3.math.NumberUtils' | 4 | 64 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.api.user.User' | 4 | 66 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.business.Form' | 4 | 75 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.business.FormHome' | 4 | 76 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.service.upload.FormsAsynchronousUploadHandler' | 4 | 79 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.util.FormsConstants' | 4 | 80 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.forms.util.FormsResponseUtils' | 4 | 81 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.plugins.workflowcore.business.action.Action' | 4 | 82 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.admin.AccessDeniedException' | 4 | 83 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.admin.AdminUserService' | 4 | 84 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.message.SiteMessage' | 4 | 86 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.message.SiteMessageService' | 4 | 88 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.search.SearchResult' | 4 | 89 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.security.LuteceUser' | 4 | 90 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.security.SecurityService' | 4 | 91 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.util.AppLogService' | 4 | 94 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.service.workflow.WorkflowService' | 4 | 96 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.html.DelegatePaginator' | 4 | 103 |
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.util.html.IPaginator' | 4 | 104 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_ACTION_ERROR'. | 3 | 130 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_ERROR_TOKEN'. | 3 | 131 |
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_ACTION_SUCCESS'. | 3 | 132 |
| UnusedPrivateField | Avoid unused private fields such as 'ACTION_SAVE_TASK_FORM'. | 3 | 149 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_WORKFLOW_ACTION_LIST'. | 3 | 155 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_ID_FORM_RESPONSE'. | 3 | 156 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_ID_ACTION'. | 3 | 157 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_TASK_FORM'. | 3 | 158 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_LIST_FILE'. | 3 | 159 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_POINTS_GEOJSON'. | 3 | 169 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_POINTS_ID'. | 3 | 170 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_POINTS_FIELDCODE'. | 3 | 171 |
| UnusedPrivateField | Avoid unused private fields such as 'MARK_POINTS_TYPE'. | 3 | 172 |
| UnusedPrivateField | Avoid unused private fields such as 'PARAMETER_ID_ACTION'. | 3 | 181 |
| CommentRequired | Public method and constructor comments are required | 3 | 185–255 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 194 |
| UnusedLocalVariable | Avoid unused local variables such as 'listResultsGeoloc'. | 3 | 201 |
| UnusedLocalVariable | Avoid unused local variables such as 'nCurrentItemsPerPage'. | 3 | 216 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 216 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 216 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 218 |
| AddEmptyString | Do not add empty strings | 3 | 244 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 59–150 |
