Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/forms/modules/solr/service/SolrFormsIndexer.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 96–732

fr/paris/lutece/plugins/forms/modules/solr/service/Utilities.java

Rule Violation Line
ClassNamingConventions The utility class name 'Utilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 36–56
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 36–56

Priority 3

fr/paris/lutece/plugins/forms/modules/solr/service/FormsSolrPlugin.java

Rule Violation Line
CommentRequired Header comments are required 12–35

fr/paris/lutece/plugins/forms/modules/solr/service/SolrFormsIndexer.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34–732
GodClass Possible God Class (WMC=52, ATFD=89, TCC=1.754%) 96–732
CommentRequired Public method and constructor comments are required 115–118
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 153
ConfusingTernary Avoid if (x != y) ..; else ..; 210–219
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 231
ConfusingTernary Avoid if (x != y) ..; else ..; 248–249
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 292
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 361
CyclomaticComplexity The method 'addResponseValueByType(SolrItem, IEntryTypeService, Response, StringBuilder, int)' has a cyclomatic complexity of 12. 522–583
ConfusingTernary Avoid if (x != y) ..; else ..; 547–555
ConfusingTernary Avoid if (x != y) ..; else ..; 564–576
ConfusingTernary Avoid if (x != y) ..; else ..; 575
ShortVariable Avoid variables with short names like sb 599
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 609
CyclomaticComplexity The method 'addDynamicFieldGeoloc(List, Map, SolrItem, String, Set)' has a cyclomatic complexity of 12. 629–675
ShortVariable Avoid variables with short names like x 633
ShortVariable Avoid variables with short names like y 634
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 637
ConfusingTernary Avoid if (x != y) ..; else ..; 639–672
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 697
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 697
ConfusingTernary Avoid if (x != y) ..; else ..; 699–728

fr/paris/lutece/plugins/forms/modules/solr/service/Utilities.java

Rule Violation Line
CommentRequired Header comments are required 36–56

Files

fr/paris/lutece/plugins/forms/modules/solr/service/FormsSolrPlugin.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 12–35

fr/paris/lutece/plugins/forms/modules/solr/service/SolrFormsIndexer.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 34–732
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 96–732
GodClass Possible God Class (WMC=52, ATFD=89, TCC=1.754%) 3 96–732
CommentRequired Public method and constructor comments are required 3 115–118
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 153
ConfusingTernary Avoid if (x != y) ..; else ..; 3 210–219
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 231
ConfusingTernary Avoid if (x != y) ..; else ..; 3 248–249
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 292
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 361
CyclomaticComplexity The method 'addResponseValueByType(SolrItem, IEntryTypeService, Response, StringBuilder, int)' has a cyclomatic complexity of 12. 3 522–583
ConfusingTernary Avoid if (x != y) ..; else ..; 3 547–555
ConfusingTernary Avoid if (x != y) ..; else ..; 3 564–576
ConfusingTernary Avoid if (x != y) ..; else ..; 3 575
ShortVariable Avoid variables with short names like sb 3 599
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 609
CyclomaticComplexity The method 'addDynamicFieldGeoloc(List, Map, SolrItem, String, Set)' has a cyclomatic complexity of 12. 3 629–675
ShortVariable Avoid variables with short names like x 3 633
ShortVariable Avoid variables with short names like y 3 634
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 637
ConfusingTernary Avoid if (x != y) ..; else ..; 3 639–672
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 697
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 697
ConfusingTernary Avoid if (x != y) ..; else ..; 3 699–728

fr/paris/lutece/plugins/forms/modules/solr/service/Utilities.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 36–56
ClassNamingConventions The utility class name 'Utilities' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 36–56
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 36–56