The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 47–108 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 44–64 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_listChildren' doesn't match '[a-z][a-zA-Z0-9]*' | 69 |
| FieldNamingConventions | The final field name '_templateDisplay' doesn't match '[a-z][a-zA-Z0-9]*' | 70 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_formDisplay' doesn't match '[a-z][a-zA-Z0-9]*' | 58 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_listChildren' doesn't match '[a-z][a-zA-Z0-9]*' | 51 |
| FieldNamingConventions | The final field name '_listICompositeDisplay' doesn't match '[a-z][a-zA-Z0-9]*' | 52 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 48–207 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 44–84 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 52–346 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 78–82 |
| Rule | Violation | Line |
|---|---|---|
| AssignmentInOperand | Avoid assignments in operands | 198 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 114 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'field' | 164 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'entryChild' | 173 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 187 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 94–117 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 107 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 169 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like id | 70 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 150 |
| Rule | Violation | Line |
|---|---|---|
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 152 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 153 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–71 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 57–231 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 58–231 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 51–119 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 51–100 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 49–94 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 44–64 |
| CommentRequired | Public method and constructor comments are required | 54–57 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 42–152 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 50–131 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 61–240 |
| ImmutableField | Private field '_templateService' could be made final; it is only initialized in the declaration or constructor. | 67 |
| UnusedFormalParameter | Avoid unused constructor parameters such as 'nIterationNumber'. | 82 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 179 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 55–189 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 137 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 49–106 |
| ImmutableField | Private field '_templateService' could be made final; it is only initialized in the declaration or constructor. | 55 |
| SingularField | Perhaps '_step' could be replaced by a local variable. | 56 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–821 |
| CommentRequired | Header comments are required | 96–821 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 97–821 |
| ImmutableField | Private field '_templateService' could be made final; it is only initialized in the declaration or constructor. | 151 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 207 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 269 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 295 |
| CommentRequired | Public method and constructor comments are required | 296–314 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 323 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 358 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 395–402 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 426–428 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 446 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 480 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 515–522 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 539 |
| CyclomaticComplexity | The method 'getConfirmRemoveComposite(HttpServletRequest)' has a cyclomatic complexity of 10. | 540–582 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 543 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 622 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 668 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 694 |
| CommentRequired | Public method and constructor comments are required | 695–708 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 699–706 |
| CommentRequired | Public method and constructor comments are required | 711–732 |
| CommentRequired | Public method and constructor comments are required | 735–751 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 48–207 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 44–84 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 52–346 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 78–82 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AssignmentInOperand | Avoid assignments in operands | 3 | 198 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 114 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'field' | 3 | 164 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'entryChild' | 3 | 173 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 187 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 94–117 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 107 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 169 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like id | 3 | 70 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 150 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 152 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 153 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 47–108 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 41–71 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 57–231 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 58–231 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 51–119 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 51–100 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 49–94 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 44–64 |
| CommentRequired | Header comments are required | 3 | 44–64 |
| CommentRequired | Public method and constructor comments are required | 3 | 54–57 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 42–152 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 50–131 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 61–240 |
| ImmutableField | Private field '_templateService' could be made final; it is only initialized in the declaration or constructor. | 3 | 67 |
| FieldNamingConventions | The final field name '_listChildren' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 69 |
| FieldNamingConventions | The final field name '_templateDisplay' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 70 |
| UnusedFormalParameter | Avoid unused constructor parameters such as 'nIterationNumber'. | 3 | 82 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 179 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 55–189 |
| FieldNamingConventions | The final field name '_formDisplay' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 58 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 137 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 49–106 |
| FieldNamingConventions | The final field name '_listChildren' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 51 |
| FieldNamingConventions | The final field name '_listICompositeDisplay' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 52 |
| ImmutableField | Private field '_templateService' could be made final; it is only initialized in the declaration or constructor. | 3 | 55 |
| SingularField | Perhaps '_step' could be replaced by a local variable. | 3 | 56 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–821 |
| CommentRequired | Header comments are required | 3 | 96–821 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 97–821 |
| ImmutableField | Private field '_templateService' could be made final; it is only initialized in the declaration or constructor. | 3 | 151 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 207 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 269 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 295 |
| CommentRequired | Public method and constructor comments are required | 3 | 296–314 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 323 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 358 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 395–402 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 426–428 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 446 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 480 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 515–522 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 539 |
| CyclomaticComplexity | The method 'getConfirmRemoveComposite(HttpServletRequest)' has a cyclomatic complexity of 10. | 3 | 540–582 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 543 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 622 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 668 |
| UnnecessaryAnnotationValueElement | Avoid the use of value in annotations when its the only element | 3 | 694 |
| CommentRequired | Public method and constructor comments are required | 3 | 695–708 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 699–706 |
| CommentRequired | Public method and constructor comments are required | 3 | 711–732 |
| CommentRequired | Public method and constructor comments are required | 3 | 735–751 |
