Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/grustoragedb/modules/broadcast/rs/Constants.java

Rule Violation Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3969

fr/paris/lutece/plugins/grustoragedb/modules/broadcast/rs/SubscriptionRest.java

Rule Violation Line
FieldNamingConventions The final field name '_logger' doesn't match '[a-z][a-zA-Z0-9]*' 65
FormalParameterNamingConventions The method parameter name 'demand_type_id' doesn't match '[a-z][a-zA-Z0-9]*' 120
FormalParameterNamingConventions The method parameter name 'demand_type_id' doesn't match '[a-z][a-zA-Z0-9]*' 144
FormalParameterNamingConventions The method parameter name 'demand_type_id' doesn't match '[a-z][a-zA-Z0-9]*' 183
FormalParameterNamingConventions The method parameter name 'demand_type_id' doesn't match '[a-z][a-zA-Z0-9]*' 209

fr/paris/lutece/plugins/grustoragedb/modules/broadcast/rs/SwaggerRest.java

Rule Violation Line
FieldNamingConventions The final field name '_logger' doesn't match '[a-z][a-zA-Z0-9]*' 69

fr/paris/lutece/plugins/grustoragedb/modules/broadcast/service/NotificationAlertBroadcastService.java

Rule Violation Line
FieldNamingConventions The static field name 'DEMAND_SERVICE_BEAN_NAME' doesn't match '_[a-z][a-zA-Z0-9]*' 62
FieldNamingConventions The static field name 'STATUS_FAILED' doesn't match '_[a-z][a-zA-Z0-9]*' 63
FieldNamingConventions The static field name 'KEY_NOTIFICATION_EVENT_LIST' doesn't match '_[a-z][a-zA-Z0-9]*' 64
FieldNamingConventions The static field name 'KEY_START' doesn't match '_[a-z][a-zA-Z0-9]*' 65
FieldNamingConventions The static field name 'KEY_END' doesn't match '_[a-z][a-zA-Z0-9]*' 66
FieldNamingConventions The static field name 'PROPERTY_GRU_ALERTS_FROM_NAME' doesn't match '_[a-z][a-zA-Z0-9]*' 68
FieldNamingConventions The static field name 'PROPERTY_GRU_ALERTS_FROM_MAIL' doesn't match '_[a-z][a-zA-Z0-9]*' 69
FieldNamingConventions The static field name 'PROPERTY_GRU_ALERTS_SUBJECT' doesn't match '_[a-z][a-zA-Z0-9]*' 70
FieldNamingConventions The static field name 'GRU_ALERTS_FROM_NAME' doesn't match '_[a-z][a-zA-Z0-9]*' 71
FieldNamingConventions The static field name 'GRU_ALERTS_FROM_MAIL' doesn't match '_[a-z][a-zA-Z0-9]*' 72
FieldNamingConventions The static field name 'GRU_ALERTS_SUBJECT' doesn't match '_[a-z][a-zA-Z0-9]*' 73

Priority 2

fr/paris/lutece/plugins/grustoragedb/modules/broadcast/rs/SubscriptionRest.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 65

fr/paris/lutece/plugins/grustoragedb/modules/broadcast/rs/SwaggerRest.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 69

Priority 3

fr/paris/lutece/plugins/grustoragedb/modules/broadcast/rs/Constants.java

Rule Violation Line
ShortVariable Avoid variables with short names like ID 45

fr/paris/lutece/plugins/grustoragedb/modules/broadcast/rs/SubscriptionRest.java

Rule Violation Line
ShortVariable Avoid variables with short names like id 182
ShortVariable Avoid variables with short names like id 209
ShortVariable Avoid variables with short names like id 249
ShortVariable Avoid variables with short names like id 267
ShortVariable Avoid variables with short names like id 295
ShortVariable Avoid variables with short names like id 313

fr/paris/lutece/plugins/grustoragedb/modules/broadcast/rs/SwaggerRest.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 142
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 152
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 155

fr/paris/lutece/plugins/grustoragedb/modules/broadcast/service/NotificationAlertBroadcastService.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 59159
CommentRequired Public method and constructor comments are required 78147
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 90
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 91
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 129

fr/paris/lutece/plugins/grustoragedb/modules/broadcast/web/AbstractManageSubscriptionsJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 50102

fr/paris/lutece/plugins/grustoragedb/modules/broadcast/web/SubscriptionJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 55256
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 111
ConfusingTernary Avoid if (x != y) ..; else ..; 128

Priority 4

fr/paris/lutece/plugins/grustoragedb/modules/broadcast/service/NotificationAlertBroadcastService.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.util.Map.Entry' 52

Files

fr/paris/lutece/plugins/grustoragedb/modules/broadcast/rs/Constants.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 3969
ShortVariable Avoid variables with short names like ID 3 45

fr/paris/lutece/plugins/grustoragedb/modules/broadcast/rs/SubscriptionRest.java

Rule Violation Priority Line
FieldNamingConventions The final field name '_logger' doesn't match '[a-z][a-zA-Z0-9]*' 1 65
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 65
FormalParameterNamingConventions The method parameter name 'demand_type_id' doesn't match '[a-z][a-zA-Z0-9]*' 1 120
FormalParameterNamingConventions The method parameter name 'demand_type_id' doesn't match '[a-z][a-zA-Z0-9]*' 1 144
ShortVariable Avoid variables with short names like id 3 182
FormalParameterNamingConventions The method parameter name 'demand_type_id' doesn't match '[a-z][a-zA-Z0-9]*' 1 183
FormalParameterNamingConventions The method parameter name 'demand_type_id' doesn't match '[a-z][a-zA-Z0-9]*' 1 209
ShortVariable Avoid variables with short names like id 3 209
ShortVariable Avoid variables with short names like id 3 249
ShortVariable Avoid variables with short names like id 3 267
ShortVariable Avoid variables with short names like id 3 295
ShortVariable Avoid variables with short names like id 3 313

fr/paris/lutece/plugins/grustoragedb/modules/broadcast/rs/SwaggerRest.java

Rule Violation Priority Line
FieldNamingConventions The final field name '_logger' doesn't match '[a-z][a-zA-Z0-9]*' 1 69
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 69
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 142
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 152
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 155

fr/paris/lutece/plugins/grustoragedb/modules/broadcast/service/NotificationAlertBroadcastService.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.util.Map.Entry' 4 52
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 59159
FieldNamingConventions The static field name 'DEMAND_SERVICE_BEAN_NAME' doesn't match '_[a-z][a-zA-Z0-9]*' 1 62
FieldNamingConventions The static field name 'STATUS_FAILED' doesn't match '_[a-z][a-zA-Z0-9]*' 1 63
FieldNamingConventions The static field name 'KEY_NOTIFICATION_EVENT_LIST' doesn't match '_[a-z][a-zA-Z0-9]*' 1 64
FieldNamingConventions The static field name 'KEY_START' doesn't match '_[a-z][a-zA-Z0-9]*' 1 65
FieldNamingConventions The static field name 'KEY_END' doesn't match '_[a-z][a-zA-Z0-9]*' 1 66
FieldNamingConventions The static field name 'PROPERTY_GRU_ALERTS_FROM_NAME' doesn't match '_[a-z][a-zA-Z0-9]*' 1 68
FieldNamingConventions The static field name 'PROPERTY_GRU_ALERTS_FROM_MAIL' doesn't match '_[a-z][a-zA-Z0-9]*' 1 69
FieldNamingConventions The static field name 'PROPERTY_GRU_ALERTS_SUBJECT' doesn't match '_[a-z][a-zA-Z0-9]*' 1 70
FieldNamingConventions The static field name 'GRU_ALERTS_FROM_NAME' doesn't match '_[a-z][a-zA-Z0-9]*' 1 71
FieldNamingConventions The static field name 'GRU_ALERTS_FROM_MAIL' doesn't match '_[a-z][a-zA-Z0-9]*' 1 72
FieldNamingConventions The static field name 'GRU_ALERTS_SUBJECT' doesn't match '_[a-z][a-zA-Z0-9]*' 1 73
CommentRequired Public method and constructor comments are required 3 78147
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 90
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 91
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 129

fr/paris/lutece/plugins/grustoragedb/modules/broadcast/web/AbstractManageSubscriptionsJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 50102

fr/paris/lutece/plugins/grustoragedb/modules/broadcast/web/SubscriptionJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 55256
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 111
ConfusingTernary Avoid if (x != y) ..; else ..; 3 128